The 2nd Monitor

Mast

15:00

@Vogel612 No, I was searching for the () -> {} part. You can't be the first to write that.

Pin Crash

@Mast RAS Syndrome

Mat's Mug

eh, it's like OOP programming

or aspect-oriented AOP

TDD-driven is the best though

Vogel612

oh cool I was actually able to remove it after cleaning the duplication at the other call site

Pimgd

-1

A: Generating 'Decent' numbers

The problem is this A Decent Number has the following properties: Its digits can only be 3's and/or 5's. The number of 3's it contains is divisible by 5. The number of 5's it contains is divisible by 3. If there are more than one such number, we pick the largest one. Ouput in console Print the...

help; answerer "explained" his answer...

via... translating it to english.

Mast

@Pimgd That's both NAA and VLQ IMO.

Mat's Mug

15:06

Thanks for clarifying. Unfortunately it's still an independent solution that doesn't relate to the OP in any way and, as such, doesn't constitute a code review. — Mat's Mug ♦ 6 secs ago

Mast

> How do you find?

Pimgd

@Mast loop the answer

"how do you find" -> "I think there might be room for improvement."

Mat's Mug

language barrier

Mast

Just install your OS in English and you'll learn soon enough.

Kaz

@Mat'sMug New project's finished (2k LoC). I decided *not* to post the whole thing this time ^^

Mat's Mug

15:12

lol

Kaz

Correction, 1.6k LoC written directly for this project, plus another 1.6k LoC of general methods I keep adding to.

Mast

No harm in uploading the 1.6k general methods with a small part of the other 1.6k as example use-case.

2

Captain Obvious

0

The following is the top-level procedure for aggregating, analysing and reporting my company's submitted business from 2015 - present. Reviewing the entire project is unfeasible, so I am just seeking opinions on Variable/Method naming and general readability. For reference, CLS_Data_Report is a ...

0

Q: Can my cache be more thread safe?

I have been working on a cache that can handle multiple reads at the same time, but the write is blocking. Is this code overkill by using a ConcurrentHashMap and a ReentrantReadWriteLock? Could I get away with just the lock? Are there any other optimizations I could make. Papa Bless! public...

java multithreading concurrency cache

Mast

The devs like you, they raised the character limit once already for you. Let's do it again!

4

@CaptainObvious Holy mother of titles...

Vogel612

The status 99 part is... Legacy, the application owner doesnt remember. — Reaces 2 mins ago

Mat's Mug

15:15

@CaptainObvious trust me when I tell you. either it's thread-safe or it's not. there's no such thing as "somewhat thread-safe".

3

@CaptainObvious wat

Pimgd

@CaptainObvious gettotalaggregatedsummarydatareport-namingishard

URL does not like you.

3

Vogel612

@Mat'sMug actually... there kinda is.... sometimes.

Mat's Mug

lalalalalala... my rubberduck doesn't agree

Vogel612

the three dreaded words strike again

@Mat'sMug well you're doing funky stuff in half-global state..

Pin Crash

@Vogel612 can you glance over my answer to that SQL one and see if that's what you had in mind?

Pimgd

15:18

@Vogel612 rebooting system now?

Mat's Mug

@Vogel612 I'm open to ideas :)

it's not global, it's not singleton, it's constructor-injected in SingletonScope. define funky.

2

Mast

Pimgd

@Mat'sMug Superman coding

Vogel612

@PinCrash looks awesome

Pimgd

Is it a global? Is it a singleton? No! It's constructor-injected!

Mast

15:19

I'm seeing stars.

4

Kaz, is that you?

Vogel612

@Pimgd that's 4 words, if you mean what I think you mean

no I'm talking about "possibly race condition"

Dan Pantry

I just uploaded 2k commits to a remote repo. took TFS 2 hours to download each changeset. Took 3 minutes to upload it to a remote Git repo. TFS vs Git.

Pimgd

@Vogel612 Ah, you mean "safe code thread"

Pin Crash

@Vogel612 "Possibly your location" hahah, loved that one

Pimgd

err

Kaz

15:20

@Mast A justified assumption, but alas, I am out of stars.

Dan Pantry

@Kaz now you are

Mat's Mug

lol

Vogel612

@Mat'sMug as soon as I get Rubberduck to run on my machine, I can try to take a look and venture into the dangerous abyss of multithreading

Mast

such conditions, Race PITA. to debug a

6

Mat's Mug

I really need to see it work and have that "ah-HA!" moment

Pimgd

15:22

do threads have needles

Mat's Mug

no but they sting anyway

2

Pimgd

friday comedy in 2nd monitor is best

Mat's Mug

TGIF

Captain Obvious

0

Q: while loop with comma operator verses duplicate code verses "break;"

After reading a great answer about the comma operator in C/C++ (What does the comma operator do), I wanted to know which is the most readable, maintainable, preferred way to implement a while loop. Specifically a while loop whose condition depends on an operation or calculation, and the conditio...

c++ c

Mat's Mug

@Captain it's "versus", not "verses"

Vogel612

15:25

also it's stub code

Kaz

I feel like my naming is getting slightly too verbose: KeepOrRemoveArrayRowsWhereComparisonIsTrue()

Pimgd

while(s.len() > 5)  // might be false the first pass
{
   //do something
   read_string(s); // subsequent calls to update the condition
}

Mat's Mug

also it's closed

Mast

The hammer was faster than me.

Pimgd

while(1)           // this looks like trouble
{
   read_string(s);
   if( s.len() > 5 ) {
       break;     // hmmm, where else might this loop exit?
   }
   //do something
}

VTC broken code they don't work the same

Mast

15:25

@Pimgd Yuck.

Vogel612

@Kaz no you're doing too much stuff at once

Or in a method name is a huge red flag

Dan Pantry

@Kaz wat

Vogel612

split keeping and removing into separate methods

Pimgd

@Kaz KeepOrRemoveMatchingArrayRows

Vogel612

and suddenly you have KeepWhere()and RemoveWhere()

Pimgd

15:27

Like, what the hell is WhereComparisonIsTrue without an argument

Vogel612

^ that

Kaz

I left the arguments out, because that would be long

Dan Pantry

long ~~cat~~ func is long

Vogel612

figures.. Your method is doing too much

that's why the arg-list is long and that's why the name is long

KISS :)

Pimgd

SortByProvidedArgumentInAscendingDirection(/*no arguments*/)

Mr. Programmer, why did you leave the arguments out?

"Because it'd make the function signature too long"

wut

Kaz

15:29

@Pimgd 'Public Function KeepOrRemoveArrayRowsWhereComparisonIsTrue(ByRef sourceArray As Variant, ByVal colIndex As Long, ByVal operator As ComparisonOperator, ByVal comparisonValue As Variant, ByVal hasHeaders As Boolean, ByVal keepOrRemoveOnTrue As KeepOrRemove, Optional ByRef arrayOfRemovedRows As Variant) As Variant'

Satisfied?

Pimgd

Yes, very much so.

Dan Pantry

@Kaz hear that? that's the sound of a puppy dying

4

Pimgd

It sounded more like a few rodents and a lawnmower to me

Pin Crash

Could you extract the comparison into its own function, and call that? (or pass it around to the big sub (if VBA allows (which it may not)))

Pimgd

@Kaz how about "filterArrayRowsWhereComparisonIsTrue" returning 1 array

and then being able to remove the the array

like some sort of "subtract this array from the array you have"

keepOrRemoveOnTrue As KeepOrRemove

so it picks one of the two on true

and it picks neither on false

Mast

15:32

@Kaz Baaaad! Bad bad bad bad!

Vogel612

@PinCrash that would require first order functions, which VBA doesn't really have

Mat's Mug

s/doesn't really/really doesn't

2

Kaz

@Mat'sMug TS

Vogel612

@Mat'sMug call by name?

Pimgd

@Vogel612 Hey, no namecalling!

Vogel612

15:33

you Pimgd!

Mat's Mug

@Vogel612 works

Pimgd

You Vogel six one two!

Vogel612

@Mat'sMug that's not really first order functions, but it's closer than java was 'til 8

Mat's Mug

lol, hear that JAVA?

Vogel612

on that note, Phrancis is right.

you should extract comparison operator and comparison value into a separate Predicate object

Kaz

15:35

@PinCrash There is a separate comparison function for actually comparing values.

Pimgd

Ooh that's nice

You might not be able to do function pointers

Kaz

@Vogel612 That sounds, interesting.

Pimgd

but that doesn't stop you from using strategy pattern

Mat's Mug

10

Q: Generating and calling code on the fly

Delegate This class module defines what I'm calling, in this context, a Delegate - here a function that can take a number of parameters, evaluate a result, and return a value. Close enough to the actual "delegate" thing I find. Example usage Set x = Delegate.Create("(x) => MsgBox(""Hello, "" & x

oop regex vba delegates meta-programming

somewhat relevant / possibly ~~useful~~ overkill

also, @Kaz you'll be happy to hear that Rubberduck 2.0 will help you experiment with renaming functions on a whim. 1.4.3 might already do it, but so many bugs have been fixed since July that I don't even consider 1.4.3 release-ready...

Kaz

@Mat'sMug Considering I had to uninstall it to get my VBA projects to run properly again, I'm tempted to agree with you.

Mat's Mug

15:39

:(

Kaz

(might not have been Rubberduck's fault directly, but removing it did certainly fix the imminent problems)

Mat's Mug

then it's RD's fault.

Jeroen Vannevel

You hear that @RubberDuck?

@Mat'sMug is shifting blame

Mat's Mug

lol

Mast

If the problem looks like a duck, walks like a duck and sounds like a duck, it's probably not made of rubber.

3

Going to rob the hardware store, going to be fun.

Mat's Mug

15:41

...

if the police calls, we'll quote you on that

Pimgd

What if the hardware store calls?

Vogel612

lol...

it seems the web-presence of the newest rightmost right-wing party in Germany has been hacked :D

Donald.McLean

@Mast Not yet. I have lots of ideas. For some things, a collaborator would be helpful to keep things moving along.

Pimgd

friday 16:45

time to start the sprint

Duga

codereview.stackexchange.com is for improvements of working code; StackOverflow is for improving broken code. — Blazemonger 1 min ago

Captain Obvious

16:05

0

Q: If Not ComparisonIsTrue(thisPost, ComparisonOperator.Equals, goodCode) then Me.Answer

This is a follow-on to a global enum for comparison operators. I wanted to pass a logical expression E.G. >= someValue as a parameter to a function, so I made an Enum and an accompanying function to analyse logical expressions. Is my approach a good way to implement this functionality in VBA? ...

vba excel math-expression-eval

Pimgd

@CaptainObvious !true, why not false?

Kaz

@Pimgd Good point

Vogel612

adjusted answer...

Pimgd

... wondering whether goodCode is a constant

but it can't be because good code supports change

Vogel612

now we're getting into Matchers..

that's complicated

Pimgd

16:09

How Can Code Have Morals If Human Morality Is Undefined

Vogel612

@Pimgd it can't....

that's the inherent problem with Asimov's laws of robotics

Pimgd

So how do you know it's Good Code, then?

Maybe it's evil.

Vogel612

if it has no morality it's neither Good nor Evil.

it just is

Pimgd

Maybe it wants to be good but it has to perform fast so it can make enough money to feed its family, even sacrificing correctness in a few corner cases

it just has to, in order to survive, even if some people don't make it into Arstotzka

Vogel612

Hail Arstortzka.

Papers, Please

Pimgd

16:13

=D

Vogel612

jailing people because your son needs medicine after you couldn't afford heating

Captain Obvious

0

Q: Filtering Arrays by values in a specific Column

The following function, as evidenced by its name KeepOrRemoveArrayRowsWhereComparisonIsTrue is probably trying to do too much. How can I better structure/refactor/split it to be cleaner whilst retaining the original intent: "Here's an array, filter it based on the values in this column"? Pub...

vba excel

Pimgd

don't hate the player, hate the player's algorithm

Duga

I'm voting to close this question as off-topic because it's not about non-functioning code. This is more approriate for CodeReview but check their guidelines first. — Paulie_D 24 secs ago

Kaz

I think, at this point, I'm probably out of functions I can post without overlapping my previous questions today.

Pimgd

16:17

@CaptainObvious FGITW answer goooo

okay now to look at it for real

Vogel612

@Kaz you really want a FGITW for that OR in your method name?

Pimgd

What the hell.

that code

can you do boolean equals in VBA

ahhhh vba syntax is hard

4

I'll just write stupid code instead

0

A: Filtering Arrays by values in a specific Column

Select Case keepOrRemoveOnTrue Case KeepOrRemove.keep removeCounter = 0 For ix = startRow To UB1 sourceValue = sourceArray(ix, colIndex) If IsNull(sourceValue) Then sourceValue = 0 If IsNull(comparisonValue) Then...

There you go

            Dim remove as Boolean
            remove = False

            If keepOrRemoveOnTrue = KeepOrRemove.remove Then
                remove = True
            End If

ewwwwwwww

Mat's Mug

lol, semicolons in VBA

RubberDuck

@JeroenVannevel lulz

@Mat'sMug I call that VB#

Pimgd

VBA is hard

it's like doing everything you've been thought not to do

Duga

16:26

Assuming this all compiles and works correctly, it looks like it might fit better on CodeReview.SE. — Jerry Coffin 7 secs ago

Mat's Mug

remove = False is redundant

Pimgd

... can't I just

Dim remove as Boolean = keepOrRemoveOnTrue == KeepOrRemove.remove

you know, nice and short java-ish

Mat's Mug

nope

Pimgd

Well that sucks

xl4all.blogspot.nl/2012/03/iif-inline-if.html

Mat's Mug

but you could do

Pimgd

16:27

"IFF"

Vogel612

@Pimgd that's ternary

Mat's Mug

Dim remove as Boolean: remove = (keepOrRemoveOnTrue = KeepOrRemove.remove)

Vogel612

^ actually you shouldn't need the colon...

Pimgd

Also dear lord the font on that place

@Mat'sMug yoink

Vogel612

IIRC you can initialize dimmed variables directly...

Mat's Mug

16:28

not in VBA

in VB.NET, but not in VBA/VB6

Pimgd

@Vogel612 but what if they're bright

Mat's Mug

IMO VBA's biggest problem is that it's using the same token for comparison and assignment.

other than that it's a very decent [although dated] language

Pimgd

VBA is taking Code Reuse the wrong way

Select Case

Vogel612

@Pimgd no...

Pimgd

Case A

Case B

Vogel612

16:30

you're taking VBA Code Reuse the wrong way

Pimgd

They're not reusing code, they're reusing keywords

Mat's Mug

that's because "switch" has "witch" in it

2

RubberDuck

@Vogel612 Oh, but you do!

@Mat'sMug agreed there! I can ignore a lot of it's flaws, but that one.... it's evil and ambiguous and wrong.

Mat's Mug

especially if you're writing an EBNF grammar for the damn thing

RubberDuck

s/R/F

=;)-

Mat's Mug

16:33

whatever

RubberDuck

lol

Vogel612

Extended Backus-Naur Form, yea yea

Mat's Mug

whatever .g4 format is

Vogel612

that's just a type 2 Chomsky in disguise

Pimgd

Vogel do you use german keyboard layout

Vogel612

16:34

yea I do, why?

Pimgd

I recently saw a picture which showed a Y in the bottom left

Mat's Mug

is that KWERTY?

Vogel612

@Pimgd correct

@Mat'sMug QWERTZ

Pimgd

but it was a shot from the back, so you saw it upside down

I had to google tons

Mat's Mug

omg and I thought azerty was frakked

Vogel612

16:35

right beside <>|

Pimgd

but eventually

Dan Pantry

I have a question directed @ people who work in corporate teams... if anyone fits that bill here

Mat's Mug

hmm so it's just Y<->Z

Pimgd

@Mat'sMug "U"A"O

.... right, I have ctrl+shift disabled at work.

Vogel612

@Mat'sMug and umlauts where you have braces

Pimgd

16:36

You don't have Control

You have a Struggle instead

Mat's Mug

@Vogel612 that's like the fr-CA layout

Dan Pantry

can you guys who work in multiple teams see other projects? like if you are in team A and work on project A, can you see project B which is being worked on in team B?

Pimgd

or whatever Strg stands for

Vogel612

@DanPantry depends...

some projects in the issue-tracker are public, some aren't

Pimgd

... also what's up with shift... down...?

Vogel612

16:37

in general only related teams see related projects

Dan Pantry

@Vogel612 So I work in internal apps and I have a colleague who works in customer facing stuff. Both projects use the same technology. But I can't see their project, and they can't see mine.

Vogel612

@Pimgd that's CAPS

@DanPantry that sounds like a stupid idea

Dan Pantry

Which sucks because as they use the same tech, we can't knowledge share

Vogel612

17:05

wow... 3 answers today.

I'm on a spree

Pin Crash

@Vogel612 Nice!

Dan Pantry

Nice @Vogel612

Captain Obvious

0

Q: Need comments on my own thread pool using boost::thread

I would like to make a portable thread pool using boost::thread. Some one could tell me to look at boost::thread_group and boost::asio. I know, but I am not really familiar with these things so I don't know if they are suitable for my purpose. Please give me comments on what I supposed to do her...

c++ boost

Vogel612

in VBA Rubberducking, 32 mins ago, by Vogel612

coverage is back

in VBA Rubberducking, 1 min ago, by Vogel612

and it dropped by a measly 20%

#fun

Dan Pantry

lol

So, my credit limit increased to £1k. I guess I can buy a Mac now

Pimgd

17:18

more like you can get screwed over by the ~~bank~~ CC company even more now

Dan Pantry

That too

Pin Crash

What is the point of having LastUpdate datetime fields in tables if the only way they will ever be accurate is if you manually update them each time you write to a record. /rant

Vogel612

@PinCrash cough TRIGGER cough

Pin Crash

IKR

Vogel612

it's probably better than attaching a history-table on everything

Dan Pantry

17:22

@PinCrash triggered? ;D

Pin Crash

I tend to like the history tables, but for all the wrong reasons (out of necessity)

Vogel612

@DanPantry TS

Pin Crash

RSA

Mat's Mug

@PinCrash I have DateInserted and DateUpdated columns in ALL my tables. But the only write operations happening on my DB's happens overnight with an SSIS package. During the day, only SELECT is done on them.

DateInserted and DateUpdated are nothing but an annoyance in a transactional db. they're tremendously useful in a data store though </BoldAndProbablyWrongStatement>

Donald.McLean

Finding this funny: dzone.com/articles/java-will-get-local-variable-type-inference

Vogel612

17:33

yesterday, by Vogel612

In the latest news, people are discussing var for java...

Mat's Mug

@Donald.McLean me too!

Pin Crash

@Mat'sMug lol - no writes during business hours yeah right ;D

Mat's Mug

the writes happen in the source systems

the operational DB isn't even a database

it's a file-based system written in BASIC in the 80's and running on a linux box

Vogel612

youch

that's the very definition of legacy right there

Mat's Mug

yup

and it's being maintained/modified DAILY

Vogel612

17:39

Do I even want to know how Sage comes into this mess?

Dan Pantry

@Mat'sMug That is almost as old as my mother.

Not as old as me - as old as my mother.

Mat's Mug

@DanPantry that doesn't make me much younger...

@Vogel612 lol, Sage is used by the accounting dept. I need to make a process to transfer purchase orders from that legacy system into Sage.

> A final note is that the word var is proposed to be a reserved type name and not a Java keyword. This means that code that uses var as a variable, method, or package name will not be affected; code that uses var as a class or interface name will be affected (but these names violate the Java naming conventions anyhow)

that's dumb. Java tries to be like C#, and fails miserably.

Captain Obvious

0

Q: Saving and Loading data with SQLite

I'm in the process of learning SQLite in C# and I've come up with some generic methods for finding and updating data. I would appreciate any pointers with the design of my methods and/or my SQL syntax. FYI: I'm using System.Data and Mono.Data.SqliteClientfor C# Mono 2.0 (Unity3D). Here is an ex...

c# sql database sqlite

Pin Crash

        using (var dbCommand = dbConnection.CreateCommand ())
        {
            dbCommand.CommandText = string.Format ("SELECT {0} " +
                                                   "FROM {1} " +
                                                   "WHERE {2} = @whereValue", selectHeader, tableName, whereHeader);

Vogel612

@Mat'sMug meh..

Pin Crash

17:43

@CaptainObvious I don't think that's how you're supposed to do this...

Vogel612

@PinCrash go write an answer ;)

Pin Crash

Surely C# has prepared statements... right?

Vogel612

@Mat'sMug Java draws inspiration from C# and adjusts it to fit into the Java ecosystem better

@PinCrash of course

PreparedStatements can be obtained from Connections IIRC

Pin Crash

Gotcha, found the doc for SqlCommand.Prepare on MSDN

Mat's Mug

the introduction of var in C# didn't break any existing code, respectful or not of naming conventions.

Duga

17:48

I'm voting to close this question as off-topic because It is about working code and should ask at codereview.stackexchange.com — Jens 34 secs ago

Vogel612

@Mat'sMug I strongly challenge that

Mat's Mug

?

Vogel612

one does not introduce a new keyword named var without breaking some variable names in code-bases

Alien Herb Nite

if you're using var as a variable name in your codebase, then you're already doing something else wrong

Mat's Mug

100

A: Why can I create a class named "var"?

var is not a keyword according to this list. it is a contextual keyword, so from the context the compiler is be able to decide which is your class and which is the contextual keyword, and no confusion arises. a contextual keyword is: used to provide a specific meaning in the code, but it is...

Vogel612

17:49

@AlienHerbNite correct, but unfortunately var is incredibly common

@Mat'sMug so it's strictly speaking not a keyword in the original sense...

Mat's Mug

keyword is "contextual"

Alien Herb Nite

Actually, variables named var won't break

Vogel612

sidenote: the behaviour described in the JEP is exactly that of a contextual keyword

Alien Herb Nite

this line of code compiles:

Mat's Mug

something that seems absent from the Java implementation, yet is crucial cornerstone of C#'s

Alien Herb Nite

17:50

var var = 10;

Vogel612

@Mat'sMug no keywords in themselves are not contextual.

there is contextual keywords.

and there is reserved words

Mat's Mug

then the feature is half-baked

Vogel612

@Mat'sMug you just want to hate on it, right?

Mat's Mug

var f = () -> { };
^
(lambda expression needs an explicit target-type)

^^ fail

Vogel612

var f = (Runnable) () -> {};

Johan Larsson

17:52

dotnetfiddle.net/orbndL

Mat's Mug

the whole idea of introducing var in C# was to allow the concept of anonymous types

Vogel612

var fun = () => {};

Mat's Mug

the whole idea of introducing var in Java seems to be to halfway mimick C#

Vogel612

> Cannot convert lambda expression to type 'Program.var' because it is not a delegate type

same problem

Johan Larsson

java steals from c#, c# steals from f#, f# based on ocaml, ocaml ded

2

Vogel612

17:54

@JohanLarsson meh...

Johan Larsson

which part is meh?

Vogel612

@Mat'sMug is that inherently wrong?

@JohanLarsson c# stealing from f#

especially since it existed before f#

Johan Larsson

seriously?

Mat's Mug

@Vogel612 not necessarily, but where are the anonymous types?

Vogel612

in general all major languages are making a move into the functional direction

@Mat'sMug not sure what you're getting at...

Hosch250

17:56

Let me know when C# steals whitespace indentation from F#.

Mat's Mug

aka the very reason for the existence of var in C#...

Johan Larsson

I'm lloking forward to when records are stolen

Vogel612

@Mat'sMug I'm sorry you'll have to explain that to me a little... what is an anonymous type?

Johan Larsson

Will remove one of the sad parts of c#

Mat's Mug

var foo = new { Name = "Bob" }; // what type am I?

Alien Herb Nite

17:57

@Vogel612 This might help: msdn.microsoft.com/en-us/library/bb397696.aspx

Johan Larsson

@Vogel612 Name one feature added to c# after f# that is not ~stolen~.

Steal is a poor word, of course it is good to use nice things.

Vogel612

@Mat'sMug something extending Object

Transcript for