RELOAD!

[Cardshifter/Cardshifter] 13 commits. 1 opened issue. 3 issue comments.

[retailcoder/Rubberduck] 18 commits. 3 opened issues. 5 closed issues. 5 issue comments.

[Cardshifter/Cardshifter] Zomis pushed commit 7f922a2e to gdx

> fixed default constructors for API message classes

[Cardshifter/Cardshifter] Zomis pushed commit 3d6e0ca8 to gdx

> added CardshifterClientContext

[Cardshifter/Cardshifter] Zomis pushed commit d120f384 to gdx

> added some handling of actions, and actions with targets

[Cardshifter/Cardshifter] build #717 for commit d120f384 on branch gdx passed

hey!

hey

[skiwi2/HearthMonitor-LogReader] skiwi2 pushed commit adc56f25 to develop

> Added ability for parsers to only be used at a specific indentation level.

[skiwi2/HearthMonitor-LogReader] skiwi2 pushed commit e02a9595 to develop

> Renamed CreateGameGameEntity.log to GameEntity.log, similarly renamed CreateGamePlayer.log to Player.log.

[skiwi2/HearthMonitor-LogReader] skiwi2 opened issue #2: Create a strategy for the indentation level to use in parsers

> Currently you can create parsers with the following idiom: - CreateGameEntryParser.create(), will match entries at any indentation level. - CreateGameEntryParser.createForIndentation(indentation), will match entries at the specific indentation level. It would be better to supply some kind of strategy that allows it to match indentation levels either smaller than, equal or bigger than a specified indentation level. This should be able to be combined with a strategy that increases the...

specified indentation level by for example 4.

[skiwi2/HearthMonitor-LogReader] skiwi2 added label enhancement to issue #2: Create a strategy for the indentation level to use in parsers

[skiwi2/HearthMonitor-LogReader] build #63 for commit e02a9595 on branch develop passed

[skiwi2/HearthMonitor-LogReader] skiwi2 opened issue #3: Clean CreateGameEntryParser

> Currently the code in the CreateGameEntryParser class looks ugly, take this snippet from the parse method: ``` //construct a log reader from the line reader LogReader logReader = LogReaderUtils.fromInputAndExtraLineReader( lineReader.readNextLine(), lineReader, line -> (LogLineUtils.isFromNamedLogger(line) && LogLineUtils.countLeadingSpaces(LogLineUtils.getContentFromLineFromNamedLogger(l‌​ine)) > 0), new HashSet<>(Arrays.asList( (restrictIndentation) ?...

GameEntityEntryParser.createForIndentation(indentation + 4) : GameEntityEntryParser.create(), (restrictIndentation) ? PlayerEntryParser.createForIndentation(indentation + 4) : PlayerEntryParser.create() )) ); ``` The idea is that when the indentation is unrestricted, it should match all GameEntityLogEntry and PlayerEntityLogEntry at 4 indentation or higher, and not at 0 indentation or higher. I believe this can be implemented once issue #2 is resolved.

[skiwi2/HearthMonitor-LogReader] skiwi2 added label enhancement to issue #3: Clean CreateGameEntryParser

[skiwi2/HearthMonitor-LogAPI] skiwi2 pushed commit c5ea5b97 to develop

> Added ActionStartTriggerLogEntry.

[skiwi2/HearthMonitor-LogAPI] build #22 for commit c5ea5b97 on branch develop passed

[skiwi2/HearthMonitor-LogAPI] skiwi2 pushed commit 28407d61 to develop

> Added ShowEntityLogEntry.

[skiwi2/HearthMonitor-LogAPI] build #23 for commit 28407d61 on branch develop passed

Damnit!

I have an issue in HearthMonitor

I just spot these things...

> [Power] GameState.DebugPrintPower() - TAG_CHANGE Entity=skiwi tag=MULLIGAN_STATE value=WAITING

> [Power] GameState.DebugPrintPower() - TAG_CHANGE Entity=[name=Dread Infernal id=34 zone=HAND zonePos=3 cardId=CS2_064 player=1] tag=ZONE value=DECK

> [Power] GameState.DebugPrintPower() - TAG_CHANGE Entity=[id=33 cardId= type=INVALID zone=DECK zonePos=0 player=1] tag=ZONE_POSITION value=2

They are all the same log entry, right?

maybe @SimonAndréForsberg or anyone else who chimes in has opinions ;)

I try to refactor as least as possible and focus on actually implementing functionality... but I'm afraid I cannot ignore this

Also seems that one is for a player, and other two are meant for a card

Seems like one variant is used for cards of which you are not allowed to know anything, and the other is used for known cards

they don't really look the same to me

[skiwi2/HearthMonitor-LogAPI] skiwi2 pushed commit 007aa7d2 to develop

> Added EntityLogObject, PlayerEntityLogObject and CardEntityLogObject.

[skiwi2/HearthMonitor-LogAPI] build #24 for commit 007aa7d2 on branch develop passed

@SimonAndréForsberg They are the same concept though

@Duga I solved it with this...

[Cardshifter/Cardshifter] Zomis pushed commit daef5e26 to gdx

> cleaned up logging when receiving data from server

[Cardshifter/Cardshifter] Zomis pushed commit 34a4e2d6 to gdx

> fixed bug with not removing CardViewHidden views

[Cardshifter/Cardshifter] Zomis pushed commit f1106fb6 to gdx

> added some logging for CardViewHidden

bah, 6 new messages and all were from @Duga... silly me.

@SimonAndréForsberg You were wondering who talked?

yeah

it was you!

[skiwi2/HearthMonitor-LogAPI] skiwi2 pushed commit ebbcd6b2 to develop

> Updated existing classes to move to the new EntityLogObject.

[skiwi2/HearthMonitor-LogAPI] build #25 for commit ebbcd6b2 on branch develop passed

[Cardshifter/Cardshifter] build #718 for commit f1106fb6 on branch gdx passed

Now I'll also need to rewrite my parsers... ugh

[skiwi2/HearthMonitor-LogAPI] skiwi2 pushed commit 5199ce2e to develop

> Added HideEntityLogEntry.

@SimonAndréForsberg I just got caught by the same issue lol

I'm scared...

what just happened

I was doing a commit

Seems like only issuing that command was enough to recover

[skiwi2/HearthMonitor-LogAPI] skiwi2 pushed commit b9d0b194 to develop

> Renamed ActionStartTriggerLogEntry to ActionStartLogEntry.

[skiwi2/HearthMonitor-LogAPI] skiwi2 pushed commit d0a7a47b to develop

> Updated javadoc.

lol

now it gets even more fun

> [Power] GameState.DebugPrintPower() - ACTION_START Entity=[name=Faerie Dragon id=57 zone=PLAY zonePos=1 cardId=NEW1_023 player=2] SubType=ATTACK Index=-1 Target=[name=Voidwalker id=31 zone=PLAY zonePos=1 cardId=CS2_065 player=1]

[skiwi2/HearthMonitor-LogAPI] build #26 for commit d0a7a47b on branch develop passed

Apparently the index/target can refer to a number, or to a full entity...

[skiwi2/HearthMonitor-LogAPI] skiwi2 pushed commit 11266081 to develop

> Updated ActionStartLogEntry to support entities over strings for the index and target fields.

[skiwi2/HearthMonitor-LogAPI] build #27 for commit 11266081 on branch develop passed

Monking!

hey @Phrancis

Looks like my log API is almost golden :)

@SimonAndréForsberg That is entirely possible, a bit difficult to say just how much they are, though - Did you get to play test them at all?

@skiwi Ahh nice!

Only need to update and write a bunch of parsers still

@Phrancis I have playtested most of them, yes. It feels like some cards are really powerful.

@skiwi golden as in 'works' or golden as in 'clean and nice'?

@SimonAndréForsberg Well, there isn't much "working" about the api, it's that I implemented almost all relevant log entries

btw, this is awesome:

How fast trucks can break brake

@SimonAndréForsberg Well, I could see it one of two ways. Either the new ones are too powerful, or the old ones were really too weak...

@Phrancis well, the earlier ones was a bit too boring, that's for sure :)

Are you warm to the idea of a 0.5 SNAPSHOT as we talked about a few days ago?

Don't people check the pinned stuff anymore?

Oh shit did not even notice, good deal!

Is the .policy file also needed?

@Phrancis for the server, yes. I have a running server right now on stats.zomis.net port 4242 if you need a server to play on.

AFK

Yeah from work I need to run local, but I'll definitely try it tonight on your server. @bazola Are you running 0.5-SNAPSHOT on dwarftowers.com ?

[Vogel612/testclient_javabot] Vogel612 commented on issue #17: Mark replies as reply and highlight their target on hover

@Phrancis not yet but I will work on that some time today

Cool beans

[Vogel612/testclient_javabot] Vogel612 pushed commit dd36c5dc to master

> Added filtering functionality to MessageBox

[Vogel612/testclient_javabot] Vogel612 added label closed-as:completed to issue #17: Mark replies as reply and highlight their target on hover

[Vogel612/testclient_javabot] Vogel612 closed issue #17: Mark replies as reply and highlight their target on hover

[Vogel612/testclient_javabot] Vogel612 pushed commit e9d28e88 to master

@SimonAndréForsberg soo.. linesplitting now works fine?

[skiwi2/HearthMonitor-LogAPI] skiwi2 pushed commit eb8a316f to develop

> EntityLogObject now implements LogObject.

That was... kind of crucial

[skiwi2/HearthMonitor-LogAPI] build #28 for commit eb8a316f on branch develop passed

[skiwi2/HearthMonitor-LogReader] skiwi2 pushed commit 54ec0405 to develop

> Added the ObjectParser interface.

[skiwi2/HearthMonitor-LogReader] skiwi2 pushed commit 03d68bbd to develop

> Added EntityObjectParser.

[skiwi2/HearthMonitor-LogReader] skiwi2 pushed commit 7724f23a to develop

> Updated TagChangeEntryParser and TransitioningEntryParser to use the new EntityLogObject.

[skiwi2/HearthMonitor-LogReader] build #64 for commit 7724f23a on branch develop passed

@Phrancis You know there is a pull request waiting to be merged (made by you ) ;)

github.com/Cardshifter/cardshifter.github.io/pull/29

Yeah haven't got a chance to test it, I don't know if it works or not

Don't want to merge something if it's broken, do I?

I've only made changes one on of the HTML, and added one template, so I guess it wouldn't be that bad even if it didn't work

I've tried synching STS to the pull request but wasn't able to, I must be doing something wrong with either Git or STS (or both)

Guess I'll just merge it to develop and fix it tonight if it doesn't work right

[Cardshifter/cardshifter.github.io] Phrancis merged pull request #29: Create header.html template from header-template into web-content

[Cardshifter/cardshifter.github.io] Phrancis pushed 4 commits to web-content

[Cardshifter/cardshifter.github.io] Phrancis pushed commit 7368fe9d to web-content

TTGH but I'll check it later too !

OK. The file I put the change in is index.html - And damn, getting off work at lunch time? ;p

No I need to go to the dentist

so leaving early

[Cardshifter/cardshifter.github.io] Phrancis deleted branch header-template

@Phrancis That's generally in all cases a good idea yes!

[skiwi2/HearthMonitor-LogReader] skiwi2 pushed commit c75a10f0 to develop

> Added HideEntityEntryParser.

[skiwi2/HearthMonitor-LogReader] build #65 for commit c75a10f0 on branch develop passed

[skiwi2/HearthMonitor-LogReader] skiwi2 pushed commit f81225a1 to develop

> Fixed typo in the comments.

[skiwi2/HearthMonitor-LogReader] skiwi2 pushed commit d81f32f3 to develop

> Fixed another typo in the comments.

[skiwi2/HearthMonitor-LogReader] build #66 for commit f81225a1 on branch develop passed

[skiwi2/HearthMonitor-LogReader] build #67 for commit d81f32f3 on branch develop passed

[skiwi2/HearthMonitor-LogReader] skiwi2 pushed commit a192db3b to develop

> Fixed incorrect variable name.

[skiwi2/HearthMonitor-LogReader] build #68 for commit a192db3b on branch develop passed

[skiwi2/HearthMonitor-LogReader] skiwi2 pushed commit 7c480d2e to develop

> Fixed incorrect test method names.

[skiwi2/HearthMonitor-LogReader] build #69 for commit 7c480d2e on branch develop passed

[skiwi2/HearthMonitor-LogReader] skiwi2 pushed commit 78ea5cf1 to develop

> Added ShowEntityEntryParser.

One more parser to go!

Unfortunately, it's the most difficult one

[skiwi2/HearthMonitor-LogReader] build #70 for commit 78ea5cf1 on branch develop passed

[skiwi2/HearthMonitor-LogAPI] build #29 for commit 5199ce2e on branch develop passed

@Vogel612 I think so, yes. I guess the only thing left is to add a quote mark at the beginning of the next message, but that shouldn't be a problem.

Is there anything re-usable for visually showing a game of HS?

[skiwi2/HearthMonitor-LogReader] skiwi2 pushed commit 53dca8e1 to develop

> Fixed javadoc typos.

[skiwi2/HearthMonitor-LogReader] build #71 for commit 53dca8e1 on branch develop errored

@skiwi, your build reported bad status: Errored!

@Duga huh?

Suddenly... compiler error?

@Duga Argh, that's an old commit that built late and is now giving issues!

As an out-of-date snapshot got published

@skiwi In Cardshifter? Absolutely.

[skiwi2/HearthMonitor-LogAPI] build #29 for commit 5199ce2e on branch develop passed

@SimonAndréForsberg Like, which ones? I don't want to redo things if not necessary for HearthMonitor :p

@skiwi like.... all of it?

[skiwi2/HearthMonitor-LogReader] skiwi2 pushed commit ce392a2f to develop

> Fixed issue with reading extra lines in CreateGameEntryParser.

@SimonAndréForsberg you maybe want to investigate reassembleTokens there

@SimonAndréForsberg I'm more or less looking for a view where relevant hero/cards are shown and where you manually can go to next turn/next step, etc.

[skiwi2/HearthMonitor-LogReader] build #72 for commit ce392a2f on branch develop errored

@skiwi, your build reported bad status: Errored!

@Duga No, it didn't error!

[skiwi2/HearthMonitor-LogAPI] skiwi2 pushed commit b994f224 to develop

> Fixed comment.

Hopefully this will trigger a correct build

[skiwi2/HearthMonitor-LogAPI] build #30 for commit b994f224 on branch develop passed

Uh...

please don't scream

Set<EntryParser> innerEntryParsers;
try {
    innerEntryParsers = entryParsers.stream()
        .map(Object::getClass)
        .map(clazz -> {
            try {
                if (restrictIndentation) {
                    if (clazz.equals(ActionStartEntryParser.class)) {
                        Method method = clazz.getDeclaredMethod("createForIndentation", int.class, Set.class);
                        return (EntryParser)method.invoke(null, indentation + 4, entryParsers);
                    }

But how does this introduce cyclic inference?

Maybe I'm now too heavily using the ship first, fix later route though!

Oh nevermind

Forgot .collect(Collectors.toSet());

[skiwi2/HearthMonitor-LogReader] build #72 for commit ce392a2f on branch develop passed

@Duga Yasay!

[skiwi2/HearthMonitor-LogReader] skiwi2 pushed commit 6b5b2827 to develop

> Added ActionStartEntryParser, still contains lots of hacks.

[skiwi2/HearthMonitor-LogReader] skiwi2 added label enhancement to issue #4: Fix ugly hacks in ActionStartEntryParser

[skiwi2/HearthMonitor-LogReader] skiwi2 opened issue #4: Fix ugly hacks in ActionStartEntryParser

> In the parse method in the ActionStartEntryParser class there currently is this block of code: ``` //TODO clean this up Set<EntryParser> innerEntryParsers; try { innerEntryParsers = entryParsers.stream() .map(Object::getClass) .map(clazz -> { try { if (restrictIndentation) { if (clazz.equals(ActionStartEntryParser.class)) { Method method = clazz.getDeclaredMethod("createForIndentation", int.class, Set.class); return (EntryParser)method.invoke(null, indentation + 4, entryParsers); }...

Method method = clazz.getDeclaredMethod("createForIndentation", int.class); return (EntryParser)method.invoke(null, indentation + 4); } if (clazz.equals(ActionStartEntryParser.class)) { Method method = clazz.getDeclaredMethod("create", Set.class); return (EntryParser)method.invoke(null, entryParsers); } Method method = clazz.getDeclaredMethod("create"); return (EntryParser)method.invoke(null); } catch (NoSuchMethodException | InvocationTargetException | IllegalAccessException ex) { throw new...

RuntimeException(ex); } }) .collect(Collectors.toSet()); } catch (RuntimeException ex) { throw new NotParsableException(ex); } ``` The goal is to instantiate the supplied set of entry parsers with the correct indentation level. The best solution may be to use a factory pattern and supply the factories instead.

[skiwi2/HearthMonitor-LogReader] skiwi2 opened issue #5: EntryParser/ObjectParser should be generified.

> The EntryParser and ObjectParser should know which entries/objects they are parsing via generics.

[skiwi2/HearthMonitor-LogReader] skiwi2 added label enhancement to issue #5: EntryParser/ObjectParser should be generified.

[skiwi2/HearthMonitor-LogReader] build #73 for commit 6b5b2827 on branch develop passed

[skiwi2/HearthMonitor] skiwi2 pushed commit 22e65452 to develop

> Improved parsing for FullEntityLogEntry, TagChangeLogEntry and TransitioningLogEntry log entries.

Guess I've done some stuff today

Can't wait to see the reload tomorrow!

[skiwi2/HearthMonitor] build #18 for commit 22e65452 on branch develop passed

@Duga Thanks!

Who's the secret starrer here?

me

hehe, ok

[Cardshifter/cardshifter.github.io] Zomis added label new page to issue #32: Use Cardshifter code to view cards

[Cardshifter/cardshifter.github.io] Zomis added label enhancement to issue #32: Use Cardshifter code to view cards

[Cardshifter/cardshifter.github.io] Zomis added label graphics to issue #32: Use Cardshifter code to view cards

[Cardshifter/cardshifter.github.io] Zomis opened issue #32: Use Cardshifter code to view cards

@Phrancis @Marc-Andre what do you think of that suggestion? ^^

@SimonAndréForsberg github.com/Cardshifter/cardshifter.github.io/issues/18

I say we are ready to do this :P

@Marc-Andre erhm... sorry... perhaps mine should be marked as duplicate? or are they two separate issues?

They feel similar to me, but @Phrancis is good at managing issues !