1
-2
1
I'm going to try to review this in spite of the lack of decent indentation and whitespace (in some places). As such, I won't mention them below. I'd recommended improving on this first, as that will help you improve everything else.
The #include <...>s could be in alphabetical order for bette...
3
Following up on List<T> implementation for VB6/VBA, I'd like some thoughts about the revisited IsTypeSafe function, below.
The previous version pretty much implemented VB.net's Option Strict setting, by only allowing widening numeric type conversions, and preventing implicit conversion between n...
1
I have never used SQLite either, but something is jumping at me in your code: the addAuthor() procedure owns the connection, which means if you're calling it 10,000 times in a loop you're going to be opening and closing 10,000 connections, which is ..well to be honest, nuts.
Looking at the metho...
1
I'm not going to rewrite this code right now, but I can highlight a few points:
Naming.
Identifiers should have a meaningful name.
Disemvoweling is evil.
Adding a 1 after an identically-named variable is bad.
Adding a 2 after an identically-named variable is terrible.
Adding 21 instead of a 3...
public class Singleton {
private static volatile Singleton instance = null;
public static Singleton getInstance(){
if(null == instance){
synchronized(Singleton.class){
//double check
if(null == instance){
instance = new S...
0
0
I need to add logging functionality for an existing code, based on a result of an operation. I was thinking of creating a class that when constructed receives a condition function and a function for execution, and based on the result of the condition, the code will be executed.
Example:
class ...0
0
I have a library that's parsing some expressions, part of which is a CSS selector. More accurately, it's a jQuery-compatible selector. The selector itself is opaque to my library - I don't need to pick it apart, and I don't need to verify that tag and attribute names are valid HTML, or that its...
This is my first foray into the wild world of jQuery plugin development. The plugin "ajaxifies" forms, which isn't particularly spectacular:
It gets the basics (action, method) from the form itself, serializes the form's fields, and sends the request.
Users can provide (via its options) callb...
This is a question about performance and what pattern would be favorable to that.
Often there are people who say the module pattern (closures) is perfect (it can be in some situations) and point to Douglas advocating it.
It may however be a bad desing if a lot of instances need to be created ...1
A number of Questions have come up recently where the code is not the asker's own code, prompting a 'close' response. It would be convenient if there was an 'off-topic' close option that included:
off-topic because the code you want reviewed is not your code. See the help (item 2) for on-topi...
I have implemented a solution to Project Euler problem 5:
2520 is the smallest number that can be divided by each of the numbers from 1 to 10 without any remainder.
What is the smallest positive number that is evenly divisible by all of the numbers from 1 to 20?
My solution uses Python 2....
