I advised you that it is called main and not everything, and you did a good job of moving code out of main. Now main looks a lot closer to what I'd expect to see.
But, we still have functions that are doing too much. Plus, we've made a bad problem worse. We've replaced doing everything in the...
I'm new to Ruby and don't know all the methods, so I was thinking there would probably be and easier way to do something like this. I'd love any input on how to refactor this Thanks!
define_singleton_method(:delete) do |id|
revised_words = []
@@words.each do |word|
...
I've posted an excerpt from my Nginx configuration with the hope that someone can give me advice on anything I've done wrong or could do better. Please note that the below config works, but has been edited for brevity.
The area I'd like you to focus on is TEST1 and TEST2.
TEST1 is redirecting...
I tried deleting a file using a function.
Here is the function: http://pastebin.com/p6GBmVVT
I get an error on line 10. It tells me that the variable I'm using is not suitable for conversion or something along the lines of that.
Am I using the std::remove() function wrong? Any help is appreci...
This question caught my eye because it had accumulated close votes as being a duplicate of another question, which is very rare on CR. The target was a question I reviewed last year by the same user.
The new question:
Has no indication that it is a follow-up.
Makes all of the same mistakes as...
Here is my function code.. I am getting so lost I don't know what to do anymore.
{
int i, j;
int length;
for(i=0; string[i] != '\0'; i++)
{
length++;
}
while(i<length/2 )
{
if(string[i] != string[length-1-i])
{
return FALSE;
...
I built a calculator in C# with WPF for the UI. I'm still a beginner at WPF and C# in general, and I'm just looking for some constructive criticism.
Here's the XAML
And here's the MainWindow.xaml.cs file
Hosted on pastebin because they might be a bit long
The user will input two number (say 19 (starts with 0) and 5). We need to equally divide 19 equally into 5 groups such that each group will have the start index and the end index. Example:
Grp 1: 0 1 2 3
Grp 2: 4 5 6 7
Grp 3: 8 9 10 11
Grp 4: 12 13 14 15
Grp 5: 16 17 18...
this is my first try for the SPOJ ADDREV problem. Please correct me if am wrong. My compiler gives me right answer. But SPOJ doesnt accept it.
problem link
#include<iostream>
#include<string>
#include<algorithm>
#include<vector>
#include<sstream>
int main()
{
int num1,num2;
std::stri...
As a morning exercise I have been writing an implementation of Mengenlehreuhr in Python using curses.
The source of this is as follows:
import curses
from datetime import datetime
from math import floor
class Mengenlehreuhr():
screen = None
panel_name = [
'seconds', 'five_hours...
I have the following tables:
val postTable = TableQuery[Posts]
val postTagTable = TableQuery[PostTags]
val tagTable = TableQuery[Tags]
One post can have multiple tags and postTagTable just contains the relation.
Now I could query the posts and tags like this:
val query = for {
post <- po...
Moderator Note:
This question has been identified a number of times as being a
candidate for migration to Meta.SE - the main meta site.
This question is really about tracking Code Review's 'probable' spot
in line, and is not a general purpose all-beta-site tracking system,
thou...
This is an extension method to get a string that is no bigger then a maximum length.
Any comments?
public static class StringExtensions
{
public static string WithMaxLength(this string value, int maxLength)
{
if (value == null)
{
return null;
}
...
First I want to thank you for the update. This graduation procedure has been taking so long already that we sometimes feel a little forgotten. I also want to thank you for asking us this question instead of forcing it on us.
There are things this community has, needs and doesn't need.
What we h...
I often see questions which are blatantly off-topic, like, for instance, when this question (can only be viewed with enough rep, as it has been deleted) showed up.
The shown c# code had been
try
{
int a;
int b;
int c=a+b;
}
catch (exception ex)
{
//Nothing here
}
Which is,...
I would like a review of the RAC implementation for the function setGist()
I've posted the code on gist.github.com for easier reading: https://gist.github.com/lfaoro/18ca4b63ed982574eec2
Any suggestions would be highly appreciated, thanks everyone in advance.
enum ConnectionError: ErrorType {
...
While @Mat'sMug has an awesome C# 6.0 solution, if you aren't using C# 6.0, or don't plan to update, you might want to make these changes.
First of you're just checking for a null string value. What if the user enters an empty string as well? You have three options here
Return null when an emp...
If you're using C# 6.0, I believe you can drop the null-check:
public static string WithMaxLength(this string value, int maxLength)
{
return value?.Substring(0, Math.Min(value.Length, maxLength));
}
Other than that, it's like Jeroen said: that's pretty much as good as it gets.
The class a...
A new diagnostic has seen the light of day! This one will alert you when you have a string.Format() call where the formatting placeholders in the wrong order. The right order is defined as
For each placeholder with index N, its value should be higher or equal to the placeholder at index N-1
...
I'd like to get a review for the function build_list() which reads a file containing words (separated by spaces) and returns a linked-list of words:
#include <stdio.h>
#include <assert.h>
#include <stdlib.h>
typedef struct ListNode {
char* word;
struct ListNode *next;
} ListNode;
typed...I've completed a program as a learning experience to make sure I've got the concepts down. I found the practice project online and decided to try it out. The program compiles and runs exactly how it should with no problems.
The program is a game called Artillery. You have to fire a cannon at one...
I wrote a python sort function that uses shell sort.
Here it is:
# shell sort
# ignore the comments
def shell_sort(sequence):
# shell sort needs an increment sequence
# the increment sequence used here is 1, 2, 4, 8, 21, 56, 149, 404, 1098...
# the sequence is defined by the followin...
