The 2nd Monitor

@Mat'sMug Does this inspection just see if there are no references? github.com/rubberduck-vba/Rubberduck/issues/798

That would prevent those bugs, I believe, although it might break it in other use cases.

I don't understand

A variable should not be removed if there are references to it.

correct

12:25 AM

So basically, just see if the variable has references - otherwise, offer to remove it.

That way, any bugs are in the reference thingy.

most of the problems with that inspections stem from the resolver

Ah, OK.

That sounds like an incredibly tricky part of the program.

_declarations.Item.Where(e => e.DeclarationType == DeclarationType.Variable && !e.References.Any())

^^ in a nutshell

(there's a bit more to it)

OK, so that bug is the resolver, not the inspection.

correct. e.References is assumed to contain all references

FWIW, I have an unsynced commit that fixes the WithEvents bug

the For/For Each part is already fixed

12:29 AM

OK.

I'm surprised the resolver doesn't pick up the second one.

@mjolka given "if Equals returns true for two objects, these two objects must have the same hash code", ..how is OP's implementation compliant?

@Hosch250 which?

Dim ax As Axis
Set ax = cht.Axes(xlValue)

ax.MajorGridlines.Border.Color = RGB(200, 200, 200)
ax.MinorGridlines.Border.Color = RGB(230, 230, 230)
ax.Crosses = xlAxisCrossesMinimum

oh yeah.. that was overlooked

a dumb bug

mjolka

@Mat'sMug if pin.Equals(other) == true, then pin.Id == other.Id, so pin.GetHashCode() == pin.Id.GetHashCode() == other.Id.GetHashCode() == other.GetHashCode()

Huh, you said it does work.

12:31 AM

now it does

OK.

@mjolka that's facepalm-worthy right?

mjolka

@Mat'sMug ?

I somehow got mixed-up

you're right

I've upvoted this answer because it makes a very good reference for implementing Equals and GetHashCode. However if pin.Equals(other) == true, then pin.Id == other.Id, so pin.GetHashCode() == pin.Id.GetHashCode() == other.Id.GetHashCode() == other.GetHashCode() (thanks @mjolka) — Mat's Mug ♦ 57 secs ago

stole it ;-)

mjolka

@Mat'sMug :)

12:36 AM

@Mat'sMug huh? You lost me. Might have made more sense if the code could have been properly formatted. — RubberDuck 18 secs ago

I sense a duck coming

If Equals was based on Id and GetHashCode on the 4 fields involved here, then yeah OP's implementation wouldn't have been compliant. But it is ;-) — Mat's Mug ♦ 41 secs ago

12:57 AM

@Mat'sMug Can I ask you a question quick? (It's a best-practices question)

sure

I've got this DB table, called dbo.Settings. Right now I have five columns in it. Name (nvarchar(64)), Value (nvarchar(128)), GroupId (int), ValidValuesMessage (nvarchar(MAX)), and DisplayName (nvarchar(MAX)).

The problem, is that Name is the PK.

And I use Name in the programme to get the setting values.

I.e.: masterDbContext.Settings.First(x => x.Name == "PostsPerPage").Value

(EF6 by the way.)

@EBrown *program

I'd make an int PK and have a unique constraint/index on Name

Yup.

In my DB book, we always create a Name_ID for PK.

1:00 AM

@Mat'sMug But is this idiomatic in the code?

it's bug-prone

For example, by that route it would become masterDbContext.Settings.First(x => x.Id == 5).Value.

Now you have to remember what 5 represents.

(This is the reason I ask.)

masterDbContext.Settings.SingleOrDefault(x => x.Name == "PostsPerPage")?.Value

no, the PK is irrelevant

I'm Torn (Natalie Imbruglia).

@Mat'sMug So just use Id int as the PK, but use Name (varchar(64)) as the reference value?

yes

only the DB needs to care about a PK

1:02 AM

@Hosch250 noun: programme "a series of coded software instructions to control the operation of a computer or other machine."

@Mat'sMug Alright. That's easy enough, right now the PK is on Name.

what you care about is a Natural Key / NK

@Mat'sMug Aha, that's exactly what I needed to hear.

So, I'll change the Name to not be a PK, but instead have a Unique constraint.

And make an Id (int) as the PK.

and thank yourself later ;-)

@Mat'sMug Yeah, I thought that using Name (nvarchar(64)) was a smell.

        [Key()]
        public int Id { get; set; }

        [Index(IsUnique = true), MaxLength(64)]
        public string Name { get; set; }

@Mat'sMug Fixed.

I love EF Code First.

@EBrown You can program databases in C#?

I didn't know you could define them in C#.

1:05 AM

@Hosch250 Sorta. It's called "Code First" and it allows you to declare your models, then have Entity Framework create the DB as needed.

@Hosch250 that's the beauty of code-first

I get to use GUI's and SQL.

@Hosch250 msdn.microsoft.com/en-us/data/…

Huh, interesting.

it's actually EF creating the db

1:06 AM

It's really cool.

you override OnModelCreating in your DbContext implementation

public int? GroupId { get; set; }

[ForeignKey("GroupId")]
public virtual SettingGroup Group { get; set; }

I prefer using mapping classes instead of polluting the POCO's with attributes though

So what that does is save GroupId to the DB, but then when EF loads the model, it will also (lazy) load the SettingGroup model with that GroupId.

@Mat'sMug That's "Fluent API".

no

classes

1:07 AM

You don't use Fluent-API for it?

        DbModelBuilder.Entity<RoleForumPermissions>().HasKey(x => new { x.RoleId, x.ForumId });
        DbModelBuilder.Entity<PrivateMessageTopicMembership>().HasKey(x => new { x.TopicId, x.UserId });

So beautiful.

that gets very verbose

The problem I have is I use Fluent-API and Annotations together.

Because I don't trust either exclusively.

I can't remember exactly the name of the base class off the top of my head, but essentially you make a member for each of those HasKey calls instead

then you load the mappings into the modelbuiler

makes a pretty clean OnModelCreating override, and annotation-less POCO's

Ah, I like my annotations though.

They make it easy for me to see what's going on in the POCO itself.

Though I am worried that I went from Web Forms to an MVVM style.

I now have the two combined in one application.

But I think it'll be fine.

@Mat'sMug Do you ever have issues with the Package Manager Console erroring on you?

nope

1:14 AM

Damn.

@EBrown Yes.

man, why does it feel like whenever I post an answer on SO, I need to pimp RD? stackoverflow.com/a/32929094/1188513

If I open it once, then leave it for a while, it throws an error when I go back to it.

Not sure why, but it started when I installed every feature VS offered, and stopped when I uninstalled most of them.

@Hosch250 Peculiar. I don't have all of them selected.

1:16 AM

Probably just one culprit...

You think EF will populate my new ID column correctly?

@Hosch250 I think it has something to do with this SO question.

I bet the two are related.

I wonder if Powershell on this system isn't borked.

Dunno. I was having a NuGet error.

I have some error with it, can't remember what.

Makes it a PITA to do migrations though.

Once I scaffold one migration, if I make another later on, I have to restart VS to scaffold another migration.

@EBrown EF, no. SQL Server, yes. the [Key()] annotation makes an identity column by default

@Mat'sMug Problem is how will it fill those ID's?

1:19 AM

SQL Server does

Does it really?

Id int identity(1,1) not null primary key

yes

Holy f---.

It did.

Wtf.

Just what I wanted it to do.

@Mat'sMug I owe you a cookie.

lol

Wonder if I should reinstall Windows.

Oh wait, I already did.

1:21 AM

you seem to have quite a lot of time on your hands

No, I just keep losing dev time to this f---ing publish dialogue.

got 30 hours to lose? hey, reinstall VS!

@Mat'sMug That was a fluke.

After rebooting my PC the install took an hour.

> Time to install: 1hr, time to uninstall: 30hr. microsoft

This ASPX is a mess.

Business Logic != Display Logic, quit doing that.

2

At least this product can use Markdown. That's a nice reprieve.

commitstrip.com/en/2013/07/04/…

Even better: commitstrip.com/en/2013/07/01/quand-lapi-rend-fou

1:42 AM

Hello

Monkeve.

Hey.

> Visual Studio 2015 has stopped working

How is everyone doing?

@EBrown Huh?

All I wanted to do was commit to my Bitbucket.

But no, you had to go and crash on me VS.

Such a prick.

@MannyMeng My Visual Studio is borked somewhere.

Well, more than that, my Windows install is borked somewhere.

1:44 AM

@EBrown lol

And I don't have the time (or energy) to fix it.

use something else then.

Can't.

oh.

1:59 AM

seems like the only time this place is active is when someone comes on.

weekends can be like that

(hi!)

(hello!)

Well, I'm going to bed.

'night!

Take care everyone, I'll catch you all later.

2:05 AM

goodnight!

man, that Rubberduck TestEngine is convoluted

2:49 AM

This question would be more appropriate for the Code Review stack exchange site, however be sure to read their how to ask guidelines to make sure your question is in a format that is on topic for that site. — Scott Chamberlain 40 secs ago

This sounds like a perfect question for Code Review. — Drew Gaynor 23 secs ago

Q: I need help building a two player turn based simple dice game in Javascript

@Duga what would we do without you?

StackOverflow

-1

I relatively new to programming so forgive me for my code. The goal is to create a simple dice game in which there are two players in Javascript. Each time the "roll the dice" button is clicked, it triggers the roll dice function. the roll dice functions rolls two dice using the random function, ...

@StackOverflow Oh come on.

Then you need to narrow down on the issue and ask a more specific question; as it stands this question is too broad to be on-topic. Also, make sure you take a look at the tag wiki for the code-review tag ;-) — Mat's Mug 25 secs ago

yeah

F* this S* lol

3:04 AM

If the code is not working yet (as it appears to be the case), please note this would be off-topic for CodeReview.SE. — Phrancis 34 secs ago

Hey I made some apparently working, OO code

<Question><CodeDump/>Where's my bug?</Question>

Or, "OO", as this is ChucK and not fully-featured

so, is it "OO", or "uh-oh"?

Well,... ... a bit of both, but it works so far

3:09 AM

Is it just me who got a bizarre mortarboard badge?

@rolfl yup

which site?

Bug ^^^

@rolfl no repro

public class OscPitch
{
    this.freq => float freq;
    getSemitoneRatio() => float SEMITONE;

    fun float getFreq() { return freq; }
    fun void setFreq(float val) { val => freq; }

    fun float change(float steps)
    {
        freq * Math.pow(SEMITONE, steps) => freq;
        setFreq(freq);
        return freq;
    }

    fun float getSemitoneRatio()
    {
        return Math.pow(2.0, 1.0/12.0);
    }
}

tired of rep-capping on CR, you start rep-capping on PPCG now? ;-)

Yeah, without earning any rep too... ;-)

Hmmmm: codegolf.stackexchange.com/help/badges/25/…

3:11 AM

I'm actually a bit surprised I can call getSemitoneRatio() within the object itself, but that's probably due to my inexperience in OO

I actually earned that badge a while ago on that site.

A: I need a program where the user inputs an array of doubles and the program outputs the array sorted

must be a COBOL bug

> Awarded dec 28 '13 at 22:31

37

COBOL Sure! "Even a monkey can do this!" Here is a simple COBOL program that will sort the input for you. Read the comments to see exactly how trivial and extensible it is. The real benefits of this are that it is tried and true mechanism, it does not rely on new and relatively untested langu...

answered dec 27 '13

Q: Spurious, incorrect notification of previously awarded mortarboard

0

Well, I got a surprise in my notification inbox just now.... apparently I was just awarded a mortarboard on PCG (Code Golf).... except, I have had no reputation on that site for a while, and I was awarded that badge a couple of years ago... This is what my notifications currently look like: T...

bug badges achievements-dialog

> it's probably too long to blame caching.... given that it's two years too late.

2

lol

hahaha

3:31 AM

Functions are fun

This is weird though, maybe...

> [chuck](VM): sporking incoming shred: 1 (Untitled)...
110.000000 :(float)
220.000000 :(float)
440.000000 :(float)
880.000000 :(float)
106102874769984 :(OscPitch)

OscPitch foo;
110 => foo.freq;
<<< foo.getFreq() >>>;
foo.setFreq(220.0);
<<< foo.getFreq() >>>;
foo.change(12);
<<< foo.getFreq() >>>;
foo.change(12);
<<< foo.getFreq() >>>;
<<< foo >>>;

Wonder why 106102874769984 is the value of foo, but the get value is actually the value I'm after

Or is it possible that 106102874769984 is just the computer's way of storing 880.000000?

I doubt that

but I have no idea what that code does

<<< foo.freq >>>; // 880.000000 :(float)

Maybe that big random number is just its memory location or something?

why would a memory location become the value of foo?

I have no idea why it would, it probably doesn't

Maybe the foo object just has an Id, and that is it

Also, this might be a better question for Code Review. — Nate Barbettini 1 min ago

4:27 AM

0

Q: Agario Java code

I made a agario single player version(soon to become a multi player one using socket). What can be some improvements? Controller: package agario; import java.awt.Color; import java.awt.Frame; import java.awt.Graphics; import java.awt.Rectangle; import java.awt.event.MouseEvent; import java.awt...

java gui

Q: Beautiful Soup -- replace the src of an img tag with a variable

4:44 AM

0

I am new to Python and beautiful Soup. Here's my HTML I would like to replace the 'src' of this image (there is only one occurrence of the image so no need of a loop). The new src which is a hyperlink is coming from an excel file which is read into my python file as a variable. Can this be done...

python beautiful-soup

5:11 AM

Java update popped up at the same time as another program crashed. I'm going to silently assume blame.

5

Hello

Jamal

This user is probably one of the worst help vampires I've seen.

@Phrancis I would too

Just checking in using the stack app. i would rather use a computer....

@Jamal Gotta love the type...

Jamal

@Malachi Same here. I still use the browser app, but sometimes the SE app for certain edits.

5:21 AM

gosh

I use ChatSEy for chat

i need the code can someone help me... — Mark Joseph Medina Carrillo 29 mins ago

Sleeping in the RV again tonight!. Ttgtb later all!

Still waiting for ChatSEy for iPhone... Safari will do meanwhile...

Jamal

sir can u transfer it in java thx.... — Mark Joseph Medina Carrillo 17 mins ago

5:23 AM

@Malachi Later motorcycle guy

users.ignore("mark-joseph-medina-carrillo");

And, of course; the crash lost what I had been working on. Man I need to get this on VCS

5:38 AM

0

Q: Keeping Node Routes DRY

I have a very simple Node application that routes requests to /users to the following file: users.js var express = require('express'); var router = express.Router(); var User = require('models/user'); var sequelizeSuccessHandler = require('lib/sequelizeSuccessHandler'); var sequelizeErrorHandle...

node.js express.js

6:00 AM

possible answer invalidation by Quill on question by RedPanda: codereview.stackexchange.com/posts/106355/revisions

Q: ADT stack in C with dynamic array

0

I'm starting to learn about data structures. I'm also learning to code in c. The stack is the simplest of all data structures so I'm trying to implement an ADT stack with dynamically allocated array in c. This implementation does have one obvious problem i.e. it hoards memory even after popping t...

c data-structures stack

~~TTGTB~~ SHBIBAHA

should have been in bed an hour ago

6:35 AM

possible answer invalidation by Maroloccio on question by Maroloccio: codereview.stackexchange.com/posts/106473/revisions

Q: MS SQL FileTable and View Concerns

0

Looking for a better way to manage employee photos for employee records in our database, and a way to query for the employee photos while having them on disk I have used a FileTable to store all the EmployeePhotos. Then in my Employee View I created a join using substring's... Which I am concer...

sql-server

Q: Find the hypotenoues of triangle

6:56 AM

0

Following is a problem from CodeChef: Transform the Equilateral triangle keeping two sides fixed and alter the third side such that it still remains a triangle, but the altered side will have its length as an even integer, and the line drawn from the opposite vertex to the mid-point of the al...

python performance algorithm mathematics

0

Q: ADT stack in c with dynamic array

I'm starting to learn about data structures. I'm also learning to code in c. The stack is the simplest of all data structures so I'm trying to implement an ADT stack with dynamically allocated array in c. This implementation does have one obvious problem i.e. it hoards memory even after popping t...

c data-structures stack

Q: Find common "characters" in 2 given strings (rev2)

7:09 AM

1

Could you help me further improve this code, which includes some feedback from this site already (Find common "characters" in 2 given strings)? import java.util.ArrayList; import java.util.Arrays; import java.util.Collection; import java.util.List; import java.util.Set; import java.util.stream.C...

java

Q: Find common “characters” in 2 given strings (rev3)

7:26 AM

0

Could you help me further improve this code, which includes some feedback from this site already (Find common "characters" in 2 given strings (rev2))? import java.util.ArrayList; import java.util.Arrays; import java.util.Collection; import java.util.List; import java.util.Set; import java.util.s...

java

8:00 AM

0

Q: encryption wrapper code

I am writing an encryption class using Crypto++. The idea is the client connects using RSA(Encrypt,Decrypt) with username, password, 32 byte key. The server will then return using the stream cipher(simEncrypt,simDecrypt) a session id. Then any communication between the systems use the stream...

c++

Q: Find common “characters” in 2 given strings (rev4)

8:57 AM

0

Could you help me further improve this code, which includes some feedback from this site already Find common “characters” in 2 given strings (rev3)? import java.util.ArrayList; import java.util.Arrays; import java.util.Collection; import java.util.Iterator; import java.util.List; import java.uti...

java

9:19 AM

Holy mother of follow-ups...

4

9:49 AM

~~Hi again,~~ *Monking!*I am thinking of making a convenient, arbitrary precision java library that provides functionalities for encapsulating surds, complex numbers, constants like pi, e, etc.

I wnt teh opinionz...

(Is there something wrong with the MD renderer? I'm sure I posted valid MD)

Hmm... Since the room is empty now, I'd better post my requests. They are:

@ambigram_maker Apache Math is not good enough?

My suggestion: Don't reinvent that wheel. That's a big wheel to reinvent. If you want to reinvent a wheel, there are many other wheels you can reinvent instead.

Right.

Does it have interoperability with BigDecimal? (Also, I think a beginner might be easily overwhelmed by the Apache library)

@ambigram_maker Are you the beginner, or is someone else the beginner?

Some one else, say...

Read about Apache Commons Math here: commons.apache.org/proper/commons-math

10:05 AM

I was just doing that...

What makes you think that a beginner would use your mathematics library? What would make your library stand out of the crowd?

Because it wouldn't evaluate an expression unless required.

that sounds like functional programming

Yep. I would provide an ExpressionBuilder to keep constants and surds as is.

first answer by a new user, could use some upvotes codereview.stackexchange.com/a/106463/81541

10:07 AM

Does a beginner care about when the expressions are evaluated? How much does a beginner know about functional programming?

The beginner may care about the accuracy. :)

(I meant precision)

It's easy to be overwhelmed by the Apache libraries, but it is also good practice to acquaintance yourself with them.

@ambigram_maker commons.apache.org/proper/commons-math/javadocs/api-3.5/org/…

If you want full precision for mathematical constants like e or pi, good luck.

Wikipedia says one only need pi upto the 39th digit after the decimal to calculate the volume of the universe accurate to the nearest length-of-a-Hydrogen-atom.

Also, monking

Chronology of computation of π

I hope my users wouldn't be dumb enough to set about setting a new world record. :)

You guys get it, right?

If you don't:

The table below is a brief chronology of computed numerical values of, or bounds on, the mathematical constant pi (π). For more detailed explanations for some of these calculations, see Approximations of π. == See also == History of pi == References == == External links == Borwein, Jonathan, "The Life of Pi" Kanada Laboratory home page Stu's Pi page Takahashi's page...

10:13 AM

I doubt your users would even be interested in pi upto the 39th digit. And if they do care about that, they will probably go with another, more well-known, library instead of yours...

I would too. ;)

I don't want to discourage you from making anything, but I'd like you to reflect on why you are really making it. And consider what things your target audience care about, and why, and all the implications...

Functional programming might be a motive. Also, convenience.

And clarity.

@SimonForsberg BTW: (Another topic). If I write some code and add a (c) ambigram_maker 2015, does it become a copyright? Is something else required to copyright my code?

Also, is YAML used these days? The project seems to be stuck in 2009.

10:30 AM

@ambigram_maker Probably a better question for law.se

@Zak Yeah, I'll do that.

A: What can I assume if a publicly published project has no license?

@ambigram_maker Well, technically, you don't even need to add that.

28

If a repository has no license, then all rights are reserved and it is not Open Source or Free. You cannot modify or redistribute this code without explicit permission from the copyright holder. I'm unsure of the legal implications of actually pulling the source local and building/using the so...

Not too many people are aware of that though.

Interesting....

Do you know of any person/organisation that uses YAML. I'm interested to build a parser for it jYAML is ancient.

But if you want to make a library, then what license do you really want to apply to it? Read through a couple of licenses and think: Do I want other people to be able to use my code? Do I want others to modify my code? etc...

@ambigram_maker Way too many. I hate YAML.

GNU hands down.

10:34 AM

GNU GPL?

GPL, I mean

Then there's a lot of people that will never ever use your library.

I am one of them.

GPL is like a virus. If you make your code GPL and I want to use your library, I believe I pretty much have to make my code GPL also.

Alternative? ~~LGPL?~~

Or not, scrap that.

LGPL is better, yes. I am mostly a fan of Apache License, MIT License, or Modified BSD License.

Enlightening.

10:37 AM

but it's all up to you, depending on what rights you want to give people to your code.

I used to be extremely restrictive with my code, especially my Minesweeper Analyze code, because I strongly believed that a company would take my code and use it and make money from it.

Now, I've had that code open source for quite a while and to my knowledge, no one has made money from it yet.

The best way to make money of your own code is to make it open source, so that other people can look at it and realize how awesome you are and give you a job.

4

Exactly. I believe in what the original hackers intended. But sadly, many don't want people to know how they solved a problem that (they think) is challenging.

@SimonForsberg I used to believe that its mandatory to add javadoc to your code before publishing it. You proved me wrong. ;-)

How did I prove you wrong? Because how horribly bad I am at ~~adding javadoc?~~ all kinds of documentation?

Q: Recursive Memoized Fibonacci in C++

11:31 AM

0

I was reading an article on Wikipedia about memoization, so I wanted to try and apply it. I am fairly new to this subject, so I thought I'd start small. Does the program use memoization correctly? Is there anything that I can improve? #include <iostream> int fibonacci(int num, int* memoize); i...

c++ fibonacci-sequence memoization

0

Q: stack implementation using arrays in java

Could someone please review my code and let me know if there is any scope for optimization for better performance. package com.gmail.practice; import java.util.Arrays; public class Stacks { private int top; int size; int[] stack; public Stacks(int arraysize) { size = arraysize; stack...

java array stack

possible answer invalidation by Catprog on question by Catprog: codereview.stackexchange.com/posts/106517/revisions

12:17 PM

Consider moving to codereview.stackexchange.com — Kristoffer Bohmann 30 secs ago

@Duga @mods needs rolling back

@Zak Rolling back is not the answer, but editing the edit.

Okay, cool.

I guess rollback is only when the edit is purely editing code that should not be edited?

And the community can handle such things without moderator intervention.

oh, who can perform rollbacks then?

/edits

12:23 PM

all users with edit privileges can perform rollbacks

Cool, duly noted.

In this case, the best thing to do is probably to rollback first, and then re-apply some of the edits, and add a frequently-posted comment

It is better for the community if the community learns how to handle this, rather than moderators doing it every time.

Will you take care of this, @Zak, or do you want me to?

@SimonForsberg Can you do it, and I'll observe so I can see how its done.

Done

in this case I used code from the revision 2

possible answer invalidation by Simon Forsberg on question by Catprog: codereview.stackexchange.com/posts/106517/revisions

12:36 PM

@Duga yeah yeah

@SimonForsberg Okay, cool.

Thanks :)

Thank you. Sorry for dismissing your flag, I should probably have marked it helpful instead.

This was one of the more problematic invalidations, as the edits included so much

@SimonForsberg I don't care (too much) about the flags. Just glad to have learned how to be more helpful.

skiwi

Monking