The answer to this question is probably "W-what!? What the !@#$-- Stop!! That's a terrible idea!",. but I would like to hear your thoughts...
Lets say I have two classes and one inherits from the other.
class A(object):
def t1(self):
self.t2()
def t2(self):
print "A"
cl...
Finds the equilibrium. For sum/mult an equilibrium is defined as the index i at which sum/mult of all elements at index < i is same as sum/mult of all elements of at index > j. respectively. Edge cases are documented clearly in javadocs.
Note, I do understand merits of unit testing in separate ...
I'm using Rails engines to break up a big app into smaller pieces. The parent app mostly handles users and authentication.
In one of my engine tests I want to log in a user before each test. How should I access this user log in functionality, which exists in the parent app, from the engine?
It ...
The answer to this question is probably "W-what!? What the !@#$-- Stop!! That's a terrible idea!", but I would like to hear your thoughts...
I have two classes and one inherits from the other.
class A(object):
def t1(self):
self.t2()
def t2(self):
print "A"
class B(A):
...
As stated in the Help Center, one of the criteria for a question to be on topic is:
Is it actual code from a project rather than pseudo-code or example code?
What is the rationale for that rule?
Is this example code? The edited out "let's say" and the variable names suggest this. If so, then this is off-topic as we only review real code. — Jamal ♦7 secs ago
I'm a beginner to Model-View-Presenter pattern and I'm finding a way to use it in a sample application
In my C# winforms application has a Employee Class and it has properties like EmployeeID,Name, Address, Designation etc. Also it has behaviors like viewEmployee(), AddNewEmployee(), PromoteEmpl...
@syb0rg hmm.. it's actually fraying with off-topic, it's not real code, it's his "current understanding" of MVP, wants high-level design guidance => Programmers.SE
I am working on some performance test on various data structures. In my list I have HashMap and Trie data structure. I am done with HashMap but not sure how to use Trie for below problem -
I have a text file which contains 2 million english words with their frequencies in this format -
hello 10...
I would like to give it a try and ask about my codes on here from now on to see if there are improvement for'em
this code is supposed to combine two sql tables into one.
SELECT * FROM (SELECT * FROM posts WHERE id < $lastpost AND position = submitter order by id DESC LIMIT 5) t1 JOIN (SELECT us...
A very simple Thread pool:
Any work added to the pool will be executed. The destructor will wait for all work to be finished before letting the threads stop. We then join all threads before letting the destructor exit.
#include <thread>
#include <mutex>
#include <condition_variable>
#include <f...
Is it okay to edit the question to include the improved code?
I would like to do so for the following reasons:
To share the improved code with others
To show the answering persons that I take their feedback seriously
To make sure that I understood (and implement) the feedback in the right mann...
From a mod's perspective, I see this as a major complication on this site. Although different questions can go through different iterations (or none at all), these things are certain:
The original code must not be updated based on answers; we want answers to be linked to the code that was revi...
This code animates the my main game sprite by increasing the animation frame. How can I make it more elegant and optimised in terms of speed.
if (moving){
anispeed++;
if (anispeed==animaxspeed){
anispeed=0;
animationframe++;
if (animatio...
Return any three descending numbers that appear sequentially in the input. Since problem description contains 'any' I could not unit test using junits. Looking for request code review, optimizations and best practices.
final class DescendingTriplets {
private final int high;
private fi...
It has been a while I haven't implemented a QuickSort and I wanted to write it down like I remembered. Here it is:
int MyPartition(List<int> list, int left, int right)
{
int pivot = list[left];
while(true)
{
while(list[left] < pivot)
l...
Finds the equilibrium. For sum/mult an equilibrium is defined as the index i at which sum/mult of all elements at index < i is same as sum/mult of all elements of at index > j. respectively. Edge cases are documented clearly in javadocs.
Note, I do understand merits of unit testing in separate ...
I fidn it very hard to try to answer such question... Too much non-obvious things going on, on which there is not much to review unless I'd be using Java 8 in my review :P
I'm stuck with this example which I don't know how to solve
A: I've said bad things to my mum.
B: If I were you, I'd apologise to
your mum.
Is it suppose to be 'your', or 'my' instead?
My feeling tells me that your is right, but my sounds more logical.
Is it okay to edit the question to include the improved code?
I would like to do so for the following reasons:
To share the improved code with others
To show the answering persons that I take their feedback seriously
To make sure that I understood (and implement) the feedback in the right mann...
I think you don't understand the exact meaning as of now... There are two types of cards in my game: Monster cards and Fusion cards. There is nothing more to them than that ^^
@skiwi My post makes recommendations that depart from previous accepted practice on this site, because I've observed that appending revised code to questions tends to make a mess of things. I should have made it clear that it's a new recommendation.
You have several options for follow-ups:
If one of the answers gives you good advice with clear directions for improving your code, just accept the best answer and upvote any other answers you feel were helpful. The checkmark that you confer is the best way to show appreciation on this site, a...
@Vogel612 - funny thing about the Lunar Eclipse, is that it shadows the entire moon, so, whomever can see the moon at about 07H00Z on Wednesday (2-am EST Wednesday) will see the eclipse. This means pretty much all of the americas.
@Nobody Well, it could also be done differently, take this:
public class Hand {
private final List<Card> list = new ArrayList<>();
private final int capacity;
public Hand(final int capacity) {
this.capacity = capacity;
}
public boolean isFull() {
return (list.size() == capacity);
}
public void add(final Card card) {
Objects.requireNonNull(card);
ExceptionUtils.throwOnFail(this::isFull, IllegalArgumentException::new, "hand is full");
list.add(card);
I could also just write:
if (isFull()) {
throw new IllegalArgumentException("hand is full");
}
I'm trying to implement String-Pool. I'm maintaining a HashMap to store the keys. Here is the code.
public class TestStringCaching {
static Map<String,String> cache = new HashMap<String,String>();
public static void main(String[] args) {
int iter = 8000000 ;
String[] temp = new String[it...
I'm trying to implement String-Pool. I'm maintaining a HashMap to store the keys. Here is the code.
public class TestStringCaching {
static Map < String, String > cache = new HashMap < String, String > ();
public static void main(String[] args) {
int iter = 8000000;
Strin...
it looks like you are doing a lot with making all sorts of variables that are really confusing to look at, maybe I am simple minded and that is why I can't figure it all out.
not really sure what you are doing with the t but I changed it to i
XmlNodelist ClientNodes;
ClientNodes = Clientes[0]...
I would vote on some of yours @Morwenn but they all look like they are in C++
Finds the equilibrium. For sum/mult an equilibrium is defined as the index i at which sum/mult of all elements at index < i is same as sum/mult of all elements of at index > j. respectively. Edge cases are documented clearly in javadocs.
Note, I do understand merits of unit testing in separate ...
The answer to this question is probably "W-what!? What the !@#$-- Stop!! That's a terrible idea!",. but I would like to hear your thoughts...
Lets say I have two classes and one inherits from the other.
class A(object):
def t1(self):
self.t2()
def t2(self):
print "A"
cl...
I'm using Rails engines to break up a big app into smaller pieces. The parent app mostly handles users and authentication.
In one of my engine tests I want to log in a user before each test. How should I access this user log in functionality, which exists in the parent app, from the engine?
It ...
As stated in the Help Center, one of the criteria for a question to be on topic is:
Is it actual code from a project rather than pseudo-code or example code?
What is the rationale for that rule?
I am working on some performance test on various data structures. In my list I have HashMap and Trie data structure. I am done with HashMap but not sure how to use Trie for below problem -
I have a text file which contains 2 million english words with their frequencies in this format -
hello 10...
I would like to give it a try and ask about my codes on here from now on to see if there are improvement for'em
this code is supposed to combine two sql tables into one.
SELECT * FROM (SELECT * FROM posts WHERE id < $lastpost AND position = submitter order by id DESC LIMIT 5) t1 JOIN (SELECT us...
A very simple Thread pool:
Any work added to the pool will be executed. The destructor will wait for all work to be finished before letting the threads stop. We then join all threads before letting the destructor exit.
#include <thread>
#include <mutex>
#include <condition_variable>
#include <f...
Is it okay to edit the question to include the improved code?
I would like to do so for the following reasons:
To share the improved code with others
To show the answering persons that I take their feedback seriously
To make sure that I understood (and implement) the feedback in the right mann...
From a mod's perspective, I see this as a major complication on this site. Although different questions can go through different iterations (or none at all), these things are certain:
The original code must not be updated based on answers; we want answers to be linked to the code that was revi...
This code animates the my main game sprite by increasing the animation frame. How can I make it more elegant and optimised in terms of speed.
if (moving){
anispeed++;
if (anispeed==animaxspeed){
anispeed=0;
animationframe++;
if (animatio...
It has been a while I haven't implemented a QuickSort and I wanted to write it down like I remembered. Here it is:
int MyPartition(List<int> list, int left, int right)
{
int pivot = list[left];
while(true)
{
while(list[left] < pivot)
l...
I'm stuck with this example which I don't know how to solve
A: I've said bad things to my mum.
B: If I were you, I'd apologise to
your mum.
Is it suppose to be 'your', or 'my' instead?
My feeling tells me that your is right, but my sounds more logical.
I'm trying to implement String-Pool. I'm maintaining a HashMap to store the keys. Here is the code.
public class TestStringCaching {
static Map<String,String> cache = new HashMap<String,String>();
public static void main(String[] args) {
int iter = 8000000 ;
String[] temp = new String[it...
it looks like you are doing a lot with making all sorts of variables that are really confusing to look at, maybe I am simple minded and that is why I can't figure it all out.
not really sure what you are doing with the t but I changed it to i
XmlNodelist ClientNodes;
ClientNodes = Clientes[0]...
