I'm not familiar with 8051 assembly in particular, but there are some readability things I want to point out.
Commenting
This should really be stressed: well-commented is not the same as excessive-commented. You have comments after pretty much every line, which just makes your code hard to rea...
please give me some feedback to my malloc implementation. i implemented this design to understand the basic concept...
#include <stdio.h>
#include <stdbool.h>
#include <string.h>
#define HEAP_MEM_SIZE 150
#define MEMORY_AVAILABLE 1
#define MEMORY_USED 0
struct chunk_header {
struct chunk_h...
Things you did well:
Some use of comments.
Use of typedef.
Things you could improve:
Syntax/Styling:
Never use goto. Yes, there are some rare situations where you may find it necessary to use it. This is not one of them.
err:
printf("could not allocate mem\n");
return 0...
Please review the code.
Thanks.
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<title>RGB to HEX (and vice versa) converter</title>
<link rel="stylesheet" href="http://cdnjs.cloudflare.com/ajax/libs/normalize/3.0.0/normalize.min.css">
<style>
body{
color: #...
Is there a better (functional or more idiomatic) way to get the first positive number that is not included in a set.
val set = Set(4, 1, 2, 0, 5)
var x = 0;
while(set.contains(x)) x +=1
println(x); // Should print 3
i have a server application using TcpListener in Backgroundworker, where my application is doing some work, and in the background listening to a IP:PORT.
The DoWork Of The BackgroundWorker :
private void m_oWorker_DoWork(object sender, DoWorkEventArgs e)
{
while (true) //in...
Is there any better way to write this code:
bool success = true;
if(x == 0)
{
if(do_up)
run_do_up();
else if(do_a)
run_do_a();
else if(do_n)
run_do_n();
else
success = false;
}
else if(x == 1)
{
if(do_n)
run_do_n();
else if(do_a)
...
Sorry for my English
I tired to write code that inits or restores state in onCreate() (by checking whether or not the savedInstanceState argument is null), and saves state in onSaveInstanceState().
So I wrote these classes:
StateManager
public abstract class StateManager {
public final v...
I would like to know how can I tell to compiler that a #define is an unsigned char.
#define SET_BITS_LOW 0x80
Here SET_BITS_LOW is, by default, an int but I want an unsigned char
So in my latest project I am using fullscreen background images for each page. I decided to write some code to fetch the different thumbnail sizes and then use it as a background for the appropriate viewport size using media queries. I also made sure that in the case of big screens the smallest i...
Ok so I have this adventure game, where when you click a button, it replaces the div you're currently on with the new div option that you chose. Example:
Sample of my HTML:
<div id="menu">
<button class="menubutton" onMouseover="mouseoversound.playclip()" onclick="start()">Start</button><br>...
Please refer below code
$(".nna-icon-excel").click(function (e) {
var $this = $(this);
$this.parent().attr("href", "?excel=1")
var href = $this.parent().attr("href");
if (activeTab.toLowerCase() == "table") {
ac...
The code below will split environment variables from a command line (always appear at the end of the command line). Environment variables are represented by '-E key=value'. I've achieved this like so, but I'm wondering if there's a more elegant way
public class TestSplit {
public static void ...
How do I refactor this?
'-hello--world-'.chomp('-').squeeze('-').reverse.chomp('-').reverse # => 'hello-world'
HTML form field names must be equal to SQL table field names.
Changing only table name and allowed fields can be used in many other update pages.
How can I improve this?
$allowed = array("name","surname","email","rank");
$items = '';
foreach($_POST as $key => $value) {
if (in_array($key ,...
I'd like some additional assistance on refactoring. This is my latest update for this iteration.
The previous post can be found here.
#region WMI Classes
/// <summary>
/// The Win32_OperatingSystem WMI class represents a Windows-based OS installed on a computer. Any OS that can be
/// install...
Your algorithm is way off.... ;-)
Let's consider the solution to a decent number.
For any decent number, the more 5's we put at the front, the better.
So, let's break it down to some maths....:
d => number of digits in the decent number
f => number of fives in the decent number
t => number o...
I have an Olympics database from each Olympic year and I want to find the person that has made the most medals - The main problem is that I'm basically querying the same sub-query twice in SUBSET1 and SUBSET2. How would I go about changing this so that it would be more efficient
Select athlete ...
I have long been looking for an elegant, one-line solution to map enum to strings automatically, for use with the << and >> stream operators.
I know that a lot of macro have been proposed to achieve that, but I never found a really simple scheme, with only one macro call.
This is my attempt, an...
I went with what I know and can use well, not what I know and can't figure the syntax out to make it look good.
so please enjoy the code and prepare to school me (probably in the basics) in C#
public static void Main (string[] args)
{
/* Here are your rules:
"Scissors cuts paper,
...
Task:
I know we can all add two numbers the short way, using +. Your task is to create the longest code you can to add two input numbers.
Rules:
All of the code must be on topic (don't fill it with non-addition code to add length)
The count is in characters, but do not count tabs, spaces, or ...
In Farbox, I am trying to insert videos in Markdown. I can insert 2 videos. But when I am trying to insert 3 videos. It didnot work out. Does anyone know why?
works. But:
doesn't.It works here. But the second one doesn't work in Farbox.
It looks quite good, some, mostly minor notes:
class Controller implements ActionListener {
Having an actionPerformed method in the controller smells a little bit for me. I'm not sure about that but I'd rename the controller's method to changeModelState() (without any parameter) and use an ...
When your hammer is C++, everything begins to look like a thumb.
If you put a million monkeys at a million keyboards, one of them will eventually write a Java program.
The rest of them will write Perl programs.
For some reason, I'm having difficulty remembering. I've got a photo of the ingredients, but some advice on exactly how to combine them would be appreciated.
I received a ton of help from 200_success once again here.
Since then, I decided to go with OOP Style and prepared statements, and so far I like it a lot more than the procedural style. Much more understandable in my opinion.
For this CodeReview, I've just included my PHP code that interacts wi...
I like the demo, from a once over:
the functionNames make my eyes glaze over, data tables variables should be sorted and tabbed in my mind:
var functionNames = [
{ name: "matrix", type: functionParamTypes.length},
{ name: "matrix3d", type: ...
I've got the following Elixir code:
defmodule Envvar do
def exists?(env) do :os.getenv(env) != false end
def get(env) do
if exists?(env) do
{env, :os.getenv(env)}
else
{env, nil}
end
end
end
Two things:
Am I using the ? correctl...
Here's an attempt I've made of implementing the Barnes-Hut nbody algorithm, or it's initial stage - The quadtree. That there're lots of lengthy doc strings might excuse the lack of detailed explanation here. My primary concerns as a beginner are to-
Avoid complexity
Avoid library imports
Make f...
Task:
Draw a grid with a given number of rows and columns. Each cell can be any color. The same grid should also be updated at a predetermined time interval. The grid should cover the entire visible portion of the page in the browser. Add a context menu with which you can change the parameters o...
I have a function that returns the index of the first alphabet letter found in a string, or -1 if no letter is found. It seems like there should be a way to do this with extension methods instead of looping, but I can't think of one:
int findFirstLetter(string str)
{
for(int ctr=0;ctr<str.Leng...
