I have been given this piece of code to REFACTOR. I have refactored, but I am not sure whether I missed something on refactoring or maybe someone has a better idea :)
Here is unrefactored given code
import java.io.*;
import java.util.ArrayList;
import java.util.Scanner;
class TriviaQuesti...
I am trying to re-factor (improve design of existing working code) with the following principals:
Switch statements removal.
Encapsulate Field
Extract Class
Extract Interface
Extract Method
Extract Subclass
Extract Super Class
Form Template Method - Before
Move Method - Before
Introduce Null Ob...
I wrote this function to find the index of the first substring. I was wondering if you guys can help me find some flaws or possibly increase performance? thanks!
ex:
str = "happy"
substr = "app"
index = 1
my code:
public static int subStringIndex(String str, String substr) {
int substrle...
public class circularLL {
Node start;
Node last;
circularLL()
{
start=null;
last=null;
}
class Node
{
int data;
Node next;
Node(int datanew)
{
data=datanew;
}
public void setNext(Node n)
{
next=n;
}
public Node getNext()
{
...
I've created a BST. and now I want to find the height of the BST developed.
Here is my code for constructing the BST
class Node:
'''represents a new node in the BST'''
def __init__(self,key):
self.key=key
self.disconnect()
def disconnect(self):
self.left=None...
I have a text file that contains name,age,salary,hoursWorked,randomText and were filled with different delimiters
textfile
susan:25-2600,28[asd]
mary:21-2200,38[asd]
john:23-3400,46[asd]
instead of breaking them into individual strings using the code shown below.
string name,age,salary,hour...
I am thinking about passing private Variable of one Class into another Class, for some belonging case like 'company --> department --> employee'. As a employee can tells some information of his company, there's some private Variable I like to pass.
I think this relationship is not as same as com...
I am not new to html however would like to know about best practices, I need to develop a structure **
what structure i proposed is
<div id="body">
<div id="body-main">
<div id="body-main-upper">
<div id="body-main-upper-image">
<image></image>
...
factor this code so that I don't have to insert the parameters any time I need to use one of the functions.
I have a class, say "julian", for calculating julian dates of today, a date I insert and the difference between these two julian dates.
Example:
int julian::calc_julianToday()
...
Continuation of this question: https://codereview.stackexchange.com/questions/36561/unit-of-work-with-generic-repository-pattern-mvvm-vol-2
I have made some modifications:
Implement lazy-loading (hope so)
Add() and Update() returns T instead of void
Add IFeedItemRepository, FeedItemRepository,...
I tried out this problem :
https://www.hackerrank.com/contests/amrita-icpc-onsite-2013-practice/challenges/h1
Initially, I used a backtracking solution, which obviously was slow and got TLE (Time limit Exceeded). Later, I was told that a simple BFS is enough to arrive at the solution and so...
my question is really simple, shall an adapter (design pattern) class should be unit tested, and how?
Example:
I want to create a class ClientSocket with PHP wich is an adapter of the fsockopen, fread, fwrite.
Class ClientSocket extends SenderAdapterAbstract
{
private $s = null;
public fu...
A job application of mine has been declined because the test project I submitted was not coded in a clean and straightforward way.
Fine, but that's all the feedback I got. Since I like to continuously improve my coding skills, are there people here who want to check out this project at Github? I...
I have designed the following input validation implementation with one goal: DRY. I'd like to know whether it is intuitive and what are the possible shortcomings.
$vlad = new \ay\vlad\Vlad();
$test = $vlad->test([ // Test script
[ // Group of selectors and validators. Each selector is asses...
Hi this is a piece of code written for a sunwave clock and I want to know why it goes slowly when its zoomed in a lot but quick when it's zoomed out (even though it has a lot more to draw when zoomed out).
Javascript Canvas Webpage
html://www.magicartland.com/sunwave.html
This is a code for FizzBuzz. I have also hosted in on my github
I Start with a test on FizzChecker
[TestClass]
public class FizzChecker_Tests
{
IFizzChecker _fizzChecker;
bool isFizz;
[TestInitialize]
public void TestInitialize()
{
//Arrange
_fizzChecker = new FizzChecker();
...
Suppose I have a text file which contains 10,000 random values between 0 and 1 and I want to count the number of values within a specific interval. An example may explain it more clearly.
Example
Suppose my Datefile.txt contains data like-
0.0102244
0.028072
0.0144578
0.064578
0.08148
0.012749...
There must surely be a nicer way of writing this :-/
The wrinkle of complexity is that prev_seq or next_seq might be an empty string if the user moves the question to the first or last position, but it could also validly be '0.0' so I can't just rely on 'falsiness'.
I hope it's clear what I'm t...
In Calculating Julian dates, the author asks a question that doesn't make sense:
Refactor this code so that I don't have to insert the parameters any time I need to use one of the functions.
[...]
What I would like to do in main() is to be able to use calc_juliandate() without havin...
I have written a function for switching advert image based on $template. Function is working completely fine without any problem and getting everything dynamically with no issue.
Concerning performance, I want some feedback and suggestion from you experts to optimize code in better way.
Since b...
This is a .wav to .flac encoder that I wrote a little while ago. The only method that is really called is encode(), which takes in a .wav file, converts it to .flac, and stores it in the .flac file that is taken in as a parameter.
I would prefer suggestions on how to improve the method, decreas...
I have a list A of fields say for example 35 fields and 1000s of columns .
Now I have compare a list of 7 dates(Already known information) (e.g field 3,4,6,11,14,22,67 within this fields with NULL
There are a number of way to do this.
Say
1) Have numerical constants corresponding to these fi...
I implemented a CSS class to add margin bottom.
.mb24 {
margin-bottom: 24px;
}
Which I thought I could just add to any div that needed that amount of spacing. But there were some conflicts when I added the class to a div with the class "row" (I am using foundation). So I ended up just usin...
I have been using HTML and CSS for a long time, and and just starting to learn jQuery. I created a calculator by myself from research and trial and error and would like someone to let me know what I'm doing wrong as far as code efficiency, structure, and comments. Here is the html:
<!DOCTYPE html
This is a subclass of Backbone.Collection with a method fetchNextPage that returns a Q promise.
To find out the next page's URL, it looks in meta.next from server response.
The server will return null for the last page.
It also has a getState method that returns a state with empty and fetching ...
