Room for Thomas Ward and Vogel612

Vogel612

16:44

HEya

Thomas Ward

room mode changed to Private: only approved users may enter this room (this should only be used for moderation purposes)

oops meant gallery

what's up?

grr stupid access system is stupid >.>

there

Vogel612

this is about your latest flag

Thomas Ward

you mean the retracted one?

literally got your ping as i hit 'retract'

Vogel612

ohhh...

yes. if you retracted it

Thomas Ward

it's retracted yes.

Vogel612

16:46

I was actually kinda tempted to go into your answer and delete the "Red alert" section

Thomas Ward

@Vogel612 you still can :)

i wouldn't argue

Vogel612

If you don't mind, could you elaborate on why exactly you think the question is not reviewable (aka. should be closed) in it's current state

or if you no longer think so, why that?

Thomas Ward

@Vogel612 there's in-depth 'brain dump' in the chat room

TL;DR, as is the code can't run

the code is reviewable if we ignore the clear() requirement and yank it out

Vogel612

hmm ... we never required code to be runnable

Thomas Ward

@Vogel612 and by 'runnable' I mean working

so here's my interp

unless we got rid of the "working code" requirement, not having a custom module written by OP and embedded in the code will return an ImportError on a nonexistent module

Vogel612

16:49

in a lot of [java] / [c#] / [$oo-language] we don't get any more information about the used types beyond the API that is used in the code under review

Thomas Ward

@Vogel612 right, but in this case, Python is... picky.

@Vogel612 ignoring that requirement, the code is still reviewable

Vogel612

meh. Java will happily give you a compilation error

Thomas Ward

I hate Java so :P

Vogel612

that means the java code isn't runnable out of the box either

Thomas Ward

@Vogel612 for all intents and purposes, the code is still reviewable but if i'm going to omit the clear requirement i'm yanking it from my code example with a "Yeah this doesn't exist, so i'm yanking it out for the review"

OP should still be required to include their 'clear' code though

my opinion that carries little to no weight :p

Vogel612

16:50

why though? if we require code to be runnable, we might as well require them to include their whole system

Thomas Ward

heh

@Vogel612 keep in mind two things:

(1) when I wrote the review it was the tail end of my work day and I was already very tired.
(2) I'm salty when tired or uncaffeinated

2020 hindsight is the retract

and the revision i just pushed

Vogel612

hang on ... I don't see a flag to close in the mod timeline

Thomas Ward

i filed one.

the system may have ignored it

Vogel612

no, even if you retract, the system still logs it to the timeline

Thomas Ward

unless the system didn't pick up the flag

Vogel612

16:53

retractions are shown as clear by Community

Thomas Ward

which could have happened

the retract was the custom mod flag

it didn't even show the other one on my end

Vogel612

hmm ...

Thomas Ward

which has happened in the past when the system doesn't fully process a request

and that's an SE issue that's sometimes transient

Vogel612

so basically the flag to close didn't reach SE...

Thomas Ward

in any case, not an issue since i yanked those bits of the answer (I still mention that we can't fully review without the clear code though, and I yanked it out for the review bits.)

Vogel612

16:54

it doesn't show up in your flag history and not in the post timeline

Thomas Ward

@Vogel612 my complaining earlier was the non-caffeinated saltiness

and the retract is the w20/20 hindsight

Vogel612

then the only thing that's left is a "thank you for your time" :)

Thomas Ward

ultimately, there's no real problems left to work with, but eh. (I'm salty in the mornings...)

yep :)

room mode changed to Gallery: anyone may enter, but only approved users can talk

there now you can store that in the mod logs :)

Vogel612

I was just rather confused that you'd flag "other" for a "close"

Thomas Ward

because from my side I had 'cast' it but it never completed the request, so bleh.

Vogel612

16:56

yea. that sums it up :D

Feeds

Thomas Ward has added Vogel612 to the list of this room's owners.

Thomas Ward

all's good :)

Vogel612

aight then I'm back to starting the heating in my room and dropping a bit of work into finally unpacking my moving cartons

Thomas Ward

indeed, enjoy

returns to nomming pizza for lunch

Vogel612

I've been semi-moved for the whole damn week now and finally got to installing a proper light in my room

Transcript for

♦ Room for Thomas Ward and Vogel612