The Loop

Brandt Solovij

00:13

@kaiser someone has a case of the tuesdays hahaha. Cheer up mate, its another day out there tomorrow :)

bungeshea

09:04

> @rarst and @toscho are both now working on developer.wordpress.org

make.wordpress.org/docs/2013/10/14/…

Rarst

laaate reaction! :)

s1lv3r

11:48

Just posted my second question ever on the site ... hope it isn't too stupid. :-)

toscho

@s1lv3r An explanation why you don’t just replace $wpdb or filter query would be useful.

s1lv3r

@toscho I'm not sure I unterstand. You mean filtering the SQL with the posts_clauses_request filter?

toscho

well, that or filter 'query'.

s1lv3r

12:05

@toscho I updated the question a bit, I hope it's now clearer. Thank's for your advice.

toscho

@s1lv3r query is the complete SQL query. You can do anything with it.

s1lv3r

@toscho indeed, but wordpress needs to be able to handle what the query is giving back (if you don't plan to rewrite get_posts() ) ... :-(

toscho

indeed, WP_Query::get_posts() is a nightmare.

s1lv3r

... first project on which I really needed to understand what is happening in there ... it's a hell to debug. :-|

kaiser

Why do you need to overwrite it? Maybe it's a XY Problem.

s1lv3r

12:17

@kaiser I did write it into the question why I wasn't able to achieve it with the filters in the original WP_Query ... only other way would be to totally do it outside of wp core ...

kaiser

@s1lv3r In the posts_clauses or the later filters you can overwrite the complete query string.

s1lv3r

@toscho ... it was even worse, when I first tried to filter the_posts to fetch and merge the other posts through calling another instance of WP_Query() ... - you can imagine what a kind of great idea that was. :-D

@kaiser yeah, I already was that far and builded a gigantic UNION query ... but I couldn't make get_posts() understand what was comming back from that query ...

kaiser

So "Combining the result of multiple WP_Query-s" and "Let WP_Query set her internals based on a custom query" are the two questions you're actually having?

You're adding your custom query in the posts_clauses filter. Then $wp_query->found_posts, $wp_query->next_post, etc don't work anymore?

Writing a plugin to extend WP_Query

s1lv3r

@kaiser nice link. :-P

kaiser

12:33

@s1lv3r "(...) in the need of merging posts from different blogs in one query (...)" THAT won't end well.

Run a custom query and let go.

s1lv3r

@kaiser Exactly! Not in one query.

kaiser

Why the heck do you need to query from different blogs?

s1lv3r

Only if I have a function which wraps the single queries and cares about merging them (i.e. solving ID conflicts etc.) that's what I'm using my extended class for.

@kaiser Project requierement .... actually this runs totally smooth. I just don't find a way to build it into the main query ...

kaiser

You won't. Better do some queries and care about caching properly.

s1lv3r

So you say I should forget about using the main_query and better build anything custom? Archive pages, post-search etc. ...

Stephen Harris

12:37

@s1lv3r You want a cross blog search?

Good luck :)

s1lv3r

@StephenHarris I already have one, I just want to integrate it into the main_query ... :P

@StephenHarris ... it even allows advanced meta_query filters accross multiple blogs ... :-P

Stephen Harris

@s1lv3r yeah... multisite is like several independent sites. It doesn't work nice as 'sub-sites' of a parent site...

In short, you're better of starting from scratch :/

s1lv3r

@StephenHarris That is no option anymore. :-)

kaiser

So your boss said "WASTE ALL THE MONEEEY!" ? ;)

s1lv3r

@kaiser na, my boss said just build it and didn't want to spend any time for conceptual phase. :-D

TBH it's 99% done ... and wordpress at all was a fail for it ... the customer doesn't care it looks and works nice and was done in time ... - but from a code viewpoint I just wouldn't do it with wp again. ;-)

But atleast I learned a lot of (basic) things ... for example I thought wordpress network sites have a seperate user base (somehow you read this alot), when I realized it doesn't I needed to spend a week to make it really have seperate user bases (like in different wp_users und wp_usermeta tables) ...

toscho

12:57

@s1lv3r You are aware you can set custom user tables depending on $_SERVER['HTTP_HOST']?

s1lv3r

@toscho That's what I did in the end ... but it doesn't seem to be a really 'safe' feature, you still need to change all the backend functions to take this into account and it causes pretty strange issues with object caching ...

GhostToast

13:20

good morning

Tom J Nowell

14:04

thoughts? docs.google.com/presentation/d/…

My talk for manchester interest group tonight

Rarst

a little too much text (depends on how you will be displaying it), high on technical detail which depends on kind of people you have there :)

I had to go light on technical and hard on ecosystem for my WCEU talk

Tom J Nowell

hmmm, text is mainly just demonstrative output

I thought I'd show them a most basic composer.json to identify a package

then introduce a dependency, then a theme, then a plugin

Rarst

a lot of text is hard on projector :(

Tom J Nowell

tho thirtythirteen is more intimidating

Rarst

Otto had nice talk at WCEU but his slides were nearly useless on projector

GhostToast

14:11

did he wear a ballcap?

Rarst

yes

GhostToast

:)

GhostToast

14:25

i have a philosophical question (read: User Interface) and would like to throw an idea out there to see what others think...

I am preparing a site that will have filtering of Businesses by 2 taxonomy dropdowns: Community (city), and Activity (such as dining, museum, park, etc)

what i want is to have codependency between these two dropdowns such that either one may be used initially, but then the other updates. I know how to do this (i think), but not sure best way to do it so that the user understands what is happening.

Tom J Nowell

oooh, throw out the dropdowns, use a different UI pattern instead

e.g. drilling down

GhostToast

typically in AJAX filtration you start with 1 dropdown and move linearly. For example: Choose Make => Ford; Choose Model => Focus; Choose Color => Red

Tom J Nowell

Pick X then pick Y, where X and Y are one of your criteria in any order

GhostToast

ok so I am thinking Y is a dropdown still, and so is X. you choose X

Tom J Nowell

I still think dropdowns are an awful way to go about it

Rarst

14:28

interdependent dropdowns are confusing like hell

GhostToast

Back to my original example. I choose Community: Sycamore. Now the "Activity" dropdown shows: [choose an activity in sycamore] [ sports ] [ dining ]

or [sports (sycamore ) ] [ dining (sycamore) ]

so if not dropdowns, what?

Rarst

I'd not depend them on each other. getting no results is less confusing than when dropdown sets change dynamically on you (and fail to change if anything happens to ajax request)

toscho

@GhostToast list of check boxes so the user can combine values with an OR clause

GhostToast

@Rarst i know. but client constantly asks for such thing

@toscho my only concern is aesthetically, this can become very cumbersome if there are many terms

Rarst

you didn't expect us to validate your client's opinions, did you? :)

GhostToast

14:32

this isn't an amazon search result with sidebar necessarily. although i do like that option

Tom J Nowell

it's a nightmare on freeagent when you pick from dropdown A, then pick from dropdown B, but dropdown B changes afte ryou've opened it and it's out of date, and nothing makes sense

GhostToast

lol

s1lv3r

@GhostToast ... make it wizzard style with AJAX?

GhostToast

unfortunately, i am being called into a meeting

Tom J Nowell

client wants dropdown because client doesnt know any better and its all they can think of, they shouldn't be dictating your UX design

GhostToast

14:33

sorry guys. be back soon

toscho

If I want to play ping pong in Minas Morgul or Minas Tirith, I should be able to select both

Tom J Nowell

and I have an interview at 4 so I'll be heading off in a few minutes

kaiser

good luck

s1lv3r

@TomJNowell Customers and clients atleast know what a dropdown is. Actually I have recently realized a lot of users don't get all the fancy javascript multi-select input elements ...

Tom J Nowell

they never will, which is why I prefer drilling down through categories to picking them in a combo box or some over convoluted multiselect field

s1lv3r

14:41

yeah, it's pretty bad when your ui elements look all fancy, but your users don't even realize it's supposed to be an input element at all ... (jqueryui.com/button/#checkbox for example) :-P

its_me

Looks like a bug. Even with a custom value for label 'not_found', I still see 'No items found.' instead of something like 'No subjects found.'

Anyone using custom taxonomies, could you please see if the same thing's happening to you?

(If you have a test site without any terms under the custom taxonomy, that is, or if you can delete them to check.)

nvm, looks like it's not what the label is for.

its_me

15:23

...

Does wordpress have a built-in function to convert normal numbers (1, 2, 3, ...) to ordinal numbers (1st, 2nd, 3rd... ) and words (first, second, third...)??

I want the number in custom field to be displayed as ordinal number/word

kaiser

0

A: WPSE Scope: Minimum Competency Requirement

Proposal: Meta Tags As I've seen that there're help tags used on SO (constantly pushed in their PHP chat), I could imagine that we use something similar, but a bit reworked: A list of new meta-tags, that have a tag wiki, explaining what's wrong. needs-info Please provide additional informatio...

GhostToast

ok i'm back

so if dropdowns are the devil, what is the better method?

@its_me i doubt wordpress does, but PHP probably does

its_me

@GhostToast I could find neither. :/

GhostToast

actually i found a funciton like that once. lemme see if i canf ind it

its_me

ok

kaiser

15:33

GhostToast

@kaiser thanks did not realize this existed

kaiser

@GhostToast keep in mind that the only way to get good answers over there is to use a mock up/screenshot.

GhostToast

@its_me this wasn't that hard to find: stackoverflow.com/questions/3109978/…

PHP's native solution should probably work too if you are php 5.3+

its_me

@GhostToast Guess the difference was the search term you used :P

@GhostToast I'll give it a shot, thank you very much!

GhostToast

@its_me no problem. googling is a real skill lol. i searched for "apply st nth rd php numbers"

its_me

15:40

:)

its_me

16:22

@ChipBennett About your answer (wordpress.stackexchange.com/a/16111) on checking if a custom field is defined... can't we use metadata_exists instead?

I mean, is it any better?

Chip Bennett

@its_me well that's an old question/answer...

Context?

its_me

@ChipBennett Checking if a custom field has a value defined

@ChipBennett Yes, just wanted to know if metadata_exists better for the if/else checking

or it doesn't matter?

Chip Bennett

Given that metadata_exists() is a brand new function in WP 3.7-beta...

It appears to be fine to use :)

its_me

@ChipBennett Oops! :P Thought it was introduced in 3.3.x. stackoverflow.com/a/13816155

probably got delayed

Chip Bennett

oops... I need more coffee

What I'm reading says source not since derp

nobody bothered to add it to the Codex function reference

its_me

16:32

@ChipBennett Hmm... so considering that it exists, is if( metadata_exists( ... ) ) {...} better for the purpose than if( ! empty( get_post_meta( ... ) ) ) { ... }

Chip Bennett

define "better"...?

its_me

I meant, does it matter what I choose to go with? (e.g. "No, don't do it this way; performance sucks.")

Chip Bennett

so, "better" = performance?

its_me

yes

in this instance

Chip Bennett

I'm not seeing much performance difference at first glance. They're both relying on get_post_meta() for post post-type

but performance at that level is not really my area of expertise

its_me

16:36

@ChipBennett ok. I really only wanted to be sure that I wasn't taking the "No! No!" route. Thanks! :)

Chip Bennett

WordPress usually has lots of ways to do the same thing; it's not always the case that one way is demonstrably preferable to another

usually, as long as you're avoiding functions intended to be used internally, you're probably okay

its_me

ok

G. M.

17:45

0.2.0 out now @kaiser (same features, but 35 files instead of 1, 1900 lines instead of 1000) still refactoring... github.com/Giuseppe-Mazzapica/CleverRules

kaiser

@G.M. nice!

Wyck

ya that does look nice^

kaiser

Does it work when you drop in into the plugins folder, @G.M. ?

G. M.

@kaiser it seems

:)

kaiser

Cool! :)

Notes:

1. Add defined( 'ABSPATH' ) or exit to the head of your files. Prevents direct access

2. No need to define a plugin path constant. You can simply use plugin_dir_path( __FILE__, 'your/path' ); everywhere

3. If you need to load all files from a folder: foreach( glob( 'path' ) as $file ) include $file;

G. M.

17:51

no, not everywhere, in file 'inside' folder plugin_dir_path( FILE, 'your/path' ) refers to file folder

kaiser

Try it

toscho

@G.M. var $replacements; is PHP 4. Please use public $replacements;. :)

G. M.

i've used var? really? where? :)

kaiser

lolz... everyone jumping in with suggestions to make it better :)

toscho

Matcher

kaiser

17:53

Anyway, it really looks great!

@G.M. Url

G. M.

@toscho @kaiser was night and 3 chars semmes better than 6 :P joking, it's a bad habit...

@kaiser, thanks

kaiser

Another thing:

public function foo()
{ #<-- !!!
    // bar
}

No, really, it looks great. Very readable!

Having problems with #WordPress and rewrite rules? Meet #CleverRules https://github.com/Giuseppe-Mazzapica/CleverRules for a sane approach.

Tweeted by unserkaiser on October 16, 2013 at 5:57 PM

G. M.

I know it's the right way, but i don't like braces in that way. I can't read my code fluently if I use braces on new line

UAU @kaiser, thanks!

toscho

@G.M. No auto-loader?

G. M.

@toscho. I'm always afraid of autoloader in WordPress. 2 autoloaders (if another plugin has one) doesn't conflict?

toscho

17:59

no

See the auto-loader in Cube

kaiser

Use composer autoloader

G. M.

Composer is perfect. In laravel is life saving. but I think is too early for that in WP. Maybe I'm wrong

Wyck

2018

Rarst

@G.M. not too early for you in WP. just stop limiting yourself to lowest WP baseline experience :)

kaiser

@G.M. Posted it to poststat.us as well.

@G.M. listen to @Rarst . We're already at the point where we must let go all the old bad habbits and PHP versions.

G. M.

18:06

@Rarst have you notice system if anyone type 'composer' in this site? :P Joking. Maybe is time for composer... way to version 1.0 is still long...

kaiser

way to version 1.0?

G. M.

now 0.2, version 1 for me is when I remove the 'beta' from title @kaiser

kaiser

Car manufacturers make it the same. Alpha = Beta = RC -> push to client, see what happens :D

G. M.

this week I want to make it more clean in some parts. Then I'll use for my pourpose .. I will change something for sure while using. When I'm happy with it, I remove beta. I hope in that moment I'll not the only one who has tested it :D

Tom J Nowell

18:46

@G.M. Im about to give a composer talk =]

T MINUS 10 MINUTES

toscho

@TomJNowell Good luck!

kaiser

@TomJNowell where?

Tom J Nowell

MWUG

this is Mike little land

Chip Bennett

19:12

Presented without comment:

There is no code yet. I need to query the author custom post type that has the same name as the book's taxonomy. Suggestions are welcome. — Troy Templeman 4 mins ago

Rarst

19:24

@toscho you are on Windows right? I wrote that in issue/rant in GitHub then it hit me I don't clearly recall that :) I don't clearly recall a lot of WCEU :)

toscho

yes

Rarst

ok, hadn't embarassed myself with memory hole, winning

toscho

Sometimes, I think a single close would be enough: Your question sucks.

kaiser

@ALL What was the online service to check if some site is online

Rarst

ismyblogworking.com

although I often skip that step and go straight for redbot.org and extra info

kaiser

19:35

thanks

TomHarrigan

19:53

hadn't used that one before @Rarst, i've always used downforeveryoneorjustme.com but they look pretty much the same

Rarst

yeah, there are plenty like that around :)

GhostToast

i use terminal

though i guess that could fall under the "or just me" context

kaiser

Point is that you want to know if it doesn't work elsewhere too

toscho

Or ask on Twitter :)

TomHarrigan

..or fly a plane to another location and test

where's Tom speaking?

Wyck

20:02

@GhostToast I also use terminal

Lynx that is:)

its_me

Is this an okay way of writing a function? (functions.php)

function aahank_book_edition_format() {
	global $post;
	if ( $post->post_type == 'aahank_book' ) {
		$edition_number = get_post_meta( $post->ID, 'test_edition', true );
		$number_format = numfmt_create( 'en_US', NumberFormatter::ORDINAL );
		return numfmt_format( $number_format, $edition_number );
	}
}

I mean, should I change it so that there's a return; for else, or something like that, or is it fine the way it is?

toscho

@its_me First, test if $post is actually a post object

Chip Bennett

What if get_post_meta() returns an empty string?

toscho

Second, return early when the guard ($post->post_type == 'aahank_book') fails

its_me

@ChipBennett it won't. it's a personal blog :D (I intentionally avoided it as it's required to be filled in my case.)

Chip Bennett

20:15

I'd still protect against that

toscho

@its_me always write portable code

its_me

@ChipBennett and @toscho Got it! I'll add it up then :)

@toscho I was wondering how...

toscho

function aahank_book_edition_format()
{
	global $post;

	if ( ! is_a( $post, 'WP_Post' ) )
		return '';

	if ( $post->post_type !== 'aahank_book' )
		return '';

	$edition_number = get_post_meta( $post->ID, 'test_edition', true );

	if ( ! $edition_number )
		return '';

	$number_format = numfmt_create( 'en_US', NumberFormatter::ORDINAL );

	return numfmt_format( $number_format, $edition_number );
}

its_me

@toscho Thank you very much! Learnt some stuff. :)

Chip Bennett

Also: if ( 'aahank_book' !== $post->post_type )

its_me

20:22

@ChipBennett ? It's there in the fixed code that toscho provided above.

You want it to be the other way around?

toscho

indeed, the variable should stay on the right side

Rarst

yoda conditions

its_me

oh! ok

Chip Bennett

Not much of a risk when the comparator is not-equal; but good practice to get into anyway

kaiser

Reads like an episode of CSI. Everyone saying the obvious and repeating each other :D

its_me

20:23

done!

its_me

20:38

@toscho When you said, *"test if $post is actually a post object" did you mean to check if it's within the loop? In that case how about I do something like this?

if ( ! is_a( $post, 'WP_Post' ) )
	$post = get_post( $post );

toscho

@its_me other code can overwrite or unset the $post object, because it is a global variable. So your get_post() wouldn’t change anything.

its_me

Oh :P

@toscho Last question (please take your own time). Does "return early" apply everywhere? For example, isn't this:

add_filter( 'option_default_post_format', 'aahank_bookmark_post_format' );
function aahank_bookmark_post_format( $format ) {
    global $post_type;

    if( $post_type == 'aahank_bookmark' ) {
        $format = 'link';
    }

    return $format;
}

simpler than something like this:

add_filter( 'option_default_post_format', 'aahank_bookmark_post_format' );
function aahank_bookmark_post_format( $format ) {
    global $post_type;

    if ( 'aahank_bookmark' !== $post->post_type )
        return $format;

    $format = 'link';
    return $format;
}

toscho

the last two lines in the second code are too long: return 'link'; would be enough

plus, the second code is broken, and I have no idea where $post_type comes from

its_me

@toscho It's a filter. And here I thought a highly upvoted answer would be correct :-/ wordpress.stackexchange.com/a/72030/10691

I can do this though:

$post_type = get_post_type_object( $post->post_type );

After the check that tests if "$post is a post object" (from the code you gave earlier)

toscho

20:56

@its_me risky. if the option is called in any other page than wp-admin/options-writing.php, the global variable $post_type is probably empty.

its_me

@toscho Hey, that's function is for wp-admin

see the filter I am using: add_filter( 'option_default_post_format', 'aahank_bookmark_post_format' );

toscho

anyway, I have to stop now, can't type anymore

its_me

no problem, thank you.

GhostToast

problem: i have plugin that needs early hooks (wp_loaded, wp_enqueue_scripts) but would prefer to only load it on certain pages...

i dont think plugin can know what $post->ID is...

Rarst

enqueue is not early

GhostToast

21:08

global $post; var_dump($post) returns NULL

Rarst

look at query, $post is crap

its_me

@toscho Worked on it for a bit and ended up with this. (To make it easy for you -- please type 'G' for good, or 'N' to say you suck!)

add_filter( 'option_default_post_format', 'aahank_bookmark_post_format' );
function aahank_bookmark_post_format( $format ) {
	global $post;

	if ( ! is_a( $post, 'WP_Post' ) )
		return '';

	$post_type = get_post_type_object( $post->post_type );

	if ( !is_object( $post_type ) || 'aahank_bookmark' !== $post->post_type )
		return $format;

	return 'link';
}

GhostToast

@Rarst queried_object_id points to nothing

how may i know what page i am viewing?

Rarst

is_page()

GhostToast

@Rarst my page check is much happier in the wp_enqueue_scripts hook than wp_loaded

derp

kaiser

21:42