Unfortunately I need to say that I agree with your boss. Maybe having 300 LOC function is not a good idea, but having many small functions with few LOC doesn't make any sense, even makes code more difficult. It may be even little bit less error prone if you think of that this way, but its just annoying to jump from one small function to another all the time.
@marxin I agree completely. Having a method isApp... is pointless. I agree that a method for getting the phone number would be better for extend-ability purposes in most scenarios, but this is for one thing and one thing only. Could that ever change? Yes, so could not getting the phone number at all and you actually want email, so he should have a generic method that will take any input and will attempt to validate every possibly way? No. That makes no sense. The ternary for .has(... is enough.
Discussion on answer by David Arno: M…
Discussion on answer by David Arno: M…