hello.

Hi @SamuelLiew! I've just reinstalled the script and so far no favicon changes. That was a fast fix!

:D

Yup, looks pretty stable.

So what was it?

Firefox resets the favicon to the domain favicon upon any network request. In this case since it was on SE, it tries to get chat.stackexchange.com/favicon.ico

Wow. I wonder why it only messed up some sites?

no idea, but it seems my fix worked

I take it your fix is to re-request it?

something like that

Thanks so much for the help!

and I added a cachebuster (random token) to the favicon url too

by the way, do you have ChatImprovements installed?

For anybody who's wondering, we're discussing this bug report about a userscript that Samuel wrote that only manifests in the newest Firefox version.

@SamuelLiew doesn't look like it. Want me to check something with it?

no, but I think you might find it useful

Just installed -- refreshing to pick it up.

Oh that's cool!

Err, it's showing me a list of other rooms I'm in that I'm not in (but that I have favorited).

yeah, this script also auto-rejoins favorites..

I should probably add it as an option

Oh, yeah -- not sure I want to do that...

for now I'm using starred rooms to indicate which ones I want to always be in

sorry about that

brb -- leaving all and then I'll be back.

I wish there were both favorites and something like a watch list. There are rooms I want to look in on occasionally so I have them starred, and then there are the rooms I go into a lot.

I would bookmark the ones I need to check occasionally, then star the rooms I want to be always in, since this is the best way to implement this feature as SE provides a /chats/join/favorite endpoint

I use several devices and not always the same browser (FF on some, Chrome on others), so managing the bookmarks wouldn't be ideal for me.

But SE chat doesn't get a lot of love, so I just have to work with it warts and all.

And that means I don't do "join all" and am more selective. Oh well.

okay gotcha. I'll look into removing the rejoin all favs feature then you can enjoy the rest of the script

I appreciate all the feedback

Or just make it an option; I don't want to make your script harder for you to use, after all!

Thanks for investigating a very bizarre bug for me!

nah, I can put rejoin all favs as a button click for example..

That'd be great.

done, v1.3: github.com/samliew/SO-mod-userscripts/blob/master/…

won't auto rejoin favs

@Monica one of the other main features is link-rewriting, like this i.stack.imgur.com/HuWy2.png

@SamuelLiew oh, nice! So we get transcript links by default and I can stop doing that manually. :-)

so some links won't be truncated which makes it very difficult to follow, yes and no more direct links to chatrooms

it only changes the link for those viewing the chatroom with my userscript, it doesn't edit the link in actual message sent to everyone

@SamuelLiew yeah, I figured it was a client-side change, not an actual data change.

I mean, editing other people's links wouldn't be polite, and for my own I know how to get a transcript link. :-)

Should we retire to another room for further discussion?

if there are any further issues with my scripts, feel free to pop by chat.stackoverflow.com/rooms/info/170520/sams-moderation-room

have a great day everyone!

@SamuelLiew oh, didn't realize you had your own room! Thanks again for the help. Have a good day/evening/night.

Please help me find in the talmud regarding modesty, something about women went with one eye revealed but we're very immodest, that it is not only what you wear but how you wear it

I found this but it says the opposite sefaria.org/Rashi_on_Shabbat.80a.7.2?with=Shabbat&lang=bi