Room for Sie and Matt Jens Jensen

Sie

20:36

Hey. So I did some moving around and got it kind of working. Key word kind of.

Matt Jens Jensen

Hey man, what's up?

Sie

using UnityEngine;
using System.Collections;
using Valve.VR;
using System;

public class WandController : MonoBehaviour {
    private Valve.VR.EVRButtonId gripButton = Valve.VR.EVRButtonId.k_EButton_Grip; //Essentially this is accessing
                                                                                   //SteamVR_TrackedObject.cs and telling our script
                                                                                   //and defining it here.


    private Valve.VR.EVRButtonId triggerButton = Valve.VR.EVRButtonId.k_EButton_SteamVR_Trigger;

Matt Jens Jensen

What's the compiler giving you now?

Sie

See this line? "if (rightDevice.GetTouch(SteamVR_Controller.ButtonMask.Touchpad))". Well when I changed from device to rightDevice to get input only from that controller the editor started giving some errors at runtime.

get_frameCount can only be called from the main thread.
Constructors and field initializers will be executed from the loading thread when loading a scene.

Which was a reference to SteamVR_Controller.cs on line 60.

//========= Copyright 2015, Valve Corporation, All rights reserved. ===========
//
// Purpose: Wrapper for working with SteamVR controller input
//
// Example usage:
//
//	var deviceIndex = SteamVR_Controller.GetDeviceIndex(SteamVR_Controller.DeviceRelation.Leftmost);
//	if (deviceIndex != -1 && SteamVR_Controller.Input(deviceIndex).GetPressDown(SteamVR_Controller.ButtonMask.Trigger))
//		SteamVR_Controller.Input(deviceIndex).TriggerHapticPulse(1000);
//
//=============================================================================

here is the pastebin version: pastebin.com/u1PhwxJu

Matt Jens Jensen

Oh yeah, which thread is WandController running on?

Sie

20:39

I'm assuming it runs all on one core? I might be mistaken. I've only played with high level stuff.

Matt Jens Jensen

Oh, have you tried moving rightDevice and leftDevice into private fields on your class?

Unity inherently splits things up

private SteamVR_Controller.Device rightDevice = SteamVR_Controller.Input(rightIndex);
private SteamVR_Controller.Device leftDevice = SteamVR_Controller.Input(leftIndex);

in the class, that might make it run on the loading thread

Sie

I was just doing that.

It doesn't like that. "A field initializer cannot reference the non-static field, method, or property 'WandController.rightIndex'".

Matt Jens Jensen

Oh yeah, what you'd have to do is:

SteamVR_Controller.GetDeviceIndex(SteamVR_Controller.DeviceRelation.Rightmost)

private SteamVR_Controller.Device rightDevice = SteamVR_Controller.Input(rightIndex);

sorry, auto sent the message

private SteamVR_Controller.Device rightDevice = SteamVR_Controller.Input(SteamVR_Controller.GetDeviceIndex(SteamVR_Controller.De‌viceRelation.Rightmost));

It looks a little verbose, but that will fix the issue

Sie

Just a sec.

Unity is being a pita.

Matt Jens Jensen

Yeah man, I understand that, Unity and C# can be a pain

Sie

20:45

Eh. Unity has somehow decoupled itself with VS.

What I mean is the errors will show up in console but VS will not "see" them.

"Unexpected symbol `<internal>' in class, struct, or interface member declaration" is what Unity is saying in the output but in VS it looks fine to me and the error console (ie no errors).

Ok I just reset both of them and now the error is magically gone.

Brilliant.

The same errors are back though unfortunately.

get_frameCount can only be called from the main thread.
Constructors and field initializers will be executed from the loading thread when loading a scene.
Don't use this function in the constructor or field initializers, instead move initialization code to the Awake or Start function.

That is on line 60.

Ya @Matt it really doesn't like being called from anything but the main thread apparently.

:/

Matt Jens Jensen

Hmm.. it's odd that it will allow the other device but not left and right

Oh!

Idea

private SteamVR_Controller.Device rightDevice = { get { return SteamVR_Controller.Input(SteamVR_Controller.GetDeviceIndex(SteamVR_Controller.De‌viceRelation.Rightmost)); } }

How about that?

Sie

Testing now.

I think the formatting on that is busted. I tried moving them but it doesn't care for it.

private SteamVR_Controller.Device rightDevice = { get { return SteamVR_Controller.Input(SteamVR_Controller.GetDeviceIndex(SteamVR_Controller.De‌‌viceRelation.Rightmost) } };

Matt Jens Jensen

No, it's a block getter, no simicolons after required, but inside the block they are

It's a missing ); at the end of Rightmost)

Sie

I just went back and tried your original code and no dice still.

I added an extra ) where you said and that just added another syntax error.

ffs

Never had this issue before with Unity or C#.

Why does it care so much about which thread it's running on?

Matt Jens Jensen

21:01

No no, that's good

Because, race conditions

it would crash if it accessed that memory

private SteamVR_Controller.Device rightDevice = { get { return SteamVR_Controller.Input(SteamVR_Controller.GetDeviceIndex(SteamVR_Controller.De‌viceRelation.Rightmost)); } }

that code exactly, on one line

Sie

Oh well I guess it's just doing it's job in that case...

Matt Jens Jensen

does that cause a syntax error?

Sorry, I meant this:

private SteamVR_Controller.Device rightDevice { get { return SteamVR_Controller.Input(SteamVR_Controller.GetDeviceIndex(SteamVR_Controller.De‌viceRelation.Rightmost)); } }

that's what you want

That exactly should work

Sie

No that worked.

I think chat formatting was fucking something up.

Matt Jens Jensen

Woo, so that should use a lock getter so it should work on the right thread

Sie

Nope. Same slew of errors as before.

Matt Jens Jensen

21:05

Screenshot?

Sie

Sure. Sec.

btw really appreciate the help with this up until now

Alright.

Matt Jens Jensen

Absolutely man, hopefully I can get it working for you

Sie

There are a few unrelated errors in there but feel free to ignore those. Just a save thing.

I gotta eat diner. I will be back in like 20 min.

Matt Jens Jensen

Okay man, I'll do some research

Matt Jens Jensen

21:18

I figured it out mate, you just have to move everything that must be called on the main thread to Start

private SteamVR_Controller.Device rightDevice;

and then in Start():

rightDevice = SteamVR_Controller.GetDeviceIndex(SteamVR_Controller.De‌viceRelation.Rightmost));

Sie

21:31

So close.

Cannot implicitly convert type 'int' to 'SteamVR_Controller.Device'

Matt Jens Jensen

No worries, I didn't copy the whole thing

I meant:

rightDevice = SteamVR_Controller.Input(SteamVR_Controller.GetDeviceIndex(SteamVR_Controller.De‌viceRelation.Rightmost));

Sie

Well closer now.

It let me run nit but then it gave more errors. Screenshot coming.

Matt Jens Jensen

Could you send a snippet of the WandController's properties?

Like all of the private properties on the class

Sie

Sure.

Matt Jens Jensen

It's the same issue, so we'd need to move every private property from the class declaration to the Start method

Sie

21:46

Christ. This seems like it's much harder than it should be.

Here you go:

private Valve.VR.EVRButtonId gripButton = Valve.VR.EVRButtonId.k_EButton_Grip; //Essentially this is accessing
//SteamVR_TrackedObject.cs and telling our script
//and defining it here.

private Valve.VR.EVRButtonId triggerButton = Valve.VR.EVRButtonId.k_EButton_SteamVR_Trigger;
private Valve.VR.EVRButtonId Touchpad = Valve.VR.EVRButtonId.k_EButton_SteamVR_Touchpad;

private SteamVR_Controller.Device controller { get { return SteamVR_Controller.Input((int)trackedObj.index); } }
private SteamVR_TrackedObject trackedObj;

Matt Jens Jensen

Oh trust me mate, Unity makes it a bit easier, I have about 20,000 lines of C++ just wrapping OpenVR

private SteamVR_Controller.Device controller { get { return SteamVR_Controller.Input((int)trackedObj.index); } }

that's the line that is causing the issue

since you shoulding be using it in the Update now that you have rightDevice, just comment or delete the line

Sie

Well I just commented it out for good measure and it goes back to that same default error.

Matt Jens Jensen

default error?

Sie

> Unexpected symbol `<internal>'

On this: rightDevice = SteamVR_Controller.Input(SteamVR_Controller.GetDeviceIndex(SteamVR_Controller.De‌‌viceRelation.Rightmost));

Matt Jens Jensen

Can you send me visual studio screenshot of the error and what line it highlights?

Sie

21:50

Matt Jens Jensen

on line 55, replace controller with rightDevice

and any where else controller shows up with a red line under it, replace with rightDevice

Sie

Same error.

Matt Jens Jensen

Yes, but different location, double click the error where visual studio shows it and it should highlight the offending line

Sie

> rightDevice = SteamVR_Controller.Input(SteamVR_Controller.GetDeviceIndex(SteamVR_Controller.De‌‌viceRelation.Rightmost));

2 mins ago, by Sie

Matt Jens Jensen

That's not the line, Visual Studio would highlight it with red if there was an error there; recompile and then send a screenshot of the build output (errors)

I know it can be frustrating getting into C# and MS Visual Studio

Sie

21:56

Well that's the line Unity is taking issue with.

:/

Matt Jens Jensen

What's the error that Unity is throwing now?

Sie

Unexpected symbol `<internal>'.

Matt Jens Jensen

Can you show me a screenshot of what window that error is coming from?

Sie

Matt Jens Jensen

I got an idea

Sie

22:00

I

I'm up for whatever.

Matt Jens Jensen

I'm typing it up now, I'll send it over in a minute

Sie

k

Matt Jens Jensen

gist.github.com/mattjensjensen/05185fa433bf545d18cc1f6c16a05bc8

I sent a Github Gist because it was easier to preserve code formatting than StackChat

Sie

Moar errors.

Moth of christ it never ends lol.

Matt Jens Jensen

No no this is good, it revealed the true error

Sie

22:10

the true error?

lol

Now there is a false prophet error.

Bad jokes aside I think you can tell I like the design side of things more than the code :P.

Matt Jens Jensen

gist.github.com/mattjensjensen/05185fa433bf545d18cc1f6c16a05bc8

Yeah man, I've been a programmer for 12 years now, so this stuff is fun for me

Are you using MotionControl anywhere?

Sie

I don't mind it but it does aggravate me after awhile.

Matt Jens Jensen

MotionControl and trackedObject are the same thing with two names

Sie

It is null apparently.

Controller not initalized

Matt Jens Jensen

yeah

Sie

22:12

Shouldn't it be getting detected?

Matt Jens Jensen

then lets comment out the declaration of MotionControl and trackedObject and replace it with rightDevice

or you could send me the entire WandController.cs and I could fix any issues I see with it and clean it up so it's a little simpler?

Sie

pastebin.com/zLE4JjE1

Sure. I appreciate it.

Matt Jens Jensen

Absolutely man, just give me a few minutes and I'll send something over

gist.githubusercontent.com/mattjensjensen/…

Now, this still might have some final things to fix, but at least now it isn't trying to use things that will permanently be null

Sie

Thank you so much. It's finally working semi-properly now.

What a pain that was. Really appreciate the help though :).

Why'd you stop coming to the main room btw?

Matt Jens Jensen

Absolutely man!

Oh I've just been busy as hell with my dayjob and working on a horror game

Sie

22:24

Ah I get that. Horror game? I like horror games. What kind?

Matt Jens Jensen

Right now, it's turned into a kind of fleeing a hostile state

As in, you're stuck in a small country controlled by an evil military influenced by demons

I'm just playing around with the ideas, but it's creepy as hell with bugs

Sie

Hmm. Is it like an action game kind of? I kind of tend to go for slower more atmospheric horror games like Soma, Amnesia and Penumbra.

Matt Jens Jensen

No, it's more like Amnesia in the woods where the enemy has guns and you have to evade and survive

Sie

Sounds cool :).

Matt Jens Jensen

You set up traps with the environment and you make them patrol themselves to their own death

haha

Sie

22:27

Anyway I've gotta get some other stuff done. Thanks a bunch.

Matt Jens Jensen

Absolutely man! Have a great day

Sie

yep you too

Transcript for

Room for Sie and Matt Jens Jensen