« first day (49 days earlier)      last day (158 days later) » 

Quill
Quill
04:54
5
Q: Profiles with profiling checkboxes

realisationI have this HTML down below that creates a list with two columns, the left one containing profile information, and the right one containing checkboxes of the user feedback in a horizontal list. The list behaves so that when the element of the questionAnswer array is true, there is a font-awesome...

javascript html css angular.js
Bounty ending in 18 hours
 
6 hours later…
Dan Pantry
Dan Pantry
11:04
I'll be looking to see if I can review this before I start streaming today @Quill
Quill
Quill
11:39
Okay, cool
 
1 hour later…
Dan Pantry
Dan Pantry
12:50
@Quill codereview.stackexchange.com/questions/100849/…
:S
I ca't seem to answer this question, IU have no idea what any of this data is
 
2 hours later…
Quill
Quill
14:47
either way, there's a bounty up for grabs, so I you want to just comment on immediate pitfalls rather than pitfalls + architecture
Quill
Quill
15:21
user image
@IsmaelMiguel ^^
Ismael Miguel
Ismael Miguel
Honestly, I don't even have any idea how memer is working now
It has so many changes
Quill
Quill
Because they're positive, that's usually helpful
Ismael Miguel
Ismael Miguel
But bad in one way
Quill
Quill
In which way?
Ismael Miguel
Ismael Miguel
Well, I don't know how it is working now
That's bad, for me
Quill
Quill
15:25
Ah, okay
Ismael Miguel
Ismael Miguel
You broke the BTW meme
github.com/ismael-miguel/memer/commit/…
By changing it to .+, it matches anything and everything
Quill
Quill
ah, okay
Ismael Miguel
Ismael Miguel
The dot, in a regex in Javascript, literally means "anything that isn't a newline character"
I had (BTW\\.[a-zA-Z]+) on purpose so it wouldn't match the common btw or btw.
And to only match if and only if there was at least 1 letter after
Quill
Quill
hmm, okay
Ismael Miguel
Ismael Miguel
But was it matching things that it shouldn't?
Quill
Quill
15:32
it didn't stop for the space and just kept going
I thought it was the regex, and that explains it
Ismael Miguel
Ismael Miguel
That's quite weird
The regex doesn't match spaces
regex101.com/r/qR5dF1/1
All slashes have to be escaped
Quill
Quill
that looks alright, but it's gotta have the i flag too
Ismael Miguel
Ismael Miguel
Why's that?
Quill
Quill
it should match btw.whatever
as well as BTW.whatever
Ismael Miguel
Ismael Miguel
15:51
Alright
regex101.com/r/qR5dF1/2

« first day (49 days earlier)      last day (158 days later) »