The Cactus Game Engine

Ethan Bierlein

19:00

Done

Removed __version__.

Duga

[ShearOfDoom/Cactus] Annonomus-Penguin commented on cactus/__init__.py of commit 4b95dfb4

> I mean, what's its purpose?

[ShearOfDoom/Cactus] ShearOfDoom pushed commit be446d9d to master: Removed version from init.

Ethan Bierlein

Now beginning github.com/ShearOfDoom/Cactus/issues/42. Thank you for your cooperation. Have some ~~merge conflicts~~ cake.

Duga

[ShearOfDoom/Cactus] Annonomus-Penguin commented on cactus/game.py of commit 4b95dfb4

> Wouldn't it make more sense to define these outside __init__()?

Annonomus Penguin

@EthanBierlein that's shouldn't be a major change, either

Ethan Bierlein

Edited

Duga

19:04

[ShearOfDoom/Cactus] ShearOfDoom commented on cactus/game.py of commit 4b95dfb4

> No, because each of the possible class data keys belong to the class itself, so it makes sense to have them stored there.

[ShearOfDoom/Cactus] ShearOfDoom commented on cactus/game.py of commit 4b95dfb4

> Would it make more sense as being defined inside _check_class_data as a local function variable?

Annonomus Penguin

@Duga @Ethan I meant still in the class, but outside __init__()

Ethan Bierlein

@AnnonomusPenguin I added another comment.

Annonomus Penguin

@EthanBierlein yeah, that would make more sense

Again, why is this a breaking change?

And:

2 hours ago, by Annonomus Penguin

@Ethan issues you need to reply on: 40, 41, 45, 50.

Ethan Bierlein

@AnnonomusPenguin What do you mean breaking change? Are you talking about colorama implementation? That's not a breaking change. Class validation isn't either.

Annonomus Penguin

@EthanBierlein I meant that won't create merge conflicts

You add a new file, and add one line of code to another

Ethan Bierlein

19:07

okay

Annonomus Penguin

How were you planning on doing it?

Ethan Bierlein

Implementing colorama? I'm just gonna drop the source inside of Cactus/cactus and work some __init__ magic.

We do have to do some legal stuff, as colorama is licensed.

Annonomus Penguin

@EthanBierlein IAMAL, but I can do that

Ethan Bierlein

Oh, and I'm going to close issue 45, since I already took care of it.

taht okay?

Annonomus Penguin

@EthanBierlein no you didn't

Ethan Bierlein

19:09

oh. okay. What do I still need to do with it?

Annonomus Penguin

@EthanBierlein read the entire issue?

Ethan Bierlein

Ah, forgot to validate types.

Annonomus Penguin

And it won't throw an error if the user adds an extra type, correct?

Ethan Bierlein

Yes

Annonomus Penguin

There's that, too.

Ethan Bierlein

19:10

So, I still need to do that. Scratch implementing colorama rn. I'm going to continue working on class validation.

Annonomus Penguin

@EthanBierlein ehh, make a file called color.py so the colors aren't all dumped on the user if they don't want colors.

Nothing with __init__

(This is more of an addon than a feature)

Ethan Bierlein

Okay.

Annonomus Penguin

And then we can import the init module into Game where we can call it in play_game()

Ethan Bierlein

We still need a way to activate ansi.sys so that the user doesn't have to manually enable it.

Annonomus Penguin

@EthanBierlein no we don't

Ethan Bierlein

19:17

So that colors work on windows

Annonomus Penguin

Nope.

Colorama works on Windows out of the box

Ethan Bierlein

Oh, I thought you were talking about implementing our own color module.

Annonomus Penguin

> Calling init() has no effect on other platforms (unless you request other optional functionality, see keyword args below.) The intention is that applications can call init() unconditionally on all platforms, after which ANSI output should just work.

Ethan Bierlein

Never mind.

Annonomus Penguin

I was just saying importing all the colors into color.py so that the user had to explicitly say import cactus.colored_text

Ethan Bierlein

19:18

okay

Annonomus Penguin

b) You must cause any work that you distribute or publish, that in
whole or in part contains or is derived from the Program or any
part thereof, to be licensed as a whole at no charge to all third
parties under the terms of this License.

I guess we're not using pyfiglet

Ethan Bierlein

Well, then.

Bah

Oh well

Well, can we close that issue then?

Annonomus Penguin

@EthanBierlein Let me look for another engine

Ethan Bierlein

okay, maybe you can change the title of the issue or something.

Annonomus Penguin

Hmm....

7

A: Is there a python library that allows to easily print ascii-art text?

PIL gives a cool way to do this very simple. You can render the text onto a b/w image and convert that bitmap to a string stream replacing the black and white pixels to chars. import Image, ImageFont, ImageDraw ShowText = 'Python PIL' font = ImageFont.truetype('arialbd.ttf', 15) #load the font...

Ethan Bierlein

19:32

Aaaargh.

Annonomus Penguin

What?

Ethan Bierlein

from flowchart import Flowchart

Traceback (most recent call last):
  File "C:\Users\Ethan Micah Sophie\Desktop\Cactus\TEST_test1.py", line 2, in <module>
    import cactus
  File "C:\Users\Ethan Micah Sophie\Desktop\Cactus\cactus\__init__.py", line 1, in <module>
    from .game import Game
  File "C:\Users\Ethan Micah Sophie\Desktop\Cactus\cactus\game.py", line 1, in <module>
    from flowchart import Flowchart
ImportError: No module named 'flowchart'

Annonomus Penguin

umm...

I thought I fixed that. Apparently not.

Ethan Bierlein

Well, let my try something

Annonomus Penguin

I think this is the fix (not sure)

from .flowchart import Flowchart

Ethan Bierlein

19:36

ah, that worked

Annonomus Penguin

Aargg.. I have no issues to fix.

Duga

[ShearOfDoom/Cactus] Annonomus-Penguin added label wontfix to issue #43: pyfiglet support

[ShearOfDoom/Cactus] Annonomus-Penguin commented on issue #43: pyfiglet support

> GPL license :sob:, so we can't do this.

[ShearOfDoom/Cactus] Annonomus-Penguin closed issue #43: pyfiglet support

[ShearOfDoom/Cactus] Annonomus-Penguin removed label feedback/ideas wanted from issue #45: How should we validate class_data?

[ShearOfDoom/Cactus] ShearOfDoom pushed commit 70e284ef to master: Added type validation to class data checking.

Ethan Bierlein

@AnnonomusPenguin Alright, class data validation now has type checking.

Annonomus Penguin

@EthanBierlein Now just making sure there are no extra values

Duga

[ShearOfDoom/Cactus] ShearOfDoom pushed commit 459fc4fd to master: Added checking for invalid keys to class data validation.

Ethan Bierlein

19:49

@AnnonomusPenguin Added validation for extra values.

Can I close the issue now?

@AnnonomusPenguin Well, I'll let you decide that. I gotta go. BBIAW

Duga

[ShearOfDoom/Cactus] Annonomus-Penguin commented on TEST_test1.py of commit 459fc4fd

> WHAT IS THIS I SEE?

Annonomus Penguin

@EthanBierlein we need it to be validated on change. I got that, though.

Duga

20:38

[ShearOfDoom/Cactus] Annonomus-Penguin pushed commit dfc30b87 to master: Closes #45

[ShearOfDoom/Cactus] Annonomus-Penguin closed issue #45: Validate class_data

[ShearOfDoom/Cactus] Annonomus-Penguin commented on issue #46: Ensure that external code can edit dictionary

> Also make sure that external code can edit the instances defined outside class (like Position is defined outside)

Duga

21:35

[ShearOfDoom/Cactus] ShearOfDoom commented on TEST_test1.py of commit 459fc4fd

> AAAAAAAAHHH! RUN FOR YOUR LIVES! IT'S A TRAILING COMMA!

Ethan Bierlein

I'm back.

Annonomus Penguin

I'm going to be signing off for the night in like ten minutes.

Ethan Bierlein

Well, night then.

Hello @Quill

Duga

[ShearOfDoom/Cactus] ShearOfDoom commented on issue #40: Correctly set leading underscore for class members

> I think we'll put leading underscores for anything that shouldn't be directly run/changed.

Annonomus Penguin

21:52

@EthanBierlein not night per se, but yeah.

I might be back for a bit around 9:30 CST

I have to be gone for like four hours here

Ethan Bierlein

Oh, okay. Well I'll still be up then. :P

Duga

22:04

[ShearOfDoom/Cactus] ShearOfDoom pushed commit 985cb362 to master: Added spaces in the test file for clarity.

Ethan Bierlein

Announcement: Starting work on issue github.com/ShearOfDoom/Cactus/issues/41. Error handling FTW!

Duga

22:25

[ShearOfDoom/Cactus] ShearOfDoom pushed commit 910dbf8b to master: Added a simple error handling system.

Duga

23:34

[ShearOfDoom/Cactus] ShearOfDoom pushed commit 5ab31a8a to master: Added new error handling system using decorators.

Ethan Bierlein

Announcement: When you write a class method, do, from .errors import cactus_class_method_exception_handle, next, put a decorator on the method: @cactus_class_method_exception_handle.

Duga

23:51

[ShearOfDoom/Cactus] ShearOfDoom pushed commit e5558a34 to master: Fixed issue with errors not being logged. (maybe)

Ethan Bierlein

Hello @Quill

Quill

Hello

Ethan Bierlein

Well, brb. Gonna go take a swim.

Transcript for