Code Review - Discussion about help vs. review

« first day (12 days earlier) ← previous day next day → last day (47 days later) »

10:18

Here is also a kind of "gimme-the-codez" question which I at the moment don't like:

Hi guys I'm new to Java and I really don't understand how to make more classes work like one. So if anybody could explain me that and help me devide my large code to smaller classes (like Player.java, Main.java,Move.java, etc.) Because I have a problem; I want to check if player hits wall and eas...

Not sure whether to downvote or VTC. Although it is from a brand new user...

200_success

11:06

I don't see that as a gimme. Assuming that the existing code works, it's a valid question, just like any other CR question. You also don't have to answer with a working solution, just advice.

1 hour later…

rolfl

12:14

And this question asks specificcally about best practice, not for a code review:

Q: How specific should my unit test be?

I have made the pragmatic decision to have my repository serve as both a repository and a a severely thin service layer. One method of the class that I want to test is the Add method. It looks like this: public void Add(Post post) { post.Slug = SlugConverter.Convert(post.Title); conte...

c# unit-testing

@SimonAndréForsberg I totally agree. I would call it a 'design first' question.

They don't want the code reviewed, they want it rewritten (even though the code works).

Now, if we review the code, then it will be useless to the OP because they already know the review problems.... (break it in to classes, extract functions, etc).

Their code produces a result, sure, but not the way they want it to, and thus, in my eyes, the code is not working, and not ready for review.

On the other hand, these questions by current agreement, are on-topic, and the code can be reviewed for what it is, not what it should be.

Simon André Forsberg

@rolfl That questions asks something like "Which of these is the best practice?" which is OK IMO

rolfl

12:32

I know, right, but I wou't upvote and won't answer it .... (because the answer is likely 'both').

Maybe I should, just to rep-whore.

Simon André Forsberg

@200_success It seems though that he knows what advice we're gonna give already. He knows about classes, he just doesn't seem to know how

rolfl

12:43

Rather: instead of: code can be reviewed for what it is, not what it should be

it is: Code can be reviewed for what it does, not what it should do.

4 hours later…

200_success

16:50

@SimonAndréForsberg Then you would probably feel the same way about this question?

Q: Python script for making a table

I have written a Python 2.6.6 script in order to make tables by taking the third column of every text file in a particular subgroup (signal and background in this case[particle physics]). However, I used the exec command too often and I think this code can be written more elegantly. #!/usr/bin/p...