« first day (58 days earlier)      last day (3803 days later) » 

06:38
Monking
> You can do this by running for example mvn -T 1C cleaninstall to run it multithreaded with one thread per core, but it does not gain a significant speed advantage.
 
9 hours later…
15:22
@bazola around?
hey @skiwi what is up
Was just wondering as I haven't seen you around much last days
had a pretty busy weekend
I am working on setting up the server right now
ah cool
I integrated FindBugs into the project, so there's some things you need to know
yeah I was going to ask you about FindBugs since I saw you mention it
15:27
The project will not build when there's any potential bugs in it
I recommend to install the FindBugs plugin in Netbeans
unfortunately the Netbeans FindBugs plugin is more strict than the compile-time FindBugs checker, so that's a pity
So I disable some (silly) FindBugs rules if they do let the code compile
If you cannot get your code to compile with Maven & FindBugs, then it is a real issue
i will install the plugin. have you done some commits that I need to grab?
Yeah, a lot to develop mainly
I'd suggest to grab them into javafx as well
so go ahead and merge develop into javafx to get those 2 commits?
@bazola You'll probably get more :)
16:02
@skiwi well it seems like everything still works :)
@bazola Did you pull it onto the javafx branch?
i pulled and then i merged develop into javafx
Ah nice
I fixed mostly the FindBugs errors in javafx though ;)
Evenking @SimonAndréForsberg
16:11
@bazola I'd recommend pushing the javafx branch after you've pulled and merged
[Cardshifter/Cardshifter] bazola pushed 2 commits to javafx
> Merge remote-tracking branch 'origin/develop' into javafx
hey @SimonAndréForsberg how is it going
@bazola It's going quite well thanks, been working a lot this recent week. Now I will only work tomorrow as well and then I'll have some more time to work on the TCG.
Until a couple of weeks at least when it's time to do some more work :)
thats cool, so you did pretty much all the work for the new job in just a week and a half?
well, both yes and no... that's all the job they have for me so far.
at least that's the work they are willing to pay for, for now...
16:17
i guess that is both good and bad
okay guys, I have my web server running the cardshifter server permanently now, and it is no problem for me to leave it running indefinitely. I just tested connecting to it at dwarftowers.com port 4242 and it appears to be working, and I have consumed the first AI.
@bazola great :) I also have a server we could host a server on, if your's ever go down (the same one that is hosting @Duga)
[Cardshifter/Cardshifter] build #209 for commit 6d7bbafc on branch javafx passed
cool :) I figured since you were busy I would go ahead and get it going for now, so now anyone that downloads the release could potentially play
17:03
cool @bazola
Uh... @SimonAndréForsberg
What on earth happened here ^
17:22
@skiwi MERGE All the branches!
 
3 hours later…
20:02
@SimonAndréForsberg Thanks to the interrupted article, I wrote this
	private void drainMessagesQueue() {
		while (true) {
			try {
				postDrainedMessages(messagesQueue.take());
			} catch (InterruptedException ex) {
				List<List<String>> drainedMessages = new ArrayList<>();
				messagesQueue.drainTo(drainedMessages);
				drainedMessages.forEach(this::postDrainedMessages);
				break;
			}
		}
	}
to...
	private void drainMessagesQueue() {
		try {
			while (true) {
				postDrainedMessages(messagesQueue.take());
			}
		} catch (InterruptedException ex) {
			List<List<String>> drainedMessages = new ArrayList<>();
			messagesQueue.drainTo(drainedMessages);
			drainedMessages.forEach(this::postDrainedMessages);
			Thread.currentThread().interrupt();
		}
	}
Looks better?
@skiwi Is that code from Cardshifter? I don't recognise it :) It looks a bit better, yes. But I'd need to see more context to be sure.
Hmm... that must be from the @Duga source, right?
@SimonAndréForsberg It's from our lovely bot
It's the main handler that posts to chat
I actually think that might solve the issue with Tomcat being slow to stop
The fact that I re-interrupt the thread?
It feels good to know what I'm doing now though
@skiwi no, the fact that before it just restarted the while-loop when it was interrupted. This time it actually breaks that loop.
20:13
@SimonAndréForsberg Didn't the break; ensure that it would quit the while loop already?
@skiwi right, I missed that part.
then I guess this didn't solve it
still not sure about what that code is meant to do though, will have to look into that at a later time
> Interrupting the messages queue in the StackExchangeChatBot now re-interrupts the thread.
I don't think that necessarily changed anything though.... it depends on if your outer code actually checks if thread has been interrupted... which I doubt that it does.
I wouldn't be surprised if Tomcat actually did that
The pom for that project stll looks horrible
I had no clue what I was doing yet back then
Tomcat interrupts your threads, it is up to your code to check if it has been interrupted.
20:18
I might investigate the threading issue tomorrow evening. But I don't want to promise anything :)
@SimonAndréForsberg But effectively all heavy work is is done in the BlockingQueue.take(), which by itself checks for interruption
"heavy work"? Sounds more like waiting work :)
Yeah... that ^
@Duga Shouldn't we wait until the push to master closes it? :)
@skiwi My intention wasn't actually to close it. Although now that I understand why it got closed, I like that it is closed now.
I think we really should consider using that for project management
I'll check it otmorrow
the idea is that Ready = Things that are ready to be worked on. In progress = Currently being worked on. Done = Done (Duh!). Backlog = Things that needs something else to be finished first before being ready to be worked on
21:00
I wish we could automatically close some issues that have been pushed to the develop branch
As the current Github model of closing issues is only relevant to external observable issues
@skiwi using the waffle.io thing, it's all about drag + drop
@SimonAndréForsberg Hmm I see
Looks immensely useful IMO, especially as we've used quite a bit of Github issues lately
I'm TTGTB now though
night
we can look into it more tomorrow
21:21
that waffle.io looks pretty awesome

« first day (58 days earlier)      last day (3803 days later) »