VBA Rubberducking

Duga

00:05

REFRESH!

[Minesweeper] 72 Games Played. 51 Bombs Used. 8337 Moves Performed. 11 New Users

[rubberduck-vba/Rubberduck] 784 additions. 46 deletions. 7 commits. 3 issues closed. 1 issue comments

Mathieu Guindon

01:17

ha!

Mathieu Guindon

02:38

this looks better now: api.rubberduckvba.com

3

Mathieu Guindon

03:43

pfffft I give up for tonight, this is dumb... controller factory isn't creating a controller for "webhook", but it works locally :/

Duga

12:12

[rubberduck-vba/Rubberduck] retailcoder closed issue #5907: DeclareAsExplicitType QuickFix makes incorrect change for implicit Variant, if reference is assigned using a line continuation

[rubberduck-vba/Rubberduck] BZngr pushed commit 542e8e6a to next: Add ConcatOpContext evaluation capability

[rubberduck-vba/Rubberduck] BZngr pushed commit 54dd27b6 to next: Merge branch 'next' into 5907HandleConcatOpContext

[rubberduck-vba/Rubberduck] web-flow pushed commit ae094068 to next

Merge pull request #6027 from BZngr/5907HandleConcatOpContext

Add ConcatOpContext handling to the ImplicitTypeToExplicitRefactoringAction

[rubberduck-vba/Rubberduck] build for commit 54dd27b6 on next: 97.58% (target 0.00%)

Mathieu Guindon

12:25

ooh, progress!

2

> Unable to cast object of type 'Rubberduck.WebApi.Controllers.WebHookController' to type 'System.Web.Mvc.IController'.

now why tf does it think it wants a Web.Mvc controller

Duga

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot prereleased draft prerelease Prerelease-v2.5.2.6142

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft prerelease Prerelease-v2.5.2.6142

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot published prerelease Prerelease-v2.5.2.6142

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created tag Prerelease-v2.5.2.6142

[rubberduck-vba/Rubberduck] build for commit ae094068 on next: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] build for commit ae094068 on next: 97.58% (target 0.00%)

Mathieu Guindon

12:55

Still having difficulties correctly updating the examples for some reason

Feeds

20:45

I wonder how hard it would be to ride an electric scooter in a hamster ball.

Duga

21:02

[rubberduck-vba/Rubberduck] GmausDev forked us into GmausDev/Rubberduck

2

[rubberduck-vba/Rubberduck] GmausDev created comment on issue #5829: Add multiple untyped declaration example for rubberduckvba.com

> Hi @Vogel612 Actually I´ve Done this task. Can u review the fix?

> Hi i try to solve this issue.

[rubberduck-vba/Rubberduck] Vogel612 commented on Rubberduck.CodeAnalysis/Inspections/Concrete/MultipleDeclarationsInspection.cs of pull request #6028: Issue #5829 Added the required example to documentation.

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created comment on pull request #6028: Issue #5829 Added the required example to documentation.

[rubberduck-vba/Rubberduck] build for commit ef17ac71 on unknown branch: AppVeyor build failed

BUILD FAILURE!

[rubberduck-vba/Rubberduck] Vogel612 commented on Rubberduck.CodeAnalysis/Inspections/Concrete/MultipleDeclarationsInspection.cs of pull request #6028: Issue #5829 Added the required example to documentation.

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created comment on pull request #6028: Issue #5829 Added the required example to documentation.

> :x: Build Rubberduck 2.5.2.6143 failed (commit github.com/rubberduck-vba/Rubberduck/commit/d885f3b2e7 by @GmausDev)

[rubberduck-vba/Rubberduck] GmausDev commented on Rubberduck.CodeAnalysis/Inspections/Concrete/MultipleDeclarationsInspection.cs of pull request #6028: Issue #5829 Added the required example to documentation.

[rubberduck-vba/Rubberduck] GmausDev synchronized pull request #6028: Issue #5829 Added the required example to documentation.

[rubberduck-vba/Rubberduck] GmausDev commented on Rubberduck.CodeAnalysis/Inspections/Concrete/MultipleDeclarationsInspection.cs of pull request #6028: Issue #5829 Added the required example to documentation.

[rubberduck-vba/Rubberduck] retailcoder added label hacktoberfest-accepted to pull request #6028: Issue #5829 Added the required example to documentation.

[rubberduck-vba/Rubberduck] Vogel612 commented on Rubberduck.CodeAnalysis/Inspections/Concrete/MultipleDeclarationsInspection.cs of pull request #6028: Issue #5829 Added the required example to documentation.

Duga

21:34

[rubberduck-vba/Rubberduck] retailcoder created comment on pull request #6028: Issue #5829 Added the required example to documentation.

> There are a number of validations that run on xmldoc; one of them is failing this build:

> C:\projects\rubberduck\Rubberduck.CodeAnalysis\Inspections\Concrete\MultipleDeclarationsInspection.cs(37,27): error DuplicateNameAttribute: The value 'MyModule' is used in the 'name' attribute of multiple 'module' elements. [C:\projects\rubberduck\Rubberduck.CodeAnalysis\Rubberduck.CodeAnalysis.csproj]

Basically it's not letting us use the same module name twice in the same example, ...which is confusi

Vogel612

@Duga @MathieuGuindon that failure is on the old state before fixing the split into multiple examples

I expect that to actually be fixed

Duga

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created comment on pull request #6028: Issue #5829 Added the required example to documentation.

> :white_check_mark: Build Rubberduck 2.5.2.6144 completed (commit github.com/rubberduck-vba/Rubberduck/commit/2a84f11fa4 by @GmausDev)

[rubberduck-vba/Rubberduck] build for commit b2e3fae1 on unknown branch: AppVeyor build succeeded

Vogel612

called it

Mathieu Guindon

haha nice

Duga

[rubberduck-vba/Rubberduck] GmausDev created comment on pull request #6028: Issue #5829 Added the required example to documentation.

> >
Can i resolve it?

[rubberduck-vba/Rubberduck] Vogel612 created comment on pull request #6028: Issue #5829 Added the required example to documentation.

> You just did :)

[rubberduck-vba/Rubberduck] GmausDev pushed commit ef17ac71 to next: Issue #5829 Added the required example to documentation.

[rubberduck-vba/Rubberduck] GmausDev pushed commit b2e3fae1 to next: Fix the tags

[rubberduck-vba/Rubberduck] web-flow pushed commit c78459af to next: Merge pull request #6028 from GmausDev/issue_5829

[rubberduck-vba/Rubberduck] build for commit b2e3fae1 on next: 97.58% (target 0.00%)

Mathieu Guindon

21:42

...and a webhook just complained about not being able to create the wrong type of controller

Vogel612

yay

Mathieu Guindon

or will, once there's a tag

tbh that one baffles me

Duga

[rubberduck-vba/Rubberduck] GmausDev created comment on issue #5723: Review inspection types

> Hi ! i try to take it

[rubberduck-vba/Rubberduck] GmausDev created comment on issue #5723: Review inspection types

> Just send the Commit , i have a doubt over the last requirement . Normally when u have an Enum u can put a default value thats what u want?

> I´ve been added the required information. I hope its fine.

[rubberduck-vba/Rubberduck] Vogel612 created comment on issue #5723: Review inspection types

> @GmausDev that commit will not work, since all the references to the enum elements will also need to be adjusted. I highly recommend setting up a "proper" IDE for this

M.Doerner

@MathieuGuindon Just a blind guess, did you double check the imports in you api code?

This kind of looks like it is searching for the type in the wrong namespace or in the wrong order of namespace s

Another question, what is the difference of the local and web setup? Are there different versions of frameworks/packages involved?

Mathieu Guindon

not sure what to be looking for.. there's a MVC IController called Home, and the other controllers are all HTTP ApiController; when hitting any controller locally everything works fine, but hitting the "webhook" controller from a webhook request only in production the MVC stuff kicks in, and shouldn't

Duga

21:51

[rubberduck-vba/Rubberduck] GmausDev created comment on issue #5723: Review inspection types

> Hi , i had vss 2022 enterprise version. Im looking all the references let me a moment :p

[rubberduck-vba/Rubberduck] GmausDev created comment on issue #5723: Review inspection types

> There is no reference to the value who i´ve changed . Maybe any problem with the interface or the models?

[rubberduck-vba/Rubberduck] GmausDev synchronized pull request #6029: Issue #5723

[rubberduck-vba/Rubberduck] retailcoder created comment on issue #5723: Review inspection types

> Unfortunately this repo doesn't build with VS 2022 for some reason (works fine in VS 2019 though).

Inspection default configs are admittedly a bit of a mess - what appears on the website is being parsed from a decoded sub-section of this file: https://github.com/rubberduck-vba/Rubberduck/blob/next/Rubberduck.CodeAnalysis/Properties/CodeInspectionDefaults.settings

But the `InspectionType` strings need to match the `InspectionType` enum values.

[rubberduck-vba/Rubberduck] GmausDev created comment on issue #5723: Review inspection types

> Ahaha, okay . No worries I´ll open with vs2019. And i try to change the settings document . The enum change its fine? If i understand good now i must change the references of the settings.

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft prerelease Prerelease-v2.5.2.6145

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot prereleased draft prerelease Prerelease-v2.5.2.6145

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created tag Prerelease-v2.5.2.6145

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot published prerelease Prerelease-v2.5.2.6145

[rubberduck-vba/Rubberduck] build for commit c78459af on next: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] build for commit c78459af on next: 97.58% (target 0.00%)

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created comment on pull request #6029: Issue #5723

> :x: Build Rubberduck 2.5.2.6146 failed (commit github.com/rubberduck-vba/Rubberduck/commit/267cdc9bc0 by @GmausDev)

[rubberduck-vba/Rubberduck] build for commit fc95d2ed on unknown branch: AppVeyor build failed

BUILD FAILURE!

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created comment on pull request #6029: Issue #5723

> :x: Build Rubberduck 2.5.2.6147 failed (commit github.com/rubberduck-vba/Rubberduck/commit/ece997bbf0 by @GmausDev)

[rubberduck-vba/Rubberduck] build for commit 0433ab4a on unknown branch: AppVeyor build failed

BUILD FAILURE!

[rubberduck-vba/Rubberduck] retailcoder created comment on issue #5723: Review inspection types

> I'd expect all the enum members to be at least used once for mapping to a particular icon asset somewhere... I think it's much safer to rename the members with a proper Rename refactoring in Visual Studio 😉

Vogel612

22:15

@MathieuGuindon the rename does not actually recognize the references in the settings file

Mathieu Guindon

I know... trying to think where these enums might be used (as symbols in the source code), all I could think of was the icon mapping.

Vogel612

translations

Mathieu Guindon

ooh

probably better to Ctrl+Shift+F across the solution

M.Doerner

22:32

@MathieuGuindon So, do I understand correctly that the webhook works properly locally with the real webhook hitting it?

Is the configuration identical between local and production?

I.e. does the webhook hit the same entry point?

Just stabbing in the dark here.

I have no experience in web nor any idea about the code you use.

Duga

[rubberduck-vba/Rubberduck] GmausDev created comment on issue #5723: Review inspection types

> ´kay ;D I´ll try take tomorrow .

Mathieu Guindon

22:49

@M.Doerner the real hook goes to API.rubberduckvba.com, but I'm sending the exact same payload with the exact same headers at the exact same /url. ..and local config is pointing to prod and being deployed as-is. It's very weird.

Duga

23:47

[rubberduck-vba/Rubberduck] retailcoder added label hacktoberfest-accepted to pull request #6029: Issue #5723

[rubberduck-vba/Rubberduck] retailcoder converted_to_draft pull request #6029: Issue #5723

[rubberduck-vba/Rubberduck] retailcoder created comment on pull request #6029: Issue #5723

> I've converted this PR to "draft", since it's a work-in-progress - don't hesitate to ask any questions, we're very happy to help!

[rubberduck-vba/Rubberduck] 1655 stars vs. [decalage2/oletools] 2228 stars

Transcript for