00:02
[rubberduck-vba/Rubberduck] retailcoder added label hacktoberfest-accepted to pull request #6026: Handle inconsistent results from Find All references gracefully
[rubberduck-vba/Rubberduck] 496 additions. 2 deletions. 2 commits. 1 issues closed. 5 issue comments
00:19
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot prereleased draft prerelease Prerelease-v2.5.2.6138
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft prerelease Prerelease-v2.5.2.6138
[rubberduck-vba/Rubberduck] retailcoder closed issue #5291: False positive `Variable '{x}' is not used'
[rubberduck-vba/Rubberduck] retailcoder closed issue #5908: False positive inspection results are generated for Public fields in Class Modules that define an interface
Align which unused procedures are reported
Now, implemented interface members and members in class modules marked as interface are reported as unused, if there are no references to them.
In addition, we no longer report unused procedures in in exposed class modules, sine these modules are clearly intended for external use.
We do not treat standard modules without the Private Module option the same way, because not having the option is the default in contrast to the exposed attribute.
Now, implemented interface members and members in class modules marked as interface are reported as unused, if there are no references to them.
In addition, we no longer report unused procedures in in exposed class modules, sine these modules are clearly intended for external use.
We do not treat standard modules without the Private Module option the same way, because not having the option is the default in contrast to the exposed attribute.
[rubberduck-vba/Rubberduck] MDoerner pushed commit 0112003e to next: No longer report unused public variables in exposed class modules
[rubberduck-vba/Rubberduck] MDoerner pushed commit c3de5ae8 to next: No longer report unassigned public variables in exposed class modules
[rubberduck-vba/Rubberduck] MDoerner pushed commit 5680516a to next: No longer report unused public constants in exposed class modules
00:46
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft prerelease Prerelease-v2.5.2.6139
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot prereleased draft prerelease Prerelease-v2.5.2.6139
[rubberduck-vba/Rubberduck] retailcoder closed issue #5952: Find All References of Enum in Interface crashes Excel if Implementing class is edited and not parsed
Handle inconsistent results from Find All references gracefullt
The results of Find All References take the input code from the reference's line in the VBE and the highlight selection based on the reference selection. If this happens in a dirty state, the highlight can be outside the input code on the line that is now on the line the reference was on before. Previously, this caused an ArgumentOutOfBoundExcetion in the UI code when applying the highlight, which brought down the host. Now, we c
The results of Find All References take the input code from the reference's line in the VBE and the highlight selection based on the reference selection. If this happens in a dirty state, the highlight can be outside the input code on the line that is now on the line the reference was on before. Previously, this caused an ArgumentOutOfBoundExcetion in the UI code when applying the highlight, which brought down the host. Now, we c
01:12
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot prereleased draft prerelease Prerelease-v2.5.2.6140
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft prerelease Prerelease-v2.5.2.6140
5 hours later…
5 hours later…
3 hours later…
14:54
> Closes #5907
Issue #5907 points to the existence of a line continuation as the cause of the incorrect `AsTypeName` outcome. However, the issue had nothing to do with the line continuation and everything to do with the '&' operator between the string literals.
The goal of the `ImplicitTypeToExplicitRefactoringAction` is to provide an _improved_ result, when possible, relative to the `DeclareAsExplicitVariantQuickFix`. Absent a unified Expression engine (#3969), the refactoring action is
Issue #5907 points to the existence of a line continuation as the cause of the incorrect `AsTypeName` outcome. However, the issue had nothing to do with the line continuation and everything to do with the '&' operator between the string literals.
The goal of the `ImplicitTypeToExplicitRefactoringAction` is to provide an _improved_ result, when possible, relative to the `DeclareAsExplicitVariantQuickFix`. Absent a unified Expression engine (#3969), the refactoring action is
15:25
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created comment on pull request #6027: Add ConcatOpContext handling to the ImplicitTypeToExplicitRefactoringAction
> :white_check_mark: Build Rubberduck 2.5.2.6141 completed (commit github.com/rubberduck-vba/Rubberduck/commit/a413fd250f by @BZngr)
3 hours later…
19:02
[rubberduck-vba/Rubberduck] BZngr commented on RubberduckTests/Refactoring/ImplicitTypeToExplicit/ImplicitTypeToExplicitRefactoringActionConstantTests.cs of pull request #6027: Add ConcatOpContext handling to the ImplicitTypeToExplicitRefactoringAction
[rubberduck-vba/Rubberduck] BZngr commented on RubberduckTests/Refactoring/ImplicitTypeToExplicit/ImplicitTypeToExplicitRefactoringActionConstantTests.cs of pull request #6027: Add ConcatOpContext handling to the ImplicitTypeToExplicitRefactoringAction
19:33
2 hours later…
2 hours later…
23:50
« first day (3049 days earlier) ← previous day next day → last day (131 days later) »
Transcript for
Oct10
Oct '2211
Oct12
VBA Rubberducking
This chat has moved to Discord: discord.gg/MYX9RECenJ