VBA Rubberducking

Duga

12:02 AM

RELOAD!

[MDoerner/AdventOfCode2020] 1 commit. 192 additions. 24 deletions.

[rubberduck-vba/Rubberduck] 10 issue comments.

[Zomis/FactorioMods] 10 commits. 44 additions. 843 deletions.

[Minesweeper] Games Played: 56, Bombs Used: 30, Moves Performed: 7096, New Users: 9

Duga

12:37 AM

[rubberduck-vba/Rubberduck] Vogel612 commented on Rubberduck.Deployment/InnoSetup/Includes/German.CustomMessages.iss of pull request #5756: German translations for the installer for 2.5.2

Duga

7:49 AM

[rubberduck-vba/Rubberduck] MDoerner synchronized pull request #5756: German translations for the installer for 2.5.2

Duga

8:15 AM

[rubberduck-vba/Rubberduck] build for commit dd5f3805 on unknown branch: AppVeyor build succeeded

Duga

8:49 AM

[rubberduck-vba/Rubberduck] Danbsky starred us

3

Duga

1:26 PM

[rubberduck-vba/Rubberduck] retailcoder merged pull request #5756: German translations for the installer for 2.5.2 from MDoerner/Rubberduck/GermenInstallerTranslationsFor252 into...

rubberduck-vba/Rubberduck/next

[rubberduck-vba/Rubberduck] MDoerner pushed commit 3640c774 to next: German translations for the installer for 2.5.2

[rubberduck-vba/Rubberduck] MDoerner pushed commit 762af33b to next: Address comments to PR #5756

[rubberduck-vba/Rubberduck] MDoerner pushed commit dd5f3805 to next: Fix typo in German installer translation

[rubberduck-vba/Rubberduck] web-flow pushed commit 129460b0 to next

Merge pull request #5756 from MDoerner/GermenInstallerTranslationsFor252

Adds new German translations for the installer script.

Duga

1:51 PM

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot prereleased draft prerelease Prerelease-v2.5.2.5894

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft prerelease Prerelease-v2.5.2.5894

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot published prerelease Prerelease-v2.5.2.5894

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created tag Prerelease-v2.5.2.5894

[rubberduck-vba/Rubberduck] build for commit 129460b0 on next: AppVeyor build succeeded

Duga

3:41 PM

[rubberduck-vba/Rubberduck] retailcoder created pull request #5758: Release 2.5.2 to merge next into main

[rubberduck-vba/Rubberduck] retailcoder pushed 1 commit to next

[rubberduck-vba/Rubberduck] web-flow pushed commit 5870ada3 to next: Merge branch 'main' into next

[rubberduck-vba/Rubberduck] retailcoder synchronized pull request #5758: Release 2.5.2

Duga

4:06 PM

[rubberduck-vba/Rubberduck] build for commit 129460b0 on next: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] retailcoder synchronized pull request #5751: Introducing 'Peek Definition' commands

Duga

4:33 PM

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft prerelease Prerelease-v2.5.2.5896

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot prereleased draft prerelease Prerelease-v2.5.2.5896

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot published prerelease Prerelease-v2.5.2.5896

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created tag Prerelease-v2.5.2.5896

[rubberduck-vba/Rubberduck] build for commit 5870ada3 on next: AppVeyor build succeeded

Duga

4:58 PM

[rubberduck-vba/Rubberduck] build for commit 5870ada3 on next: AppVeyor build succeeded

Mathieu Guindon

and here we are

FreeMan

5:15 PM

Yay!!!!

where are we?

Duga

[rubberduck-vba/Rubberduck] retailcoder merged pull request #5758: Release 2.5.2 from next into main

Mathieu Guindon

building!

Duga

[rubberduck-vba/Rubberduck] retailcoder pushed 420 commits to main

[rubberduck-vba/Rubberduck] web-flow pushed commit a5708b34 to main

Merge pull request #5758 from rubberduck-vba/next

Release 2.5.2

[rubberduck-vba/Rubberduck] build for commit a5708b34 on main: GitHub Pages successfully built your site.

Mathieu Guindon

first thing to merge post-release should be @IvenBach's resource clean-up PR I think

> v2.5.1: 11,674 downloads

Duga

[rubberduck-vba/Rubberduck] build for commit c99ba19f on unknown branch: AppVeyor build succeeded

Mathieu Guindon

5:47 PM

That's very badly written code. If you want a better understanding of Scripting.Dictionaries then google for VBA scripting.Dictionary. If you want to get a better understanding on writing good VBA then install the free and fantastic RubberDuck addin and look at the code inspections. In the code above d(e) is using the default member method. It should be more correctly be written as d.Item(e). The for loop is bad because it does not check to see if e is present in the dictionary before doing operations on its value. I wouldn't be surprised if the code failed first time through the loop. — freeflow 5 mins ago

Duga

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft release RETAGMEWITHAMESSAGE

[rubberduck-vba/Rubberduck] build for commit a5708b34 on main: AppVeyor build succeeded

Hosch250

6:12 PM

Hey, @MathieuGuindon, do you still manually set the version on the website?

Mathieu Guindon

no, but I need to run the content updater app (only because I haven't re-scheduled it yet... normally runs on a scheduler)

Duga

[rubberduck-vba/Rubberduck] retailcoder edited release v2.5.2

[rubberduck-vba/Rubberduck] retailcoder released release v2.5.2

Mathieu Guindon

running now

Duga

[rubberduck-vba/Rubberduck] retailcoder published release v2.5.2

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created tag v2.5.2

Mathieu Guindon

and we're live

4

Hosch250

6:15 PM

You pull it from GitHub's API?

Mathieu Guindon

yep

the app also downloads the xmldoc assets off [next] and [main], and then proceeds to generate the content and update the db records

Hosch250

Nice.

HackSlash

6:29 PM

Wow! New Release. Shiny!

Blogging Duck

Rubberduck News: Introducing Rubberduck 2.5.2

posted on May 03, 2021 by Rubberduck VBA

Version 2.5.1 was released August 22, 2020. Since then, the installer was downloaded over 11,600 times; we are now 420 commits and 650 modified files later, and the time has come to deliver all that work into a convenient little installer package and move on to the next dev/release cycle. What’s New? If you’ve kept… Continue reading Introducing Rubberduck 2.5.2 →

Vogel612

6:51 PM

@BloggingDuck @MathieuGuindon typo: it should be "the cure was worse than the disease". It's a sickness, not the act of dying 😀

Mathieu Guindon

thanks, fixed!

Duga

7:04 PM

[rubberduck-vba/Rubberduck] retailcoder synchronized pull request #5751: Introducing 'Peek Definition' commands

HackSlash

Arg. Why does Visual Studio 2019 freeze for long periods of time with no CPU usage? What the hell is it doing? I get "Not responding" all the time. Especially when editing .csproj

Duga

[rubberduck-vba/Rubberduck] retailcoder created pull request #5759: 2.5.2 Hotfix for VB6 to merge retailcoder/Rubberduck/vb6cmds into rubberduck-vba/Rubberduck/next

> Reverts commit 8ee1b175 (get VB6 menu positions by name, reverts to by index)

Duga

7:29 PM

[rubberduck-vba/Rubberduck] build for commit ae4c6521 on unknown branch: AppVeyor build succeeded

Mathieu Guindon

@Duga @mansellan did you run into any issues in VB6 since 8ee1b175? I got a DM on Twitter about an exception on startup in Office.CommandBars.get_Item(Object Index) and immediately thought of that commit and it's probably better to just revert it for VB6, but I'm hoping it's consistently failing in VB6... seems odd nobody mentioned any problems about a commit that was merged... 29 days ago?

mansellan

@MathieuGuindon Oh dang, is that the one you asked me to check forever ago?

Mathieu Guindon

think so :)

mansellan

eek. right, gimme a sec.

got a new laptop a while ago, but I had it set up as a works BYO device so can't put VB6 on it. The old one, meanwhile, has a dying wifi card...

digs out ethernet cable

ok cool, should I pull that commit or just main?

Mathieu Guindon

In principle main is blowing up atm

mansellan

7:36 PM

ok cool

Mathieu Guindon

thanks!

mansellan

i'll try the installer first, not even sure if VS is up together enough to build RD on the old lappy atm

Mathieu Guindon

Sounds good! and then (assuming a repro) you can try the CI build that just completed (should work), don't need to build =)

mansellan

ok

heh, smortscreen..

ugh, and avast :-(

yep, repro'd on 2.5.2

yeah arg out of range on CommandBars_get_Item. Checking the newer build.

Mathieu Guindon

awesome, thanks!

...and that means we have exactly 0 VB6 users running a pre-release build lol

mansellan

7:48 PM

lol

still borked in 5896 :-(

same error

uninstalled, trying a reboot

nope :-(

Duga

[rubberduck-vba/Rubberduck] build for commit fee71f02 on unknown branch: AppVeyor build succeeded

Mathieu Guindon

Damn, IDK what the problem is then

@Duga @mansellan oooh wait, THAT is the hotfix build!

(5896 was my peek branch)

mansellan

ah ok makes sense - log showed it still going through the commandBarName overload

can't see 5901 on releases yet, is duga still doing her thing?

oh wait, it wouldn't be there till merged right

Mathieu Guindon

8:05 PM

^

mansellan

lemme try and build it 1 sec

Mathieu Guindon

you should be able to just grab the asset from the AppVeyor build though

mansellan

oh ok, didn't see it there

ah i got it

yep 5901 loads. want me to check anything else?

Mathieu Guindon

awesome, merging - thanks!

mansellan

ok nw

Duga

8:09 PM

[rubberduck-vba/Rubberduck] retailcoder merged pull request #5759: 2.5.2 Hotfix for VB6 from retailcoder/Rubberduck/vb6cmds into rubberduck-vba/Rubberduck/next

mansellan

menus seem ok

Duga

[rubberduck-vba/Rubberduck] retailcoder pushed commit fee71f02 to next: revert 8ee1b175 (get VB6 menu positions by name, reverts to by index)

[rubberduck-vba/Rubberduck] web-flow pushed commit ceb00e3d to next

Merge pull request #5759 from retailcoder/vb6cmds

2.5.2 Hotfix for VB6

mansellan

sorry about that - I won't lose track of that laptop again!

Mathieu Guindon

nw

mansellan

in other news, I opened a tB discussion on namespaces

Duga

8:34 PM

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot prereleased draft prerelease Prerelease-v2.5.2.5902

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft prerelease Prerelease-v2.5.2.5902

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot published prerelease Prerelease-v2.5.2.5902

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created tag Prerelease-v2.5.2.5902

[rubberduck-vba/Rubberduck] build for commit ceb00e3d on next: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] retailcoder created pull request #5760: Hotfix for VB6 to merge next into main

> Reverts a commit that fixed VBA menu positioning but broke VB6 integration.

Duga

8:55 PM

[rubberduck-vba/Rubberduck] retailcoder pushed 1 commit to next

[rubberduck-vba/Rubberduck] web-flow pushed commit 3108e01e to next: Merge branch 'main' into next

[rubberduck-vba/Rubberduck] retailcoder synchronized pull request #5760: Hotfix for VB6

Duga

9:05 PM

[rubberduck-vba/Rubberduck] build for commit ceb00e3d on next: AppVeyor build succeeded

mansellan

9:29 PM

@mansellan I wonder if there's any way stop enum members polluting the global namespace... Type "vb" into twinBASIC and you get dozens upon dozens of enum members. If there were a way to tell it to use the .net way of typing EnumType.EnumMember, that would go a long way...

Duga

[rubberduck-vba/Rubberduck] build for commit 3108e01e on next: AppVeyor build succeeded

M.Doerner

@MathieuGuindon @BloggingDuck The heading for the Introduce Get Accessor quick fix is missing its underline.

Mathieu Guindon

thanks, fixed! (they're actually links to the corresponding website page)

M.Doerner

Should we also mention in the list of PRs, that you can exclude projects from parsing now?

this

9:48 PM

@mansellan Sounds like an addition to the Option Strict proposal.

mansellan

@this Yeah was just thinking that... been trying out vb.net in dotnetfiddle - looks like with Option Strict you can't assign an enum member of the wrong type.

this

Option Disallow Ambiguity Because This Is Not Politics, Poetry Or Humor

mansellan

But... where would VB be without hand-wavey voodoo?

this

That's what the Caribbean islands are for.

mansellan

Not sure if that would work for all the "fake enums" in the standard lib like VBA.VbKeyPressConstants. If they were taken out of the global intellisense (so you had to qualify them) when Option Strict was on, could that cause problems?

also, feature request... avoid the need for "fake enums" - Public Enum SomeEnum >>>As LongLong<<<

istr all VBx enums are Long under the covers...

Duga

9:55 PM

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot prereleased draft prerelease Prerelease-v2.5.2.5905

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft prerelease Prerelease-v2.5.2.5905

this

Nah, i think with strict on, you'd have to type VBA.vb*** instead of just vb**

Duga

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot published prerelease Prerelease-v2.5.2.5905

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created tag Prerelease-v2.5.2.5905

[rubberduck-vba/Rubberduck] build for commit 3108e01e on next: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] retailcoder merged pull request #5760: Hotfix for VB6 from next into main

mansellan

@this Hmm... hadn't considered that

Duga

[rubberduck-vba/Rubberduck] retailcoder pushed 3 commits to main

[rubberduck-vba/Rubberduck] web-flow pushed commit bd30cc1d to main

Merge pull request #5760 from rubberduck-vba/next

Hotfix for VB6

[rubberduck-vba/Rubberduck] build for commit bd30cc1d on main: GitHub Pages successfully built your site.

mansellan

@Duga @mansellan feels guilty he cost Mug a bunch of time pushing an immediate hotfix

this

9:56 PM

Technically it's just a bunch of unrelated constants.

mansellan

@this yeah indeed

this

for giggles, one should request Public Enum Derp As String

mansellan

haha

this

Foo = "Foo"

It's one another annoying aspect - you have a need to have string constants but there's no way to relate them.

in .nET you can get around with it by using a static class

mansellan

yeah. I could see a case for c# allowing enums of strings, but I guess it has assumptions about being about to do maths on them...

this

9:59 PM

True.

yo, compiler! What's "foo" * "bar"?

mansellan

would make more sense if it defaulted to only allowing actual enum members to be passed, but then how do you allow bitwise flags...

this

I don't think you can/should use bitwise flags.

mansellan

if flags.HasFlag("Derp")...

yeah perhaps... but they are the tightest way of packing a bunch of bits together. 1 bool != 1 bit...

so I can see a use in hot paths

Mathieu Guindon

@mansellan no worries :)

this

"foo" | "bar" = "voo"

mansellan

10:07 PM

tbh if my namespaces proposal (or something like it) gets adopted, it should be possible to replace the standard lib (especially if some kind of "static linking" feature was added as well...

this

I think what we really want is package reference

then hey, no more finding the dll in a certain path or looking at registry and hoping for the best.

mansellan

oh absolutely, that would be a massive help too

not sure you'd want that for VBA and stdole though?

this

#FunFact: You can unreference stole. Some do.

mansellan

huh, #TIL

this

In case of VBA, I am not sure that is even possible.

Doesn't really matter, anyway.

mansellan

10:15 PM

If tB had a way of exposing static linking though... you could add code from libs that would be baked into the exe. An actual single file mode, not .Net5's "don't look behind the curtain because its actually many files in one" approach...

this

I think that is already the case? Not sure I follow.

Mathieu Guindon

MVVM textbox bindings work both ways now

this

Nice. Curious; how you have been debugging?

Mathieu Guindon

but I'm really starting to itch for multiple-file support

'@Description "An entry point module for debugging."
module App
    '@Description("An entry point to test/debug as a standalone .exe")
    public sub Main()
        Dim Context As IAppContext
        Set Context = New AppContext()

        Dim VM As TestViewModel
        Set VM = New TestViewModel()

        Dim TextBox As MSForms.TextBox = CreateObject(FormsProgID.TextBoxProgId)
        Dim Label as MSForms.Label = CreateObject(FormsProgID.LabelProgId)

        Context.Bindings.BindPropertyPath VM, "Value2", TextBox

@this ^ like this :)

mansellan

@this Well, tB does it internally. The VBA and ole functions (at least, the ones that actually get used) are statically linked into the output. That's how you get a single .exe with no runtime dependencies. I'm just proposing that be available for abitrary libs, not just the ones baked into tB.

Could only work for c-style libs though, not dlls

Mathieu Guindon

10:18 PM

also this project makes me want inheritance in tB

this

@MathieuGuindon hmm. That's one way to do it, I guess.

tB needs an unit testing library. :D

Mathieu Guindon

yes

mansellan

Yeah it needs multi-file - suspect most would use that as the default

Mathieu Guindon

YES

this

Agreed 100%.

Mathieu Guindon

10:19 PM

3.6K lines and ~~counting~~ itching

mansellan

the twinproject file has binary bits - I've managed to corrupt it several times in testing

this

@MathieuGuindon and some VB guy is going to come along and scoff at a mere 3.6K and tell you to man up. :-D

mansellan

NEEDS MOAR COPYPASTA FROM SO :/

Mathieu Guindon

and then I'll get back to them with 12K and laugh because they can't compile it

because 10K in VB6 blows up at compile-time, right?

Duga

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft release RETAGMEWITHAMESSAGE

Mathieu Guindon

10:21 PM

whee here we go

this

within a single module? Can't remember if that was a limitation particular to VBA or to both VBA/VB6.

Definitely the case w/ VBa.

Duga

[rubberduck-vba/Rubberduck] build for commit bd30cc1d on main: AppVeyor build succeeded

this

(but why are you churning out 10K modules?!?)

Remember that guy who wanted to write an operating system on VBA?

Mathieu Guindon

@this the one time I encountered it (in VB6) was a colleague copy-pasting chunks of a couple hundreds of lines of code whenever she needed to make a new report

mansellan

@MathieuGuindon 65534 lines. You'll hit other limits before that one though.

Mathieu Guindon

10:24 PM

interesting

mansellan

@this pretty sure they were trying to write an app-launcher, just didn't know the right words. Not a great start...

Mathieu Guindon

I didn't remember it was that bad... but vividly recall that moment lol

this

Still the wrong tool for the job, though.

> A single line of code can consist of up to 1023 bytes. Up to 256 blank spaces can precede the actual text on a single line

I kind of understand the fixing length to 1023 bytes but restricting only 256 blank spaces in front? Seems strange.

Mathieu Guindon

64 standard indentation levels, cool cool

this

Please stop nesting your code

I vaguely recall a old post from somewhere where a guy got that idea to write a huge module and he was complaining about losing his indentation.

Uh, you have bigger problems than indentations, bud....

Mathieu Guindon

10:28 PM

3.5K is going to grow though, I've yet to port the other control binding classes, all the layout stuff, ..and this thing needs so many tests...

this

Ideally, the tests need ot be their own project

Mathieu Guindon

good point

this

You don't want to ship the test modules in your DLL/EXE.

Mathieu Guindon

true

food o'clock :)

Duga

11:02 PM

[rubberduck-vba/Rubberduck] retailcoder published release v2.5.2.1

[rubberduck-vba/Rubberduck] retailcoder edited release v2.5.2.1

[rubberduck-vba/Rubberduck] retailcoder released release v2.5.2.1

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created tag v2.5.2.1

Mathieu Guindon

in today's #ImAnIdiot news..

Vogel612

at least it's descriptive

this

Nah, that's a a friendly reminder to the duckies to tag Teh Ducky™ in their twitter & facebook feeds and leave a message praising Teh Ducky™ to the high heavens.

I see no idiocy there.

Mathieu Guindon

fml why isn't it picking it up lol

tag v2.5.2.1 has IsPreRelease=0 and ..oh crap the timestamps

and fixed

Greger

11:46 PM

[rubberduck-vba/Rubberduck]: 1332 stars vs. [decalage2/oletools]: 1530 stars

Transcript for