@BloggingDuck option to Select only Property Gets is one I could use often.
> Instead, copy the IUser interface into the new Class1 module, select all, and Ctrl+H to replace “Property Get ” (with the trailing space) with “Function With” (without the trailing space).
^ I believe screenshots of this will help readers that don’t do this type of renaming understand what you’re actually doing.
> #5506 fixed it for me! I was able to load the project and run a full parse for the first time without the application hang I was experiencing before. Thank you @MDoerner for your work on this!
@BloggingDuck Awesome article. The Builder example really lends itself to showcasing the bulk code generation/modification chops of RD. Really well done.
@M.Doerner The DefaultStyle.xaml should only contain styles. Because it's then used as a dictionary in other xaml files, there are restrictions on what you can put in DefaultStyles.xaml. Which is partially why Toolbar.xaml still has some styling elements.
I don't remember having any images.... but I am not sure I had to move images; I left them as they were since they were usually specific to a particular element. It all depends on whether a ResourceDictionary is allowed to have an image or not.
I currently have the error icon image in the resource dictionary of the Rename control, the MoveToFolder control, the MoveFolder control and the AnnotateDeclaration control.
I use it in the new TextBoxErrorStyle, which basically makes the textbox look like the one on the rename dialog when there is a validation error and, in addition, has a tool tip with the first error message.
I plan to change the three other dialogs to use it, too.
I think the WPF way would have been to define a control template once, then re-use that template in other places sot hat you only define the icon once in that template, and the dialogs that needs similar textbox + icon functionality just instantiates that template.
Unfortunately I've never actually created a template so I don't know how that would be done.
The TextBoxErrorStyle basically does that; it defines an error template to use. However, to show the error tooltip conditional on whether there is an error, I need a style trigger.
To implement a real control template would probably be a bit more involved.
@BloggingDuck I do not like the idea to generate a result for a missing tribute if there is a @Predeclared annotation, but the attribute has the value False.
@M.Doerner I'm not suggesting that either - that bit was written from the POV of the user wondering why it wouldn't work ;-) ...but I always try to find AttributeOutOfSync results under Rubberduck Opportunities. I recall a convo about it being a Code Quality Issue on the basis that is could break the code (like VB_PredeclaredId being out of sync does), but... I just think it makes more sense under RD Opportunities