I'm interested to hear about the situation in other cultures.
I'm Dutch. There are phone books full of weird Dutch family names. Such as Naaktgeboren (Born naked), Windzak (Windbag), Palingdood (Dead eel) and many many more. How did this came to be?
When the French took over the Batavian r...
To fix, change the ByVal to ByRef in the function:
Public Sub RunMe()
Dim wksTestArray() As Worksheet
MsgBox SendArrayToFunction(wksTestArray())
End Sub
Public Function SendArrayToFunction(ByRef vntArray As Variant) As Boolean
SendArrayToFunction = True
End Function
apparently the latest n' greatest update will break every piece of VBA code that's passing an array to a ByVal Variant parameter... I wonder if RD should start warning about known-to-be arrays being passed to a ByVal Variant parameter, or if it's just a bug they introduced...
Got me wondering - what does .NET do that it doesn't run into problems COM has? It obviously does a better job of hiding all the tedious memory management than COM does (not that COM tried to hide it in first place), but oh boy, you better get it right or it'll just crash.
One thing's for sure that .NET did that COM didn't is that they didn't ask people to implement memory management themselves. However, you'd have to stay inside .NET's walled garden whereas COM is supposed to work with any languages, so it can't manage the memory for you in any language.
and in that case, the walled garden is no longer safe.
it's a lie to think that just because it's in a block labeled unsafe and it works fine when executing code in that block doesn't mean that it did something very bad to something somewhere else
We see that all time in RD even though we have zero unsafe nor fixed blocks in the codebase.
I do truly worry about kids who grows up on only the managed languages, never have seen unmanaged code work, and getting their first AV.
@MathieuGuindon I'm pretty sure it's zero. The key is that we use Marshal to do all that work.
My point was that even if we did, it's wrong to think that unsafe-ness stays within that block. It doesn't. The fact that our code doesn't contain any unsafe and still can get AVs proves that point.
Using Marshal makes it convenient for us because we don't have to add the switch to the compiler --- wasn't there other issues with enabling unsafe code?
@Vogel612 you will also note that Wayne mention that some operations we do might be faster if we used unsafe but he avoids it by creating the addressable variables to "safely" cast between unmanaged and managed stuff.
But IMO, naming various methods as unsafe is correct. We are actually manipulating unmanaged memory.
From what I have seen, what a segfault is on a Linux system is a bit unclear, either a memory access to not owned memory or only those found and reported by the system.
A GPF on a windows system is clearly only a caught AV.
However, in practice, the distinction is really mood.
FWIW - if worksheets are yours to control and it's used internally, you might cut out lot of code by making a data connection. Just a thought in case it applies.
I'm trying to find a legit use case for this, beyond "toying with win32 api"
@MathieuGuindon In this instance, it is to improve my API/project's interface. I am creating a wrapper for the SetTimer API, and would still like to give the opportunity for users to pass a TIMERPROC callback directly. A second level abstraction will use a command class/ an event source to make things more VBA-idiomatic. For maximum flexibility I'd like to expose the raw workings though, and one aspect of my wrapper API is that it allows a synchronous first call to the TIMERPROC, so I'm looking for the best (least Windows-update-breakable) way to do that. Mac support was dropped from the start — Greedo13 mins ago
I'm just trying to get ahead of the curve when I get the request of "We need this to also work with the upcoming code cycle too." IE two different data sets that need to remain distinct.
Apart from the initialization code, nothing outside the factory modules is allowed to call code inside those modules.
What I do is to set up a method Initialize_Properties and then call that from my factory module for that interface.
The exception are factories for simple data containers without logic.
I know that @MathieuGuindon uses factory methods on predeclaredId classes, but I do not really like that because I have not found any way to properly hide them.
@M.Doerner I don't like having a "factory module" that can create anything and its mother though. I guess we can meet in the middle and use a dedicated SomethingFactory class?
@QHarr what's up?
@Duga importing an existing module doesn't add the @Folder annotation. adding a new module does though
The code below is functional and works as expected, but I imagine there is a better way to test for the error that I am testing for .
The scenario is that data is transferred between two different servers throughout the year, so I built in an error handler that checks to see if the connection to...
I have in my mind to borrow the idea from Wayne's PR and create a new class VBIDEExtensions or something, and tie its lifetime to the original vbe instance, and get the related classes from that.
@this Heh, a couple of them are mine (providers for the root VBE and AddIn objects). Had to use that pattern as a factory would have needed access to all the concrete types, which would have created circular dependencies. With a provider, you can delegate that to another assembly.
In all fairness that PR was knowingly more than past-Iven could handle. I'd stand a lot better chance at it now. :shakes-fist-at-nothing-in-partuclar: were it not for upcoming University I'd give it the old college try.
I am currently coding up several different ways of achieving the same end goal i.e. to check if some files are available during a certain window and download if so. I am using it as a case study to explore synchronous versus async versus multiprocessing versus threading. As each will be a piece of code in and of itself how would I go about posting them to code review? I was thinking one at a time as I complete them and incorporating feedback from earlier code review answers to later postings where applicable. Just not sure if that is considered bad form?
@QHarr if feedback from the first post would be applicable to subsequent posts, I'd just post one, get the feedback, apply/refactor/enhance, and then post another one (linking to the first one if appropriate)
@MathieuGuindon That was my thinking. It doesn't matter that it is for the same goal? I would hope not as the approaches are substantially different. I would have thought people might be pissed if I didn't take on board feedback from prior questions though (where applicable!)
I think your PR will be in conflict with Wayne's PR since we changed several things, including a small change to the ComProject
and besides, we need the data in the Declaration, rather than inspections so that you don't need to access typelib API from inspections. IMO, the access to typelib API should be limited to Com*** which can be then picked up by the parser/resolver.
Ok, I tried - and failed. Sorry but this code needs to burn and be essentially rewritten. First thing to do is to de-tangle the ForEach variables. Don't use loop variables for anything other than iterating the loops: don't reuse them after the loop finished, the reference held is a residual pointer to whatever the last iteration was at. Without running the code I'm not seeing how the exit condition can even be met. I wish I could post an answer, but this code needs serious attention. Fix the foreach variable reuse, then qualify all Range calls; that'll be a good start. — Mathieu Guindon1 min ago
My code below works, but I'm sure could use some help to speed it up.
I'm using an adodb connection with sql to get info and put it in a userform.
Any suggestions would be appreciated.
Sub Booked_Loans_To_Review()
Dim conn As ADODB.Connection
Dim rs As ADODB.Recordset
Dim SQLStr As String
Dim d...
I'm interested to hear about the situation in other cultures.
I'm Dutch. There are phone books full of weird Dutch family names. Such as Naaktgeboren (Born naked), Windzak (Windbag), Palingdood (Dead eel) and many many more. How did this came to be?
When the French took over the Batavian r...
To fix, change the ByVal to ByRef in the function:
Public Sub RunMe()
Dim wksTestArray() As Worksheet
MsgBox SendArrayToFunction(wksTestArray())
End Sub
Public Function SendArrayToFunction(ByRef vntArray As Variant) As Boolean
SendArrayToFunction = True
End Function
My code below works, but I'm sure could use some help to speed it up.
I'm using an adodb connection with sql to get info and put it in a userform.
Any suggestions would be appreciated.
Sub Booked_Loans_To_Review()
Dim conn As ADODB.Connection
Dim rs As ADODB.Recordset
Dim SQLStr As String
Dim d...
VBA Rubberducking
VBA Rubberducking