@MathieuGuindon Check out build-rubberduck-toc.xlsm. The idea is to use the VBA to build the TOC, add it as a static webpage to the site and link to it in the main menu. You would have to update it at the end of the month when the posts archive but that should only take about 10 minutes. It's a shame the the h2 tags don't have Ids. If they did you could use them as bookmarks. Anyway it's just an idea. — TinMan1 min ago
> I think the foreign identifier is a red herring. I can duplicate this with no code at all. The first time I open the metrics window with an empty workbook, Sheet1 shows nothing and ThisWorkbook shows 0 lines of code. After any change to ThisWorkbook, it doesn't show anything at all. It I add a module, it doesn't update the open metrics window. At the risk of sounding clichéd, that points to a caching problem.
Followers: it’s been great contributing to the Excel/VBA community over the past two years. Due to new projects and time constraints, I’ll be taking my site, http://excelvirtuoso.net offline in the coming days. Thanks to all of you who have provided input.
@PeterMTaylor Just taking the obligatory JS stab there. The article is quite interesting - it points to the much wider problem of accounting for the value of unpaid services.
Reminds me of the perennial debate over how much value stay at home parent contribute to economic activity.
@PeterMTaylor Not really - we're doing that on purpose apparently.
> Did a bit of digging into this, and found something interesting. It is definitely related to default member resolution, but there is a little bit of a twist. When I first attempted to replicate this, I was lazy and tried to use a `Collection` instead of adding a reference to DAO. That did *not* trigger the false positive. So I added DAO, and... replicated:
``` Sub Bad(foo As DAO.Recordset) Debug.Print foo("Field") 'Only Fields has an identifier reference, not foo. End Sub
IOW, the method invokes an object that has a default member that itself is an object, and has a default member, then we will get that default member of that object.
The point being that if it refers to an object that has an default member access to another object that itself has a default member, we get the final member
not the intermeritary
in Recordset's case - the default member is Fields, which then contains a Item
That's why I don't think that's just a DAO thing - that's a VBA thing - multiple default member accesses lead to fun times.
I think SCP is actually as solid as it's going to get in the VBE code panes. I've been thinking, Avalon might end up requiring a second implementation on top of it.
I honestly doubt it'll make a difference - this is for Deployment, which is too late for him.
AV
one thing i don't understand is if I try to Build the RD.Deployment, it insists on building all other dependent projects, even though those were successfully built.
> Just spit-balling here, but would it make sense to add a "Cancelling" parser state to account for this type of situation? If we set the state to Cancelling and then immediately to Ready afterward, we'd at least be able to respond to that event in the listeners.
I have someone dropping by the pond at some point.
> I am a computer science student aspiring to be a programmer specializing in the languages of either c++ or c#. I was just wondering if you had any opportunities (like an internship or volunteering opportunities) that I could participate in to help gain practical experience.
I'm responding with a link to the GH repo and our war pond.
> I have to say that I do not really like that idea. This would introduce a new source of state changes outside the ParseCoordinator that could change the overall parser state anywhere in the parsing process because it would possibly be triggered from another thread.
Code Inspections yields the following false positive:
**_Object variable 'CustomDocumentProperties' is assigned without the 'Set' keyword_**
Environment: Version 2.3.0.4235 OS: Microsoft Windows NT 10.0.17134.0, x64 Host Product: Microsoft Office x64 Host Version: 16.0.11001.20108 Host Executable: WINWORD.EXE
The problem is that the inspection does not correctly take into account the multiple default member accesses.
Without default member access, the call would look like this. ```vba ActiveDocument.CustomDocumentProperties.Item("SomeProperty").Value = "SomeString" ```
"So sorry, already sent an email asking if the letter has been received. I can retract if someone tells me how." This is what happens when you let doctors manage things. :/
@MathieuGuindon ah, gotcha! No, I don't believe I'm getting any false positives on arrays or variants. though... I added an '@Ignore on one yesterday for a built in Excel property that takes a variant - let me see if I can find it. I don't believe there was any default involved
Private Sub foo()
Range("a1").Interior.ThemeColor = xlThemeColorLight2
End Sub
Private Sub bar()
With Range("a1").Interior
.ThemeColor = xlThemeColorLight2
End With
End Sub
However this does:
Public Sub BlankCol(ByVal theRange As Range, ByVal Color As String)
Dim Theme As Long
Theme = xlThemeColorLight2
With theRange.Interior
.PatternColorIndex = xlAutomatic
.ThemeColor = Theme
.TintAndShade = Tint
.PatternTintAndShade = 0
End With
End Sub
like... holy crap the web is one fugly hack on top of a hack on top of a hack [...] on top of something a physicist slapped together to allow interlinking docs
@this, @MathieuGuindon - here's the end of the RD log post-crash, pre-restart:
2018-11-30 08:29:34.4609;ERROR-2.3.0.4235;Rubberduck._Extension;System.Exception: RemoveWindowSubclass Failed
at Rubberduck.VBEditor.WindowsApi.SubclassingWindow.ReleaseHandle() in C:\projects\rubberduck\Rubberduck.VBEEditor\WindowsApi\SubclassingWindow.cs:line 73
at Rubberduck.VBEditor.WindowsApi.SubclassingWindow.Dispose(Boolean disposing) in C:\projects\rubberduck\Rubberduck.VBEEditor\WindowsApi\SubclassingWindow.cs:line 125
at Rubberduck.VBEditor.WindowsApi.FocusSource.Dispose(Boolean disposing) in C:\projects\rubberduck\Rubberduck.VBEEditor\WindowsApi\FocusSource.cs:line 45
@Vogel612 he's got a very valid point! Chris wandered off after he no longer had an interest in VBA. Everyone else here will eventually burn out, lose interest, have health issues :tear:, or otherwise. RD isn't mission critical, but...
> Over the last several weeks, I've had an increasing frequency of Excel crashing on exit. I'm running Win10, Excel 2016 (desktop) and have had several incremental builds installed. Currently, I'm on .4235, and was shutting down to install .4244 to test another fix.
Here's the complete log after one such event. [RubberduckLog.txt](https://github.com/rubberduck-vba/Rubberduck/files/2633368/RubberduckLog.txt)
Then I get facebook notifs about how inspiring we all are and how we're making the world a better place, and damn, all the RD bugs don't feel so overwhelming any more
@MathieuGuindon yeah, well, eventually it will happen. Or your wife will get tired of you not coming to bed, or your kids will get involved in things that take more of your time, or, you know, something else will become a higher priority. We'll all understand, nobody will blame you, but... you'll be gone some day.
OK, off that rant. Time to shut down Excel again (reopened to confirm my latest changes were saved) then test out .4244 to see if it fixes the false Missing Set issues.
If you've ever gone on a road trip, you probably have made pit stops, right? Noticed how establishments that offers free bathrooms are usually clean and well-maintained? In contrast, if you dare to stop at those dinky former-service-garage-now-gas-station where they hand you a key to the bathroom chained to a large brick or a toilet seat, the bathrooms are horrid and gross.
Wait, wasn't the key supposed to keep the riff-raff out?!?
Still it's a bit illogical - they lock up the bathroom because it's around the back yet it somehow manage to be in a state of filth and abuse that it's good stand-in for a haunted house.
> This "real world" (yet minimized) example produces a false positive in build .4244:
```VBA Public Sub BlankCol(ByVal theRange As Range, ByVal Color As String) Dim Theme As Long Theme = xlThemeColorLight2 With theRange.Interior '@Ignore ObjectVariableNotSet .ThemeColor = Theme End With End Sub ```
as is evidenced by the `'@Ignore ObjectVariableNotSet` annotation I had RD install for me.
**HOWEVER** these two MC(n)VEs do NOT generate an inspection result:
With the establishments that offers you clean free bathrooms, they explicitly do it as a part of business -- you might not be paid to use it but you almost certainly will buy other stuff from them and that justifies the operating costs.
@BZngr and given the choice , it's better to have a stale FOSS that you can fix yourself over a stale POS software that you have no chance of fixing yourself.
@BZngr Bingo. If the author wants to whinge about his free stuff not working, the solution is to either contribute yourself or use other tools that suit your needs. The attitude that "my free lunch wasn't very tasty" doesn't get much traction here.
> Unlike Apollo astronauts, who never experienced lunar sunrise, the next explorers are going to establish a permanent outpost. They'll be there in the morning when the storm sweeps by.
eh, they could whip up an Apollo 18 mission pretty quick. HHCIB?
Yay! only 141 meaningful names to go!!
duh check: If I pass an object to a method ByRef I'm passing in the actual pointer the calling method is holding, thus all changes made in the called proc effect the caller's object. If I pass the object ByVal, I'm passing a copy of the pointer, but it's pointing to the exact same object in memory, so the called proc is still impacting the caller's object. Right?
@FreeMan the only thing it changes is whether the parameter can be Set locally. If it's byref, method can set it to nothing and caller loses the object. ByVal/ByRef have no bearing on whether the object's state is "carried"
> To fix the false-positive above we will require a expression type evaluation engine. The problem is that the LHS is Variant and we do not properly evaluate the RHS.
Generally, I would prefer to error on the conservative side and do not generate an inspection result, if we cannot determine properly whether the assignment requires a `Set`.
@MathieuGuindon My guess is that having ByRef be the default was simply laziness - IIR in COM the caller is responsible for managing the memory of a Variant passed to another procedure. Passing everything ByRef simplifies the memory management tremendously.
So, ByRef allows the called proc to destroy the actual object, while ByVal doesn't, therefore ByRef is "safer". Otherwise, the main difference is that if I pass ByRef that's a hint to future users to expect something in the object to change vs ByVal is a hint that nothing should be changing. Baring that, flip a coin as to which I want to use. In VBA, of course.
@Duga @M.Doerner I'm not sure I understand the comment "I would expect it to work for all call statements and all non-traditional index expressions." Is the problem that it's working from the CallStmtContext?
VBA Rubberducking
VBA Rubberducking