unless it's strictly a presentation concern. the code-behind belongs to the view, it's reserved for purely presentation stuff (e.g. if you want a button to glow on hover)
@IvenBach I want the IQueryable to be executed on the database, or whatever LINQ provider it is targeting, and do whatever follows in-memory, i.e. via LINQ-to-objects.
@Mat'sMug Well, it's both... If it's a project or not, it's got to show different text when displayed to the user, but also use a different command when the menuitem is chosen
@shadowofsilicon it's one possible implementation of the ICommand interface. A rather cool one, that makes it easy to delegate the CanExecute and Execute methods to private members of the VM, or even inline a trivial implementation
The injected commands inherit CommandBase, which implement Can/Execute in a separate class; the trivial ones are DelegateCommand instances, with take a (wait for it..) delegate (who knew!) for the Can/Execute implementations
So you can have a new DelegateCommand(o => DoSomething(o)) and implement the meat in DoSomething
@shadowofsilicon of course it is. very little is impossible with WPF. You want a transparent, ducky-shaped window? You can! (in an actual WPF app at least)
@Mat'sMug Actually, I tried to do that there (admittedly, I didn't try very hard). It isn't particularly simple to hide a context menu item the way we are doing it for some reason or another.
I think it is related to the way it isn't in the actual layout tree, or whatever it is called.
@Hosch250 I'd take the file/folder browser dependency out of the command (and into the VM), give it a string/path parameter, inject that into the VM, and make a delegate command that takes the selected node as a parameter and thus knows if we're looking at a project or a module (exporting a [bunch of] procedure node[s] into a .cls or .bas file would be awesome too)
@ThunderFrame how about "implicit conversion from literal before assignment"?
@Mat'sMug Well, actually, the pretty-printer converts 1.12345@ to 1.1234@ - It should almost be mandatory to use a type hint in an literal assignment - YUK!
I guess there wouldn't have to be a menu item for it in the Rubberduck menu, but IMHO there really should be, at least for Export All... I don't believe that functionality should be exclusive to the Code Explorer
Damnit, CodeExplorerWindow.cs! Y U BROKEN? What did I do to you?
ExportCommand is inside the Code Explorer class... it recieves a CodeExplorerComponentViewModel and tells the VBE to export that component (actually, we overload the VBE's method)
The ExportAll command that I wrote currently takes a IVBProject and does the same thing with all of the components in the IVBProject...
However, that will prob be changed to CodeExplorerProjectViewModel
Or, if activated via the Rubberduck menu, it receives nothing... then it uses the active project
100 'line-number 200: 'line-number with instruction spearator 300 Beep 'Line-number and instruction 400: Beep 'Line-number with instruction separator and instruction
bar: 'line-label buzz: Beep 'Line-label and instruction 50 fizz: 'line-number and line-label 10 foo: Beep 'Line number and line-label (that matches procedure name) and instruction 20 boo: Beep 'Line number and line-label and instru
> It doesn't matter whether the line-number is 1 digit or 7 digits, all of the numbered lines below trigger the inspection:
```vb Sub foo()
1 'line-number 20: 'line-number with instruction separator 300 Beep 'Line-number and instruction 4000: Beep 'Line-number with instruction separator and instruction
bar: 'line-label buzz: Beep 'Line-label and instruction 50000 fizz: 'line-number and line-label 600000 foo:
> They all end with... a numeric value (:facepalm:), that's why. Fix is simple: the inspection needs to ignore any declaration whose Context is a LineNumberLabelContext.
sorry, I think I may have distracted you - although, sometimes it is interesting to see what people do think is 'worthy'; this was a proposed solution chuckels
Resolves optional parameter default value expression, fixes ImplicitVariant quick-fix for constants, and UnusedLabel now properly ignores line numbers and yields expected results.
@IvenBach Already planning to have them review WiseOwl tutorials :). Not all of them of course (there are some videos that I have never needed the content of) but they are a good beginner series on VBA.
^ With that you have to keep in mind that For Each only works with Enumerable types, so you cant use For Each on a Dictionary for example. You may have a hard time teaching a user that distinction through an inspection (and it generally is a micro-improvement if I am not mistaken).
@SlowLearner Certainly go for it. I would be interested to see the effects, especially since I use a lot of dictionaries that arent enumerable and it may be worth converting to COllections or using Thunderframe's enumerable class.
@BrandonBarney I would love some kind of abstraction-level-benchmarking. Where it starts at the top and then lets you expand each statement/subroutine/loop etc. to see where all the time got spent.
@SlowLearner No, pretty much just timing code, but timing individual functions, subroutines, loops, etc.
@SlowLearner You may want to wander through the star list for this. I believe @Mat'sMug and/or @ThunderFrame (go figure) were doing some benchmarking on someone's question about this. They found some generalish cutoff points on where things were faster one way or the other (including copying cells to an array vs working in the worksheet, if I recall), but the real answer is #ItDepends
The real answer is "Build it. Make sure it works. If it's taking too long, time bits of your code to find out where 90% of the time's being spent, and then re-architect that bit a little"
Also: Arrays, Dictionaries, and avoid directly manipulating worksheets/books
I spent a few months manually looping i, then y to find one record, get a couple values, and then onto the next one. Enter dictionaries. Life changing.
I did have one where I would sort both tables before loading the array, and I would then try to save the LastFoundRecord position, and do some other stuff. It did certainly cut down on time, but it was still a painfully slow loop.
In C#, are ' and " interchangeable? Or do they have special meaning for defining strings?
Also, can I use LINQ on an object[,] or must I convert the object[,] to some form of a class? I am hoping to filter using the headers defined in the first row.
@SlowLearner You just never know who supports what party. I definitely dont care for Trump, but I also dont want to be stepping on anyone's toes who might support him.
@SlowLearner Just above the list of stars to the right ---> is a link for show all 8047 (note: number subject to change very quickly round these parts!)
@SlowLearner I get annoyed at everyone on "my side" for treating Trump like some incompetent imbecile. I'm like "NO! Do you not get it. This guy went up against the combined political establishment of one of the most powerful countries in the entire world and beat them all anyway. Don't f****** underestimate him."
Yeah, it was a few days ago, too, and I think it was a link to an SO question that had a good discussion on it, so it won't be super obvious. Sorry... Maybe Mug or Thunder will pop in with a better memory than mine & make your life easier.
@SlowLearner I was more thrown by line numbers. Who uses those anymore? It's not like you have to sort your punch cards if you drop 'em...
@Kaz They are only really used for error reporting. I have a fogbuz account and it tells me when the code crashes and what line number... pretty handy, quick to fix. I am working on massive refactor... and yes this involves much danger....
@FreeMan erm that was for you ^^^
@Kaz... what I meant to say... was how much did you win... I mean.... were you a true believer?
Did even better out of the UK election. 6 weeks out, they were offering 100:1 odds of Boris Johnson being PM by the end of election month. Sold that bet the morning after the election at 5:1.
@SlowLearner Reading through ELU, there's not a single term I've ever heard in the UK that would be a good match.
But yes, this is very much the point. I don't want to go around pontificating on what I think will happen all the time, but I do want some way to prove that I saw it coming.
@Kaz Monday's expert refers to the outcome of the various bouts on the sports fields etc. that are played on the weekend and are invariably discussed in mind numbing detail until the following Friday.
@Kaz Agreed. I may not like the guy, but I have always said that he knows how to reach the kind of people who like him. His rhetoric may piss me off, but there is a group of people out there who are thinking exactly the same thing.
Unfortunately, my parents are part of that group of people.
@SlowLearner It can make family time a little uncomfortable, but they have mostly learned to just keep quiet on politics. They've improved a bit as well which is good. The world (and religion) they grew up with though dictated their worldview, and it is very difficult to change someone's perception when they've been seeing in the same "shade" of the world for the last 30 years.
(Not saying my parents are 30. They definitely arent lol.)
@Mat'sMug I think I figured it out, but basically I have an object[,] and each value in that array is an object with an underlying type. I am working on converting the array into a data table (so I can use LINQ on it) but in order to do that I need to set the types of the property columns, as well as of the individual values.
I ended up doing this Convert.ChangeType(Data[1,1], Data[1,1].GetType()) to convert it to it's underlying type, now I am working on the data table.
Also, there's a very good chance that there is an easier way to get from point A to point B. I am just piecing things together slowly. I can improve the code as I learn.
@Hosch250 Yeah. If I dont bring it up, they dont bring it up. It makes things much easier. I occasionally post on FB, but for the most part I just sit and listen.
@puzzlepiece87 I need For each Foo in Dict.Keys which can't be done (unless I am mistaken).
@Mat'sMug that is something I don't understand.... sometimes I feel the need too see what is in a dictionary other times I want to know what something is... defeats? Me thinks augments? Or am I missing something?
@Mat'sMug @SlowLearner is right. It only defeats the purpose of a dictionary if you already know what's in the dictionary. If you don't, being able to loop the keys is a big help.
@puzzlepiece87 Assume something like Dict.Add sID, Student (using HN to help illustrate). Do that a few times and then try For each sVar in Dict.Keys. You'll get an error.
+1 to Mat's Mug as well. You can return an array of Keys() or Items(). It isnt a Collection.
And yeah, it does somewhat undo the point of a dict (if you're looping through all of them), but frankly it is one of those bad habits where I just like to have all of my Collections as Dicts unless a Collection is necessary :).
@Mat'sMug This interests me, it sounds a bit nicer. Are you saying you can do For lngIndex = Lbound(dictName.Keys) to Ubound(dictName.Keys)?
@SlowLearner Since Hungarian notation isn't a good practice, they're both equally wrong lol.
@SlowLearner I don't use s or other one letter Hungarian because it would be wrongly confused with apps Hungarian that people should use, where s stands for safe.
@SlowLearner For my purposes Dict's just make sense. It is much easier for me to say If Not Dict.Exists(Key) Then Dict.Add Key, Student than to figure out how to use the filter in such a way that can do what already is done very quickly.
@BrandonBarney @SlowLearner @Mat'sMug You can't use .Exists() in a collection, right? So that's why I would still use a dictionary instead of a collection. And then again, I'm looping through the keys because sometimes I don't know what's in the dictionary.
@FreeMan @SlowLearner This is what I am referring to, and tl;dr - a variable that is safe is one that has been confirmed to be of the type you think it is, to prevent stuff like SQL injection.
Function FixesActiveCount() As Long
FixesActiveCount = 0
Dim varKey As Variant
For Each varKey In dictCorrectionOptions.Keys()
Dim lngCorrectionTypeRow As Long
lngCorrectionTypeRow = CorrectionTypeOptions.Columns(1).Find(what:=varKey).Row
If CorrectionTypeOptions.Shapes("ToggleBackground" & lngCorrectionTypeRow - 1).TextFrame.Characters.Text = "On" Then
dictCorrectionOptions(varKey).boolActive = True
Else
dictCorrectionOptions(varKey).boolActive = False
@puzzlepiece87 You could reverse the logic of that to go through all your CorrectionTypeOptions.Shapes and set the appropriate dictionary entries as appropriate. Not necessarily better, but an option.
@FreeMan For the sake of saying why it would need to be that way only, though it doesn't apply to that particular example from my code, that reversal would only work if all the shapes had a corresponding dictionary item.
@FreeMan But you are definitely right for that example :) I have others where it's more ambiguous.
@BrandonBarney mwell, there's 2 badges awarded for answering old posts. besides the other answers all involved brittle, painful solutions. the shapes one is particularly terrible IMO.
@puzzlepiece87 You could also do For i = 1 to Dict.Count since the Array is always 1-Based. You just have to check to ensure there is a key existing in the dict before iterating.
@SlowLearner Depends on your needs and the conventions in your office, but yeah. You're welcome. Keep that site bookmarked - you'll refer others to it, too.
Use Option Explicit, and above all avoid using l and 1 as identifier suffixes. FWIW Rubberduck would have warned you about loopl not being declared and loop1 never being used. — Mat's Mug1 min ago
@Hosch250 @Mat'sMug How much experience with C# do you think is necessary to get the most out of Dependency Injection in .NET? I'm not grasping the ideas and wanted a ballpark knowledge level to know when to go back and try it again.
> In addition to variable/enum name collisions, the VBE allows a name conflict to be created (and saved) between an Enum type name and a ClassModule name. The good news is that the Enum/Class name conflict is identified by the VBE when closing the editor/Excel. That said, the user can still click 'OK' when closing the editor, and the conflict is allowed to persist.
I'm looking for some input on this issue. I have code that adds the inspection to detect an existing name conflict between an
at AnalystTools.DataContainer.GetColTypes(Object[,] InputData) in C:\Users\b.barney1\Desktop\Macro Workbook\VB Net Testing\AnalystTools\AnalystTools\AnalystToolsRibbon.cs:line 87
at AnalystTools.DataContainer..ctor(Object[,] InputData) in C:\Users\b.barney1\Desktop\Macro Workbook\VB Net Testing\AnalystTools\AnalystTools\AnalystToolsRibbon.cs:line 57
at AnalystTools.AnalystToolsRibbon.TableFilter_Click(Object sender, RibbonControlEventArgs e) in C:\Users\b.barney1\Desktop\Macro Workbook\VB Net Testing\AnalystTools\AnalystTools\AnalystToolsRibbon.cs:line 45
VBA Rubberducking
VBA Rubberducking