VBA Rubberducking

Duga

18:01

[EBrown8534/RubberduckWeb] EBrown8534 pushed commit 251163cb to master: Updated all the "Features" pages to look a little more uniform.

[EBrown8534/RubberduckWeb] EBrown8534 pushed commit 4de6cc53 to master: Blog Feed posts look a little cleaner.

Duga

18:14

[rubberduck-vba/RubberduckWeb] ckuhn203 opened issue #18: Disable Project & Module naming inspections

> The web inspections is triggering a few informational inspections that should probably be disabled for web, because we're the ones providing the VBProject and Module. I've not looked at the web implementation, but I'm assuming it's a matter of configuration.

![image](https://cloud.githubusercontent.com/assets/2716800/21110779/a3141bfe-c06c-11e6-923e-e09a50340ac5.png)

[EBrown8534/RubberduckWeb] EBrown8534 pushed commit 36652b8e to master: Cleaned up "Inspections" and the results from it substantially, made it slightly more user friendly.

[rubberduck-vba/RubberduckWeb] retailcoder commented on issue #18: Disable Project & Module naming inspections

> We'd have to cherry-pick inspection results' Target.DeclarationType and filter out DeclarationType.Project and DeclarationType.ProceduralModule to get these ones out of the way without outright disabling that inspection.

[rubberduck-vba/RubberduckWeb] EBrown8534 created pull request #19: Standardized some of the pages to merge EBrown8534/RubberduckWeb/master into rubberduck-vba/RubberduckWeb/master

> I'm just getting started, but this at least standardizes some of the pages to be a little more uniform and less ugly.

EBrown

@Duga @Mat'sMug You want to assign me to some of the issues on RDWeb?

Mat's Mug

I think you can assign yourself to whichever you feel like implementing

EBrown

Alright, I'll grab one or two of them here quick.

Duga

[rubberduck-vba/RubberduckWeb] ckuhn203 commented on issue #18: Disable Project & Module naming inspections

> Ahh. Not as simple as I thought. Cloning now.

[rubberduck-vba/RubberduckWeb] EBrown8534 commented on issue #6: Install wordpress to new subdomain blog.rubberduckvba.com

> Do we want to self-author this in the current website (/Blog) or use a separate piece of software for it?

[rubberduck-vba/RubberduckWeb] EBrown8534 assigned EBrown8534 to issue #7: Permanently redirect .html pages to mvc controllers

[rubberduck-vba/RubberduckWeb] retailcoder commented on issue #7: Permanently redirect .html pages to mvc controllers

> FWIW I'm not going to be renewing the original rubberduck-vba.com domain when it expires in February.

[rubberduck-vba/RubberduckWeb] EBrown8534 commented on issue #18: Disable Project & Module naming inspections

> The results are currently of type ICodeInspectionResult, how trivial would it be to get the Target.DeclarationType from that?

EBrown

@Mat'sMug Is it trivial to build previous versions of RubberDuck?

Mat's Mug

18:25

I guess.... but why would you want to do that?

EBrown

2.0 is beta right now, correct?

Mat's Mug

yep

EBrown

So why don't we add a dropdown to Inspections for 1.x (Stable) and 2.x (Beta)?

Mat's Mug

because the 1.x parser will choke on half the code you give it

EBrown

Why? What's different between them?

Mat's Mug

18:26

uhm, a full rewrite?

EBrown

Ah, alright then.

Also, how can we get that Target.DeclarationType from ICodeInspectionResult?

(I know nothing of Rubberduck to be fair.)

Mat's Mug

gah, you got me there.. the Target is a member of the base abstract class, InspectionResultBase. that's rather annoying.

all results can be safely cast to the base type though

IInspection specifies it:

IEnumerable<InspectionResultBase> GetInspectionResults();

basically ICodeInspectionResult is probably redundant

EBrown

It's a piece of cake then.

Also, added another PR. Not sure if you want to merge it or not.

@Mat'sMug Target is null for inspections.

Mat's Mug

all of 'em?

Hosch250

What do you need the target for?

EBrown

18:35

Checking that now.

Aha, not all of them.

Mat's Mug

depends on the inspection type - some results are instantiated with a ParserRuleContext, others with a Declaration (the Target)

EBrown

Think I have the fix for that.

Whoop whoop. Fixed. :)

Also added a "No issues were found" if no inspection results are identified.

Mat's Mug

huh, pretty that was there already. IIRC it even said "congratulations, Rubberduck couldn't find any issues in your code"

or something like that

EBrown

Not in the website.

Mat's Mug

I think I like "no issues were found" better though

EBrown

18:40

Boom, committing and closing.

You want to merge that other PR I have or should I?

Mat's Mug

taking a look

Duga

[rubberduck-vba/RubberduckWeb] ckuhn203 commented on issue #18: Disable Project & Module naming inspections

> Dirty hack incoming @EBrown8534, just a sec.

Mat's Mug

@Duga interesting

Duga

[rubberduck-vba/RubberduckWeb] EBrown8534 commented on issue #18: Disable Project & Module naming inspections

> @ckuhn203 Alright, but I just fixed it, committing to my fork then adding PR...;)

EBrown

Lmao Apparently he and I are going to be competing to fix this stuff. Lol

Duga

18:42

[rubberduck-vba/RubberduckWeb] retailcoder merged pull request #19: Standardized some of the pages from EBrown8534/RubberduckWeb/master into rubberduck-vba/RubberduckWeb/master

[rubberduck-vba/RubberduckWeb] EBrown8534 pushed commit 6cca6ffe to master: Standardized copyright with general web style.

[rubberduck-vba/RubberduckWeb] EBrown8534 pushed commit 251163cb to master: Updated all the "Features" pages to look a little more uniform.

[rubberduck-vba/RubberduckWeb] EBrown8534 pushed commit 4de6cc53 to master: Blog Feed posts look a little cleaner.

[rubberduck-vba/RubberduckWeb] EBrown8534 pushed commit 36652b8e to master: Cleaned up "Inspections" and the results from it substantially, made it slightly more user friendly.

[rubberduck-vba/RubberduckWeb] web-flow pushed commit 0eb70993 to master

EBrown

@Duga I commit a lot...lol

Duga

Merge pull request #19 from EBrown8534/master

Standardized some of the pages

[rubberduck-vba/RubberduckWeb] ckuhn203 forked us into ckuhn203/RubberduckWeb

EBrown

@Mat'sMug One of the inspections has a capitalization issue:

> variable 'foo' is not used

But all the other issues are:

Duga

[rubberduck-vba/RubberduckWeb] ckuhn203 created pull request #20: Strip out Module & Project naming suggestions Fixes #18 to merge ckuhn203/RubberduckWeb/master into rubberduck-vba/RubberduckWeb/master

> We provide the project & module, so it's a bit confusing for a user to get inspection results for bad names outside of their control. It's kind of a dirty hack to use the names, but works well enough.

EBrown

> Variable 'foo' is used but not assigned

Mat's Mug

18:46

hmm probably because the word "variable" is itself taken from a ressource and the string is reused for "procedure 'DoSomething' is not used"

Duga

[rubberduck-vba/RubberduckWeb] ckuhn203 commented on issue #18: Disable Project & Module naming inspections

> Oops. Just submitted #20 @EBrown8534...

Mat's Mug

it's a tought problem: we can't capitalize "variable" in the resources because it's often used in the middle of a sentence, and we can't capitalize the first character of the inspection result description because we don't know what language it is and whether a capital first letter even means anything

EBrown

Why does it show for the other inspection as capitalized though?

Mat's Mug

probably because "Variable" is part of that inspection's resource string. a procedure isn't "used but not assigned" ;-)

Duga

[rubberduck-vba/RubberduckWeb] retailcoder commented on issue #18: Disable Project & Module naming inspections

> ...let's see which dirty hack is the cleanest :racehorse:

[rubberduck-vba/RubberduckWeb] EBrown8534 commented on issue #18: Disable Project & Module naming inspections

> @ckuhn203 It's all good, if you don't mind merge the PR you made and I'll move that code to the view to line up better with MVC's style, I also fixed another issue in my fix (which I haven't PR'd yet) which is "No issues were found" should display when no inspection results are returned.

Likewise, are we sure we don't want to use the method @retailcoder suggested? It's quite trivial:

var results = Model.Where(o => ((InspectionResultBase)o).Target != null && ((InspectionResult

[rubberduck-vba/RubberduckWeb] EBrown8534 commented on issue #18: Disable Project & Module naming inspections

> @ckuhn203 It's all good, if you don't mind merge the PR you made and I'll move that code to the view to line up better with MVC's style, I also fixed another issue in my fix (which I haven't PR'd yet) which is "No issues were found" should display when no inspection results are returned.

Likewise, are we sure we don't want to use the method @retailcoder suggested? It's quite trivial:

var results = Model.Where(o => ((InspectionResultBase)o).Target != null && ((InspectionResult

EBrown

18:52

Aha, @Duga has a bug.

Duga

[rubberduck-vba/RubberduckWeb] retailcoder commented on issue #18: Disable Project & Module naming inspections

> @EBrown8534 that might remove inspection results where Target is null though; I like @ckuhn203's solution, which hardwires the actual inspection type. After all, we are looking at one specific inspection.

[rubberduck-vba/RubberduckWeb] retailcoder merged pull request #20: Strip out Module & Project naming suggestions Fixes #18 from ckuhn203/RubberduckWeb/master into rubberduck-vba/RubberduckWeb/master

Mat's Mug

merged

Duga

[rubberduck-vba/RubberduckWeb] retailcoder closed issue #18: Disable Project & Module naming inspections

[rubberduck-vba/RubberduckWeb] Unrecognized author pushed commit e072c053 to master

2

Strip out Module & Project naming suggestions

We provide the project & module, so it's a bit confusing for a user to get inspection results for bad names outside of their control. It's kind of a dirty hack to use the names, but works well enough.

[rubberduck-vba/RubberduckWeb] web-flow pushed commit 071ae69f to master

Merge pull request #20 from ckuhn203/master

Strip out Module & Project naming suggestions Fixes #18

EBrown

@Mat'sMug I'll update my version to use his solution and then fix the "No issues were found" thing.

Mat's Mug

@Duga lol, it's been too long has it?

3

@EBrown perfect!

EBrown

18:55

@Mat'sMug How do I update my GitHub fork to pull the stuff you merged?

Mat's Mug

PR from RubberduckWeb to your fork

hi @RubberDuck!

RubberDuck

Hi!

EBrown

@RubberDuck I'm going to slightly alter your solution, but I won't take your fix away. :)

RubberDuck

No worries mate. Just figured I'd fix it since I raised it.

If you've got a better way, I'm all about it.

EBrown

My method wasn't better, other than where we were going to put it, but even that's arguable.

I'm going to just add a quick feature, so that if no inspections are found it will display "No issues were found"

2

RubberDuck

18:58

My first thought was to change the vbe builder to make it not trigger to begin with, but then I realized it was in a dependency and the method wasn't virtual and...

I'm at work, so quick hack it was.

EBrown

Yeah, I think you saw my solution, no?

Duga

[EBrown8534/RubberduckWeb] EBrown8534 created pull request #1: Merge from RDWeb Base to merge rubberduck-vba/RubberduckWeb/master into EBrown8534/RubberduckWeb/master

> Merge RDWeb commits to local fork

[EBrown8534/RubberduckWeb] EBrown8534 merged pull request #1: Merge from RDWeb Base from rubberduck-vba/RubberduckWeb/master into EBrown8534/RubberduckWeb/master

[EBrown8534/RubberduckWeb] web-flow pushed commit 0f0e824f to master

Mat's Mug

@RubberDuck it's ok, I'll add a note about it in the builder, so we don't change the project/module names

RubberDuck

@EBrown no, link?

Duga

Merge pull request #17 from EBrown8534/master

Fixed all the packages

[EBrown8534/RubberduckWeb] web-flow pushed commit 0eb70993 to master

Merge pull request #19 from EBrown8534/master

Standardized some of the pages

[EBrown8534/RubberduckWeb] Unrecognized author pushed commit e072c053 to master

EBrown

18:59

@RubberDuck It's in the issue @Mat'sMug closed.

Duga

Strip out Module & Project naming suggestions

We provide the project & module, so it's a bit confusing for a user to get inspection results for bad names outside of their control. It's kind of a dirty hack to use the names, but works well enough.

[EBrown8534/RubberduckWeb] web-flow pushed commit 071ae69f to master

Merge pull request #20 from ckuhn203/master

Strip out Module & Project naming suggestions Fixes #18

[EBrown8534/RubberduckWeb] web-flow pushed commit e47db869 to master

Merge pull request #1 from rubberduck-vba/master

Merge from RDWeb Base

Mat's Mug

@EBrown eh, it closed itself!

EBrown

@Mat'sMug Mhmm. ;)

Mat's Mug

"Fixes #18" in the commit message did it

EBrown

Ah

Mat's Mug

19:01

GitHub is magic :)

4

EBrown

Yeah and now I can't do a pull...lol

RubberDuck

@Mat'sMug lol. I think it picked up my work email... oops.

Comintern

Re inspection capitalization, resource strings, and internationalization, I use something like this all the time:

public static string Captialize(this string input)
{
    var tokens = input.Split(new[] {' '}, StringSplitOptions.RemoveEmptyEntries);
    if (tokens.Length == 0)
    {
        return input;
    }
    tokens[0] = CultureInfo.CurrentCulture.TextInfo.ToTitleCase(tokens[0]);
    return string.Join(" ", tokens);
}

EBrown

"See the output window for details" there are no details.

THERE ARE NOT UNCOMMITTED CHANGES

Mat's Mug

@Comintern huh, we want that

EBrown

19:06

Good thing I wasn't actually working on anything, just gonna delete that whole project from this PC.

Duga

[rubberduck-vba/RubberduckWeb] comintern commented on issue #18: Disable Project & Module naming inspections

> Are the inspections running with the default settings? Wouldn't it be easier to just set the severity to "Ignore"?

[rubberduck-vba/RubberduckWeb] retailcoder commented on issue #18: Disable Project & Module naming inspections

> @comintern they are. But that would disable the inspection altogether, not just filter out the specific results about the test module / test method names.

EBrown

@Mat'sMug I see how the original "No Inspection Results Found" thing worked, @RubberDuck fixed it with his hack, no need for me to do anything there. ;)

Duga

[rubberduck-vba/RubberduckWeb] ckuhn203 commented on issue #18: Disable Project & Module naming inspections

> @comintern that would disable all of the UseMeaningfulName inspections, so we would miss bad variable names.

EBrown

Ehh yes there is, so ugly.

RubberDuck

@EBrown I didn't even mean to. lol

EBrown

19:10

@RubberDuck Totally accidental on your part. Lol

@RubberDuck @Mat'sMug @Hosch250 If you all don't mind, I'm going to change how errors are display on Inspections as well. (If you enter invalid code, etc.)

Hosch250

@EBrown Sure.

Mat's Mug

whatever works and looks pretty :)

Duga

[EBrown8534/RubberduckWeb] EBrown8534 pushed commit da765287 to master: Replaced how we display the fact that no issues were found in inspections with a more clean solution. (Follows the design more tightly, and eliminates a view.)

EBrown

@Mat'sMug That's the kicker: "looks pretty." ;)

RubberDuck

@EBrown that's the best kind of bug fix IMO.

EBrown

19:28

@RubberDuck Feel free to read the messages I posted above about altering the MVC structure and adjusting the design a bit and let me know what you think of any/all of them. It's your project too.

Comintern

19:51

Should indenting trigger a reparse? The token locations in the parse tree are wrong for lines that get indented.

Vogel612

then yes :)

ThunderFrame

maybe it could do a reparse only, without needing to resolve?

RubberDuck

@EBrown IMO the controller should be doing the filtering & ordering, not the view. At least, unless you're allowing the client to filter & sort with some js.

Also, it's so not my project anymore.

Comintern

Oh, yeah. It busts all the quick-fixes if you already have inspection results.

RubberDuck

That's my first commit in a year...

Vogel612

19:55

@RubberDuck this forces you to have a beefy-ish server though.

and if we go for "getting inspection results as some kind of JSON", we might as well filter on client-side

RubberDuck

@Vogel612 the server's doing the work anyway, its in the razor.

But yeah, you're right.

ThunderFrame

erghh, dat naming

0

Q: VBA Code optimizing

I have the below code, but is very slow. Is there a way to improve it? I'm a beginner with VBA and would appreciate your help. What it does is it goes through a table and looks up in each worksheet for criteria to match and give values accordingly. Criteria differ by line in the initial range: S...

Comintern

@ThunderFrame - That was a good test for bracketed identifiers inside string literals. Cells(CEllrow, TC + 5) = "=[@[Actual Rebate $ for Line]]-[@[Committed - Rebate]]". :shudders:

Mat's Mug

Argh! You have GoTo statements within your If statements which lead into other legs of the If statement! — YowE3K 14 mins ago

lol

Comintern

20:11

The fun one is GoTo Filler: in the ElseIf leg that leads to the If leg. Ummm... can I lend you an Or keyword?

ThunderFrame

@Comintern string literal content shouldn't have any impact.

Comintern

It was a problem in the indenter - the fix for chat.stackexchange.com/transcript/message/33933348#33933348 was to escape bracketed expressions and string literals at the same time.

Duga

21:22

[rubberduck-vba/RubberduckWeb] ckuhn203 commented on issue #6: Install wordpress to new subdomain blog.rubberduckvba.com

> It was a long time ago, but was thinking of just migrating the wordpress.com blog to a self hosted Wordpress site at blog.rubberduckvba.com. Honestly, probably not ever going to be a big deal.

Mat's Mug

21:41

Rubberduck's indenter basically is Smart Indenter for VBA - it's just a C# port of the original VB6 codebase (with additional bug fixes and 64bit support). — Comintern 10 mins ago

"just a C# port" ...and a massive refactor/despaghettification

Duga

[rubberduck-vba/RubberduckWeb] retailcoder added label wontfix to issue #6: Install wordpress to new subdomain blog.rubberduckvba.com

[rubberduck-vba/RubberduckWeb] retailcoder closed issue #6: Install wordpress to new subdomain blog.rubberduckvba.com

Comintern

@Mat'sMug Didn't say how the additional bugs got fixed... :-)

Mat's Mug

:)

Mat's Mug

22:07

@Comintern perhaps we should have an "indent your code here" box on the indenter page?

Comintern

That shouldn't be difficult - It'd basically be like the sample code in the settings window.

I should really get VS2015 installed at home.

ThunderFrame

22:24

WTF?

?[Concatenate("","]")]
Error 2015)]

Comintern

That error is so last year.

2

ThunderFrame

how the hell does it include ")]" in the result?

Comintern

That's a damn good question. It almost looks like whatever is throwing is crashing a buffer somewhere.

ThunderFrame

last year was an overflow?

Comintern

?[Concatenate("","]")] This can be pretty much anything...
Error 2015)] This can be pretty much anything...

Got it. It's Debug.Print just appending anything after a single ":

?" Foo
 Foo
?[[Concatenate("","]")]
Error 2015
?[Concatenate("","]
Error 2015
?[Concatenate("","]        "This gets appended.
Error 2015This gets appended.

ThunderFrame

22:44

huh, in a procedure block it gets converted

Debug.Print [Concatenate("","]; ")]"

I'm betting the parser/indenter can't handle that?

Comintern

Unsure. The VBA parser can't handle it, so I can't really check:

If [Concatenate("","]")] <> vbnullstring Then '<--Expected Then or Goto

ThunderFrame

Debug.Print [Concatenate("","]; " : Beep : 'Not a comment)]" 'Is a " comment

Comintern

This is a parse error, but VBA handles it fine:

Sub foo()
If True Then
Debug.Print [Concatenate("","]; ")]"
End If
End Sub

Sub foo()
    If True Then
        Debug.Print [Concatenate("","]; ")]"
    End If
End Sub

Indents fine though.

@ThunderFrame I get a resolver error on that one.

ThunderFrame

@comintern - yep, I suspect it thinks the comment starts at the first '

Hosch250

Probably.

ThunderFrame

23:09

And... Out of Memory in VBE

blames square brackets

and BOOM

Duga

23:36

[rubberduck-vba/Rubberduck] MDoerner commented on issue #2414: Get SpecialFormsDeclarations out of DebugDeclarations

> I think I can do this tomorrow. There are only two places where the DebugDeclarations are injected, ParserState and MockParserState. So extracting the SpecialFormsDeclarations into their own class and injecting that as well should be easy.

ThunderFrame

@Duga Does MDoerner know we're here?

Mat's Mug

23:49

I think not. We should invite him.. but if he doesn't have the CR rep (20) I won't be able to grant him explicit wrire access until later tonight (it's 6h50pm, heading home)

Hosch250

Room owners are supposed to be able to grant that, I think, but it doesn't work.

Mat's Mug

<driving>

Transcript for