I'm not ditching the wrappers just yet. But I'm removing the IDisposable implementations and replacing it with some IComResource - each wrapper will be responsible for releasing itself and its children, so all we'll need is one call to _vbe.Release as late as possible in the teardown process, and that will access and release every single type in the API - including the commandbars.
@PeterMTaylor makes me want to switch all enumerables to List<T> seriously; this might actually massively improve the performance of inspections
OTOH the strategy for inspections is going to change drastically when they work off an AST.. still, I tend to consistently expose IEnumerable<T> everywhere I'm returning an enumerable.
@Mat'sMug sounds like a very positive and useful good plan in the name of simplicity with performance gains. I wonder how many enumerables in total you have already in RD? Who then will be having the responsibility to put say tokens of data into these lists?
> Managed Debugging Assistant 'FatalExecutionEngineError' has detected a problem in 'C:\Program Files\Microsoft Office\Office14\EXCEL.EXE'.
Additional information: The runtime has encountered a fatal error. The address of the error was at 0x1e18e072, on thread 0x1d68. The error code is 0xc0000005. This error may be a bug in the CLR or in the unsafe or non-verifiable portions of user code. Common sources of this bug include user marshaling errors for COM-interop or PInvoke, which may corrupt the stack.
> RD's ExtractMethod refactoring names the new method `NewMethod` regardless of whether the module already contains a declaration named `NewMethod`.
If the user performs an Extract Method followed by another ExtractMethod, the user ends up with 2 methods called `NewMethod`, and no way to distinguish the calls to each method.
I'm trying to build some URLS to retrieve the reports I want, but I need specific fields in with a specific number of decimal places. I could use a favorite, but I'd prefer to request the decimal places as part of the URL.
favorite = GreenPackage favorite (not a browser favorite)
> So I uninstalled RD, cleaned up the files, removed all the office 07/10/13 entries from the registry, ran all the 2016 updates. Restarted, installed RD as admin and got the error. Ran the cmd fix as admin again and still getting the error.
The `\AppData\Roaming\Rubberduck\Logs\RubberduckLog` has no entries for today. Yesterday only has repeated
> > 2016-10-04 13:11:11.0114;WARN;Rubberduck.Parsing.Symbols.TypeAnnotationPass;Failed to resolve type VBE; > 2016-10-04 13:11:11.2504;WARN;Ru
> So I uninstalled RD, cleaned up the files, removed all the office 07/10/13 entries from the registry, ran all the 2016 updates. Restarted, installed RD as admin and got the error. Ran the cmd fix as admin again and still getting the error.
The `\AppData\Roaming\Rubberduck\Logs\RubberduckLog` has no entries for today. Yesterday only has repeated
> > 2016-10-04 13:11:11.0114;WARN;Rubberduck.Parsing.Symbols.TypeAnnotationPass;Failed to resolve type VBE; > 2016-10-04 13:11:11.2504;WARN;Ru
> My preference is for 1 blank line *after* a declaration, so that Types/Enums/Procedures are easier to identify visually:
**Before:** ```vb Option Explicit Type Fizz Foo As String Bar As String End Type Enum Buzz aaa =1 bbb = 2 End Enum Sub Foo() End Sub Sub Bar() End Sub 'TODO - Refactor FooBar Sub FooBar End Sub ```
> This should be simple to fix. The problem is that the "newMethodCall" is inserted at the SelectionStart [here](https://github.com/rubberduck-vba/Rubberduck/blob/next/RetailCoder.VBE/Refactorings/ExtractMethod/ExtractMethodExtraction.cs#L24)
> So I uninstalled RD, cleaned up the files, removed all the office 07/10/13 entries from the registry, ran all the 2016 updates. Restarted, installed RD as admin and got the error. Ran the cmd fix as admin again and still getting the error.
The `\AppData\Roaming\Rubberduck\Logs\RubberduckLog` has no entries for today. Yesterday only has repeated
> > 2016-10-04 13:11:11.0114;WARN;Rubberduck.Parsing.Symbols.TypeAnnotationPass;Failed to resolve type VBE; > 2016-10-04 13:11:11.2504;WARN;Ru
> So I uninstalled RD, cleaned up the files, removed all the office 07/10/13 entries from the registry, ran all the 2016 updates. Restarted, installed RD as admin and got the error. Ran the cmd fix as admin again and still getting the error.
The `\AppData\Roaming\Rubberduck\Logs\RubberduckLog` has no entries for today. Yesterday only has repeated
> > 2016-10-04 13:11:11.0114;WARN;Rubberduck.Parsing.Symbols.TypeAnnotationPass;Failed to resolve type VBE; > 2016-10-04 13:11:11.2504;WARN;Ru
moving a bunch of extension methods to the wrappers... removing duplicate code
ugh. broke 7 tests.
huh, one of them doesn't quite make sense
@Hosch250 test names like ExtractInterface_CanExecute_NoMembers make it easy to tell what's being tested, but impossible to tell the expected result without looking at the test implementation - e.g. that test is doing Assert.IsFalse, so ExtractInterface_CannotExecute_NoMembers would be a better name. just an example.
> This is by design, sort of - the refactoring was written before the indenter was finished - it's not a feature of the *extract method* refactoring to know how to indent code.
Changing from [bug] to [enhancement], since all that's needed is to call into the indenter interface when generating the extracted method.
> @RaymondWise there was a bug at one point (not sure which release fixed it) where RD wouldn't start without at least one project in VBE.VBProjects; since the bug is now fixed, I'll close this issue. Make sure there's a host document in the host application when you open up the VBE.
ExtractInterface tests were relying on CodePaneExtensions.GetQualifiedSelection; other tests were relying on CodeModuleExtensions.GetQualifiedSelection. It wouldn't have been too bad if the two weren't contradicting each other.
I am trying to populate a table like this in Excel. I came up with a bunch
of loops to do this. I feel like this is a brute-force approach and may not work well when populating bigger tables.
Any other ways to populate values in Excel?
Sub Fill_SLA_priority()
Dim SLAbyPrior As Worksh...
> This PR ensures every single COM type ever accessed gets properly cleaned up when RD shuts down. Also cleans up a number of extension methods, now moved to wrapper types.
This is a direct reply to Grace Note's recent CR review, more precisely the following part:
(emphasis mine)
Unanswered
Tying in to all of the above is one of the most pressing concerns about the site I had in my own review, which is the gigantic pool of unanswered questions. There are, ...
I just hate this whole election and big government stuff. I think the best government is small communities where people help each other because they care, not having the impersonal government helping in ways that don't really help.
So lets say that one thread sends a WM_QUIT message while there are still additional messages in the queue. The rest of the queue doesn't get processed.
What I'm not entirely clear on is how the RCW plays into that. IIR I read somewhere that it "bends the rules" on the STA threading assumptions. I can easily see access violations coming from that.
The funny thing is that I don't really understand most of it, but am getting 100%'s and comments that I am demonstrating thorough knowledge from the professor...
TBH, I'm not sure how well she understands it either...
> ole32.dll!CDestObjectWrapper::GetMarshalSizeMax(const _GUID & riid, void * pv, unsigned long dwDestCtx, void * pvDestObjectWrapper, unsigned long mshlflags, unsigned long * pSize) Line 493 C++
ole32.dll!CoGetMarshalSizeMax(unsigned long * pulSize, const _GUID & riid, IUnknown * pUnk, unsigned long dwDestCtx, void * pvDestCtx, unsigned long mshlflags) Line 722 C++
ole32.dll!CRemoteUnknown::DoCallback(tagXAptCallback * pCallbackData) Line 1571 C++
rpcrt4.dll!_Invoke@12 () Unknown
rpcrt4.dll!_NdrStubCall2@16 () Unknown
Not exactly sure - unfortunately the mini-dump doesn't include any of the managed stack at all. I'm trying to see if I can find out what windows message it's trying to handle.
The disposable wrappers worked exactly as intended... and that turned out being a huge mistake:
That's because the .net runtime creates a Runtime Callable Wrapper per-type, not per-instance*; it took a number of refactorings and adjustments just to be able to get the project to build and run, ...
Possibly. It has every look of a callback though, which is odd. It's almost like the RCW is gone and Excel is calling it. Kind of like it's trying to call an event handler that doesn't exist anymore.
Ugh. I wish the debugging symbols I had were better. I have no clue how to decode the RPCOLEMESSAGE that's being passed. That should have the ordinal for the procedure it's calling in it. All I can find is the missing vtable entry.
@Mat'sMug is there a difference between killing RD when VBE is empty because there have never been any projects open, and killing RD when VBE is empty but RD had previously parsed 1 or more projects (before those projects were closed)?
I am trying to populate a table like this in Excel. I came up with a bunch
of loops to do this. I feel like this is a brute-force approach and may not work well when populating bigger tables.
Any other ways to populate values in Excel?
Sub Fill_SLA_priority()
Dim SLAbyPrior As Worksh...
This is a direct reply to Grace Note's recent CR review, more precisely the following part:
(emphasis mine)
Unanswered
Tying in to all of the above is one of the most pressing concerns about the site I had in my own review, which is the gigantic pool of unanswered questions. There are, ...
VBA Rubberducking
VBA Rubberducking