Yeah, that's what I use.

[rubberduck-vba/Rubberduck] build for commit 4eab52df on unknown branch: AppVeyor build succeeded

Umm, my changes all pass.

[rubberduck-vba/Rubberduck] build for commit 196d5e73 on unknown branch: AppVeyor build failed

BUILD FAILURE!

And Next is passing.

When I merge Next into my changes, it doesn't pass...

[rubberduck-vba/Rubberduck] Hosch250 synchronized pull request #2052: Inspection bugs

[Hosch250/Rubberduck] Hosch250 pushed commit 53279d43 to inspectionBugs: Close #2048

[Hosch250/Rubberduck] Hosch250 pushed commit e58687e7 to inspectionBugs: Fix broken tests

[Hosch250/Rubberduck] Hosch250 pushed commit 823ef876 to inspectionBugs: Merge branch 'inspectionBugs' of github.com/Hosch250/Rubberduck

Everything passes on my machine right now.

I'm fully up-to-date with my PR and Next.

[rubberduck-vba/Rubberduck] Vogel612 edited pull request [#1871: Regex Assistant - [review-and-merge-please]](github.com/rubberduck-vba/Rubberduck/pull/1871)

[Hosch250/Rubberduck] build for commit 823ef876 on inspectionBugs: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] build for commit 823ef876 on unknown branch: AppVeyor build succeeded

@Mat'sMug What do you think of this? github.com/rubberduck-vba/Rubberduck/pull/2052/…

@ThunderFrame I'd go with the suggestion @Hosch250 made. OLEWoo also has the benefit of being able to run with debugging symbols, so you may be able to also figure out what OLEView doesn't like about the tlb.

@Vogel612 FWIW I didn't forget your PR

Example usage: github.com/rubberduck-vba/Rubberduck/pull/2052/…

I didn't either, but neither of them are mergeable, and both look pretty good, other than the regex tree style not quite matching the CE's tree style.

@ThunderFrame re your SO answer... debug > compile... works????

@Mat'sMug You don't need to look through all the tests, just check the bits I pointed out.

I'm not sure if that should be in InspectionBase or if it should be an extension method.

@Mat'sMug I guessed

I'm doing some minor cleanup right now..

and the Tools menu thing we touched upon

@Mat'sMug I get the same results as @ThunderFrame.

I don't get it... how is it any different than what I've been doing? Public Type in std module, consumed in class method passed byref...

I almost wonder if it's some strange compile order issue.

VBE7 has to register itself as a class factory for all of the classes that are declared in VBA code.

It doesn't generate a tlb - it uses CoRegisterClassObject, so it has to have all of the types used available when any given class is compiled.

^^ @Mat'sMug thoughts?

Other opinions extremely welcome

[rubberduck-vba/Rubberduck] retailcoder commented on RetailCoder.VBE/Inspections/InspectionBase.cs of pull request #2052: Inspection bugs

[rubberduck-vba/Rubberduck] Hosch250 commented on RetailCoder.VBE/Inspections/InspectionBase.cs of pull request #2052: Inspection bugs

@ThunderFrame - I vaguely recall something about there being an issue around finding the correct application instance when multiple instances of the application were running. Does that ring any bells?

@Vogel612 I'd put all the "parent" menus together, but yeah looks good. Eventually I want to have snippets in there, and other code-generation tools (e.g. generate a class' properties off a private type)

@Mat'sMug Why do you have ToDo Items in there instead of in the Navigate menu?

@Vogel612 Can you check the Todo Items caption/menu item description in German? They are different, but they shouldn't be, I don't think.

Also, check the Malformed Annotation Inspection resx values, please.

[rubberduck-vba/Rubberduck] retailcoder commented on RetailCoder.VBE/Inspections/InspectionBase.cs of pull request #2052: Inspection bugs

@Hosch250 R# puts it there, I figured it would be legit

[rubberduck-vba/Rubberduck] Hosch250 commented on RetailCoder.VBE/Inspections/InspectionBase.cs of pull request #2052: Inspection bugs

@Hosch250 it's fun, because the key is named ToDoItems on one and TodoExplorer for the other

which somewhat reflects in the Translations

@Vogel612 Feel free to rename the key.

"fun"

for some values of fun

on that note I realized that Menu Caption resx keys have no real convention from what I saw

and they're all hardcoded

Correct on both counts.

Yeah that's annoying

I could even imagine getting them into a different .resx

Talking about different resx's, I think we should move the SC into its own. It has a ton of keys.

I'm working on Project-Structures for the Translation Helper

sooo... that could make this loads easier

[rubberduck-vba/Rubberduck] retailcoder commented on RetailCoder.VBE/Inspections/InspectionBase.cs of pull request #2052: Inspection bugs

Also, @Vogel612, can you check the Source Control resx? There is an untranslated value there.

[rubberduck-vba/Rubberduck] Hosch250 commented on RetailCoder.VBE/Inspections/InspectionBase.cs of pull request #2052: Inspection bugs

@Duga go for that

Hang on I'll need to add a few Keys anyways when I do a full cleanup of the code that's in the PR

NP, just letting you know about the changes.

[rubberduck-vba/Rubberduck] Hosch250 synchronized pull request #2052: Inspection bugs

[Hosch250/Rubberduck] Hosch250 pushed commit df50e7c0 to inspectionBugs: Move check for ignore in declaration annotations

[Hosch250/Rubberduck] build for commit df50e7c0 on inspectionBugs: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] build for commit df50e7c0 on unknown branch: AppVeyor build succeeded

@Mat'sMug github.com/rubberduck-vba/Rubberduck/pull/2052/…

[rubberduck-vba/Rubberduck] Vogel612 synchronized pull request [#1871: Regex Assistant - [review-and-merge-please]](github.com/rubberduck-vba/Rubberduck/pull/1871)

[rubberduck-vba/Rubberduck] build for commit c568f96d on unknown branch: AppVeyor was unable to build non-mergeable pull request

BUILD FAILURE!

DAMMIT

@Mat'sMug - yes compiles and runs, but I have seen the error you're getting before. I just can't reproduce it tight now. From memory, the error doesn't refer to a Public Class module that is required, but does refer to a Public Standard module, which you can't create in VBA, but you can in VB6.

@Comintern yes, but IIRC, we get the Application from the vbComponent.Properties?

We had thought about getting the Application from the processID of the VBE, using Accessibility, but I don't remember ever getting it working. I think there was an issue with the demonstrative links that I found

OK. I'll file this for future reference then. Apparently OLE has an API function specifically for that.

okay I got the compile errors fixed, running all tests before force-update

[rubberduck-vba/Rubberduck] Vogel612 synchronized pull request [#1871: Regex Assistant - [review-and-merge-please]](github.com/rubberduck-vba/Rubberduck/pull/1871)

Duga will say build Succeeded. Who's willing to bet?

[rubberduck-vba/Rubberduck] build for commit 04dd638c on unknown branch: AppVeyor build succeeded

@Comintern github.com/rubberduck-vba/Rubberduck/issues/811

That's the one I was thinking of.

[rubberduck-vba/Rubberduck] Hosch250 edited issue #1974: Code Explorer bottom panel label touch-ups

hmm, we have the ability to get the Application from the VBE, but the order of the code changed....

github.com/rubberduck-vba/Rubberduck/blob/…

(Compare that line to line 95)

if we use the App constructor with the vbe argument, then we should be able to handle multiple application instances better.

@Mat'sMug fixed the last few things. I'd appreciate a final check from you guys and merging

Niters

Night!

Exception catching penalties

Catching hundreds of exceptions in a loop cripples any .net app