VBA Rubberducking

SlowLearner

00:00

@Hosch250 That's not my code / bug... never really used the Name function. I only ever use it to get the name of objects: e.g. ?Document(1).Name

Duga

RELOAD!

[Hosch250/Rubberduck] 16 commits. 1240 additions. 394 deletions.

[rubberduck-vba/Rubberduck] 17 commits. 7 opened issues. 5 closed issues. 33 issue comments. 1447 additions. 712 deletions.

[rubberduck-vba/RubberduckWeb] 3 issue comments.

[skiwi2/bit-vector] 2 commits. 348 additions. 44 deletions.

[VSDiagnostics/VSDiagnostics] 2 issue comments.

[Zomis/Minesweeper-Analyze] 8 commits. 56 additions. 11 deletions.

[rubberduck-vba/Rubberduck] comintern synchronized pull request #1862: "If Foo Then Bar Else" fix. Closes #1858

Hosch250

@ThunderFrame Oh, maybe.

@SlowLearner OK, just thought maybe you knew.

I got the help I needed.

Duga

[rubberduck-vba/Rubberduck] Hosch250 merged pull request #1861: Fix bug where userform events are loaded without FormEvents being loaded from Hosch250/Rubberduck/Issue1851 into rubberduck-vba/Rubberduck/next

[rubberduck-vba/Rubberduck] Hosch250 pushed commit 7741c5b5 to next: Fix bug where userform events are loaded without FormEvents being loaded

[rubberduck-vba/Rubberduck] web-flow pushed commit a83be737 to next

Merge pull request #1861 from Hosch250/Issue1851

Fix bug where userform events are loaded without FormEvents being loaded

Comintern

Down to only 2 broken bits (that I know about) that we inherited from SmartIndenter.

2

Hosch250

@Comintern Can you update your PR? I was planning on doing yours first so I wouldn't have to ask you, but it was still running.

Duga

00:06

[rubberduck-vba/Rubberduck] comintern synchronized pull request #1862: "If Foo Then Bar Else" fix. Closes #1858

Comintern

Done

Hosch250

Thanks.

SlowLearner

@Hosch250 Wish I did, I'm a self taught hack - learning slowly

Hosch250

More/less the same here, only Mug teaches me.

Or rather, he taught me. I've been learning more from Comintern lately.

SlowLearner

lol

Comintern

00:08

The 2 ignored test cases are so messed up I'm not even sure I know how they should indent.

Hosch250

Just got my first C# book today after over two years of development in it and one in C++ (I used Bjarne Stroustrup's book for that).

SlowLearner

You mentioned an internship, I figured you were studying some sort of programming course?

Hosch250

@SlowLearner IT Management. I told my professor I was looking to go into programming, and they made an exception for me to do the CS-type internship instead of the IT internship while doing the IT internship class.

Duga

[rubberduck-vba/Rubberduck] build for commit 890c2d2a on unknown branch: AppVeyor build succeeded

Hosch250

Two more builds.

SlowLearner

00:11

Ohhh... well that's pretty cool of them

Duga

[rubberduck-vba/Rubberduck] build for commit a83be737 on next: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] build for commit e4775abc on unknown branch: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] Hosch250 closed issue #1858: Indent

[rubberduck-vba/Rubberduck] Hosch250 merged pull request #1862: "If Foo Then Bar Else" fix. Closes #1858 from comintern/Rubberduck/next into rubberduck-vba/Rubberduck/next

[rubberduck-vba/Rubberduck] comintern pushed commit bae40b73 to next: "If Foo Then Bar Else" fix. Closes #1858

[rubberduck-vba/Rubberduck] web-flow pushed commit 6025e447 to next: Merge branch 'next' into next

[rubberduck-vba/Rubberduck] comintern pushed commit 890c2d2a to next: Fix indenting of multi-segment Do...Loop, If...Then...Else

[rubberduck-vba/Rubberduck] web-flow pushed commit e4775abc to next: Merge branch 'next' into next

[rubberduck-vba/Rubberduck] web-flow pushed commit 788dc2d1 to next

Merge pull request #1862 from comintern/next

"If Foo Then Bar Else" fix. Closes #1858

[rubberduck-vba/Rubberduck] Hosch250 created pull request #1863: Merge next into master to merge next into master

[rubberduck-vba/Rubberduck] Hosch250 merged pull request #1863: Merge next into master from next into master

[rubberduck-vba/Rubberduck] build for commit 788dc2d1 on next: AppVeyor build cancelled

BUILD FAILURE!

[rubberduck-vba/Rubberduck] Hosch250 pushed 171 commits to master

[rubberduck-vba/Rubberduck] web-flow pushed commit edc2df27 to master

Merge pull request #1863 from rubberduck-vba/next

Merge next into master

[rubberduck-vba/Rubberduck] build for commit 788dc2d1 on next: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] Hosch250 published prerelease 2.0.2b

[rubberduck-vba/Rubberduck] Hosch250 created tag 2.0.2b

Hosch250

00:30

Released and done.

Duga

[rubberduck-vba/Rubberduck] build for commit edc2df27 on master: AppVeyor build succeeded

Duga

01:09

[rubberduck-vba/Rubberduck] comintern created pull request #1864: Fixes the last of the (known) SmartIndenter issues inherited from VB6. to merge comintern/Rubberduck/next into rubberduck-vba/Rubberduck/next

[rubberduck-vba/Rubberduck] comintern synchronized pull request #1864: Fixes the last of the (known) SmartIndenter issues inherited from VB6.

[rubberduck-vba/Rubberduck] build for commit 96a3779a on unknown branch: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] Hosch250 merged pull request #1864: Fixes the last of the (known) SmartIndenter issues inherited from VB6. from comintern/Rubberduck/next into rubberduck-vba/Rubberduck/next

[rubberduck-vba/Rubberduck] comintern pushed commit da3f606b to next: Fixes the last of the ignored VB6 SmartIndenter issues.

[rubberduck-vba/Rubberduck] comintern pushed commit 96a3779a to next: Merge branch 'next' of github.com/comintern/Rubberduck.git

[rubberduck-vba/Rubberduck] web-flow pushed commit f6373afb to next: Merge branch 'next' into next

[rubberduck-vba/Rubberduck] web-flow pushed commit 2c6a498b to next

Merge pull request #1864 from comintern/next

Fixes the last of the (known) SmartIndenter issues inherited from VB6.

[rubberduck-vba/Rubberduck] build for commit f6373afb on next: AppVeyor build cancelled

BUILD FAILURE!

Comintern

@Hosch250 - Don't even think of redoing the release for that PR - those are the corner cases of the corner cases.

Hosch250

@Comintern OK.

See you later--off to read my C# book.

Comintern

Night.

Duga

[rubberduck-vba/Rubberduck] build for commit 2c6a498b on next: AppVeyor build succeeded

Duga

02:26

[rubberduck-vba/Rubberduck] Stevefb opened issue #1865: Code Inspection suggests Intermediate Fix, a different fix is suggested next inspection (MS Word)

> Applies to: RD 2.0.2b, edc2df2

Example. Create new document & add UserForm. Add Query Close from dropdown menu, initially it will look like this:
```
Private Sub UserForm_QueryClose(Cancel As Integer, CloseMode As Integer)

End Sub
```
On the first inspection, Rubberduck will correct the implicit ByRef and an automatic fix will look like this:
```
Private Sub UserForm_QueryClose(ByRef Cancel As Integer, ByRef CloseMode As Integer)

End Sub
```
However, when the code is reinspect

Duga

02:54

[rubberduck-vba/Rubberduck] Stevefb commented on issue #1827: Code Inspection false positive: constant 'ABC' not used

> @Hosch250 I have a simple document that reproduces this issue, let me know if you want it. Basic steps and observations are:

1 Create New document, add userform with this code:
```
Option Explicit

Private Sub UserForm_Activate()
Const RUBBERY As String = "Activate.LittleBlackDuck"
FalsePos RUBBERY
End Sub
```
2 Add Sub to standard Module (Module1) with this code:
```
'Option Explicit <-- Comment out to get the False Positive

Sub FalsePos(ByVal thisString As St

[rubberduck-vba/Rubberduck] Stevefb commented on issue #1827: Code Inspection false positive: constant 'ABC' not used

> Oh - should mention this applies to: RD 2.0.2b, edc2df2

Duga

03:06

[rubberduck-vba/Rubberduck] retailcoder commented on issue #1865: Code Inspection suggests Intermediate Fix, a different fix is suggested next inspection (MS Word)

> Actually changing `ByRef` to `ByVal` on an event handler would break the code; the inspection needs to ignore event handlers, whether they're for built-in events or not.

The suggestion to explicit `ByRef` is fine; the problem is with changing `ByRef` to `ByVal`, and that suggestion is made because a `ByRef` parameter should be an array, or should be assigned in the body of the procedure; the two results are independent of each other; actually your initial inspection results should have incl

[rubberduck-vba/Rubberduck] retailcoder added label bug to issue #1865: Code Inspection suggests Intermediate Fix, a different fix is suggested next inspection (MS Word)

[rubberduck-vba/Rubberduck] retailcoder added label code-inspections to issue #1865: Code Inspection suggests Intermediate Fix, a different fix is suggested next inspection (MS Word)

[rubberduck-vba/Rubberduck] Stevefb commented on issue #1865: Code Inspection suggests Intermediate Fix, a different fix is suggested next inspection (MS Word)

> Yes you are right about event handlers, I was thinking more about the general case when I wrote that. Showing both options in the results would be a reasonable approach :+1:

[rubberduck-vba/Rubberduck] retailcoder commented on issue #1827: Code Inspection false positive: constant 'ABC' not used

> Do you have logging enabled? Hopefully there's an exception thrown in the resolver, and logs have valuable stack trace information. I'll still try to repro, this glitch with/without Option Explicit is rather troubling.

Peter M Taylor

@Mat'sMug sorry to hear @awgaya left. I just heard when I caught up.

Hi all

SlowLearner

@PeterMTaylor Hi

Peter M Taylor

So how is it going with you @SlowLearner?

Duga

03:21

[rubberduck-vba/Rubberduck] Stevefb commented on issue #1827: Code Inspection false positive: constant 'ABC' not used

> To be honest I'm finding Word less stable than usual so the short answer is no. I can enable it for specific tests but between RD and my own code word normal way of shutting down is by Not Responding...

SlowLearner

Not bad - learning lots, slowly... you?

Mat's Mug

@SlowLearner lol, that'll never get old haha

Duga

[rubberduck-vba/Rubberduck] Stevefb commented on issue #1828: Return value of function 'iReturnSomething' is never used

> @retailcoder Ok I have reproduced in a file that I can send. Looking into it now...

Mat's Mug

@PeterMTaylor hi! :-)

Peter M Taylor

Howdy, its 1:30pm here. Just had a pluger coffee and home made french toast. ;)

SlowLearner

03:35

@PeterMTaylor - AU EastCoast?

Mat's Mug

Ha! It's still Friday for anoher 25 minutes here

SlowLearner

@Mat'sMug should this give Parameter "thisString" is never used?

Sub FalsePos(ByVal thisString As String)
Debug.Print thisString
End Sub

Mat's Mug

nope

SlowLearner

(because it does)

Mat's Mug

dafuq

SlowLearner

03:37

Word

Peter M Taylor

@SlowLearner South East Melbourne in Australia. Near melbourne.

SlowLearner

@PeterMTaylor Syd, NorWest - Lived in Moorabin, Chelt, Hampton, Clayton...

Peter M Taylor

Ah. there you go @Mat'sMug another Auzzie to content with. :)

Mat's Mug

lol

Peter M Taylor

@SlowLearner please to meet you.

Duga

03:41

[retailcoder/Rubberduck] retailcoder pushed 60 commits to next (only showing some of them below)

[retailcoder/Rubberduck] web-flow pushed commit cad72f7f to next

Merge pull request #1860 from Hosch250/Issue1616

Code Explorer Enhancements

[retailcoder/Rubberduck] Hosch250 pushed commit 7741c5b5 to next: Fix bug where userform events are loaded without FormEvents being loaded

[retailcoder/Rubberduck] comintern pushed commit bae40b73 to next: "If Foo Then Bar Else" fix. Closes #1858

[retailcoder/Rubberduck] web-flow pushed commit 6025e447 to next: Merge branch 'next' into next

[retailcoder/Rubberduck] comintern pushed commit 890c2d2a to next: Fix indenting of multi-segment Do...Loop, If...Then...Else

[retailcoder/Rubberduck] web-flow pushed commit a83be737 to next

Merge pull request #1861 from Hosch250/Issue1851

Fix bug where userform events are loaded without FormEvents being loaded

[retailcoder/Rubberduck] web-flow pushed commit e4775abc to next: Merge branch 'next' into next

[retailcoder/Rubberduck] web-flow pushed commit 788dc2d1 to next

Merge pull request #1862 from comintern/next

"If Foo Then Bar Else" fix. Closes #1858

[retailcoder/Rubberduck] web-flow pushed commit edc2df27 to next

Merge pull request #1863 from rubberduck-vba/next

Merge next into master

[retailcoder/Rubberduck] web-flow pushed commit f894f8df to next

Merge pull request #127 from rubberduck-vba/master

v2.0.2b

SlowLearner

@PeterMTaylor likewise, what brings you to RD?

Duga

[rubberduck-vba/Rubberduck] retailcoder edited wiki page _Footer

Peter M Taylor

Well....

Mat's Mug

♥ VBA ♥

Peter M Taylor

Its basically an on and off affair with VBA using Excel since I finished my IT degree since '92.

SlowLearner

03:52

@Mat'sMug don't we all?

Mat's Mug

IKR :)

Peter M Taylor

where VB was more important than VBA gossip in the department halls.

Mat's Mug

I'd really like Rubberduck to work in Visual Studio 6.0 at one point

ThunderFrame

hey @SlowLearner I used to work at NorWest, but am in Melbourne these days...

Peter M Taylor

not far from me @SlowLearner

Duga

03:55

[rubberduck-vba/Rubberduck] Hosch250 commented on issue #1865: Code Inspection suggests Intermediate Fix, a different fix is suggested next inspection (MS Word)

> Actually, now that we have the built-in event handlers, we can fix this.

ThunderFrame

I can't remember how to get a type from the F3Dynamic library...

SlowLearner

@PeterMTaylor You're not talking about these nasty green soldiers (198.100.145.159/~thebeer/wp-content/uploads/2012/07/vb.jpg) are you?

Hosch250

@SlowLearner Checking out that peculiar const bug now.

ThunderFrame

@Mat'sMug yep - VB6 should be on the 3.0 roadmap

Peter M Taylor

I discover RD by accident when I wanted to find a simplier way to do more programming in VBA along the lines of wanting to write a VBA game as I had a few ideas of my own.

Hosch250

03:58

@PeterMTaylor Ugh, use a real language.

Peter M Taylor

Actually I don't drink beer nor do I smoke. I never did.

Hosch250

@PeterMTaylor Same here :)

Mat's Mug

@Hosch250 did you read the latest RD news?

SlowLearner

@PeterMTaylor errrr. ... yeah me too...

ThunderFrame

@Mat'sMug Next time Carlos pops in, we should ask about the steps/headaches of getting VB6's VBIDE to work alongside the VBA version.

Hosch250

03:59

@Mat'sMug Yeah, I did.

Mat's Mug

IIRC he said it wasn't complicated or hard at all

SlowLearner

well not in the mornings, anyway

Hosch250

I don't buy it though--C# can do everything VBA can do, and then some--I just read about some of it in C# In Depth.

C# 4 apparently really focused on making it easier to work with COM.

Mat's Mug

easier than in previous versions of C#

Duga

[rubberduck-vba/Rubberduck] Stevefb commented on issue #1828: Return value of function 'iReturnSomething' is never used

> Ok, I think this also relates to the use of Option Explicit...

Blank doc, Module1 Has:
```
Option Explicit
Function OffSet(someTable As Table) As Integer
OffSet = someTable.Rows.Count - 1
End Function
```
Module3 has (NO option explicit)
```
Sub UsesOffSet()
Dim iOffSet As Integer
iOffSet = OffSet(Selection.Range.Tables(1)) ' <-- Result Used, but not detected
Debug.Print iOffSet
End Sub
```
Code Inspection result is that Return Value of function 'Of

Mat's Mug

04:00

working with COM is always going to be simpler in COM

Hosch250

Of course.

ThunderFrame

oh, the paradox... As C# gets better, it makes it easier to work with VBA...

Peter M Taylor

@Hosch250 I would consider making a game using C# language as the next step in my goal in programming. The only thing is my time so its a hobby at the moment.

as I have my time with work, my other half and two kids.

So I am enjoying RD with VBA until I get a hang of it then I would jump up.

Hosch250

I'm ready to scream.

My release build isn't the release.

Mat's Mug

wtf did you release then? lol

Peter M Taylor

04:04

So @Hosch250 is C# feedback is improving?

Hosch250

The last release, maybe?

ThunderFrame

there's nothing like a real project to learn a new skill. I prefer books over classes, but there's no substitute for solving a real problem.

Duga

[rubberduck-vba/Rubberduck] Hosch250 created pull request #1866: 2.0.2b to merge next into master

ThunderFrame

and if VBA isn't a real problem, I don't know what is :-{

Duga

[rubberduck-vba/Rubberduck] Hosch250 merged pull request #1866: 2.0.2b from next into master

Mat's Mug

04:05

> Rubberduck.Setup.2.0.2b.exe (5.28MB) - Downloaded 3 times.
Last updated on 2016-06-18

Duga

[rubberduck-vba/Rubberduck] Hosch250 pushed 4 commits to master

[rubberduck-vba/Rubberduck] web-flow pushed commit 7e9cc590 to master

Merge pull request #1866 from rubberduck-vba/next

2.0.2b

SlowLearner

@Mat'sMug btw that is a great article... pitched just above my level of understanding... made me read the rest of them... will have re-read them all in a week or two

Duga

[rubberduck-vba/Rubberduck] build for commit 2c6a498b on next: AppVeyor build cancelled

BUILD FAILURE!

Mat's Mug

@Hosch250 just re-upload the correct build, while everyone that downloaded it is in this room

Hosch250

Working on it.

SlowLearner

04:07

@Mat'sMug lol... really

Hosch250

I'm trying to delete the old release/tag, and I forgot how.

Mat's Mug

the big red button

Peter M Taylor

another entry for the wiki to document "how to"?

Hosch250

Found it--I had to go into the specific release.

Duga

[rubberduck-vba/Rubberduck] Hosch250 deleted tag 2.0.2b

Mat's Mug

04:09

@PeterMTaylor funny you mention the wiki, I was going to start updating it with cough 2.0.2b cough

ThunderFrame

I think I'm looking at RubberduckModule.cs for the first time. Lot's of stuff going on there!

Peter M Taylor

:) Looking forward to read the latest update.

Duga

[rubberduck-vba/Rubberduck] build for commit 7e9cc590 on master: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] Hosch250 published prerelease 2.0.2b

[rubberduck-vba/Rubberduck] Hosch250 created tag 2.0.2b

[retailcoder/Rubberduck] comintern pushed commit da3f606b to next: Fixes the last of the ignored VB6 SmartIndenter issues.

[retailcoder/Rubberduck] comintern pushed commit 96a3779a to next: Merge branch 'next' of github.com/comintern/Rubberduck.git

[retailcoder/Rubberduck] web-flow pushed commit f6373afb to next: Merge branch 'next' into next

[retailcoder/Rubberduck] web-flow pushed commit 2c6a498b to next

Merge pull request #1864 from comintern/next

Fixes the last of the (known) SmartIndenter issues inherited from VB6.

[retailcoder/Rubberduck] web-flow pushed commit 7e9cc590 to next

Merge pull request #1866 from rubberduck-vba/next

2.0.2b

[retailcoder/Rubberduck] web-flow pushed commit 48a000f0 to next

Merge pull request #128 from rubberduck-vba/master

v2.0.2b (the right build this time)

[rubberduck-vba/Rubberduck] Hosch250 commented on issue #1827: Code Inspection false positive: constant 'ABC' not used

Hosch250

@SlowLearner Please download the updated release build and try again.

Duga

> I still have no repro, following your instructions exactly.

Hosch250

04:17

The only difference I get is that without Option Explicit, I have one more inspection result--the one about no option explicit.

Maybe this was fixed as a side-affect of something else.

SlowLearner

@Hosch250 Feels like Christmas... so many presents all at the same time!

Hosch250

In only one week, to boot.

There will be more next week.

Duga

[rubberduck-vba/Rubberduck] build for commit 7e9cc590 on master: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] Stevefb commented on issue #1827: Code Inspection false positive: constant 'ABC' not used

> What's the best way to share a file?

[rubberduck-vba/Rubberduck] Hosch250 commented on issue #1827: Code Inspection false positive: constant 'ABC' not used

> Just upload it right in this issue--drag/drop should work.

Peter M Taylor

ok. will do the test I just started this morning since there's a new version.

Hosch250

Yeah, I forgot to pull from master when I created my release branch.

So, I just re-released last-weeks master.

Duga

04:21

[rubberduck-vba/Rubberduck] Hosch250 commented on issue #1814: Source Control Issue - crash on init, selecting working directory or cloning

> Please download the updated release and try again.

Hosch250

@PeterMTaylor Please try #1791 again.

Peter M Taylor

Glady.

SlowLearner

@Mat'sMug any plans to integrate RD with a packager, like InnoSetup?

Hosch250

@SlowLearner We are using InnoSetup.

Mat's Mug

^

Peter M Taylor

04:24

@Hosch250 Win Def still didn't like the file. I presume no signing the dll, yes?

Hosch250

I clean/rebuild all the solutions, then compile an InnoSetup program and publish the exe.

@PeterMTaylor Yeah, I didn't sign the dll. I need to look into that more.

SlowLearner

From within the VBA IDE?

Hosch250

Oh, no.

Mat's Mug

@SlowLearner oh, no lol - but yeah we need to look into a way to notify of a new available version

Hosch250

@Mat'sMug 2.1, first thing.

Although, TBH, people might not like updating every Monday morning when they come in to work.

Peter M Taylor

04:26

@Mat'sMug won't RD always check if a new version is available or only when the User peeks at the About screen?

Hosch250

@PeterMTaylor Neither.

It doesn't do anything, at the moment.

SlowLearner

That too, I was thinking about how building my own project into Inno....

from the VBA IDE

Hosch250

When I do this, I'm going to pop a notification Rubberduck has an update--install (goes to GitHub), ignore (perma-closes), remind me later (reminds the next time RD starts).

Mat's Mug

oh wait, you mean packaging vba code to distribute?

Hosch250

Or something along that line.

Mat's Mug

04:27

that's a pretty nifty idea actually - make an issue for it!

actually...

an installer would be a bit overkill for a bunch of files

it's not like it's a compiled executable

but an option to export everything and zip it up would be nice

Duga

[rubberduck-vba/Rubberduck] Hosch250 commented on issue #1865: Code Inspection suggests Intermediate Fix, a different fix is suggested next inspection (MS Word)

> Actually, when I see these, usually both inspections are fired up, and when it is made explicitly byref, that one stops showing. Are you sure only one is firing the first time?

SlowLearner

right how I have a pretty unique way of doing things... stackoverflow.com/questions/25497917

@Mat'sMug yes... :-)

Duga

[rubberduck-vba/Rubberduck] Hosch250 added label code-inspections to issue #1856: RD should have an inspection for use of the Open statement with filenumbers not assigned by FreeFile

Mat's Mug

no need for inno there, imo

Duga

[rubberduck-vba/Rubberduck] Hosch250 added label feature-request to issue #1856: RD should have an inspection for use of the Open statement with filenumbers not assigned by FreeFile

SlowLearner

04:31

@Mat'sMug well... it ships with several dlls, some resources, user defined custom xml

Duga

[rubberduck-vba/Rubberduck] Hosch250 added label bug to issue #1855: Resolver/Refactor issues with evil code

[rubberduck-vba/Rubberduck] Hosch250 added label code-parsing to issue #1855: Resolver/Refactor issues with evil code

[rubberduck-vba/Rubberduck] Hosch250 added label bug to issue #1852: Double Clicking on a Code Inspection result for a closed project crashes host (Word 2010)

[rubberduck-vba/Rubberduck] Hosch250 added label code-inspections to issue #1852: Double Clicking on a Code Inspection result for a closed project crashes host (Word 2010)

[rubberduck-vba/Rubberduck] Hosch250 added label bug to issue #1844: Opening a project in Access modifies all code modules

SlowLearner

New release sucks, can't reproduce any of the issues I was trying to figure out ;-/

8

Hosch250

@SlowLearner LOL!

That's a good thing for me...

@SlowLearner I should unpin our motto about fewer bugs and pin that as our new motto.

SlowLearner

@Hosch250 you have my blessing

Hosch250

Or we can always have two mottos.

ThunderFrame

04:35

fewer repros than yesterday, and more than tomorrow.

Mat's Mug

I'm so tweeting that

2.0.2b is out! Initial feedback: "New release sucks, can't reproduce any of the issues I was trying to figure out ;-/"

Tweeted by rubberduckvba on June 18, 2016 at 4:38 AM

SlowLearner

@Mat'sMug Resolving 30 Sec, Inspecting 10 Sec, until ready. Opening Code Inspection still takes a while.

Hosch250

@SlowLearner Yeah, inspecting only accounts for the time running the inspections.

Loading the UI is expensive--I made it a gazzillion times faster already, but performance still needs to improve.

If I can get that to work like lightning, I'm so making an SO post.

SlowLearner

I was wondering if Resolving is slowed down because my DLLs are not in global cache thingy?

Hosch250

No, that is Loading References.

SlowLearner

04:40

oh yeah... late binding.... happens later....

Hosch250

@SlowLearner Quick question, did parsing speed up any?

I noticed that it goes to Resolving a lot earlier than before due to some changes.

SlowLearner

Parsing was over in a flash

Hosch250

Before, we had three distinct steps: parsing, {resolving declarations, resolving references}.

Resolving did not start until everything was parsed.

Peter M Taylor

@Hosch250 well done, you hushed me up with my Resolver Error but...

Hosch250

Now, resolving starts as soon as a single module is parsed--and the state is set to resolving as soon as any module starts resolving.

That explains why resolving takes longer--it is accounting for the intermingling of the parse/resolve states.

On the other hand, the whole sequence should be much faster, is it?

@PeterMTaylor What?

SlowLearner

04:43

I'd have to run it a few times, sometimes the old version was very slow, other times it was a bit slow...

Looking at my main project now, trying to find known False Positives...

Mat's Mug

the "untyped string function usage" inspection is messed up

Duga

[rubberduck-vba/Rubberduck] PeterMTaylor commented on issue #1791: Resolver Error in v2.0.1b

> With the new version of 2.0.2b. No Resolver error occured.
I accidently had Book1 open with no project in the system. It kept Pending more than 5 mins.
![capture pending with no projects](https://cloud.githubusercontent.com/assets/2254567/16169054/ff239e14-3562-11e6-93ca-47b90b42dc6c.PNG)

Hosch250

@Mat'sMug IT has been for a while.

@Duga Yeah, but I'd say not an issue if you don't have anything for RD to work off of.

Mat's Mug

Duga

[rubberduck-vba/Rubberduck] PeterMTaylor commented on issue #1791: Resolver Error in v2.0.1b

> With the new version of 2.0.2b. No Resolver error occured.
I accidently had Book1 open with no project in the system. It kept Pending more than 5 mins.
![capture pending with no projects](https://cloud.githubusercontent.com/assets/2254567/16169054/ff239e14-3562-11e6-93ca-47b90b42dc6c.PNG)
If there was no Projects, I thought it will say Ready by default.

Hosch250

04:45

@Mat'sMug Yeah, I know.

SlowLearner

Ok... some functions are getting returned value is never used when they are

Hosch250

@Duga No, ready is only set when the parse/resolve is successful. RD is detecting there is nothing to parse and leaving it at the state it originally was.

I could stick a simple if in there to make Pending be Ready...

@SlowLearner Yeah, lots of bugs. Next release will focus on inspection bugs.

Mat's Mug

@Hosch250 that would break a bunch of command CanExecute implementations

Hosch250

@Mat'sMug Not really--they all need non-null selections or active code panes anyway. I'd say it would highlight potential bugs.

Mat's Mug

mkay, try it then :)

Hosch250

04:48

And the rest are the ones that are always available anyway--CE, TE, CI, TDE, &c.

Not tonight. I'm going to bed, and if I program tomorrow, it will probably be studying events and delegates to understand chapter 2 better.

ThunderFrame

I'm splitting up a long string literal. Anyone have views on number of chars per line? 80 seems too few. 120 feels about right on my 1080p 13" laptop.

Mat's Mug

@Hosch250 that book is awesome, wait till you get to anonymous types and closures :)

Hosch250

@ThunderFrame We aren't working with it. You decide what's good based on your (and your colleagues) circumstances.

SlowLearner

@Hosch250 Not as many as before... I still get a few different types of false positive but overall much better.

Hosch250

@SlowLearner Good.

@Mat'sMug I know. I already know how to use a lot of this stuff, but I'm still learning a ton.

ThunderFrame

04:51

@Hosch250 well, we're about to... ;-)

Const x As String = _
  " Lorem ipsum dolor sit amet, consectetur adipiscing elit. Aenean laoreet iaculis tincidunt. Quisque laoreet tortor est, " & _
  "id porta quam varius eu. Aenean volutpat, nisi id vulputate ullamcorper, lacus massa finibus augue, sit amet " & _
  "sollicitudin neque purus vel nibh. Nullam tempor pharetra augue, eget placerat diam sagittis facilisis. Pellentesque " & _
  "rhoncus est nec aliquet scelerisque. Nunc nisi metus, iaculis in volutpat ultrices, auctor a magna. Praesent sit amet " & _

Hosch250

And by a lot, I mean almost all. Like, I know how to use delegates more or less (with the help of my search engine for syntax), but I learned a lot in 2.1.

@ThunderFrame Looks good, but if I were you, I might just stick that in a file and read it in.

Night.

ThunderFrame

'night

Mat's Mug

'night!

Peter M Taylor

not bad. Will have something to work with

Just to let you know it took more than 5 mins of processing the "Inspection..."
when done and lost the Code Inspection when displayed as in the window was displayed BEHIND the VBE.

Mat's Mug

hmm, vbNullString inspection can't be ignored

SlowLearner

04:55

@Mat'sMug is there a distinction made between never used and never assigned?

Sub BooleanNotUsed()
Dim bTrue As Boolean
bTrue = True
End Sub

Gives Inspection result, variable is not used.... which seems fair, it's only assigned. Is that about the right way to look at this?

Mat's Mug

@SlowLearner yes

it gets a bit wonky when the variable is an array though

SlowLearner

Cool...

Peter M Taylor

ok folks. Gotta go my little daughter has a sore ear got to take her to doctors. Will catch up with some more testing on the same code later.

Mat's Mug

later!

SlowLearner

cya

Peter M Taylor

04:57

good job with this release.

bye

ThunderFrame

@Mat'sMug I'm working on a PasteSpecialAsStringLiteralCommand and a PasteSpecialAsCommentCommand... I'm going to go with 120 chars per line (excluding syntax marks), for now...

Mat's Mug

I think the formats to include in the clipboard when copying should be configurable.. copying 5000 inspection results gets pretty heavy, pretty fast

SlowLearner

This release seems really good at finding dead code... there is quite a bit of that in my project that other tools did not find.

ThunderFrame

@Mat'sMug agreed. But I'm working on inserting code from the clipboard into the codepane. That Lorem Ipsum example above is 2 paragraphs of raw clipboard text converted into a string literal.

but the idea is that you can insert SQL/HTML/XML chunks and Rubberduck adds the double-quotes and ampersands.

and for comments, it adds the leading apostrophe

Mat's Mug

@ThunderFrame ooh shiny!

SlowLearner

05:09

Has RD messed up my file browser? All my icons are black....

ThunderFrame

I can't decide what to do with long text that will end up being more than 15 line continuations. I think I'll post an SO question.

Mat's Mug

@SlowLearner shouldn't..........

@ThunderFrame warn and abort

or adjust line width accordingly

SlowLearner

Gah words having a hissy fit

Duga

[rubberduck-vba/Rubberduck] retailcoder added label code-inspections to issue #1867: We need an @Interface annotation

[rubberduck-vba/Rubberduck] retailcoder added label enhancement to issue #1867: We need an @Interface annotation

ThunderFrame

@Mat'sMug well I've seen plenty of: Dim x as String : x = "really long text" : x = x & "more long text" : x = x & "yet more text", but that precludes long text being a Const, so I'm inclined to make long text be returned by a helper function. So the function acts as a pesudo-Const.

Duga

05:15

[rubberduck-vba/Rubberduck] retailcoder opened issue #1867: We need an @Interface annotation

> Unless a class is implemented somewhere in the project, Rubberduck has no way of reading one's mind and guessing that such or such class is intended to be used as an interface.

The result of this is that even if the "return value not assigned" inspection figured out "hey that class is used in an `Implements` statement, these are member stubs, I'll just ignore them", ...it would still fire an inspection result for every single member of every single interface.

By giving RD a hint in the d

ThunderFrame

and, a function could do more efficient concatenation by doing something like

Dim x(2) As String: x(0) = "really long text" : x(1) = "more long text" : x(2) = "yet more text" : returnVal = Join(x,"")

hmm, this might be better as a CR question

Duga

05:39

[rubberduck-vba/Rubberduck] retailcoder edited wiki page Code Explorer

SlowLearner

06:06

@Mat'sMug Re the black icons, it seems to only impact file browse type dialogues with Word - Uninstalling RD resolved the issue with the exception of 1 icon; This PC is now represented by a black box... (guess I should paint my case orange?). Anyway, I let Windows apply its latest update, reinstalled RD, started Word and all's good (except, of course for This PC which remains Black).

I am running 4 displays, so could be a driver issue too.

Mat's Mug

2:10.. I'm out! 'night @Australia!

SlowLearner

@Mat'sMug thanks, has been fun

ThunderFrame

06:40

0

Q: Defining long, multi-line string-literals in VBA

I'm writing a helper in C# (for inclusion in Rubberduck) that takes text from the user's Clipboard and reformats it for insertion into a VBA module as a string-literal. The goal is to allow the insertion of SQL/HTML/XML/text strings into VBA without tedious/error-prone syntax-corrections for doub...

Duck Review

0

Q: Defining long, multi-line string-literals in VBA

I'm writing a helper in C# (for inclusion in Rubberduck) that takes text from the user's Clipboard and reformats it for insertion into a VBA module as a string-literal. The goal is to allow the insertion of SQL/HTML/XML/text strings into VBA without tedious/error-prone syntax-corrections for doub...

strings vba rubberduck vb6 constants

Duga

07:01

[rubberduck-vba/Rubberduck] Stevefb opened issue #1868: Code Inspection - Incorrect Diagnosis: Object variable is assigned without the Set keyword

> In MS Word, cos ranges are different...
```
Sub ImTooLazy(aRange As Range)
aRange = "something"
End Sub
```
In this case the suggestion should have been working towards:
`aRange.text = "something"`

Duga

07:28

[rubberduck-vba/Rubberduck] ThunderFrame commented on issue #1868: Code Inspection - Incorrect Diagnosis: Object variable is assigned without the Set keyword

> Attack of the Default member.

Duga

07:56

[rubberduck-vba/Rubberduck] Stevefb commented on issue #1868: Code Inspection - Incorrect Diagnosis: Object variable is assigned without the Set keyword

> And another... @ThunderFrame should be new issue, or pile them all in here?
```
Private Sub UserForm_KeyDown(ByVal KeyCode As MSForms.ReturnInteger, ByVal Shift As Integer)
If KeyCode = vbKeyF1 Then
KeyCode = 0 ' <-- Should be KeyCode.Value = 0
End If
End Sub
```

[rubberduck-vba/Rubberduck] ThunderFrame commented on issue #1868: Code Inspection - Incorrect Diagnosis: Object variable is assigned without the Set keyword

> @Stevefb Issues should try to cover a class of problem rather than an issue for each instance. There are many, many VBA classes that have default members, so now that we know that default members remain problematic, a small number of examples is sufficient to define the problem.

Having said that, the MSForms.ReturnInteger only has *one* member *and* it is the default member, so it's a good candidate for testing.

SlowLearner

08:25

@Duga Fair 'nuf

Duga

[rubberduck-vba/Rubberduck] Stevefb commented on issue #1868: Code Inspection - Incorrect Diagnosis: Object variable is assigned without the Set keyword

> ```
Private Sub myTextBox_Exit(ByVal Cancel As MSForms.ReturnBoolean)
If True Then
Cancel = False ' Should be Cancel.Value
End If
End Sub
```

^^^^^ Funny, originally this Sub did not actually assign a value to Cancel. RD Flagged Cancel as Unused - so I used it...

Duga

08:37

[rubberduck-vba/Rubberduck] ThunderFrame commented on issue #1868: Code Inspection - Incorrect Diagnosis: Object variable is assigned without the Set keyword

> that `If True Then` statement is looking a little redundant, but yes, ReturnBoolean would appear to be another class with a single (default) member.

So these all have a single member that is also the default member:
```
MSForms.ReturnBoolean
MSForms.ReturnEffect
MSForms.ReturnInteger
MSForms.ReturnSingle
MSForms.ReturnString
```

[rubberduck-vba/Rubberduck] Stevefb commented on issue #1868: Code Inspection - Incorrect Diagnosis: Object variable is assigned without the Set keyword

> Yep. But it looked better than an empty Sub... (was just showing the context as I had it in my program)....

Duga

11:14

[rubberduck-vba/Rubberduck] arggrande opened issue [#1869: [Question] Does Rubberduck support VBA within the O365 Runtimes](github.com/rubberduck-vba/Rubberduck/issues/1869)

> Howdy folks,

Just wondering, as per the question title, if Rubberduck supports the O365 runtimes? I notice when doing the setup that the registry has a slightly different structure, that being;

HKCU/Software/Microsoft/VBA/7.1/Common

There is no addins folder (referenced in the contrib wiki), and no VBE subfolder.

Would appreciate some assistance :)

SlowLearner

12:38

So.... can finally go forward with this.... will work with BitBucket right?! stackoverflow.com/a/37896924/3451115

Hosch250

13:48

@SlowLearner Not sure. It's been tested with GitHub only.

Transcript for