VBA Rubberducking

Mat's Mug

20:00

and... that code shouldn't be in the view

Hosch250

I'm just going to skip the ones that take anything other than RubberduckParserState as a ctor injection.

@Mat'sMug Yeah, I'll look into moving it out.

Mat's Mug

doesn't the project reference Ninject?

you'd have a much easier time working this out with proper DI

hmm looks like it doesn't

Hosch250

Referencing it now.

Mat's Mug

hmm looks like most of 'em only have a RubberduckParserState dependency

still it's better to have it DI'd, so we don't have to worry about breaking the website when we change things in the actual duck

public ParameterNotUsedInspection(VBE vbe, RubberduckParserState state, IMessageBox messageBox)

Hosch250

Yup.

OK, I have it all ready except the user input and the DI.

Mat's Mug

20:08

lol

Hosch250

And it is out of the view.

Mat's Mug

looks at a pile of 4 tires "look, a car!"

good job!

Hosch250

@Mat'sMug Nah, right now, it is more like a car without the tires.

And an empty gas tank.

Mat's Mug

and no engine

Hosch250

The engine is there.

And so is the steering.

Mat's Mug

20:10

well you're on the right path then

keep going!

that's utterly cool :)

Hosch250

The windshield isn't, though.

Mat's Mug

that IMessageBox dependency on ParameterNotUsedInspection smells; it's really a dependency of the quick-fix class

the thing needs a ResultFactory of some sort

actually all inspections should have RubberduckParserState and IInspectionResultFactory dependencies, period.

2.1

for now let's leave it

@Hosch250 walk me through what you're going to do to set up ninject :)

where's your composition root going to be?

(hint: you do not want to re-do this work for every single request)

Duga

20:34

[rubberduck-vba/Rubberduck] ThunderFrame opened issue #1593: Code Explorer should show References to other VBA projects, just like Project Explorer

> ![refs](http://i.imgur.com/TYfQgLD.png)

The visual clue is useful in Project Explorer, but Code Explorer doesn't provide the hint.

[rubberduck-vba/Rubberduck] retailcoder commented on issue #1593: Code Explorer should show References to other VBA projects, just like Project Explorer

> The Code Explorer will do much better than that once we get #950 references dialog redone. :wink:

ThunderFrame

@Duga - Dang - I was just off looking for that one

Mat's Mug

tip: # and then start typing keywords - GitHub finds the number for you ;-)

ThunderFrame

@Duga notice how VBE doesn't put the document name next to Normal project?

Mat's Mug

yeah, well, tough luck

ThunderFrame

@Mat'sMug The clipboard can accomodate multiple formats, but it's up to the consumer to decide which formats it supports and prefers, with text being the simplest. But you can't define more than one type of text format. However, it might be useful to have a Copy as Markdown button that copies text in Markdown format for GitHub or StackExchange.

Mat's Mug

20:45

meh

@Hosch250 @MitropoulosMitropoulos lol, you guys came in at the same time, it looked like HoshMitropoulos was enternig the chatroom!

ThunderFrame

Rubberduck Code Inspections - 5/26/2016 6:39:40 AM 2 issues found.
Type Project Component Issue Line Column
Error Normal (Normal) ThisDocument (Normal.dotm) Option Explicit is not specified in 'ThisDocument' 1 1
Error Project (Document1) ThisDocument Option Explicit is not specified in 'ThisDocument' 1 1

Hosch250

Hi. Just back from a 30 minute walk (including setup and teardown) with my dog.

Mitropoulos Mitropoulos

@Mat'sMug I got an email notification :)

Hosch250

My previous record for it this year was 35 minutes.

Mitropoulos Mitropoulos

I will definitely open up and do new testing as soon as you get 2.0b happening

ThunderFrame

20:47

^ Normal is not acting Normal

Mitropoulos Mitropoulos

I am super pumped

Vogel612

Walk.Setup(Dog);
Walk.Execute();
Walk.TearDown();

Mitropoulos Mitropoulos

Mat's Mug

@Vogel612 phew. you know, Execute(Dog) would have been a disaster.

Hosch250

If you guys execute my dog, you'll have me to deal with.

ThunderFrame

20:48

using Dog {Walk}

Hosch250

And it won't be funny for you. Or rather, you won't be.

Mat's Mug

you'll tear us down

Hosch250

@ThunderFrame Well, she more walks me.

Mitropoulos Mitropoulos

I haven't had a whole lot of time to run more tests lately or keep up with what you guys have been up to: how's it been going?

Hosch250

Pretty much the only thing she doesn't do is look for cars and set the pace too fast for me (she tries).

@MitropoulosMitropoulos Busy.

Mat's Mug

20:49

@MitropoulosMitropoulos there's 6 PR's waiting to be merged... all just today's work

Hosch250

Right now, I'm working on the website.

Mitropoulos Mitropoulos

woooowww

great

ThunderFrame

TTGTW

Mitropoulos Mitropoulos

I haven't been this excited since Ocarina of Time came out (lol)

Hosch250

@Mat'sMug This is where I'm going to load my kernel:

protected void Application_Start()
{
    AreaRegistration.RegisterAllAreas();
    FilterConfig.RegisterGlobalFilters(GlobalFilters.Filters);
    RouteConfig.RegisterRoutes(RouteTable.Routes);
    BundleConfig.RegisterBundles(BundleTable.Bundles);
}

Mat's Mug

20:51

good! in global.asax

Hosch250

Yup.

Now, where in the world will I dispose of it?

Just make that implement IDisposable?

Mat's Mug

no

Hosch250

Isn't there an Application_Stop() method, or something?

Mat's Mug

what do you need to dispose?

whatever

Hosch250

The kernel.

Mat's Mug

20:53

I'm talking about the dependencies

i.e. why do you need to dispose of the kernel

Hosch250

System.Web.HttpApplication

That already implements Dispose--just need to override it.

Mat's Mug

yup

Hosch250

@Mat'sMug Because it implements IDisposable.

Mat's Mug

ok, good, yes.

Hosch250

And to dispose of anything it loads.

Mat's Mug

20:54

but this is a web application, you don't know when the application is going to shut down

if ever

so I'm asking, how will you set up your bindings?

Hosch250

Well, if it ever does, it should be able to dispose.

Mat's Mug

yes, but if that's 1200000 requests after it started, you might have memory issues on the web server

Hosch250

I'm going to inject it into the static class I'm using to get the inspections results.

I made the inspection list static too.

Mat's Mug

there are things you want to keep alive as long as the app is running, e.g. your Mock<VBE>

that's not how OOP works ;-)

Hosch250

Oh, right.

@Mat'sMug I'm pretty sure I need it static so I can call it from the view.

Mat's Mug

20:57

let go of the control over the lifetime of objects - that's the IoC container's job

no. the view can - and should - take it as a model

Hosch250

Oh, OK.

On the other hand, if it is static, doesn't that mean there will be a single instance servicing all calls?

Vogel612

@Hosch250 interleaving is a problem then

Mat's Mug

if it's static, it means there's no instance

Hosch250

Oh, OK.

Vogel612

@Mat'sMug meh. that's not quite right

if you have a static field that means there is only ever a single incarnation

Mat's Mug

20:58

IIRC there's no static class in Java, right?

Vogel612

there is...

it should do the same as in C#

Mat's Mug

anyway, what I'm trying to get to, is that you should bind whatever needs to live for the span of a single request, .InRequestScope()

and the kernel will dispose it as it should, if it has to

Hosch250

Oh, OK.

Vogel612

and stuff that needs to stay around longer can be bound in other scopes

Mat's Mug

yep

Vogel612

21:00

I'm guessing there's a SessionScope and an ApplicationScope in the very least

in The 2nd Monitor, 10 secs ago, by Vogel612

heya there @ScottCraner nice to see you drop by

Hosch250

OK, so what should be in call scope?

The text from the user?

Mat's Mug

isn't that just the model?

Hosch250

Everything else, AFAIK, can be reused between all calls, except the parser.

Vogel612

@Hosch250 you should get that as a Request Parameter. probably a form value

Mat's Mug

^

Hosch250

21:02

Yeah.

@Vogel612 Yeah, I know.

Vogel612

that shouldn't be injected through DI

Hosch250

I know.

Mat's Mug

so, quick recap before I leave work: you set up your kernel in global.asax, tell ninject to take over the controller instantiating, and then you can have constructor parameters in your controllers, and ninject deals with them automatically

that way you can constructor-inject the IInspector or whatever you've got there, into the InspectionsController

Vogel612

you'll need access to both the Parser and the IInspector

because those are decoupled

Mat's Mug

well-executed MVC is such enjoyable code

Vogel612

21:07

> Cause it's easy once you know how it's done, you can't stop now it's already begun, you feel it flooding through your bones, ...

Hosch250

NVM for now.

OK, this is what I need:

I'm going to handle the button click with JS.

How am I going to call into my controller from the JS?

Everything seems to say to use AJAX and post/get calls.

Vogel612

umm... how do I put this...

you don't

Hosch250

OK.

Mat's Mug

HTTP POST 101?

Hosch250

So, how do I call into the controller when a certain button is clicked?

Vogel612

21:11

you use an <asp:button>

Mat's Mug

^

Hosch250

OK.

Vogel612

and bind OnAction

Hosch250

Thanks.

Mat's Mug

@Vogel612 been a while, you sure this isn't ASP.NET stuff?

/webforms

Vogel612

21:12

@Mat'sMug umm... shouldn't it be??

Hosch250

And how am I going to Ninject the controller to the view?

Mat's Mug

you definitely don't

Hosch250

We are using ASP.NET MVC.

Vogel612

okay then you can use that

whatever webforms is, it probably wouldn't have had that

Hosch250

I don't have asp:button.

At least, it doesn't look like it.

Mat's Mug

21:14

just make an <input> and post

or try the toolbox, there's always a toolbox with drag-n-drop things for noobs like me

I'd just post though

like, a basic HTML form that posts text to a url

Vogel612

1

Q: ASP.NET MVC action on button click

I want to take some action on a button click the code is given below---> <% if(Model!=null && Model.Count>0){%> <ul> <% foreach(var Movie in Model) { %> <li> <%= Movie.Id %> <%= Movie.Title %> <%= Movie.ReleaseDate %> <input type="but...

Hosch250

@Vogel612 We aren't using that.

Mat's Mug

the url gets routed to a controller method that takes the text as a parameter, or even a model object

Vogel612

sidenote: that uses the razor and not the XML views

Hosch250

We are using the Razor engine, not the ASP.NET engine.

Mat's Mug

21:16

@Hosch250 we are

Hosch250

Well, we aren't using the one with <%.

Vogel612

lol Razor is ASP.NET

so the XML one?

Hosch250

It shouldn't be that hard to translate it.

We are using the @{} one.

Vogel612

gosh they introduced a third engine?

Mat's Mug

never heard of "the xml one"

Hosch250

21:17

Yeah, I was just reading about it.

Mat's Mug

60

A: ASP.Net MVC 4 Form with 2 submit buttons/actions

That's what we have in our applications: Attribute public class HttpParamActionAttribute : ActionNameSelectorAttribute { public override bool IsValidName(ControllerContext controllerContext, string actionName, MethodInfo methodInfo) { if (actionName.Equals(methodInfo.Name, String...

lol

Hosch250

Oh, we aren't using ASPX.

Vogel612

dooode

Hosch250

Oh, this looks easy.

Mat's Mug

ASPX is the ASP.NET / WebForms engine

Hosch250

21:18

Then what is all that?

Vogel612

okay microsoft really needs to stop doing the same things in like... 20 different ways

Hosch250

We aren't using the one with ASPX files.

Mat's Mug

never heard of the bottom two

Hosch250

That is the most prevalent one, though, and has been driving me absolutely nuts.

@Mat'sMug I've heard of Spark, but never knew what it was.

Mat's Mug

but hey last time I wrote MVC, .net 3.5 was all the hype

Vogel612

21:19

Spark sounds suspiciously java

Hosch250

But then, I didn't know what Razor and ASPX was either.

Mat's Mug

you gotta understand the role of the controller, the view and the model though

esp. the controller :)

it exposes methods that the routing engine routes requests to

that's very much coupled with what the request url looks like

so /Foo/Bar/42 calls method Bar of controller Foo and passes parameter 42 to it

Hosch250

OK.

Mat's Mug

that's HTTP get

here you'll want to mark the controller method with an HTTP post attribute

Hosch250

And pass the text in JSON format

Mat's Mug

21:23

so that it can only resolve for a post request

or whatever you like

but yeah

so the controller receives the request, processes it, and issues a view (with a model)

Hosch250

So, basically, I just build another view that it loads and returns?

Vogel612

I personally like the xml view engine better

Hosch250

And embed it in the page?

Vogel612

I find it cleaner

Hosch250

@Vogel612 Yeah, that is the one with .aspx views.

Mat's Mug

21:28

@Vogel612 the problem with .aspx is that it tended to create literally unreadable views littered with <% tags

razor fixed that

@Hosch250 depends what the view is

you could return a partial view

gotta go

Hosch250

Like the Inspections page itself?

See you.

That is embedded in the layout page.

Mat's Mug

yeah that makes sense

TBH I need to foster my knowledge of the actual mechanics behind this, there's a big chunk that's complete magic for me

Hosch250

@Vogel612 Do you know how to tell Ninject to load the controllers?

Vogel612

not the slightest clue

I didn't even work with ninject back in the day

Mat's Mug

there's an extension specifically for mvc, and the wiki is extremely well done

Hosch250

21:37

Everything is coming along beautifully, but it crashed when it tried to load the controller because it doesn't have a parameterless ctor.

@Mat'sMug Thought you were gone.

I'll take a look.

Mat's Mug

leaving

Hosch250

Are we on MVC 5? MVC 3?

Mat's Mug

@Hosch250 that's because it's still the default controller factory creating the controllers - you want to change that to Ninject's controller factory

Hosch250

5.2.3

Mat's Mug

probably 5

Hosch250

21:39

Yeah, that's what I was asking how to do.

So, I uninstall the other Ninject now?

Mat's Mug

uh, no. it's an extension, goes on top of it

Hosch250

OK.

This should do it: github.com/ninject/ninject.web.mvc/wiki/…

Mat's Mug

lol I was going to drop you a link exactly to that url

see, it does everything for you :)

Duga

[rubberduck-vba/Rubberduck] PeterMTaylor commented on issue #1585: Tell me about implicit conversions

> Not at all. Plus one for this suggestion to user or refactor option.

Hosch250

Oh wow, just installing the thing fixed it.

Literally the only thing left is styling the form and formatting the output.

Duga

21:50

[rubberduck-vba/Rubberduck] Hosch250 commented on issue #1585: Tell me about implicit conversions

> I vote for customizeable here.

Hosch250

@Mat'sMug Any idea why this is injecting an empty enumerable?

public InspectionsController(IEnumerable<IInspection> inspections)

Vogel612

use IInspector

Hosch250

private void BindCodeInspectionTypes()
{
    var inspections = Assembly.GetAssembly(typeof(InspectionBase))
                              .GetTypes()
                              .Where(type => type.BaseType == typeof (InspectionBase));

    // multibinding for IEnumerable<IInspection> dependency
    foreach (var inspection in inspections)
    {
        _kernel.Bind<IInspection>().To(inspection).InSingletonScope();
    }
}

That finds them all.

Vogel612

that one's preconfigured and also handles special inspections correctly

Hosch250

Oh, OK.

Duga

21:57

[rubberduck-vba/Rubberduck] comintern commented on issue #1585: Tell me about implicit conversions

> I think I'd personally leave out warning about implicit conversion from anything -> Variant (or customizable). There are so many functions that take Variants in VBA that you wouldn't be able to see the code for the CVar()s.

Hosch250

22:13

It can't find IInspector.

This is weird.

ThunderFrame

overkill?

that would work in 2007+

Hosch250

Looks awesome.

Can you use the same icons we use, though?

ThunderFrame

no, I'm constrained to the built-in icons, when using Conditional formatting.

Hosch250

OK.

Vogel612

@Hosch250 github.com/rubberduck-vba/Rubberduck/blob/next/RetailCoder.VBE/…

Hosch250

22:21

@Vogel612 I know where it is.

It doesn't work even when I explicitly bind to it.

Vogel612

wat.

Hosch250

Right now, it is saying cyclical dependency.

ThunderFrame

IDK - maybe I could inline custom images in the XML.... Otherwise it's definitely possible with the Open XML clipboard format (aka a zip file like a mini xlsx), but we'd need to nuget the Open XML SDK (which we'll probably need to do anyway, at some point)

Vogel612

@Hosch250 that's interesting ...

Hosch250

I can get the exact types out, but every time I bind, it messes things up.

Oh, I'm loading it in the wrong spot.

github.com/ninject/Ninject.Web.Mvc/wiki/…

Hosch250

22:47

Got it.

> Move module-level variable 'bar' to a smaller scope. Suggestion

'TestModule1' has more than one '@Folder' annotation. Error

Consider renaming project 'TestProject1' Suggestion

Consider renaming module 'TestModule1' Suggestion

variable 'bar' is not used Warning

Option Explicit is not specified in 'TestModule1' Error

Look at that.

4

The website generated that.

I have three inspections disabled for now--Active Sheet, Active Workbook, and Parameter Not Used.

Those three inject the VBE, but I need to create that each time to set the component text.

Parameter Not Used shouldn't need it...

The other two are Excel specific, so I'm not planning on re-enabling them.

At least not until I let the user say which host they are running it on.

Once I get this done, we could even let the user experiment with the tests and refactorings.

Well, no, not the tests--yet.

Return value of function 'Foo' is never used.	Warning	CodeQualityIssues
Move module-level variable 'bar' to a smaller scope.	Suggestion	MaintainabilityAndReadabilityIssues
'TestModule1' has more than one '@Folder' annotation.	Error	MaintainabilityAndReadabilityIssues
Consider renaming project 'TestProject1'	Suggestion	MaintainabilityAndReadabilityIssues
Consider renaming module 'TestModule1'	Suggestion	MaintainabilityAndReadabilityIssues
Return value for member 'Foo' is never assigned	Error	CodeQualityIssues

ThunderFrame

23:05

Hmm. Visio let's me add a test module using the RD menu, but adding a Test method is not enabled.

Hosch250

@ThunderFrame No, running it isn't enabled.

We really should check if running isn't allowed and disable that feature.

Or rather, leave a menu item in that gives a popup prompting them to help us out if they want it.

ThunderFrame

@Hosch250 project is not running

Hosch250

Huh?

Weird.

On a happier note, I just made it accept user input.

On a sadder note, the first time I run it, it always fails at Parsed.

ThunderFrame

Oh, how do you check for is running? This is Visio 2002, so it's VBA 6. Are you inspecting a command bar? Maybe the command bars changed???

Hosch250

What isn't running?

OK, I fixed the resolve not finished problem.

I just committed it just in case something happens.

The only thing that is left is formatting the output.

And formatting the input block.

Hosch250

23:41

@Mat'sMug Feel free to PR/merge that any time and take over.

Literally all it needs is a couple UI tweaks (I think).

And Parameter Not Used needs to stop using the VBE and be reenabled

10 minutes to go and supper time. BBL.

ThunderFrame

^ Tests in Visio!

and Visio doesn't have Application.Run...

teases with a long pause

`Document doc = Application.Documents[qualifiedMemberName.QualifiedModuleName.ProjectDisplayName];`
`var call = GenerateMethodCall(qualifiedMemberName);`
`doc.ExecuteLine(call);`

markdown fail

Transcript for