« first day (718 days earlier)      last day (2462 days later) » 

11:01 PM
Or keep it but change child nodes icon to something that says "we think this might be here but it might not be", like some yellow exclamation mark icon
 
Hey, that's a brilliant idea.
 
I know, I know, I get those every now and then :-)
(and then things get spaghetti-like once I start implementing them, but that's another story)
 
@Hosch250 Are those Sheet and Project display-names (the host's names for Project and Worksheets) only in your branch? I've added a DisplayName property to QualifiedModuleName in my branch.
 
@ThunderFrame Nope. They are in Next.
If you touch anything related to the Code Explorer, I'll murder you.
3
That's my feature I'm making some major changes, and don't want merge conflicts.
 
lol
@ThunderFrame cool, so I'm not the only one having a hard time keeping up with all changes going on. Damn the project is moving FAST!
 
11:11 PM
Where do you build that name, I would have thought QualifiedModuleName was the perfect place?
@Hosch250 because Inspection Results could use the same property.
 
In the node VM.
 
@Hosch250 parenthesizedname?
 
Yeah, something like that.
 
OK, I'll carry on, but IMO Code Explorer can use the QualifiedModuleName DisplayName property, when I PR and you are ready. DisplayName is the name the SDK uses to describe that VBE UI candy.
 
@ThunderFrame Yep.
I'll be done in just a little bit.
 
11:20 PM
Avoids being shot and murdered...
2
 
@ThunderFrame fwiw I agree with this
 
I do too. I just don't want merge conflicts.
 
Refactoring the Indenter makes me feel like I'm code golfing...
4
 
I currently have merge conflict debt :-/
 
[Hosch250/Rubberduck] Hosch250 pushed commit de1b644c to Branch1: Correctly display error nodes.
[Hosch250/Rubberduck] Hosch250 pushed commit 66404472 to Branch1: Merge branch 'Branch1' of github.com/Hosch250/Rubberduck
 
11:28 PM
300 lines of code worth of managing state variables in the main parsing loop just evaporate once you have a LogicalCodeLine class...
 
@Hosch250 That BuiltInDocumentProperties property is only in some hosts. I think my approach is more host agnostic.
 
@ThunderFrame Awesome.
 
@Comintern wooot!!
 
[Hosch250/Rubberduck] Hosch250 pushed commit 3f3f478c to Branch1: Allow importing from a folder node
 
This is what happens when you don't pay me by lines of code.
 
11:31 PM
lol
I need to get a quote on Rubberduck swag
 
Coders should be paid by LoC removed
 
@Comintern yeah, the spec makes a point of logical lines. Do you bother breaking those up into logical statements?
 
Shouldn't be necessary for indenting
 
@Vogel612 - Within reason... you don't want stuff like this in production code:
#define P printf(
#define O(x) P"%d) Pour from %dL jug into "x"\n"
#define S P"5L: %d, 3L: %d, T: %d\n",F,H,g);}
F,H,s,g,x;l(j){P"%d) Fill %dL jug\n",++s,j);St(j,o,m){O("%dL jug"),++s,j,(j^5)?5:3);Se(j,i){O("tank"),++s,j);Smain(){scanf("%d",&x);while(x>4&&x^6&&x^9){x-=5;l(F=5);g+=5;e(5,F=0);}while(x>2){x-=3;l(H=3);g+=3;e(3,H=0);}(x^2)?(x^1)?0:(l(H=3),t(3,H=0,F=3),l(H=3),t(3,H=1,F=5),g++,e(3,H=0)):(l(F=5),t(5,F=2,H=3),g+=2,e(5,F=0));P"Volume measured out in %d turns",s);}
 
@Comintern simple solution: require linting in SC
no cheating on lines then
 
11:35 PM
[Hosch250/Rubberduck] Hosch250 pushed commit 67104dbb to Branch1: Get rid of CodeExplorerErrorNodeViewModel
 
@ThunderFrame - I have an AbsoluteCodeLine, which is the incoming text. It gets split into multi-line segments (delimited by ": "), and a LogicalCodeLine is a set of AbsoluteCodeLines joined by continuations ("_ ").
 
simpler solution: "fuck you, pay me" - regardless of how many lines added/removed, regardless of whether the project is sinking because of a nutty PM or ever-changing requirements
 
LOL!
 
@Mat'sMug gg no re, GEMA block in Germany
 
11:39 PM
@Vogel612 wut?
it's just a conference about freelancing and, well, getting paid.
 
> Dieses Video ist in Deutschland leider nicht verfügbar, da es Musik von UMG enthalten könnte, über deren Verwendung wir uns mit der GEMA bisher nicht einigen konnten.
 
translate: Dieses Video ist in Deutschland leider nicht verfügbar, da es Musik von UMG enthalten könnte, über deren Verwendung wir uns mit der GEMA bisher nicht einigen konnten.
(from German) This video is not available in Germany unfortunately, because it could contain music by UMG about using them we have not agreed with the GEMA.
dafuq
 
Waits for my paycheck
 
the better translation for "könnte" in this context is probably "might"
 
11:42 PM
also it's waayyy too complex language.
 
[Hosch250/Rubberduck] Hosch250 pushed commit 938f5bc5 to Branch1: Set child member icon to exclamation when parent component has error
 
> Dieses Video ist in Deutschland nicht verfügbar. Es enthält vielleicht Musik von UMG. Wir konnten uns mit der GEMA nicht über die Musik einigen.
 
@Hosch250 awesome!
 
That skeleton doesn't look realistic.
 
11:43 PM
hint: it's not really a decomposed technician
 
So given this code:
 
I know, but the more realistic the better.
 
Enum Foo: X as Integer: End Enum: Enum Bar
Y as Integer
End Enum
Do you intent the second line?
 
good question
surely you shoot whoever wrote that though
2
 
There's an awful lot of murderous talk today.
3
 
11:46 PM
@Comintern do you?
I think I wouldn't
 
I think I would.
 
I never use multi-lines
 
mod-closes as opinion-based
 
> Completely revise error node concept.
Allow importing component while on folder node.
 
Yeah, I know there are merge artifacts--just too lazy to go cherry-pick them into a different branch.
 
11:47 PM
Clear built-in declarations' references (#1579)

* Close #1574

* Clear built-in declarations' references.
[Hosch250/Rubberduck] Hosch250 pushed commit d1609b94 to Branch1: Merge branch 'next' into Branch1
 
@Comintern I think we'd actually need a "golfed code" inspection.
> Dude, this is VBA. If you want golfed code, pick another language. These go on multiple lines. Thank you.
 
How about MessageBox.Show("*pimp-slap*");?
 
lol
 
> Here we come to destroy your fun.
 
Could add an option to split multi-lines.
Also to split long lines with continuations.
 
11:50 PM
that'd be nice.. I think.
 
Optional of course. With a setting for maximum line length without continuations.
 
Replace : with \r\n?
 
Some people like the Dim Foo as Bar: Set Foo = New Bar idiom.
 
@Hosch250 except it gets complicated, now that we know that we can't always do that without breaking the code
 
Right, like in string literals.
 
11:52 PM
I pull out all the string literals and replace them with placeholders before I do anything.
 
[rubberduck-vba/Rubberduck] build for commit 938f5bc5 on unknown branch: AppVeyor build succeeded
 
@ThunderFrame Once that PR gets merged, feel free to change the CE stuff.
It can really be merged any time now--the current one is just building a pull from next.
 
Luckily this isn't a valid case, or I'd be screwed:
 
yeah but then I'll get @Duga screaming at me
 
Public Foo(): Debug.Print "Foo": End Sub: Public Bar()
Debug.Print "Bar": End Sub
 
11:55 PM
that's a case for MsgBox "You gotta be kidding me?!"
 
Public Sub Foo(): Debug.Print "Foo": End Sub is valid, but that should never get indented.
The multi-line followed by a line continuation is the other weird corner case:
 
OK, mergeable.
 
Public Sub Foo(): Debug.Print "Foo": _
End Sub
 
[rubberduck-vba/Rubberduck] build for commit d1609b94 on unknown branch: AppVeyor build succeeded
Code Explorer Tweaks (#1581)

* Close #1574

* Clear built-in declarations' references.

* Correctly display error nodes.

* Allow importing from a folder node

* Get rid of CodeExplorerErrorNodeViewModel

* Set child member icon to exclamation when parent component has error
 
@Comintern that shouldn't be indented either
 
11:58 PM
> Please check the CE problem on the latest commit.
 
I think the line continuation should get removed in those cases. It's completely redundant.
 
right
isn't the colon redundant as well?
 
Yeah, I guess it is.
 

« first day (718 days earlier)      last day (2462 days later) »