VBA Rubberducking

Duga

00:00

RELOAD!

[rubberduck-vba/Rubberduck] 5 commits. 2 opened issues. 2 closed issues. 19 issue comments. 18296 additions. 24934 deletions.

[rubberduck-vba/Rubberduck] grleachman synchronized pull request #1564: Changes for #1225 ExtractMethodRefactoring

g leachman

@Mat'sMug so that's a merge onto the latest greatest next

Duga

[rubberduck-vba/Rubberduck] build for commit 0a1660c4 on unknown branch: AppVeyor build failed

BUILD FAILURE!

awgaya

hmm I added NLOG to the VBEditor project but the build server doesn't seem to find it

Mat's Mug

the 3 failing tests are supposed to fail?

@awgaya AppVeyor seems to randomly fail to deal with Nuget packages

awgaya

there shouldn't be any failing tests, there are 4 ignored tests though

any idea how to deal with that nuget failure then?

Hosch250

00:15

Well, I kind of object to the private methods things, but...

Would internal work? I can set a flag to give the test project access to the guts of the other projects.

g leachman

@Hosch250 it's already set

Hosch250

Oh, OK.

Well, go ahead and test things. I already did blackbox testing on most of the other refactorings.

There aren't any tests for Extract Interface because it calls an asynchronous reparse.

g leachman

aaah

no it's not

Hosch250

I couldn't get the test to wait for everything to finish before reporting the result.

I manually tested Extract Interface pretty thoroughly, though, so I'm not too worried about it.

After 2.0, I'm going to make them all work off the parse tree instead of the code pane text, so it shouldn't be an issue.

g leachman

something like StartNew( () => { EverythingToRun .. }).ContinueWith

Is there a way for me to find blocks of code, within if statements and while statements and loops. and switch / case statements?

Mat's Mug

00:33

@ThunderFrame I answered that SO question

g leachman

Just some useful stats:

Mat's Mug

> Pre-exception error handling in the language isn't the only thing responsible for spaghetti code.

g leachman

Entire solution : 59.32%
SettingsProvider: 0%
SourceControl : 5.46%
SmartIndenter : 33.24%
VBEditor : 34.81%
RubberDuck: 34.47%
Parsing 60.50%

Is the code coverage of Rubberduck at the moment

bollocks 2am, and I have to finish moving home tomorrow

Night all.

:) Ncrunch rules

ncrunch.net

Mat's Mug

night!

hey coverage isn't too bad after all :)

> Ranting on the "stupid error crap" is fine (I'd much rather deal with exceptions too), but not when your code has unused parameters, ambiguous return types and poor naming.

g leachman

01:04

refactorings : 80%

Inspections 63%

Todo: 58%

Navigation 50%

UnitTesting: 44%

Testing : 42%

Common: 22%

UI 18%

No. Coverage is actually very good for important things.

What knocks the stats is

the grammar tests

Mat's Mug

"knocks"?

ThunderFrame

01:40

knocks/rocks/skews

@Mat'sMug yep, I was going to answer it, but there were lawns to mow...

Hosch250

03:23

@gleachman Oh, awesome.

@gleachman BTW, I'm going to have to ask you to not white-box test any of the other refactorings or quick fixes--for now.

I'm going to completely re-write those after we get 2.0 out, and I don't want to have a zillion white-box tests breaking on me and getting me mixed on what is broken and what isn't.

Also, I'll learn white-box testing and do it myself then.

That is, unless I have a very good reason to not white-box test them.

If you want to write more black-box tests, though, I'll be happy about that.

@gleachman I did that :) AFAIK, there are only two not thoroughly tested--Extract Interface and Extract Method.

You are doing the one, and I'll look into doing the other with the task thing.

Mat's Mug

> Error 2 File 'UI\NoOverflowToolbarStyle.xaml' cannot be found. Rubberduck

Hosch250

@Mat'sMug Yup, I killed it.

It wasn't doing anything.

Mat's Mug

okay, I'm missing pieces somewhere then

Hosch250

I don't know what's up there, looks like it wasn't removed from your .csproj correctly.

Just tell it to delete it, and you'll be fine.

I don't know what's up there, TBH--I deleted that last week.

Checking out the With thing?

Can we release next week if it is working?

Mat's Mug

if I can end up building the damn thing, perhaps

Hosch250

03:38

Don't swear at your kid.

Mat's Mug

lol

so.. is IParseTreeInspection supposed to exist?

Hosch250

I think so.

Mat's Mug

I don't have it here

I'm missing commits or something

Hosch250

I think @Vogel612 introduced it when he got the listeners out of the parser.

@Mat'sMug You need to do a hard pull.

Mat's Mug

mkay

Hosch250

03:43

I don't know how to do it exactly, but it is something about rebasing to Next.

Either that, or try "git pull upstream next" and see what happens (or both).

Mat's Mug

error: You have not concluded your merge (MERGE_HEAD exists).
hint: Please, commit your changes before merging.
fatal: Exiting because of unfinished merge.
C:\Users\Mathieu\Documents\GitHub\Rubberduck [rubberduck-vba-next +16 ~20 -1 | +3 ~0 -0 !]>

Hosch250

Commit and sync.

Mat's Mug

commit a broken build?

Hosch250

Well, no. Revert your changes.

IIGR, you just changed the .csproj.

(If I'm guessing right.)

Mat's Mug

but it's not conflicted

Hosch250

03:46

What's not conflicted?

Mat's Mug

I'm undoing the merge

the .csproj

Hosch250

Doesn't need to be.

It just needs to have uncommitted changes to cause it to abort.

I'd recommend you just rebase to upstream next.

Mat's Mug

C:\Users\Mathieu\Documents\GitHub\Rubberduck [rubberduck-vba-next +16 ~20 -1 | +3 ~0 -0 !]> git pull upstream next
fatal: 'upstream' does not appear to be a git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
C:\Users\Mathieu\Documents\GitHub\Rubberduck [rubberduck-vba-next +3 ~0 -0 !]>

Hosch250

You didn't set upstream.

git remote add upstream github.com/rubberduck-vba/Rubberduck.git

Mat's Mug

...already up-to-date?

...already : The term '...already' is not recognized as the name of a cmdlet, function, script file, or operable
program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At line:1 char:1
+ ...already up-to-date?
+ ~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (...already:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

Hosch250

03:50

What in the world are you entering to your command line?

@Mat'sMug OK, do this:

Mat's Mug

lol

Hosch250

First: open the Git command prompt, if it isn't open.

If you didn't set upstream yet, enter this:

git remote add upstream github.com/rubberduck-vba/Rubberduck.git

Mat's Mug

yeah did that

Hosch250

Next, create a new branch. I always do this from VS 2015 because I can tell it to not track the remote repo.

I don't know the command line for that.

Base if off upstream next.

If you can't find it, enter git checkout upstream (I'm pretty sure that is the command) into the command line.

Then, checkout your new branch.

Finally, run git pull upstream next.

That should bring you up-to-date.

Mat's Mug

\GitHub\Rubberduck [next-pr +3 ~0 -0 !]>

C:\Users\Mathieu\Documents\GitHub\Rubberduck [next-pr +3 ~0 -0 !]> git pull upstream next
From github.com/rubberduck-vba/Rubberduck
 * branch            next       -> FETCH_HEAD
Already up-to-date.
C:\Users\Mathieu\Documents\GitHub\Rubberduck [next-pr +3 ~0 -0 !]>

Hosch250

03:53

What command line are you using?

Mine doesn't show the change thing like that.

Duga

[rubberduck-vba/Rubberduck] build for commit e6e991d0 on next: AppVeyor build succeeded

Mat's Mug

powershell

Hosch250

I use the ordinary Windows command prompt opened by VS.

Mat's Mug

well [next-pr] is up-to-date and builds

Hosch250

Awesome.

Duga

04:13

[rubberduck-vba/Rubberduck] build for commit e6e991d0 on next: AppVeyor build succeeded

Peter M Taylor

05:39

Good job guys!

Peter M Taylor