Just thought I'd drop in and give you a kudos on the parser. I just have the misfortune opportunity to see if Rubberduck would parse the line For Polka = Pause To Step Step Step. No problem.
I still need to do a build from the current source at work - I let it spill that I knew VBA, so now I'm working on some ancient code that won't parse. Some really nightmarish stuff...
What's the deal with the smart indentation I'm seeing above? That's actually one of the things that I just re-wrote in the nightmarish VBA that landed on my desk.
I made a "first pass" at a C# rewrite/translation, but back then the settings weren't done yet so I moved on to other issues and haven't got back to it yet
That might be something I could take a look at. I'm curious to see what somebody else's implementation looks like. I'll also need to do the same thing on my pet project eventually.
It's basically just a simple hierarchy counting problem - one set of tokens indents a level, one set of tokens outdents a level. The only real wrench are lines like If Foo Then Bar Else Baz or For i = x To y: Debug.Print i: Next. Does the C# translation run on top of the parser, or beside it?
ObsoleteLetStatementListener doesn't seem to even run
looks like the CombinedParseTreeListener isn't exactly working
> If you want to trigger events in multiple listeners during a single tree walk, you can use the ParseTreeDispatcher object available at github.com/antlr/antlr4/issues/841
I don't think it can work, the "run" call must be returning to Rubberduck for it to work
@Duga I love it when we're their first star :)
the failing tests are probably all for the same reason
I'm looking at OptionExplicitInspectionTests - the inspection is only seeing 1 class module in UserDeclarations, yet the test is defining two
wait a minute
Debug Trace:
ClearDeclarations(Class1): succeeded
ClearDeclarations(Class1): succeeded
Module 'Class1' state is changing to 'Pending' (thread 10)
RubberduckParser handles OnStateChanged (Pending)
Module 'Class1' state is changing to 'Parsing' (thread 9)
ParserState changed to 'Parsing', raising OnStateChanged
uh, it's working off a MockParser that's returning a RubberduckParser??
oh
duh
Resolving 'Class1'... (thread 8)
Module 'Class1' state is changing to 'Ready' (thread 8)
ParserState changed to 'Ready', raising OnStateChanged
RubberduckParser handles OnStateChanged (Ready)
RubberduckParser handles OnStateChanged (Ready)
'Class1' is Ready. Resolver took 0ms to complete (thread 8)
RubberduckParser handles OnStateChanged (Ready)
ClearDeclarations(Class2): succeeded
ClearDeclarations(Class2): succeeded
Module 'Class2' state is changing to 'Pending' (thread 10)
RubberduckParser handles OnStateChanged (Ready)
Each time I start the VBE in Excel I get this error: 
First I thought there were no hotkey settings but when I check them I have these settings. 
Some questions about the hotkeys: How can I use the Tab key or similar keys in the Hotkey set
> Try deleting your configuration file, there should be more than 2 hotkey settings. As for keys needing a modifier and possible misconfigurations, .....it's on the user for now (no, tab can't be used)
> Included changes and fixes by @retailcoderfrom github.com/Vogel612/Rubberduck/pull/1 . As per their comment it's ready to merge (and I won't object) :smile:
Failed parserDeclarations_ExcludeBuiltInDeclarations
Error Message:
Test method RubberduckTests.RubberduckParserTests.parserDeclarations_ExcludeBuiltInDeclarations threw exception:
System.ArgumentException: An item with the same key has already been added.
Stack Trace:
at System.ThrowHelper.ThrowArgumentException(ExceptionResource resource)
at System.Collections.Generic.Dictionary`2.Insert(TKey key, TValue value, Boolean add)
at Rubberduck.Parsing.VBA.RubberduckParser.ParseAsync(VBComponent component, CancellationToken token, TokenStreamRewriter rewriter) in C:\projects\rubbe…
Title says most of what you need to know, really. Mass of text from Column C onward in each row may contain the names of countries, which I want to pull into the corresponding cell in row A. What I have so far is not pretty...
Sub PullCountries()
Dim Rng As Range
Dim Block As Range
Dim i As Long...
> 1. The "for next statement" can now have more than one type hint which caused an exception. Not quite sure why it's checking the parent for the type hint though since in the case of a "for next statement" the declaration of the variable including type hint could have happened somewhere else? 2. The other cases are mostly just switching the check from ParserState.Parsed to ParserState.Ready. The ToDoExplorerViewModel previously reloaded the configuration once per module which made...
I've been meaning to ask this since vogel opened his PR. Do the performance improvements of making the parser multithreaded really outweigh the added complexity?
I'm sorry about not contributing very much lately. I don't know why, but I just don't seem to want to open my IDE. Probably need more sunlight (I hear lethargy can be caused by a lack of Vitamin D, which is produced when you are exposed to sunlight).
@Hosch250 I'll remind you that you implemented nothing less than 80% of the refactorings in Rubberduck 2.0, including 100% of the new ones. Plus everything else. You deserve whatever break you want to take! :-)
@awgaya basically, yeah. ThunderFrame says there is a bug with indenting enum members named after a keyword (probably UDT members too then), perhaps we can fix that
@Hosch250 and I'm sure they're easy fixes for the most part ;-)
Instead of reading indenter settings from the registry we're storing them in our config file; the indenter should be ctor-injected with an IIndenterSettings instance
@awgaya feel free to scrap everything I did if need be :-)
Note, the settings window needs to run it to show and update a preview box, so that's something to keep in mind
The only hard requirement is that it does everything the VB6 code does - and ideally we should even detect a SmartIndenter install and import the settings from the registry
Since you need to understand the code, you may as well indent it yourself.
Seriously: To efficiently review a bunch of code, I find fixing the indents "by hand" is helpful. So I don't see any value in a code beautifier. Here are the steps I recommend:
Open the VBA module you'll be fixing....
hmm well the "then resolve references" part could easily be threaded, no? I mean, as long as a Declaration's References can be safely added to concurrently...
oh but it makes the method return before it's resolved and that is what breaks the tests
hmm
@Vogel612 would it stink to have a private _resolveSynchronously field that's true when the synchronous parse method is called (it's only used by unit tests), and false otherwise?
> Rubberduck.Setup.1.4.3.0.exe (4.32MB) - Downloaded 2497 times. Last updated on 2015-07-08
Valar Codaeris - all men must code https://twitter.com/CommitStrip/status/715961677485907968
@Mat'sMug iiuc, VBE doesn't pre-compile changes to a logical line until the user moves out of the line. RubberDuck could hook LL key presses, but only trigger a parse when a line is changed? Because parsing an incomplete line change is expensive and prone to parser error if the user is only half done.
Iirc, there's an event for a module change (because module change can be triggered by key presses, pastes, menu actions, adding control events, VBA that automates the VBE, etc.), but maybe that event was something I saw in the SDK.
Since you need to understand the code, you may as well indent it yourself.
Seriously: To efficiently review a bunch of code, I find fixing the indents "by hand" is helpful. So I don't see any value in a code beautifier. Here are the steps I recommend:
Open the VBA module you'll be fixing....
VBA Rubberducking
VBA Rubberducking