VBA Rubberducking

Duga

00:01

RELOAD!

[Cardshifter/Cardshifter] 14 commits. 1 opened issue. 3 issue comments. 348 additions. 124 deletions.

[Hosch250/Rubberduck] 21 commits. 8801 additions. 2822 deletions.

[rubberduck-vba/Rubberduck] 23 commits. 1 issue comment. 6404 additions. 2676 deletions.

[Vogel612/JavaBot] 1 commit. 1 deletion.

[Vogel612/TranslationHelper\‌] 2 commits. 1 opened issue. 1 issue comment. 42 additions. 3 deletions.

Phrancis

Good job duckies :)

Mat's Mug

02:00

Wow that code pain factory is a mess

Not your fault @Hosch250, you did exactly as I told you - there's one place I think is really problematic: QualifiedSelection shouldn't have that Select method.

I think that's a violation of SRP, and it really looks like it's what's making everything so painful

I'm refactoring that part

Hosch250

03:14

@Mat'sMug Have fun, that select method is used everywhere.

Mat's Mug

6 places actually

Hosch250

Huh?

Weird.

Mat's Mug

all recent code

Hosch250

I was sure I saw it all over the place.

In my refactorings, maybe?

Mat's Mug

no clue

Hosch250

03:15

OK.

Mat's Mug

well

all refactorings actually

the hard part isn't removing these calls... it's replacing them with what it should be

that's breaking a ton of code

and I'm down to 1 error in 1 file before I can build and test

:)

and...

that last spot is the ParameterNotUsedInspection

public ParameterNotUsedInspection(IRubberduckCodePaneFactory factory)

you realize that inspections are instantiated via reflection?

Hosch250

Oops.

I think I have that in a few of them.

Mat's Mug

I'm surprised things didn't blow up

but none of these inspections actually run

Hosch250

I never tried to run my inspections.

Mat's Mug

that's for sure

    public ParameterNotUsedInspection()
    {
        _factory = new RubberduckCodePaneFactory();

coupling is fine here, until something other than pure reflection is instantiating those

Hosch250

03:22

What about DI?

That is going to be a terrible nuisance for testing.

Mat's Mug

v1.5 is exactly why we're doing this

Hosch250

Talking about DI, sometimes when I see some code I wonder if the writer didn't DI all the way and not even create any variables.

Mat's Mug

like what?

Hosch250

Oh, when you have 9+ parameters in the constructor.

Mat's Mug

that's usually SRP taking a beating.

usually some of the 9+ parameters have something in common - they're really 3-4 groups of 2-3 parameters

and each of these "groups" ought to be an object of its own

Hosch250

03:26

public GenericProjectNameInspection(IRubberduckCodePaneFactory factory)
public MultipleDeclarationsInspection(IRubberduckCodePaneFactory factory)
public OptionBaseInspection(IRubberduckCodePaneFactory factory)
public OptionExplicitInspection(IRubberduckCodePaneFactory factory)
public ParameterNotUsedInspection(IRubberduckCodePaneFactory factory)

Those are the 5 that need updating.

Mat's Mug

thanks

Hosch250

I would do it for you, but it would probably create a conflict.

Mat's Mug

yeah don't. thanks

Hosch250

I guess I don't have anything to do, so I'll go read until I can get ready for bed.

Want to ask me anything before I go?

Mat's Mug

yeah.. for tests you'll be writing in the future, make sure the name acts as a documentation of what a feature is supposed to be doing - not just what the test is taking in

Hosch250

03:29

OK.

Mat's Mug

RemoveParametersRefactoring_LastEventParamRemoved_ParamsHaveDifferentNames_TwoHandlers

Hosch250

So, I'm stating what I'm testing there. What would be a better name?

Mat's Mug

what are you expecting out of it?

Hosch250

A success?

Mat's Mug

lol

Hosch250

03:31

UnitBeingTested_SpecificFeature_TestData_TestData

When I see the test fails, I know exactly what the test is covering.

Mat's Mug

and that's good - maybe that was a bad example

Hosch250

ParamsHaveDifferentNames actually is bad.

Mat's Mug

it does remove the last parameter right

RemoveParametersRefactoring_LastInterfaceParamRemoved

the test class is RemoveParametersTests

tests don't need to start with RemoveParametersRefactoring_ ;-)

Hosch250

I meant that the params have different names than the event params.

@Mat'sMug The TestExplorer doesn't use a nice tree like R#.

So, it is nice to see exactly what happens in there too, but yeah...

Someone on VS2015 should send a frown.

OK, is that it?

See you later then.

Mat's Mug

later!

you can group tests by class in the vanilla test explorer ;-)

Rossco

03:50

@Mat'sMug really quick question....

Mat's Mug

sure

Rossco

Do you know if your Antlr grammar is being built when your solution is recompiled?

i.e. on Appveyor?

Mat's Mug

it's not

Rossco

So you're building it and then adding it as a dll reference to the project?

Mat's Mug

build action is set to none

Rossco

03:51

no .g4 files.

ok .g4 files in solution but not compiled.

Mat's Mug

I have the .g4 in the solution, so that it's under source control

Rossco

ok, I've been tearing my hair out wondering why AppVeyor will not compile my project.

Seems that the Antlr4Compile task does not execute.

Mat's Mug

hmm that's likely

Rossco

Which means that the compiled library is missing all my types 8(

Its weird though, since the compile task is conditional on the targets file being present. Which seems to be part of the nuget package.

Mat's Mug

requires java IIRC

Rossco

03:54

Yeah, is that not available on AppVeyor?

Mat's Mug

no idea, Chris set it all up

probably though

@Hosch250 also, Assert.AreEqual(null, foobar) should be Assert.IsNull(foobar), and Assert.IsTrue(false) should probably be Assert.Fail(), or Assert.Inconclusive().

Rossco

Ok, cool. Thanks Mat.

Will do more research, now that I know what seems to be the problem.

Mat's Mug

np

Rossco

At first I couldn't get the projects to build in the correct order. Now that is sorted, I see what the actual problem is.

Rossco

04:12

Hmmm...

ci.appveyor.com/project/rossknudsen/vba-language/build/…

Mat's Mug

looks like something's missing

Rossco

ah no that bit is actually fine. Its double negative. The error task doesn't execute because the files do exist.

Took me a while to work through that.

Mat's Mug

05:08

@Hosch250 found a better example of what I wanted to say:

Factory_SelectionIsNull

it says what the input is, but not what to expect out of it

renamed to

Factory_NullSelectionCreatesNullPresenter

also

Presenter_TargetIsNull

vs

Presenter_NullTargetCreatesNullModel

Presenter_SingleParameterMemberCreatesNullModel

Presenter_NoParams -> Presenter_ParameterlessMemberCreatesNullModel

that's not a bad one: Presenter_Reject_ReturnsNull

but... Presenter_CancelDialogCreatesNullModel

that's a good one: Presenter_Accept_ReturnsModelWithParametersChanged

aaand QualifiedSelection.Select is gone

Mat's Mug

05:38

and all green

well except that rename test

Duga

[rubberduck-vba/Rubberduck] retailcoder pushed commit be0945e5 to next: removed QualifiedSelection.Select(); removed dependency from QualifiedSelection, refactored unit tests to build project. All tests pass but one.

Mat's Mug

oh wow, I don't get how there was no merge conflicts here, but woohoooo!!

Duga

[rubberduck-vba/Rubberduck] retailcoder pushed commit bf9c5100 to next: Merge branch 'next' of github.com/retailcoder/Rubberduck

Mat's Mug

> 32 changed files with 841 additions and 579 deletions.

Duga

[rubberduck-vba/Rubberduck] build for commit bf9c5100 on next: AppVeyor build succeeded

Mat's Mug

05:48

and that's all folks

Duga

10:44

[rubberduck-vba/Rubberduck] michaelvdnest starred us

Stack Exchange

12:34

The Codeless Code: Case 199: Unwitting Accomplice

posted on July 12, 2015

Master Banzen was approached by his apprentice Djishin, who said: “The Temple needs a REST library with JSON support. I have located several third-party candidates, but I do not know how to choose among them.” Banzen seemed taken aback. “Did you not author such a library yourself, and provide it to the Spider Clan?” “Yes,” said Djishin, “but now it is a stone around my neck. Every week th…

3

FreeMan

17:10

Hello? tap, tap, tap... Is this thing on?

Phrancis

HAI!

Hosch250

OK, @Mat'sMug, got it.

FreeMan

'sup?

Hosch250

Nothing, apparently.

Show's over:

FreeMan

yeah, seems that way...

Hosch250

17:18

11 hours ago, by Mat's Mug

and that's all folks

FreeMan

ah... I didn't realize the implication of that.

TTGH, then...

Mat's Mug

lol, I meant that as "TTGTB" :-)

Hosch250

Some parents seem so out-of-touch with kids.

Just read a post on Parenting about a kid just singing quieter when asked to stop.

FreeMan

I heard Porky Pig

Hosch250

I was a bit of a brat when I was younger, and know of two possibilities:

1) Kid thinks the parents don't like the noise, but don't really mind the singing.

2) Kid is deliberately being disobedient.

FreeMan

17:24

@Hosch250 I saw that too. Modern society seems to want children to be nothing more than compact size adults.

Get up too early in the morning, go off to "work" (daycare/school), come home, veg in front of a screen.

Heaven forbid a parent should play with his/her kids. Especially outside... Gasp!

/soapbox

Hosch250

My neighbor's kids never play outside.

We used to play outside, but we haven't so much this year.

Partially because the yard is a mini swamp with all the storms lately (we are the low spot).

Partially because our yard is infested with worms, so our dogs can't play out there anymore (related to the wetness).

Partially because we have more computers now.

2

Duga

[Hosch250/Rubberduck] Hosch250 pushed commit 74b9b26f to next: Remove unnecessary data in test.

[Hosch250/Rubberduck] retailcoder pushed commit be0945e5 to next: removed QualifiedSelection.Select(); removed dependency from QualifiedSelection, refactored unit tests to build project. All tests pass but one.

[Hosch250/Rubberduck] retailcoder pushed commit bf9c5100 to next: Merge branch 'next' of github.com/retailcoder/Rubberduck

[Hosch250/Rubberduck] Hosch250 pushed commit aa2b95c5 to next: Merge branch 'next' of github.com/rubberduck-vba/Rubberduck into next

Hosch250

I've been taking my dog on a walk every day, still (can't go today, too hot).

Chrismas007

2

Q: Split a single workbook into multiple workbooks containing multiple worksheets using Excel VBA

I have a workbook with single worksheet as given below. I want to split it into many workbooks containing many worksheets according to the values in it. I want to make 'n' number of workbooks according to 'n' unique values of column 1 as in the picture. And I want to make 'm' worksheets accordi...

Does a bounty automatically make a bad question good

??

33

A: How can we close questions with bounties?

The moderators have a menu to remove / refund the bounty, so this is no longer an issue. Flag such things for moderator attention as the moderators have all the tools necessary to deal with this now.

Mods have to refund bounties to close...

0

Q: Change Close Vote to Mod Flag - Bad Questions with Open Bounty

The official stance on closing bad questions with an open bounty is to flag for moderator attention, get the mod to issue a refund, and then the question can be closed Official Source. However, once you have close vote privileges, most options in the flag menu become "close vote" prompts: Whe...

feature-request flags vote-to-close bounty

RubberDuck

21:35

No no. @FreeMan back on the soapbox. Preach it brother.

Hosch250

Hi, @RubberDuck.

RubberDuck

Hey @Hosch250!

Hosch250

How are you liking your new job?

RubberDuck

Just popped by to say hi. Gotta go make dinner in a minute.

Hosch250

OK.

RubberDuck

21:37

Yes & no. The guy training me is afraid of his own code base.

Hosch250

LOL.

Doesn't sound funny.

RubberDuck

Yeah.... Lol is right.

Hosch250

Sounds like me half a year ago.

RubberDuck

I scolded him the other day.

> This is how code bases rot.

Vogel612

@Hosch250 @RubberDuck ... I am afraid of the codebase at my job

then again that codebase is probably beyond redemption ...

@Hosch250 can I bounce my new Design for the translation helper model off of you?

Hosch250

21:42

Yes.

RubberDuck

If you truly believe that @Vogel612, then it is.

Vogel612

You are aware of how I represent the resx files?

RubberDuck

Sorry. Reading The Codeless Code gets me speaking in koans...

Hosch250

Not really.

Vogel612

so basically I have a Translation class. that translation currently has { Key, RootValue, Translation } as "properties"

Hosch250

21:44

OK.

Sounds like my old version.

Vogel612

I have two documents in the model, one for "en-US" one for "de-DE"

Hosch250

Yep.

Vogel612

now I want to change the model to eliminate the "RootValue" from translation, so as to allow configurable root values

so the Translation class shrinks a little.

Hosch250

Like, how?

Vogel612

Key, Translation

Hosch250

21:46

I mean, how configurable?

Display different languages configurable?

Duga

[rubberduck-vba/Rubberduck] Greg-Hitchon forked us into Greg-Hitchon/Rubberduck

Hosch250

Display multiple languages configurable?

Vogel612

basically I'd maintain a Map<String, Document>

or in C# terms a Dictionary

Hosch250

I see.

Vogel612

the keys would be "de", "", "sv", "fr" ...

Document btw. is the parsed XML DOM

Hosch250

21:48

Oh, what is the key now?

Vogel612

which one?

Hosch250

I was thinking the key was the XML value key, like "Reorder_OptionalParamsMustBeLastError"

{ Key, RootValue, Translation } That one.

Vogel612

it is

key as in Dictionary key

Hosch250

OK, so the type will change from a String to a Map<String, Document>

Vogel612

the Document can be transformed into a List<Translation> rather simply

Document as in .resx file..

Hosch250

21:50

Of course.

So, what is the end goal here?

Vogel612

the end goal is allowing arbitrarily switching between languages

Hosch250

OK.

What I did was something somewhat different.

Vogel612

for both sides of the translation chain

Hosch250

I had a filepicker return a filepath string.

I had two buttons, one for each side.

Vogel612

and you loaded the resx "into" the side from an arbitrary, user-chosen location?

Hosch250

21:53

When the user picked a file, it would load the file from the string.

No, I left it where it was and just loaded it into my app.

Vogel612

yes, that's what I mean :D

Hosch250

When the user finished editing a cell, I would handle the event and save the changes.

Vogel612

how do you resolve key conflicts?

Hosch250

I don't handle key commands.

Oh, those.

Vogel612

soo.. file 1 contains key X, that's not present in file 2

but file 2 contains key Y that's not present in file 1

user-resolution?

Hosch250

21:55

I would display a table like | KEY | VAL1 | VAL2 |

If one file didn't have a key, the value cell for that file would be left empty and the row highlighted red.

If the user didn't edit the value, the key wasn't added, but the second the user edited the value, it was added and saved.

Vogel612

did you ever remove keys?

Hosch250

Yes.

When the user deleted a row.

Vogel612

figures...

Hosch250

Now, I have a list of files (not sure exactly what type I used).

The user can add/remove files at their leisure.

Vogel612

the type's kinda non-portable across C# and Java :D

Hosch250

21:59

I have my code on GitHub and CR (one is still waiting for a review).

So, anyway, I believe I have a key and a list of values in one of my classes.

Vogel612

hmm. I don't quite understand your code ...

Hosch250

In the other, I have the file data and methods to add/remove/save.

Vogel612

yea I found that one.. these ICommands, right?

Hosch250

A lot of what I'm using is Linq-XML and a built-in XML editing classes.

@Vogel612 Those are bound to the buttons - they execute when the buttons are pressed.

The VM handles pretty much everything for the view.

Vogel612

figures. XAML can bind directly to code-behind, right?

Hosch250

22:07

Yep.

Vogel612

in java you'd need to add an ActionListener or Annotation defined binding..

Hosch250

Data binding is a pain to learn, and a joy ever after.

Vogel612

C#'s cooler at that.

Hosch250

All those public properties and stuff are bound to the XAML.

Vogel612

hmm. I love how JSF does it though.

then again that's where I think java is a little stronger than C#..

web based stuff

Hosch250

22:09

JavaServer Faces?

Vogel612

yea.

Hosch250

Never used C# with the web, so won't try to argue.

Vogel612

basically you'd go Classname.method or Classname.property and you'd access your nicely encapsulated classes

methods being the exception, actually.

also the Scoping would be done with one Annotation, and you're usually good to go for Sessions, Request and Application lifetime

Hosch250

In fact, I've not used client/server anything, so I don't get what you are talking about :(

Vogel612

doesn't matter, just hope you don't ever have to debug it

Hosch250

22:12

Debug what?

Vogel612

webapps.

Hosch250

WPF, or JSF?

OK.

Vogel612

JSF and ASP.NET

Hosch250

It sounds somewhat like multi-threading.

Vogel612

they're both a royal PITA

it's multithreading in a gigantic state-machine where everything can change everything else if you just try hard enough

Duga

22:50

[ckuhn203/VBEX] kentat starred us

RubberDuck

23:28

Dude, web is weird. I spent the better part of the day trying to figure out why an event wasn't being raised only to realize I had to setup the control to "post back", whatever the hell that is.

Transcript for