VBA Rubberducking

FreeMan

18:00

I have a small bit of code in a PPT template file, some more in the XLS template file, and the majority in Access.

Mat's Mug

But then the VBA is in Access, no?

Oh

FreeMan

23 secs ago, by FreeMan

I have a small bit of code in a PPT template file, some more in the XLS template file, and the majority in Access.

:)

I've gotten to learn more about the PPT object model than I ever cared to...

Duga

18:23

[retailcoder/Rubberduck] retailcoder opened issue #408: Ambiguous line label identifier

> Consider this [bad but legal] code: Public Sub DoSomething() Foo: Bar End Sub Private Sub Foo() End Sub Private Sub Bar() End Sub The user's intent may have been to call both Foo and Bar procedures on a single line, but VBA will parse Foo: as a line label, and only Bar will be executed. Rubberduck should warn when it encounters a line label identifier that matches a procedure name that's in-scope. Possible quick-fix: Convert line label to procedure call - turn this: Public Sub...

DoSomething() Foo: Bar End Sub Into this: Public Sub DoSomething() Foo Bar End Sub --- Another possible fix would be to introduce a Call statement: Public Sub DoSomething() Call Foo() : Bar End Sub But that would fire up #34, and then applying the Remove obsolete Call statement quickfix would result in this code: Public Sub DoSomething() Foo: Bar End Sub In other words, this inspection solves an issue that an edge-case quickfix of #34 introduces in the user's code.

[retailcoder/Rubberduck] retailcoder added label code-inspections to issue #408: Ambiguous line label identifier

RubberDuck

@Duga I say break it. They deserve it.

2

hides

Duga

[retailcoder/Rubberduck] retailcoder commented on issue #34: Use of obsolete Call instruction

> Note that applying the quickfix on this code:

Public Sub DoSomething()
Call Foo() : Bar
End Sub

Would turn the call to `Foo` into an ambiguous line label identifier. #408 addresses that.

Mat's Mug

@RubberDuck lol

the good news is that this:

In some cases using the call keyword is pretty useful, like when you just want to use a class once. I use it today to generate a random salt Call New RNGCryptoServiceProvider().GetBytes(salt) without Call I would have had to a variable as an RNGCryptoServiceProvider first — yu_ominae Dec 12 '12 at 2:56

isn't valid in VBA (it is in VB.NET though)

oh nice, 2500 views:

15

Q: List<T> implementation for VB6/VBA

Recently I decided VB6's Collection wasn't enough for my needs, so I decided to implement something like C#'s List<T>. Here's the class that resulted, I'd like to know if the implementation could be made better /more efficient, especially with Insert and Sort methods; also I'd like another pair o...

Duga

[retailcoder/Rubberduck] daFreeMan commented on issue #408: Ambiguous line label identifier

> Since `Call()` serves no other valid purpose in VBA, as was [discussed here](http://stackoverflow.com/questions/2573597/should-i-use-call-keyword-in-vb-vba/22325284#22325284), I'd say go with the first option:

Public Sub DoSomething()
Foo
Bar
End Sub

[retailcoder/Rubberduck] retailcoder commented on issue #408: Ambiguous line label identifier

> @daFreeMan indeed. I was merely documenting an oversight in the implementation of the quickfix for #34 :wink:

Mat's Mug

+169 today already

Duga

18:38

[retailcoder/Rubberduck] Ryankey created pull request #409: Change default Inspection severity to Warning/Suggestion; Closes #400 to merge Ryankey/Rubberduck-1.22/next into retailcoder/Rubberduck/next

Mat's Mug

anyone has 1.22 handy?

try running code inspections on this code:

Public Sub DoSomething()
    Call Foo(42): Bar
End Sub

Sub Foo(ByVal i As Integer)

End Sub

System.ArgumentNullException: Value cannot be null.
Parameter name: [context] and [comment] cannot both be null.
   at Rubberduck.Inspections.ObsoleteCallStatementInspection.<GetInspectionResults>b__2(IdentifierReference issue) in c:\Users\Mathieu\Source\Repos\Rubberduck\RetailCoder.VBE\Inspections\ObsoleteCallStatementInspection.cs:line 23
   at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext()
   at System.Collections.Generic.List`1..ctor(IEnumerable`1 collection)
   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)

rather surprising, but it's the banned 1.3 pre-release.

does it blow up in 1.22 as well?

Duga

[retailcoder/Rubberduck] retailcoder merged pull request #409: Change default Inspection severity to Warning/Suggestion; Closes #400 from Ryankey/Rubberduck-1.22/next into retailcoder/Rubberduck/next

[retailcoder/Rubberduck] Ryankey pushed commit f071c7c8 to next

> Change default Inspection severity to Warning/Suggestion

[retailcoder/Rubberduck] retailcoder pushed commit f18ccd80 to next

> Merge pull request #409 from Ryankey/next

Change default Inspection severity to Warning/Suggestion; Closes #400

Mat's Mug

I need to merge Master back into Next asap. and stop working off master

damn 1.3 fiasco

FreeMan

It was easier to find linked messages when @Duga was napping... :/

She takes up a lot of screen real estate

Mat's Mug

get a bigger screen ;)

FreeMan

18:46

Can I tell my boss you said so?

Mat's Mug

> Mug says I need a bigger screen, so that I can read the VBA chatroom better - your call.

3

FreeMan

Thank you, I'll quote you on that.

Mat's Mug

lol

RubberDuck

Mat's Mug

nice!

RubberDuck

18:51

I think I have my order of operation backwards though.

Mat's Mug

indeed

well

it's supposed to be 4*3+2?

RubberDuck

Nope. It's not the order of operations. It's the order of the text.....

Which means, I basically don't have an order of operations.

I thought I did.

Mat's Mug

well you do

RubberDuck

Mat's Mug

yeah, better.

and all that changed was the input I suppose?

RubberDuck

18:53

No. Not better. Just different input.

Mat's Mug

yeah, fix that grammar ;)

FreeMan

You can just claim that the first uses RPN

Mat's Mug

uh-huh

lol, my last tweet was retweeted by someone that's running a weightloss website

3

FreeMan

that's what RubberDucks are for, weight-loss, right?

sᴉɔuɐɹɥԀ

> Does this VBA code make my ass look fat?

3

FreeMan

19:13

Say goodnight, Gracie...

RubberDuck

19:29

> Good night Gracie.

It's right. I just need to figure out how to go to the bottom first.

Mat's Mug

that's what the visitor thingy is for?

RubberDuck

Yeah. I think so. But I haven't quite figured out how to go to the bottom first.

Mat's Mug

19:45

@RubberDuck July 1st

18

Q: Look 'ma, I can read code

I have put together a naive implementation of a VB6/VBA parser, and I'd like to see if the CR community sees the same things as I see can be improved with this code, before I start refactoring. I've never written a parser, so this naive implementation is naive in all senses: I wanted to push it ...

c# parsing reinventing-the-wheel

a long, long, long way we've come!

Rossco

@Mat'sMug Thanks for that. Not sure how I missed the obvious there.

Mat's Mug

20:17

@ExcelEasy well done! #Challenge: make a more #OOP one without using the form's default/global instance! #becausewhynot

Tweeted by rubberduckvba on April 22, 2015 at 8:10 PM in reply to ExcelEasy

Stack Exchange

They probably don't like us neither http://www.commitstrip.com/2015/04/22/whats-wrong-with-ides/ http://t.co/IP6jbw6qjo

Tweeted by CommitStrip on April 22, 2015 at 5:56 PM

@ExcelEasy well done! #Challenge: make a more #OOP one without using the form's default/global instance! #becausewhynot

Tweeted by rubberduckvba on April 22, 2015 at 8:10 PM in reply to ExcelEasy

Mat's Mug

Oops

@RubberDuck You don't. I think you have it reversed. If the top-priority operations are at the root, you just need to walk your tree and evaluate as you go all the way down each branch in order; when you get to the bottom of the first child, you store the result and evaluate the next child.

RubberDuck

Idk. I almost had it.

If the expression is an Integer, return it.

Otherwise, walk left down the tree.

walk right down the tree

If operator isn't null, perform operation and return.

But I'm getting a null operator where I should be subtracting.

Mat's Mug

are you sure you're where you think you are in the tree then?

RubberDuck

Otherwise, it works. It calculated the left side of the tree fine.

No. I'm not.

Hold up. I think I know what I need to do.

Nope.

Mat's Mug

20:31

lol

Mat's Mug

21:02

well that was fun

0

A: Condense largely(Unpractical) loop based VBA code; nested For...Next loops

I am also looking for suggestions to speed up the code in general aside from screen updating and calculation suggestions. I'm guessing this means you're already implementing those then. I might not help with anything, but get rid of this line: Anvil.Select Working off the current selecti...

ryankey721

21:13

@Mat'sMug I'm not sure I understand the logic of changing For u = 16 To 70000 to u = t + 14

Mat's Mug

t is looping the rows on sheet A, from 2 to 70K; u is looping the rows on sheet B, from 16 to 70K. He's looping ~70K times on sheet B for every row on sheet A, ...oh wait, I fucked up.

...did I?

(deleted answer for now)

ryankey721

I think the first version compares each t to each u, whereas the second compares each t to t+14

Mat's Mug

exactly - my point being that there doesn't need to be ~4,900,000,000 iterations

but yeah it's actually a search he's doing.

I fucked up.

Transcript for