VBA Rubberducking

Hosch250

21:00

OK, it failed.

Do I have write access to the master?

After this I'll update my fork and switch to it.

NVM, I guess I can manually submit the changes.

Mat's Mug

hi @paoloff!

Hosch250

Oh, hi.

Didn't see you come in.

Mat's Mug

all those keys are debug builds for 1.2x

Hosch250

Sending pull requests one file at a time.

Mat's Mug

getting notifications. good sign ;)

@RubberDuck do you have registry keys for Rubberduck.UI._SettingsDialog or it's just me? @Hosch250 can you confirm that there's no registry key / GUID for Rubberduck.UI._SettingsDialog?

there shouldn't be one

Hosch250

21:08

@Mat'sMug Huh?

I have one.

That is why I made that.

Mat's Mug

ok

Hosch250

@Mat'sMug My repo needs to get your changes, how to update it?

Mat's Mug

don't. I need to test them first

Hosch250

Here, I want to re-fork your current one.

It is some 633 commits behind yours.

Mat's Mug

and yeah, the keys are ok - COM registration is at assembly level, so everything COM-visible gets a key

oh wow

Hosch250

21:11

I haven't updated it forever.

RubberDuck

@Mat'sMug Auto-generated. Not sure why it's not explicit.

[ComVisible(true)]
public partial class _SettingsDialog : Form

Damn. I thought I fixed that way back when I did this... github.com/retailcoder/Rubberduck/commit/…

Mat's Mug

it's fine if it's the installer registering it (uninstalling would remove them), but my manual registration of debug builds has generated a shitload of keys

Hosch250

@Mat'sMug How can I get my repo up-to-date?

I need to get it up-to-date with yours so I can submit things!

RubberDuck

Right, which is why I went through and gave "everything" explicit guids.

Or, thought I had.

Hosch250

They should have them, if I can get my repo updated.

RubberDuck

21:14

@Hosch250 git pull origin branchName

Mat's Mug

I have keys for inspection classes... shouldn't these be marked ComVisible(false)?

Hosch250

@RubberDuck Can't, I'm using the website and don't have Git installed.

Mat's Mug

you have Git installed, or you wouldn't be able to commit to your own repo with VS

RubberDuck

@Hosch250 You are up to date. github.com/retailcoder/Rubberduck/network

Hosch250

No, it is built in to VS.

Mat's Mug

21:15

it's not.

Hosch250

It is.

Mat's Mug

VS is using libgit2sharp

Hosch250

Oh, OK.

Close enough...

Mat's Mug

..which we're also using for RD source control integration

Hosch250

But, I can do it with VS, and I do not have Git installed!

Open up your Team Explorer.

@RubberDuck Then why is it telling me I am 633 commits behind?

3 commits ahead, 633 behind.

RubberDuck

21:18

I have not a clue man. But here's how you open the command line.

@Mat'sMug technically it is built in now. =;)-

Mat's Mug

yay, done with the 5's. about 1/4 keys were RD keys

Hosch250

@RubberDuck My command line isn't recognizing "git" or "pull" as a command...

Mat's Mug

are you opening it from within the team explorer?

Hosch250

Yeah.

RubberDuck

Not a clue.

Mat's Mug

21:20

well, install git!

RubberDuck

What branch are you on? Looks like patch1/2 are up to date, but if you're on some other branch, you're light years behind.

Hosch250

Thing is, I am not working from my repo, I got it directly from the master.

RubberDuck

I wouldn't even try to merge that.

Hosch250

So I can't just do that anyway.

OK.

Mat's Mug

I'm about to give up manual scrubbing and write some VBA to seek & destroy all the Rubberduck keys

wait, I can't launch the VBE

Hosch250

21:24

Lol.

RubberDuck

@Hosch250 here's how you sync up with our repository. help.github.com/articles/syncing-a-fork

Hosch250

Use C#.

Mat's Mug

or PS

Hosch250

@RubberDuck Great, thanks.

RubberDuck

I've gotta go feed the kids guys.

Mat's Mug

21:24

I must have removed 50+ AssertClass GUIDs

RubberDuck

Terrified to look at my registry.

Mat's Mug

just with GUIDs starting with a 4 or a 5

all 1.2x

at this point it might actually have failed to register due to a GUID clash lol

I'm in the 3F's and gotta go

Hosch250

@Mat'sMug Sent a pull request with more updates.

See you.

Mat's Mug

I'll take a look after I manage to get my VBE to not crash Excel

Hosch250

OK.

OK, I just deleted the old thing and created a new fork.

Mat's Mug

21:36

we need to add ComVisible(false) attributes eveywhere

Hosch250

Lol.

Now I need to get my repo, not the master thing.

Mat's Mug

especially the AboutWindow and the SettingsDialog

Hosch250

OK.

Then I'll change that back.

Mat's Mug

any dialog that's not dockable doesn't need to be COM-visible

Hosch250

Pull requests waiting.

Mat's Mug

21:40

all off the current master?

Hosch250

Yes.

I just trashed my fork and made a new one.

Cleaning everything containing "Rubberduck" from my registry.

> Property(C): SystemFolder = C:\WINDOWS\SysWOW64\

RubberDuck

21:56

@Mat'sMug Why? The project is set to not make anything COM-visible by default.

Mat's Mug

My build is then

Damn

RubberDuck

The about window and settings dialog need to be com visible for the add-in to load. They need GUIDs assigned is all.

Sorry. I know I usually do this stuff...

Mat's Mug

@RubberDuck Then the rename box as well

But why? They're not docked

RubberDuck

I could be wrong, but I'm pretty sure.

Couldn't exactly say why, but I seem to remember needing them COM visible when I was working on one of the releases.

Mat's Mug

I thought the docked ones needed COM visible because of the window host

I've done com interop before ducky, dialogs didn't need anything special

RubberDuck

22:03

I don't know, I'd either have to scrub my registry, or make a build to try on my other machine.

I'm just speaking from a bad memory from months ago.

Mat's Mug

Actually I used to have a WPF UI over COM Interop..

RubberDuck

Could be it didn't need it, I tried it, and it was something else that actually fixed it.

Mat's Mug

I vote for that ;)

Boy I fucked my registry up

Time to eat. Later!

Rossco

Are any of the bugs you guys have identified bad enough to pull the 1.3 release or are they just minor?

Y'all seem a bit worked up about it ;-)

Mat's Mug

22:27

@Rossco Well the rename bug is annoying me big time

Renaming a UserForm control was meant to work

Rossco

Yeah I discovered a bug with the rename as well.

first time it didn't work and the second time threw an exception

Mat's Mug

Involving controls?

Oh interesting

Rossco

but I'll wait until you've released 1.3.1 until I file a bug report.

Mat's Mug

Can you repro?

Rossco

Or I'll get a working copy of my own to debug it.

Mat's Mug

22:29

If you find all references does it give you a list of something?

Rossco

It does but it fails when I try to navigate to the location.

Mat's Mug

File the bug, I might give it a shot tonight

Rossco

What is happening is that it correctly sees several references inside of a method in ThisWorkbook but double clicking tries to go to the wrong ThisWorkbook (in another file) that is open in the VBE

I have a few addins which load.

mostly the built in ones.

I suspect that the bug might be related to things you already know about.

Mat's Mug

Ah I see. I'll definitely give it a shot

Rossco

Mat's Mug

22:35

FindModule extension needs to check the reference of the VBProject in the QualifiedName - I think it only goes by name and returns the first it's finding... which is dumb

Rossco

So that is a screenshot of the find all references which seems to work

but when I double click I get

Mat's Mug

I wrote the doubleclick nav in about 20 minutes last night.. lesson learned..

Rossco

And I see that it has opened the module in a different workbook.

Lol

I hope that explains the problem sufficiently.

Mat's Mug

Yeah I know exactly where to look

Just to be sure, doubleclick nav in the code explorer does work, right?

Rossco

BTW, you might not have known that you can create a .Net List in VBA and use it (as per the code I posted)

@Mat'sMug Yip

Mat's Mug

22:39

Yeah ArrayList is COMpatible ;)

@Rossco Cool. Consider it fixed.

(It's not the extension method, it's my quick-crap from yesterday)

Rossco

np

I'm not really using VBA at the moment.

Mat's Mug

My VBE crashes on load at the moment '~'

I think I borked my registry

Rossco

LOL

rofl

BTW navigation doesn't always work in your explorer.

haven't determined why it does sometimes and not others.

Mat's Mug

You mean right-click/navigate or double-click?

Because the context menu doesn't activate the right clicked node - and yes that's another bug ;)

I mean a right-click doesn't activate the clicked node before showing the context menu despite the selection highlight seemingly selecting the correct node

Double clicking should work though

Rossco

22:55

was only using double click, hadn't considered right click.

@Mat'sMug I was a bit late in saying, but I'm pretty sure that the regasm command has an unregister flag (if my memory serves).

so if the old assemblies exist with the CLSIDs then you could go through them and unregister them all.

which should remove the rogue registry values.

probably too late now by the sounds.

Mat's Mug

Yeah..

Rossco

I'm trying to navigate to some modules in the explorer and it isn't going anywhere. I assume that its searching for the item to open and not finding it. There is no user message, is it logging somewhere?

Mat's Mug

I'm swallowing COMExceptions there - on purpose - that might be it

Rossco

I'm guessing that the navigation code is shared between the explorer and the find references window?

Mat's Mug

Yeah

And the navigation from the code inspections and todo explorer

Rossco

23:05

which is expected.

which is why I think a lot of the bugs are connected.

Mat's Mug

Which means one shot kills 'em all! ;)

Rossco

Yeah, hence I was reluctant to escalate issues until you had resolved some. Then retest and find they are magically fixed!

Can you explain in English-code how you find the correct code module to open?

RubberDuck

It should be using the project and module names along with a hash code, right Mug?

Mat's Mug

I'm passing a QualifiedModuleName to a CodePane extension method that ~~resolves~~ should be resolving the module using the VBProject reference in the QualifiedModuleName

@RubberDuck The projects can be resolved simply with reference equality (.Equals)

That's just by memory though, I'm not in front of the code atm

Rossco

Ok, if you are holding a project reference that should work fine.

As long as you weren't matching the name of the project from a list, since they are not unique.

Mat's Mug

23:14

I say should because apparently the FindAllRefs nav isn't doing that

RubberDuck

I seem to remember some trouble with that, but I also seem to remember Mug fixing that.

Idk. My head hurts today. Did an entire week's class work in a day.

Plus, ya know, the hangover...

Rossco

Yeah, I have a massive workload myself atm.

Otherwise I would dive in.

RubberDuck

Well, it will still be here. We back logged years worth of work before we ever made it to 1.0.

Mat's Mug

lol

so true

Rossco

truly?

wow

RubberDuck

23:18

Yeah. At least when you consider it's two devs doing this in their spare time.

Rossco

The other thing you could use to uniquely identify projects, if you weren't keeping a reference, is to use the .FileName property of the VBProject.

RubberDuck

And one of them cough didn't even know C# when we started.

Rossco

lol

I <3 c#

RubberDuck

Lol. Seriously. I didn't.

Rossco

but yes I didn't know it until about 12months ago.

Mat's Mug

23:20

@Rossco won't work as soon as you Ctrl+N twice in Excel

Rossco

VBA -> VB.Net -> c#

RubberDuck

Did I tell you guys they saddled me as Community TA for this class? I'm practically teaching it...

Mat's Mug

what's TA?

Teacher's Assistant?

Too Awesome?

RubberDuck

Both.

Mat's Mug

Tamed Angrybirds?

Hosch250

23:22

Teacher Assistant.

Mat's Mug

nice

RubberDuck

Totally annoying

Mat's Mug

lol

Rossco

@Mat'sMug yeah but the FileName property throws

Hosch250

I could be a tutor in any of my classes, if it didn't require me to give G+ lessons periodically.

Mat's Mug

23:23

@Rossco I figured having a reference to the project itself was the simplest & most reliable way to go about it ;)

Rossco

totes

Hosch250

Anything I can do?

RubberDuck

23:41

Wanna build a system that tracks repository locations? I'm not looking forward to that tbh.

j/k btw. I should be starting work on that tomorrow sometime.

Mat's Mug

23:53

I have - if I counted them correctly - 238 keys under HKLM/SOFTWARE/Classes/CLSID/{29FB0A0E-F113-458F-823B-1CD1B60D2CA7}

2

Rossco

public static void SetSelection(this VBE vbe, QualifiedSelection selection)
    {
            //not a very robust method. Breaks if there are multiple projects with the same name.`

I think the first comment gives it away! ;-)

RubberDuck

Hmm... That was my comment. For the todo explorer.

Legacy code...

Rossco

I think that method is called when you try to navigate to a code location.

RubberDuck

Surely we have better ways at this point.

Rossco

but I am not able to run it at this point.

Mat's Mug

23:59

I think that might be the method I'm calling for the refs nav... hold on

RubberDuck

Or, did all of it eventually get tied to that??

Rossco

Plus, I'd rather like the registry fixes before I frig up my registry too.

Mat's Mug

yup

C:\Users\Mathieu\Source\Repos\Rubberduck\RetailCoder.VBE\Extensions\VbeExtension‌s.cs - (54, 28) : public static void SetSelection(this VBE vbe, QualifiedSelection selection)

C:\Users\Mathieu\Source\Repos\Rubberduck\RetailCoder.VBE\UI\IdentifierReferences‌\IdentifierReferencesListDockablePresenter.cs - (29, 17) : vbe.SetSelection(new QualifiedSelection(reference.QualifiedModuleName, reference.Selection));

Rossco

@RubberDuck that's why I'm bringing it up.

Transcript for