> When parsing a Class Module, identify all Private properties that don't have Public Get/Let functions. Offer to generate them one-at-a-time, or bulk generate them all. For example: Private pMyString As String Private pMyLong As Long Would produce: Public Property Get MyString() As String MyString = pMyString End Property Public Property Let MyString (ByRef x As String) pMyString = x End Property Public Property Get MyLong() As Long MyLong = pMyLong End Property Public Property Let MyLong...
(ByRef x As Long) pMyLong = x End Property The ByRef could be changed to ByVar, or it could be user-configurable.
Fair enough. Been programming a long time, finally getting my head wrapped around classes and what they can do for me. There seem to be so many extra calls with the Getter/Setter for private variables, that every little bit of optimization would help.
@Mat'sMug Ah, you're talking about my suggestion/feature request. Got it.
sorry, jumping from conversation to coding and back, I wasn't tracking with ya'
OK, hitting a wall here.
Class A is a list of items. Class B is a collection of Class A.
Procedure One generates a collection of A, then sets ClassB.Collection = the generated collection
Later I call Procedure One again, generate some more Class A items in a collection & want to Add them to the existing Class B.
My current code is overwriting them with `Set PivotTableList.PivotTableItems = PTL'.
How do I add that in?
Do I override the .Add or create a setter that creates a new list if it's null, otherwise loops through the passed collection & adds them individually?
Private Sub ProcessDataSheet(ByVal NewSheet As Excel.Worksheet, ByVal NewXLName As String, ByRef PivotTableList As PivotTableItems)
Dim PI As PivotTableItem
Dim PTL As Collection
Set PI = New PivotTableItem
PI.SheetName = NewSheet.Name
PI.TableName = pt.Name
PI.Address = "'" & NewSheet.Name & "'!" & Formula
PTL.Add PI, Key:=PI.TableName
Set PivotTableList.PivotTableItems = PTL
-------------------------------------------------------------
Public Property Set PivotTableItems(ByRef lPivotTableItem As Collection)
when ProcessDataSheet is called a second time, pPivotTableItems is getting overwritten with the new list from PTL, not adding the new list in.
Public Property Set PivotTableItems(ByVal lPivotTableItem As Collection)
Dim PI As PivotTableItem
If ppviottableitems.Count = 0 Then
Set pPivotTableItems = lPivotTableItem
Else
For Each PI In lPivotTableItem
pPivotTableItems.Add PI, Key:=PI.TableName
Next
End If
End Property
setCompany = (company: Company) => {
// This is so stupid
this.ShareSvc.Data.CompanyId = company;
// Why can't we just use angular the wait it is meant to be used instead of abusing
// it like this. I'm going to need a big tub of icecream to get over this.
}
Public Property Set PivotTableItems(ByVal lPivotTableItem As Collection)
Dim PI As PivotTableItem
For Each PI In lPivotTableItem
pPivotTableItems.Add PI, Key:=PI.TableName
Next
End Property
Which would, essentially be .Merge() (Right??)
I'm getting Run-time error '91': Object variable or With block variable not set on the .Add line
It goes and gets PI.TableName just fine, but doesn't like adding it to pPivotTableItems which is the collection...
OK, thanks! that took care of getting the data in there. Now I just have to figure out how to get it out... :/
I'll go find a random RD post on a question and give you a +1 :D
Is there any drawback/taboo about leaving that as the Set code instead of calling it Merge? Whichever name I give it, it's the only one that would be used.
This is an esoteric OOP concept and there's a little more you need to do and understand to use a custom collection of shapes.
You may first want to go through this answer to get a general understanding of classes and interfaces in VBA.
Follow the below instructions
First open Notepad.exe and ...
@FreeMan Good question.... I would say that it breaks the semantics of what a property is.
Because, it doesn't actually Set anything. It's really not what it does, so it breaks the Principle of Least Surprise.
From the Choosing Between Properties and Methods section of Design Guidelines for Developing Class Libraries:
In general, methods represent actions and properties represent data. Properties are meant to be used like fields, meaning that properties should not be computationally complex or prod...
Welcome to CR! You're probably better off including your actual code, not just "explanatory snippets" - on this site the code is front & center, and reviewers typically comment on any & alll aspects of the code. You can improve this post by using a title that somewhat describes what your code is doing, ....and @Rubberduck has beaten me to it again. — Mat's Mug8 secs ago
Whew! Thanks guys! With your help on the classes, and my eventual realization that shape.SetSourceData is invalid, but Shape.Chart.SetSourceData is valid, I'm on the road!
Also, I've starred the questions that @RubberDuck and @Mat'sMug linked earlier. Very helpful
With the following Code I try to compare the content of two Worksheets.
The first column contains a key that is unique and the following columns contain data that I want to compare (My data sets contain around 7000 rows and up to 40 columns).
My question is if there is a way to make the code ru...
> Stephen - Which email plan did you want? you - we're only 2 devs on the project, I was wondering, if I only take 1 email address, does the other dev need to have access to my godaddy account to read them, or it's separate? Stephen - There is a separate web login area not within the Godaddy account if you just want one email address you - so we can both set up the account on our respective cell phones and send/receive with that account? like, [email protected]? Stephen - Yes, if you both are sharing the email and password
That's by design. You need to insert rows at a row that's inside the ranges your formulas use - excluding the last row. Absolute refs won't change that
Our biggest two cable providers have completed their merge very recently and we got totally shafted here, I'm fearing we'll head towards American internet quality
The speed dropped from 12.5 MB/s to 3.5 MB/s on average, that's on a 120 Mbit line
Now the cable providers never had effective competition, but there was a US-based company and a Dutch company, and the US-based one bought out our Dutch one, but decided to keep that name for its reputation
This is an esoteric OOP concept and there's a little more you need to do and understand to use a custom collection of shapes.
You may first want to go through this answer to get a general understanding of classes and interfaces in VBA.
Follow the below instructions
First open Notepad.exe and ...
From the Choosing Between Properties and Methods section of Design Guidelines for Developing Class Libraries:
In general, methods represent actions and properties represent data. Properties are meant to be used like fields, meaning that properties should not be computationally complex or prod...
With the following Code I try to compare the content of two Worksheets.
The first column contains a key that is unique and the following columns contain data that I want to compare (My data sets contain around 7000 rows and up to 40 columns).
My question is if there is a way to make the code ru...
VBA Rubberducking
VBA Rubberducking