Things have not been going as planned here... Getting frustrated with not being able to sit down and finish this feature. I think I'll be able to nail it down in the mornings next week, but it's going to make for some very long ass days.
> Hi Guys, I've been looking at this in code. I found it under UI - Refactorings - Rename. I'd like to help you with this, can I? If so, I'd write first unit tests for that (I've already started ..) which branch should I use (next)?
> Yes @PetLahev. next is our development branch. You can fork and submit pull requests to it. It's up to date to the best of my knowledge. If you have a need to mock anything for your tests, we're using Moq. Give us a shout here or in chat if you need anything.
> Awesome! Pull the Refactorings branch - I'm working on that one. You'll notice a crapload of false positives in code inspections, too.. I'm planning on focusing on that problem over the next few days, so your contributions to refactorings are more than welcome! Sent from Samsung Mobile <div>-------- Original message --------</div><div>From: PetLahev <[email protected]> </div><div>Date:2015-04-02 09:46 (GMT-05:00) </div><div>To: retailcoder/Rubberduck...
<[email protected]> </div><div>Cc: Mathieu Guindon <[email protected]> </div><div>Subject: Re: [Rubberduck] Renaming an interface breaks implementations (#353) </div><div> </div>Hi Guys, I've been looking at this in code. I found it under UI - Refactorings - Rename. I'd like to help you with this, can I? If so, I'd write first unit tests for that (I've already started ..) which branch should I use (next)? — Reply to this email directly or view it on GitHub.
> Almost identical to the VariableNotUsedInspection is a ProcedureNotUsedInspection which is useful for finding dead code. However there are native handlers in VBA code that aren't meant to be called by user code, like worksheet events Worksheet_Activate and Class_Activate and Class_Terminate class members.
Ignoring methods that have an underscore in their name would be dumb... but what other way is there? Hard-coding every event in the Office object model doesn't seem to be a good solution either.
> Actually I'm working on the false positives issue / code inspections, in the GrammarIsFun branch, so if you work in Refactorings we shouldn't collide :)
This is a bit complicated to explain but I sure will do my best!
I want to register the current time and date "Year,Week,day + Time", in my program IBM Personal Communications (Session A). I have to use a .MAC extension for the final file in order for the program to read it.
This is the code th...
Sub foo()
Dim frm As VBComponent
Set frm = Application.VBE.ActiveVBProject.VBComponents("UserForm1")
Dim dsn As Object
Set dsn = frm.Designer
If Not dsn Is Nothing Then
Dim ctl As Object
For Each ctl In dsn.Controls
Debug.Print ctl.Name
Next
End If
End Sub
so whenever the parser encounters a VBComponent with a Designer, it needs to iterate the Controls collection and add a WithEvents "member" / declaration for each control.
> So whenever the parser encounters a VBComponent that has a non-null Designer, we need to add a Declaration (WithEvents) to that module, to account for the field in question. Let's create a new DeclarationType.Control for that purpose, and then the Rename refactoring will even be able to rename controls!
use case: right-click TextBox42 in a form's code-behind (say, on the line that says result = TextBox42.Text), select "Refactor/Rename", enter DescriptionBox for a new name and watch as your assignment becomes result = DescriptionBox.Text without breaking the designer!
Does Asc(Right(ToleranceLabel,1)) return 176? This part isn't very clear to me: I wanted to verify that the text I was getting the unicode symbol for decimal number 176 and not the unicode using the decimal number 186 for degree. I checked the decimal number and I get 176. — Mat's Mug1 min ago
@Mat'sMug I need your help with GitHub, I'm absolutely new and I think I made a mistake Your spaghetti code? you kidding? :) I actually haven't seen better code for long long time
@Mat'sMug when I checked the 'renaming' code two dauys ago I used the button on GitHub 'Clone to my desktop" or whatever it says
today I forked it (which is also new to me) and again cloned it to my desktop. When GitHub app asked me where I wanto to download it I chose the same location and there I think I made mistake
I think if I now commit back I'll actually commit to one of your branch
no worries. I've made change to just one class (presenterTests, which I think I created) so I can save my changes, undo all my changes, then clone again to different location and we should be fine
@Mat'sMug There's a lot of things that can be done, but the easiest is really to fork on github, clone the fork and push to the fork, and then later on do a PR.
However, if no PR is done and you still want to take some commits from it, that's certainly possible. You just git remote add petlahev [email protected]:yadayada and add @PetLahev's fork as a remote, and then you can pull commits from that remote using git pull petlahev branchname
It is possible to merge entire repositories together by setting up different remotes, @sᴉɔuɐɹɥԀ managed to do that some time on the Cardshifter repo, he merged it together with the website repo. Luckily we managed to clean up that mess.... :)
@Mat'sMug He can add your repo as a remote and pull from that. Or he can create a PR request on github from your repo to his repo, and hope that github can automatically merge them.
However, if no PR is done and you still want to take some commits from it, that's certainly possible. You just git remote add petlahev [email protected]:yadayada and add @PetLahev's fork as a remote, and then you can pull commits from that remote using git pull petlahev branchname
I do use Source Tree for some things. It's nice to view the history and really helps out when you need to figure out which commit you need to reset or revert to.
This is a bit complicated to explain but I sure will do my best!
I want to register the current time and date "Year,Week,day + Time", in my program IBM Personal Communications (Session A). I have to use a .MAC extension for the final file in order for the program to read it.
This is the code th...
VBA Rubberducking
VBA Rubberducking