I'm going over each and every code inspection tonight, tying them all to the symbol table (well all the ones that should depend on it anyway) - I need that listener flawless!
Meanwhile I'm reverting whatever pending changes I had on Next.
I like your indentation. It's nice to see well-indented VBA code, it needs to be pointed out!
Application.ScreenUpdating = False
That's generally a good idea, but all by itself, it makes a poor UX - and if calculation mode remains xlAutomatic, it might be a missed opportunity to gain some mo...
> There are 7 instructions on that line of code; there's no reason to do this. Ever.
var declarations = from item in parseResult.Declarations.Items
where item.DeclarationType == DeclarationType.Parameter
let arg = item.Context.Parent as VBAParser.ArgContext
where arg.BYREF() == null && arg.BYVAL() == null
select item;
^^ let has no equivalent that I know of with method syntax
> Hello ! First, let me say that I am impressed by the work you're doing ! I do not particularly like coding in VBA, but I think your addin will help me a lot ! I am testing your addin to see if I can use it in my everyday work. We use some proprietary addins which VBA project is protected by a password. When these addins are loaded, the Rubberduck addin does not work anymore. In particular the UnitTests part. I think you try to parse the protected modules, which throws a COM exception that...
is not handled. If you have any question, or cannot reproduce the bug, let me know ! Keep up the good work ! Florian
> Hi @FlorianChevassu! Thank you for the kind words.
What version of Rubberduck are you using? Per #289, this issue was resolved in version 1.21. Also, which Host Application are you using (Word, Excel, etc.). Unit testing is not yet supported in all of the Office Applications.
> I too have this problem with the Test Explorer not opening, I just couldn't work out what the issue was until I saw this. Reading that the issue may be caused by protected modules, and realising that I had the Solver Add-In activated (with its associated protected project listed in the Project Explorer), I unloaded the Solver Add-In and now the Test Explorer opens for me.
I am running Excel 2010 (x32) on Windows 7 (x64) with build 1.21.5553.34023 of Rubberduck.
> I don't think this is an actual parser issue and is not a duplicate of the other issues I mentioned. I suspect there is a similar snippet as this somewhere that isn't catching the exception. (Or possibly even a different exception being thrown here.) public void SynchronizeEngineWithIDE() { try {...
_testEngine.AllTests = this.VBE.VBProjects .Cast<VBProject>() .SelectMany(project => project.TestMethods()) .ToDictionary(test => test, test => _testEngine.AllTests.ContainsKey(test) ? _testEngine.AllTests[test] : null); } catch (ArgumentException) { System.Windows.Forms.MessageBox.Show( "Two or more projects containing test methods have the same name and identically named tests. Please rename...
one to continue.", "Warning", System.Windows.Forms.MessageBoxButtons.OK, System.Windows.Forms.MessageBoxIcon.Exclamation); } } Going around the parser speeds things up, but it means going around the "protected project" fix.
> That should work until we make unit test discovery use the parse results; the parse results don't include protected projects so that will remove all the redundancies there. Well done @ckuhn203!
@RubberDuck I can't tell if I am on to something or going a little to crazy with interfaces here.
Public Function Create(ByVal seed As Variant, ParamArray elements() As Variant) As Variant
Dim result As Variant
If TypeOf seed Is ICreatable Then
Dim creatable As ICreatable
Set creatable = seed
Set result = seed.Copy(CVar(elements))
ElseIf TypeName(seed) = "String" Then
result = Join(elements, vbNullString)
ElseIf cast.IsArray(seed) Then
result = cast.CArray(elements)
ElseIf TypeOf seed Is Collection Then
Set result = New Collection
Dim element As Variant
For Each element In elements
Then you could do set x = Create(List, 1,2,3,4)
Function Map(ByVal seed As Variant, ByVal sequence As Variant, ByVal op As Variant) As Variant
Dim result As Variant
Set result = Create(seed)
Dim element As Variant
For Each element In Sequence
Add result, op.Exec(element)
Next
Assign Map, result
End Function
This whole Function needs a little bit of work.
Dim cmd As SqlCommand = Nothing
Dim conn As SqlConnection = Nothing
Try
Using dt As New DataTable()
conn = New SqlConnection(GetConnectionString())
cmd = New SqlCommand(_command, conn)
cmd.Co...
my first VB answer in a while, and it is super simple....
posted on March 31, 2015 by Christopher J. McClellan
There was an issue with some of the features when a password protected VBA Project was loaded. This caused several of the tool window, most notably the Test Explorer, to fail to open. As many of the more popular add-ins are password protected, this was a pretty big problem. This has been corrected and the […]
I like your indentation. It's nice to see well-indented VBA code, it needs to be pointed out!
Application.ScreenUpdating = False
That's generally a good idea, but all by itself, it makes a poor UX - and if calculation mode remains xlAutomatic, it might be a missed opportunity to gain some mo...
This whole Function needs a little bit of work.
Dim cmd As SqlCommand = Nothing
Dim conn As SqlConnection = Nothing
Try
Using dt As New DataTable()
conn = New SqlConnection(GetConnectionString())
cmd = New SqlCommand(_command, conn)
cmd.Co...
VBA Rubberducking
VBA Rubberducking