VBA Rubberducking

« first day (296 days earlier) ← previous day next day → last day (2884 days later) »

Duga

00:00

RELOAD!

[retailcoder/Rubberduck] 6 commits. 5 opened issues. 3 closed issues. 1 issue comment.

[rolfl/MicroBench] 2 commits.

[Zomis/Prosit] 1 opened issue.

RubberDuck

@Duga That's nice to see!

Duga

@RubberDuck Star it, then!

RubberDuck

@Duga good point!

Wait.....

Sometimes I forget you're a bot.

Duga

lol

Sometimes I forget you're a duck.

Duga

01:03

[retailcoder/Rubberduck] ckuhn203 pushed commit d5ed3295 to sourcecontrol

> Sunny Day Merging

[retailcoder/Rubberduck] ckuhn203 added label user-interface to issue #352: Give User feedback about state of merge

[retailcoder/Rubberduck] ckuhn203 added label source-control-integration to issue #352: Give User feedback about state of merge

[retailcoder/Rubberduck] ckuhn203 assigned ckuhn203 to issue #352: Give User feedback about state of merge

RubberDuck

That's enough for a day. Time to relax.

Duga

[retailcoder/Rubberduck] ckuhn203 opened issue #352: Give User feedback about state of merge

> Right now, if a merge succeeds, the Merge View simply closes.
Some feedback should be provided that the merge did indeed successfully complete.

Also, while taking care of this, remove the dependency on System.Forms.MessageBox in the presenter for reporting errors. Use the Merge View itself to report errors back. The presenter should have no references to the `System.Forms` namespace.

[retailcoder/Rubberduck] ckuhn203 pushed commit 0c5d563d to sourcecontrol

> sync Branch view's current branch with repo's current branch after merge

Duga

01:56

[retailcoder/Rubberduck] ckuhn203 commented on issue #352: Give User feedback about state of merge

> Test setup for the error condition will look something like this.

var provider = new Mock<ISourceControlProvider>();
provider.Setup(git => git.Merge(It.IsAny<string>(), It.IsAny<string>()))
.Throws(new SourceControlException("message", new LibGit2Exception("inner message"));

//Assert State of Merge View

1 hour later…

Mat's Mug

02:57

I guess that's clearer:

            // bug: doesn't acquire named parameter usage
            var targets = _declarations.Items.Where(declaration =>
                IsSelectedDeclaration(selection, declaration) || IsSelectedReference(selection, declaration))
                .ToList();

        private bool IsSelectedReference(QualifiedSelection selection, Declaration declaration)
        {
            return declaration.References.Any(r => r.Selection.Contains(selection.Selection));
        }

...and yet I don't understand why it wouldn't acquire target on a named parameter usage, if a named parameter usage is indeed picked up as a reference of that parameter ...which I know it is, since renaming a parameter does rename named parameters...

well, first off ...there wouldn't be more than a single declaration or reference matching the selection, so that Where and ToList are just mudding things up.

            _view.Target = _declarations.Items.SingleOrDefault(declaration =>
                IsSelectedDeclaration(selection, declaration) || IsSelectedReference(selection, declaration));

better.

Mat's Mug

03:17

oh, nice. _declarations contains duplicates.

Mat's Mug

03:28

hmm of course... there are multiple matches because everything inside a procedure also matches the procedure.

Mat's Mug

03:40

well problem one, I shouldn't have to care about the entire procedure's body - only for its name.

Mat's Mug

04:01

well well well

that's a nice workaround!

instead of fighting with the selection glitch, I embrace it, and then instead of looking for a selection within a selection, I make a new Selection out of the first character of the selected code, and look for that instead.

^^ that's totally unclear

        private bool IsSelectedReference(QualifiedSelection selection, Declaration declaration)
        {
            return declaration.References.Any(r => r.Selection.ContainsFirstCharacter(selection.Selection));
        }

        private bool IsSelectedDeclaration(QualifiedSelection selection, Declaration declaration)
        {
            return declaration.QualifiedName.QualifiedModuleName == selection.QualifiedName
                   && (declaration.Selection.ContainsFirstCharacter(selection.Selection));

#CodeIsBetterThanThousandWords

Mat's Mug

04:21

well, everything works!

The value statement assignment rule listener sucks though. I can't come up with any meaningful names here:

        public override void EnterVsAssign(VBAParser.VsAssignContext context)
        {
            // one of these is null...
            var callStatementA = context.Parent.Parent.Parent as VBAParser.ICS_S_ProcedureOrArrayCallContext;
            var callStatementB = context.Parent.Parent.Parent as VBAParser.ICS_S_VariableOrProcedureCallContext;
            var callStatementC = context.Parent.Parent.Parent as VBAParser.ICS_B_MemberProcedureCallContext;
            var callStatementD = context.Parent.Parent.Parent as VBAParser.ICS_B_ProcedureCallContext;

#ButHeyItWorks

Duga

[retailcoder/Rubberduck] retailcoder pushed commit 044dfc3f to next

> closes #347

Mat's Mug

oh damn, I thought I had switched back to refactorings

Duga

[retailcoder/Rubberduck] retailcoder pushed 3 commits to refactorings

Mat's Mug

back to next though, ... "FindAllReferences" isn't a refactoring

Duga

[retailcoder/Rubberduck] retailcoder closed issue #347: Refactor/Rename doesn't always select the correct identifier

[retailcoder/Rubberduck] retailcoder commented on issue #347: Refactor/Rename doesn't always select the correct identifier

> Fixed. Selection seems to work exactly as intended, it's like too good to be true.

Shortstuff81000

05:15

@Mat'sMug Hello, @Mat'sMug

Darn.

6 hours later…

RubberDuck

11:39

Hi there @Shortstuff81000.

Mat's Mug

12:37

@Duga selection works. Target acquiring in a large project does reveal a few more kinks though

It's dumb. I'm ignoring the module you're in, so if there happens to be another procedure in another module at the same line position, and the other module comes up first, I'm returning that lol

#RubberduckDebuggingWorks

Mat's Mug

13:39

And I should be working in a separate Navigation branch for find all references

RubberDuck

14:02

#RubberduckDebugging #Ftw

5 hours later…