[retailcoder/Rubberduck] 15 commits. 6 opened issues. 4 closed issues. 17 issue comments.

[retailcoder/Rubberduck] retailcoder commented on issue #314: Unhandled exception when opening VBA editor

> Let's first standardize how menu items are created. The RubberduckMenu class needs a Code Review post.

[retailcoder/Rubberduck] ckuhn203 commented on issue #314: Unhandled exception when opening VBA editor

@Mat'sMug what about a ToolWindow factory instead of our DockablePresenter? ^^

Not bashing it. You did great. It's a good solution, but I'm thinking there might be a better one. It feels like a "has a" relationship. Doesn't it?

Totally. And heck, I'd bash at it!

@RubberDuck I still think it deserves a CR post ;)

Hmm... A factory may not be right either.

I'm gonna sleep on it and build 1.21x86 in the morn.

Gotta finish this chapter tonight.

[retailcoder/Rubberduck] ckuhn203 added label help-wanted to issue #316: We need a developer/tester with Office 2013

[retailcoder/Rubberduck] ckuhn203 opened issue #316: We need a developer/tester with Office 2013

> A number of bugs have recently been reported that seem to only affect Office 2013. We could really use a hand detecting and fixing bugs in that environment.

[retailcoder/Rubberduck] christophocles commented on issue #315: Excel 2013 crashes and re-opens after attempting to close Excel

> I just had a similar crash with Excel 2007. Not exactly the same exception, but it crashed at the same point -- after closing VBA editor and then Excel. This one only happens if you close it while the Code Editor is still parsing. ************** Exception Text ************** System.Runtime.InteropServices.COMException (0x80070006): System Error &H80070006 (-2147024890). The handle is invalid. at Microsoft.Vbe.Interop._VBComponent.get_Name() at...

Rubberduck.UI.CodeExplorer.CodeExplorerDockablePresenter.<AddModuleNodesAsync>d__‌​15.MoveNext() in c:\Users\Christopher\Source\Repos\Rubberduck\RetailCoder.VBE\UI\CodeExplorer\Cod‌​eExplorerDockablePresenter.cs:line 122 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotificat‌​ion(Task task) at...

Rubberduck.UI.CodeExplorer.CodeExplorerDockablePresenter.<>c__DisplayClassd.<<Add‌​ProjectNodes>b__c>d__f.MoveNext() in c:\Users\Christopher\Source\Repos\Rubberduck\RetailCoder.VBE\UI\CodeExplorer\Cod‌​eExplorerDockablePresenter.cs:line 97 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.AsyncMethodBuilderCore.<ThrowAsync>b__4(Object state) ************** Loaded Assemblies ************** mscorlib Assembly Version: 4.0.0.0 Win32...

Accessibility Assembly Version: 4.0.0.0 Win32 Version: 4.0.30319.33440 built by: FX45W81RTMREL CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/Accessibility/v4.0_4.0.0.0__b0‌​3f5f7f11d50a3a/Accessibility.dll...

Version: 4.0.30319.34209 built by: FX452RTMGDR CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_32/mscorlib/v4.0_4.0.0.0__b77a5c561‌​934e089/mscorlib.dll ----------------------------------------

[retailcoder/Rubberduck] ckuhn203 commented on issue #315: Excel 2013 crashes and re-opens after attempting to close Excel

> That one makes sense. We can handle that I believe. It crashes because the VBProjects/Components are no longer available, but the parser is still trying to parse. Related yet separate issue.

[retailcoder/Rubberduck] gouf starred us

[retailcoder/Rubberduck] ckuhn203 closed issue #312: Code Explorer does not display all methods in a module

[retailcoder/Rubberduck] ckuhn203 commented on issue #312: Code Explorer does not display all methods in a module

> Duplicate of #286.

[retailcoder/Rubberduck] ckuhn203 added label duplicate to issue #312: Code Explorer does not display all methods in a module

@Duga RubberduckParser.Parse(VBProject) just needs a try/catch to swallow a COMException and we should be good to close #315...

Wouldn't it be better to null check?

And I don't think it closes #315. The parsing should have been its own issue.

It's not a NRE, but you're right it's probably better handled elsewhere; we need a way to abort creating tree nodes when the module gets closed while the TreeViewListener is creating nodes.

Oh, just realized the above stack trace was just a comment on the issue... I was referring to that stack trace ;)

I need to catch up with yesterday's events...

I need to build an installer. Lol

Right. So we get 1.21 out and then address all that in 1.22 or 1.3?

Like, master is on a feature-freeze until next release right?

And 1.21 branch should be closed now

I need to read those x64 links you gave me. Then when I get the x64 installer up I'll have to take screenshots for the release notes, the website's features page and the wiki

x64 has to work today

Yeah. 1.21 is closed. We need to kick whatever's left to a future release.

I figure if one bitness comes out before the other, we'll just add the first installer to the latest release.

Kids are watching Toy Story - booting now

@RubberDuck Not a very encouraging read...

Yeah. I'm gonna put a call out for a dev with 2013 on my blog.

Or do you mean the x64?

2013 x64 is definitely a stretch

x64 is a stretch

I can't even get it to work on my own machine

not even in a VS debug host

Does it get added to the add-in list? Where are the keys registering to?

I basically have #305 happening

nothing anywhere

changing config to debug - I think I need a regasm.exe to run

ugh, and my laptop is slooooooooooooow

debug64 config not working either

That's... Weird. The post build should be registering the keys (except the Addins64).

So, you're using "AnyCPU", Extracting Com Info and checked COM Interop for the dll, extracting but unchecked for the tlb... Extension is registered under add-ins64. Right?

That setup really should work. sigh

I'm just trying to get the debugger to work again right now..

@RubberDuck It is

Then we've exhausted my ability to debug this from afar... Idk what to do next.

IKR.. I broke it all by myself, I'll fix it all by myself ;)

Perhaps we could set up a TeamViewer this afternoon?

I do know that if the debugger isn't working, it's probably not looking at the right .dll.

This evening maybe?

Whatever works ;)

@RubberDuck Has to be it. Hopefully I'll get it to work soon, it's probably just a stupud thing again

Okay. In the mean time, you might want to check the CodeBase values in the reg. might get you closer to getting the debugger running again.

[retailcoder/Rubberduck] beckorz starred us

> we'll be counting stars

new features have been added to the draft x64 release notes.. missing bug fixes (and all the SC stuff)

@RubberDuck drumroll...

(config: debug)

(rebuilding against Debug64 config)

build 1.21.552.23407 (MSIL) works

configuration manager > Release64...

...

and VS just crashed

#FML

restarting

@RubberDuck it has to work if we target any CPU

there's no reason it can work in debug and not in release

building

oops. rebuilding

(wiped the \bin folder before copying the installer somewhere else!)

> uh, the setup is in another project, dummy!

installing

add-in could not be found.

back to square one

taking a break, will resume tonight

@RubberDuck this is the problem I think:

> 3>ISEXP : warning : -4354: The build was unable to extract COM information from the file C:\Users\Mathieu\Source\Repos\Rubberduck\RetailCoder.VBE\bin\Release64\Rubberduc‌​k.dll in component Rubberduck.Primary_output1. Please ensure that the file is self-registering and verify that the self-registration process does not fail.

you're catching up on me, mug ^^

@SimonAndréForsberg I'm not really trying ;)

today, neither did I :)

I don't like this though:

I think I answered 2-3 questions this week

Hmm

seems like I've answered 4 questions this week

If Loki doesn't try, then I will go past him sooner or later

@SimonAndréForsberg At the end, those who deserve the top, shall be on top ;)

naaaaw, thanks

and those who deservers the mugs, should get the mugs!

And you have a mug!

Did you see the SO mug review today?

What's all this talk about mugs?

@nhgrif The guy thought he was making a good joke this afternoon

No, I mean, who deserves mugs...? What's this?

Ah, when the time is right, first-pagers get CR swag!

Swag/mug/tees

codereview.stackexchange.com/…

That?

So I get stuff?

Should, yeah ;)

Usually comes along with the new design announcement

@Mat'sMug saw it. downvoted it.

> "tough crowd tonight"

I lol'd

RELOAD!