« first day (265 days earlier)      last day (2915 days later) » 

00:00
RELOAD!
[retailcoder/Rubberduck] 8 commits. 9 opened issues. 7 closed issues. 6 issue comments.
[skiwi2/HearthMonitor] 3 commits.
00:31
@RubberDuck Huh?
00:47
Nothing. I was being dumb.
01:28
> I just went through all of the issues and added ones without miles stones and ones attached to closed milestones to Future Versions. With v1.2 coming soon, it seems like a good time to stop, reflect, and talk about the next sprint. The first question I think we need to ask ourselves is, "What is the goal of the next sprint?" Are we aiming for v1.3 with some new features, or are we going to do some house cleaning? After we decide that, I think we'll be in a better place to decide what...
actual issues are going to be addressed in the next version. Personally I think we might want to consider putting some effort into adding tests, refactoring, and perhaps some of the more minor issues before moving onto v1.3. Thoughts @retailcoder?
> Even if this could be done (and I'm not sure it can be), what's the benefit? Why did we want to do this?
> We've talk before about whether or not it makes sense to export the files before parsing in order to get to the attributes. This is a great case for doing that. It would allow us to pick up the PredeclaredId attribute. If it's true, the class has a default instance. Which means it is declared and this inspection shouldn't pick it up. Of course, that would probably mean regenerating the parser from a new grammar.
01:57
@Duga Nope. The grammar already parses the module header attributes ;)
> The .g4 grammar we're using already handles module-header attributes - no grammar change is needed for this!
> I wouldn't want to release 1.3 without any new features, even if the entire code base gets refactored to death and the whole thing ends up completely rewritten - I agree, we have some cleaning up to do, and we need a truckload more unit tests... but releasing something that's just under the hood isn't ideal IMO. Perhaps start with a cleanup and release a v1.25 if the cleanup translates into better performance and overall UX? I wanted 1.2 to mainly hint at refactoring and expand on code...
inspections - I'd like 1.3 to be released with integrated source control and expand on refactorings (and to include inspections we couldn't fit into 1.2).
02:24
> Okay. I'd say we're on the same page then. I wouldn't want to release 1.3 without new features either. I think a 1.2.1 is in order. So, yes, under the hood improvements should be made, but with an eye on performance & UX as well. I'm on board with this. (Even though I'm dying to hack out the source control integration).
Awesome news Mug. I didn't realize the grammar could handle the attributes. That's cool.
Heading to bed. Will work on some thorough testing /or release notes tomorrow.
'night!
 
4 hours later…
06:34
http://www.rubberduck-vba.com is live! There's not much there yet really, but still... #makesmyday
hey @Phrancis!
hey @Mat'sMug!
^^ made with GoDaddy's WebsiteBuilder
That is not bad at all!!
thanks! about 4 hours in the making
It needs a little more suffering tweaking
06:37
certainly
should I have waited a little more?
Absolutely not
Content is good, my only constructive criticism is to change the link color to something a bit darker. Light-gray links on a white BG are hard to see
Par exemple, "Rubberduck is open-source! Follow us on <here>GitHub</here>, fork our repository, and contribute to a little revolution."
Other than that, good lookin'!
good point; I'll also make the Rubberduck top-left label link to the home page
Just checking in, was out playing pool with a friend, guy who got me into SQL to begin with. We about tied on pool, but he also made multithreaded functions in TSQL 2014, so I guess he wins
He said he refactored a sproc from 30 minutes to 48 seconds exec time using techniques like that, pretty impressive
aye
TTGTB here
'night!
'night!
 
4 hours later…
10:31
@Mat'sMug That's....... awesome.
One step closer to qualifying for all those free open source licenses. =)
 
1 hour later…
 
1 hour later…
13:13
@RubberDuck Oh, right! I had forgotten about that... what else do we need to qualify?
I don't recall. It's a little different everywhere. What were we talking about @Mat'sMug? R#?
> You are the project lead or a regular committer.
Your OS project meets the Open Source definition.
You do not perform any paid support, consulting or training services for your OS project, and you do not distribute paid versions of your OS software. If you provide paid services for or distribute paid versions of your OS software, we might have other options available for your project. Please contact us at [email protected] for details.
Your OS project is being actively developed for a minimum of 3 months.
We would also have to start packaging the source code along with the installer.
Then again. Once they install VS on this machine, I might just buy it anyway. The company won't pay for it, but I think it's worth it.
 
1 hour later…
14:44
@RubberDuck Well, looks like we do qualify now, no?
Oh, missing the source with the installer
Might have to make sure we have obvious links to the twitter account as well. I know it's there, but not so obvious that's where people can get the latest "news".
15:23
the WebsiteBuilder plan I took is for 1GB storage and... 5 pages. Let's see...
1. Home
2. News
3. Features
4. Contributing (that page needs more content!)
5. Contact Us / Feedback
Looks right to me.
> Does your IDE support outline view of your program; jumping to definitions of classes, routines, and
variables; source code formatting; brace matching or begin-end matching; multiple file string search
and replace; convenient compilation; and integrated debugging?
Does now! page 43
> Do you have tools that automate common refactorings?
Getting there
> Are you using version control to manage source code, content, requirements, designs, project plans,
and other project artifacts?
Soon.... soon.
> Does your test environment include an automated test framework, automated test generators, coverage
monitors, system perturbers, diff tools, and defect tracking software?
Yup. Now it does.
All things in the Code Complete Tools checklist that Rubberduck adds to the VBE.
well, not exactly coverage monitors there, but yeah ...lol
I decided reading Code Complete would be a better use of my time than phoning it in at some Java 101 class.
Ordering it now.
15:45
Are you effing kidding me? $1.66?? Damn it.
 
1 hour later…
16:57
@RubberDuck I just published some changes to rubberduck-vba.com - LMK your thoughts! :)
17:09
ah, another SO post that would have been prevented with Rubberduck! stackoverflow.com/q/28748240/1188513
(or MZ-Tools)
Looks really nice @Mat'sMug.
I don't see where you use SAVE_PATH — Porcupine911 8 mins ago
Smh... The world needs Rubberduck.
What's Smh?
shaking my head
> I always wanted to chat with a duck.
3
LOL. You chat with a duck every day.
but now it's on the Contact Us page :)
> This project started on Code Review, a Stack Exchange site. You can almost certainly find us in the VBA chatroom. If we're not there, ping us!
17:23
Yeah. I saw that. =)
17:48
Re: release notes - looks good; perhaps list the new inspections and link to their respective issue# ? (I can do that tonight if you want)
17:59
@Mat'sMug Sure. That's fine. I didn't know how many there were. Didn't want to clutter things, but putting them there would make it look like the huge release it is.
I'm going to take a look at the Extract Method refactoring to see if I can't get it ship ready.
Ummmm @ticker... it's called a VLOOKUP
@RubberDuck Hadn't. Can you add screenshots or code example? It works as intended with the FizzBuzz code... Sure indentation is messed up, but it does replace the extracted code with a call to the new method. Aside from indentation, the only glitch I see is that it doesn't remove locals left unused.
@Mat'sMug Yeah. I'll open an issue. Getting around to it. In the meantime.... wow. Just.... wow.
0
Q: Modify the path

user4563174I have this code, that open all the files. The path is written in the cell (1,1). Eventually in the end of the path I have to put \, so I want to know if there is something that I could do for put \ automatically in the end of the path. Sub openfiles() Dim directory As String, fileName As Str...

The indentation isn't a huge problem, but it would be nice to fix. It's the code not inserting the new method that's not cool.
I want to create a clean project to reproduce with.
@RubberDuck It inserts it at the top of the module...
18:14
@Mat'sMug Not always..
I just checked it.
The call didn't get inserted either. I want to see how it behaves in a clean project.
Annoying. I need samples :)
I know. I know. Trying to repro. I can't toss my entire code base in an issue.
Repro'd. Getting screen shots together.
Cool
A bug that's found is a bug that's already half-fixed :)
4
So.. it removes the selected code, but doesn't create the new method+inline call?
/s/bug/*undocumented feature*
@Mat'sMug ^
Unshippable undocumented feature. lol
@Mat'sMug I find bugs before they even exist
18:21
@skiwi That's because you're secretly a machine.
in TCG Creation, 8 hours ago, by skiwi
If you name your player GameEntity, then the log reader will break down
LOL. That's awesome.
Also, not a bug. It's a feature.
I believe I can work-around it eventually
but not going to do that in the first release as it'll complicate things
And how many players are named GameEntity after all?
@RubberDuck what do you get if you only select one or two of the .Add calls, and extract that?
@Mat'sMug Already ahead of you.
@skiwi Me!
18:25
Huh?
Gimme a break, I'm on my phone here! lol
Same thing.
Public Sub DoSomething()

    Dim col As New Collection
    col.Add 1
    col.Add 3

End Sub
I selected these two lines.
col.Add 2
col.Add 3
Wasn't col picked up as a parameter?
18:28
I know why; that has to do with detecting usages of object members - gotta figure that one out...
It's not seeing col.Add as a usage of col - I bet inspections say col is never used.
I'm glad you know!
Now, can this issue be repro'd without involving objects?
Should you comment your variables? No. You should name them properly. If a variable has a nice descriptive name, there's nothing left to comment on. — RubberDuck 45 secs ago
@Mat'sMug Give me a minute.
Let me try.
(I think not - the bug is most probably in VariableUsageListener)
If not, then by fixing the listener we kill 2 birds with 1 stone :)
You mean that you can stone two birds at once?
18:42
WTF?.......
Method1 = i? Is that weird?
@skiwi I believe that assigns the return value for the method
Did you have str in the return value dropdown?
or @RubberDuck (the program) is doing something very strange
@SimonAndréForsberg Exactly
18:45
@Mat'sMug No. Just i.
Because the original isn't using it after...
Where did the i parameter go?
Try adding msgbox str after the loop, and then extract
Extract the middle of the loop?
18:47
Looks better. Let's see what happens when I hit ok.
Now there is another issue - declaration shouldn't be moved to new method if it's a for loop counter
Works flawlessly.
Ah good
Private Function Method1(ByVal i As Integer) As String

    Dim str As String
        str = "HelloWorld" & i
    Method1 = str
End Function

Public Sub DoSomething()

    Dim str As String
    Dim i As Integer

    For i = 0 To 9
    str = Method1(i)
    Next

    MsgBox str

End Sub
So it's all about object usage then!
18:55
@Mat'sMug @RubberDuck site suggestions: This site is under construction. isn't really necessary to say on the front page, you could show it on news and features though. also, I'd recommend adding a border around the image carousel at the bottom
@SimonAndréForsberg Thanks!
Honestly, the front page looks proffesional enough so "This site is under construction" was not something I expected to see.
3
eh, so I did something right then! :)
You guys' project is starting to bring some new vernacular to CR ;)
@Phrancis that's not the project, that's @RubberDuck the user!
also don't forget this:
in TCG Creation, 15 mins ago, by Simon André Forsberg
@skiwi quack quack quack? quack? quack.
2
19:05
@SimonAndréForsberg better?
@Mat'sMug Are you writing any actual HTML/CSS or does the wizard do all that for you?
it's WYSIWYG / drag-n-drop / dummy-proof
@Phrancis there's actually a bit of programming lore behind that (and thus my username).
quack
Judging after looking at the source code for the page, there is no way you could write code this ugly lol.
(oh, and there's PHP in it lol)
@ticker closed in 3... 2...
@Mat'sMug I don't have those privileges on super user...
me neither
but I expect it to burn ...fast ;)
didn't the TODO explorer refresh as it showed up? it's not happening anymore...
@Mat'sMug Might have happened when I pushed the dependencies up the chain??
19:26
no idea
Is it not happening at all, or you added one that you expected to see?
I opened a macro-enabled workbook, added a comment "'TODO: insert/update records in database", and then brought up the Todo Explorer - had to refresh.
and if I close the explorer and add another TODO comment, and bring back the explorer, I still have to refresh.
It parses when the add-in is launched I believe. Makes it come up fast when opening the tool, but there's that downside that I hadn't considered.
I'm sure I can do something about it. Can you open an issue please? Got tied up in something.
thanks
19:40
@Mat'sMug our data team just ran my big string-matching query from yesterday, turned out 25K records which I will have fixed in one massive update
Just found one Model_Number field with this data lol: RHL;A HM 417JA
I'm surprised the ; did not break something
Must have escaped it since it was VARCHAR I guess
19:54
@Mat'sMug "Den här webbsidan är inte tillgänglig" (This webpage is not accessible) - awesome! Where did you get an innovative design idea like that? Although it doesn't say much about your project...
oh, it was my internet...
huh?
@RubberDuck found an actual extract-method-specific issue - parameters shouldn't be ByRef here:
hmm and the inspection doesn't see that they can be passed by value... weird
I'm on a plane.
2
I'm a duck. I don't need a plane.
Entertain me for the next 2.5 hours.
Coding from 38k feet.
4
20:09
Can't. The sky is falling down.
I've run out of work to do
Time to whore ?
@Chrismas007 check out rubberduck-vba.com :)
@RubberDuck OMG I LOVE THIS EXTRACT METHOD TOOL
4
20:29
(proceeds to delete tons of redundant code)
@Mat'sMug Yeah. I didn't realize how often I reach for it in VS until I was working on that project here at work the other week.
I kept cursing when it wasn't in my right click menu
> todo: add a Refactor menu to the VBE context menu
yay!
(I knew already, phone buzzed ;)
2
@Mat'sMug Clearly you are too tech savvy for me :-P
20:33
lol
@Mat'sMug Your wife will be mad if you keep your phone buzzing at every follower a few months in!
good point :)
20:53
0
Q: VB UserForm having issues

Mariusz LewandowskiLong time listener first time caller here. So please go easy one me. Also a VBA newb. I am working on a UserForm to make input easier. And I am constantly getting a "COmpiler error: Sub or function not defined" I'm lost 'Sub soc_userforum_Initialize() soc_userform.SetFocus End Sub Sub tb_add...

I ♥ SqlCommand
Private Sub InsertWorksheetData(ByVal data As Collection, ByVal cn As ADODB.Connection)

    Dim record As WeeklyPlanItem
    For Each record In data
        SqlCommand.ExecuteNonQuery cn, SQL_INSERT, _
            record.FiscalYear, _
            record.FiscalWeekOfYear, _
            record.OrderTypeGroupId, _
            record.PlanningGroupId, _
            record.CategoryId, _
            record.LY_Units, _
            record.LY_Sales, _
            record.PL_Units, _
            record.PL_Sales, _
Private Const SQL_INSERT As String = _
                "INSERT INTO dbo.PlanningAndForecasting (" & _
                    "FiscalYear, FiscalWeekOfYear, OrderTypeGroupId, PlanningGroupId, PlanningCategoryId, " & _
                    "LY_Units, LY_Sales, PL_Units, PL_Sales, AF_Units, AF_Sales, DateInserted) " & _
                "VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, GETDATE())"

Private Const SQL_UPDATE As String = _
                "UPDATE dbo.PlanningAndForecasting " & _
                "SET DateUpdated = GETDATE(), " & _
@StackExchange Off-topic for CR?
indeed
21:11
@skiwi Let's hope so.
Southwest WiFi is sooooooooooooooooooooo sloooooooowwwwwwwwwwwwww
@StackExchange Getting me all excited over nothing....
Again.
21:39
signing off for a bit
21:52
Yikes. Things are way too serious in the 2nd Monitor right now.
2
in The 2nd Monitor, 6 mins ago, by Jeroen Vannevel
An unintended side-effect is not a feature, simple as that
in The 2nd Monitor, 8 mins ago, by nhgrif
I can't tell if you're serious or not...
in The 2nd Monitor, 8 mins ago, by nhgrif
But if you are, good luck having any job even remotely related to software development.
22:04
@RubberDuck Well that Escalated Quickly
user image
2
LOL. Yes it did.
See ya @Chrismas007. Nice to have you back in chat for a bit.
@RubberDuck Later
22:34
@RubberDuck You know young people always know everything... After one becomes older they learn to talk less and listen more :)
23:22
Amen @Phrancis.

« first day (265 days earlier)      last day (2915 days later) »