« first day (262 days earlier)      last day (2918 days later) » 

00:00
RELOAD!
[retailcoder/Rubberduck] 17 commits. 1 opened issue. 6 closed issues. 5 issue comments.
aawwww
> closes #241
Missed it by only a moment eh?
a few seconds!
// SoundSpeed.java
package Chapter2;

public class SoundSpeed {
	final double SOUND_TRAVEL_SPEED = 1100;
	double timeInSeconds;
	double getResult() {
		return timeInSeconds * SOUND_TRAVEL_SPEED;
	}
}
// SoundSpeedEchoTest.java
package Chapter2;

class SoundSpeedEchoTest {
	public static void main(String args[]) {
		SoundSpeed soundSpeed = new SoundSpeed();
		double echoTimeInSeconds = 35.079;
		soundSpeed.timeInSeconds = echoTimeInSeconds / 2;
		System.out.println("The sound took " + echoTimeInSeconds + " seconds to echo "
00:03
> clean up; reinstate run all tests menu button
See anything in the above you'd do a bit differently?
@Phrancis yup. I'd write it in C# ;)
I like being explicit about member accessibility. fields would be explicitly private
As in SOUND_TRAVEL_SPEED and timeInSeconds you'd make private?
00:06
they're private already, but implicitly. so yeah
> replaced old test engine with new test engine
3
Ah ok
Everything else look OK?
@Mat'sMug are you sure that doesn't actually do something?
yeah. @SimonAndréForsberg would probably say something about extenibility though
Er...
> Exception in thread "main" java.lang.Error: Unresolved compilation problems:
The field SoundSpeed.timeInSeconds is not visible
The method getResult() from the type SoundSpeed is not visible
Looks like in Java they're implicitly public no?
00:09
Yay compiler errors!
(They're better than runtime errors. Here's looking at you Ruby...)
That was after I made the fields private like mug suggested
Sounds like something is trying to access those public fields.
    Public foo As Integer

    Public Sub setfoo(ByVal value As Integer)
        Dim foo As Integer
        foo = value
        Debug.Print ThisWorkbook.foo
    End Sub
@RubberDuck yeah
> ThisWorkbook.setfoo 1234 >> outputs 0
and VB doesn't complain about "duplicate declaration in same scope" as it would if value was called foo
But Debug.Print foo should print value, right?
no, only the local foo is assigned; field foo isn't.
i.e. the local identifier is silently hiding the module-scope field
Ahhhh gotchya.
This is my kind of pull request btw.
[retailcoder/Rubberduck] ckuhn203 pushed 7 commits to master
> Merge pull request #242 from retailcoder/UICleanup

Test Explorer Refactor
> Pull Request #242 went a long way toward cleaning up the Test Explorer, but there's still a lot of logic bound up in the view that should probably be in the presenter.
holly shhh
(crosses fingers)
00:24
Did I break it?
(syncing)
> extracted UnassignedVariableUsageInspection code file
> Merge branch 'master' of github.com/retailcoder/Rubberduck
YEAH!
@RubberDuck I mean, no!
lol. Okay then.
I think I got it. Funny how you can sometimes tell what people mean when you shouldn't be able to.
00:27
starbait... =)
Code Inspections look good man. Can't wait to run it on a real project.
Spend an hour fixing all the things.
Version 1.2 is 91% complete with 0 code related issues left.
2
        public override IDictionary<string, Action<VBE>> GetQuickFixes()
        {
            return new Dictionary<string, Action<VBE>>
            {
                // no, really. this one's on the user.
                //{"Remove variable usage", RemoveVariableUsage}
            };
        }
@RubberDuck Maybe you can fix that crap that your company paid good money for
VariableNotDeclaredInspectionResult
00:39
On Error GoTo Sucks
2
@Phrancis Insta-pin
@RubberDuck and I'm still adding ad-hoc inspections left and right..
like this VariableNotDeclaredInspection, that shows what variables are undeclared before the VBA compiler complains about 'em
I'll build a pre-release when I have a moment and dogfood it as best I can.
bbl
> added VariableNotDeclaredInspection, fixed unassigned variable usage inspection
01:18
> fixed issue with IdentifierUsageInspector.UndeclaredVariableUsages
@RubberDuck there are 2 issues we can take down tonight: #201 will be completed before I go to bed, and #237 can just be agreed upon / modified to reflect what we think things should be, and then #238 is just a matter of linking to the wiki pages, replacing content in the readme file. where you do stand on #195?
@Mat'sMug I've done some research. Gonna give it a shot tomorrow.
Part of why I want to build a pre-release.
2.1's looking good :)
It is. Looking very good.
I'm a bit scared of variable usage inspections though
02:16
Just remember, we have no bugs. Only undocumented & unwanted features.
I'm sure there's tons of corner cases that users will ... that ^^
lol
And if we can crush the bugs in dockable presenter and test explorer, we can crush any bug out there.
relevant
Observe how this bug report is handled. jira.mongodb.org/browse/PYTHON-532Eric Lippert yesterday
02:31
> no problem. I understand your frustration. Thanks again for the report.
I like how the guy eventually calmed down and apologized.
@Duga that is so cool, look at all these inspections!
03:35
How in the world did you edit all those wiki pages at once?
I didn't
but I merely removed the first 2 lines of each page, was pretty quick ;)
they're all in the same format, did you see?
True
Monkeys are good at making Java very complicated flexible!
oh I missed all the discussion over there, busy editing wiki pages on GitHub ;)
04:56
05:25
06:01
ok no, inspections take waaaaay too long to run on a large project.
> 96% complete
> Closing this issue - open an [enhancement] issue if an inspection severity should be modified.
> - [ ] Do something about code inspection performance.
- [ ] Add checkmarks to this list.
lol, I meant - [ ] Add checkboxes to this list
TTGTB
> various little fixes.
> Merge branch 'master' of github.com/retailcoder/Rubberduck
> IdentifierUsageInspector must be refactored/optimized into a singleton or something - it's doing too much unnecessary/redundant work.
 
5 hours later…
11:33
> Updated Version Number, tweaked release build config
 
1 hour later…
13:12
@RubberDuck there's a big problem with inspections, a large enough code base can bring it to its knees, performance simply isn't there - the inspector class should at least cache its results
13:30
Having some trouble with the new installer too.
 
1 hour later…
14:59
Just got word. 2 years to move all 15k LoC from Access VBA to VB.Net.
@RubberDuck Good or bad thing?
@Phrancis bOTH.
15:21
good morning everyone of you
Good morning @JLILIAman
H R U?
15:57
Panicking.
It took 3 years to get that application stable and all of those features built.
Now I'm being asked to rebuild it from scratch in less than 2. Without a feature freeze.
Can't it be C#?
@RubberDuck if there are frequent changes, that sounds like a dangerous project...
@Mat'sMug I'll fight that fight you better believe it.
And it is a dangerous project. GD nightmare is more like it.
But, if we're going to do this, we're going to get Git and we're going to TDD.
I'll mutiny otherwise.
@RubberDuck Sounds like a cluster.
My boss has no idea what he's asking me to do. He's not a dev.
He has no idea how time intensive and expensive it will be to re-develop that app again.
It's already a redevelopment and consolidation of some odd 10 tools.
3 years.... God. I can't spend another 3 years redeveloping this.
16:25
@Mat'sMug is there a minimum java version for ANTLR?
16:40
@RubberDuck sure is... 6 maybe?
I'm running 6 on this machine. Shite.
I'm out of ideas at this point.
Side note, I'm very happy about the work done this weekend! :)
Wait ducky is using Java now?
17:00
No. No Java. Just using a library built on java.
Ah ok thought you had a fever there for a moment ;)
17:39
Nope. Still seeing sharp.
18:03
It's the lib2git library I think. Also, for some reason, Visio. Killing the Visio reference. Will need to build a x64 and x86 versions of the installer... Fun fun.
Installshield sucks. There has to be a better option for this.
18:31
@RubberDuck performance issues are a showstopper though... they gotta be addressed before releasing :)
1, make it work; 2, make it work faster; 3, make it pretty
18:58
I think I'll have to change the ParseResult class to include an IdentifierUsageInspector instance, so that all inspections can reuse it without having to walk the parse tree all over again. And it would make it leverage the caching in place I think, so unused variables don't need to be re-discovered for a module that didn't change.
 
1 hour later…
20:02
@Mat'sMug It's pretty bad huh?
20:21
It's beyond that... performance simply hasn't been taken into account. Will fix during the week, if not tonight ;)
Okay. Still trying to figure out which native binary to use.
Had to get some real work donw.
21:03
I'd like the inspections to run async, and then have the grid populate as inspection results come in - and I'd add a progress bar too, since I suspect larger projects will take a little while anyway.
Grid bindings are getting dropped, switching to manual mode for this.
21:35
> Update fsview.bas
> Merge pull request #18 from ptwales/master

Update fsview.bas
OH! Hi @cheezsteak!
...... I miss doing VBA for fun.
22:18
Sub TimeZone()

Dim LastRow As Long, CurRow As Long

LastRow = Range("A" & Rows.Count).End(xlUp).Row

For CurRow = 2 To LastRow
    Select Case Range("F" & CurRow).Value
        Case "AL", "IA", "IL", "IN", "KS", "KY", "MN", "MO", "NE", "OK", "TN", "TX", "WI"
            Range("M" & CurRow).Value = "Central"
        Case "MI", "NC", "NY", "OH", "PA", "SC"
            Range("M" & CurRow).Value = "Eastern"
        Case Else
            Range("M" & CurRow).Value = "Unknown"
    End Select
Next CurRow
Stupid VBA usage of the day
 
1 hour later…
23:48
Nooooo. Thou shalt not code time zones..

« first day (262 days earlier)      last day (2918 days later) »