RELOAD!

[Cardshifter/Cardshifter] 1 commit. 1 opened issue. 2 issue comments.

[Cardshifter/cardshifter.github.io] 4 commits. 2 issue comments.

[retailcoder/Rubberduck] 4 commits. 1 issue comment.

[Zomis/GithubHookSEChatService] 7 commits.

moahahaha, Cardshifter won today!

But I beat you all!

@SimonAndréForsberg We're going to get quite active next week, preparing for release of v1.2

[retailcoder/Rubberduck] retailcoder assigned retailcoder to issue #201: Update Code Inspections Wiki

[retailcoder/Rubberduck] retailcoder assigned retailcoder to issue #211: Update ReadMe screenshots & "Coming Up" section

[retailcoder/Rubberduck] retailcoder added label user-interface to issue #237: Review inspection severity

[retailcoder/Rubberduck] retailcoder added label discussion to issue #237: Review inspection severity

[retailcoder/Rubberduck] retailcoder opened issue #237: Review inspection severity

[retailcoder/Rubberduck] retailcoder added label code-inspections to issue #237: Review inspection severity

40 clicks in 10 days

I feel like removing it. I don't like collecting downvotes, and having the ad go below 6 would be a shame.

Deleted

> 3 downvotes, zero comments. What a lovely constructive community.

Really downvotes?

Wonder why?

I know why. VBA

[retailcoder/Rubberduck] ckuhn203 commented on issue #237: Review inspection severity

[retailcoder/Rubberduck] FordCoder starred us

@Duga Yeah!

@RubberDuck apparently the guy joined GitHub to star us!

        public virtual void Show()
        {
            try
            {
                _window.Visible = true;
            }
            catch (COMException e)
            {
                // bug: this exception shouldn't be happening. see issue #169.
            }
            catch (NullReferenceException e)
            {
                // bug: this exception shouldn't be happening either. may be related to #169... or not.
            }
        }

[retailcoder/Rubberduck] retailcoder added label meta to issue #238: ReadMe file reads like a blog

[retailcoder/Rubberduck] retailcoder opened issue #238: ReadMe file reads like a blog

> That readme file needs to get more to the point; let's keep the docs in the wiki, and let the readme be an entry point to the wiki pages - the time spent maintaining the readme file could be spent improving the wiki. - [ ] Move features section to wiki pages The "coming up" section should also be in the wiki, on some what's new in 1.2? page. - [ ] Move coming up section to wiki pages That leaves the intro (which could be revised), a list of links to wiki pages, and then all the bottom...

sections.

[retailcoder/Rubberduck] retailcoder removed label help-wanted from issue [#198: Remove [ComVisible(false)] attributes sprinkled everywhere](github.com/retailcoder/Rubberduck/issues/198)

[retailcoder/Rubberduck] retailcoder commented on issue [#198: Remove [ComVisible(false)] attributes sprinkled everywhere](github.com/retailcoder/Rubberduck/issues/198)

> !image

R# FTW

    public enum CodeInspectionType
    {
        LanguageOddities,
        MaintainabilityAndReadabilityIssues,
        CodeQualityIssues
    }

[retailcoder/Rubberduck] retailcoder commented on issue #237: Review inspection severity

> Indeed. Here's the inspections inventory, with their respective type and default severity level: - ImplicitByRefParameterInspection (CodeQualityIssues) | Warning - ImplicitVariantReturnTypeInspection (CodeQualityIssues) | Suggestion - MultipleDeclarationsInspection (MaintainabilityAndReadabilityIssues) | Suggestion - NonReturningFunctionInspection (CodeQualityIssues) | Warning - ObsoleteCallStatementInspection (LanguageOpportunities) | Warning - ObsoleteCommentSyntaxInspection...

(LanguageOpportunities) | Suggestion - ObsoleteLetStatementInspection (LanguageOpportunities) | Warning - ObsoleteTypeHintInspection (LanguageOpportunities) | Hint - OptionBaseInspection (MaintainabilityAndReadabilityIssues) | Hint - OptionExplicitInspection (CodeQualityIssues) | Warning - VariableNotAssignedInspection (CodeQualiftyIssues) | Hint - VariableTypeNotDeclaredInspection (CodeQualityIssues) | Warning And then there are a few others down the pipeline: -...

CanPassByValInspection (LanguageOpportunities) | Suggestion - ModuleOptionsFirstInspection (MaintainabilityAndReadabilityIssues) | Suggestion - CanPromoteStaticLocalInspection (MaintainabilityAndReadabilityIssues) | Hint - BadNameInspection (MaintainabilityAndReadabilityIssues) | Suggestion - CanExtractGoSubProcedure (MaintainabilityAndReadabilityIssues) | Warning - SetOnlyPropertyInspection (MaintainabilityAndReadabilityIssues) | Warning - AssignedInDeclarationInspection...

(LanguageOpportunities) | Hint - VariantUsageInspection (MaintainabilityAndReadabilityIssues) | Hint - CanCollapseIfBlockInspection (LanguageOpportunities) | Suggestion - CanReduceNestingInspection (MaintainabilityAndReadabilityIssues) | Suggestion - UnusedFunctionReturnValueInspection (CodeQualityIssues) | Suggestion - OnErrorResumeNextInspection (CodeQualityIssues) | Warning - CanExtractRedundantCodeInspection (CodeQualityIssues) | Suggestion

[retailcoder/Rubberduck] retailcoder pushed commit 143488a7 to master

> removed ComVisibleAttribute usages

[retailcoder/Rubberduck] retailcoder closed issue [#198: Remove [ComVisible(false)] attributes sprinkled everywhere](github.com/retailcoder/Rubberduck/issues/198)

[retailcoder/Rubberduck] retailcoder commented on issue [#198: Remove [ComVisible(false)] attributes sprinkled everywhere](github.com/retailcoder/Rubberduck/issues/198)

> 143488a7 closes this issue.

oops

[retailcoder/Rubberduck] retailcoder opened issue #239: ObsoleteGlobalInspection

[retailcoder/Rubberduck] retailcoder added label code-inspections to issue #239: ObsoleteGlobalInspection

[retailcoder/Rubberduck] retailcoder assigned retailcoder to issue #239: ObsoleteGlobalInspection

[retailcoder/Rubberduck] ckuhn203 commented on issue #239: ObsoleteGlobalInspection

> I think this falls under "Suggestion". It doesn't cause any harm or confusion.

[retailcoder/Rubberduck] ckuhn203 commented on issue #237: Review inspection severity

@Mat'sMug Did that break the config? It's okay if it did. Just need to alert users in the release notes if it did.

Also, might just want to bite the bullet and call it Maintainability and be done with it.

[retailcoder/Rubberduck] ckuhn203 commented on issue #238: ReadMe file reads like a blog

> The features should stay in the ReadMe. The read me is the first thing people see when they go to the repo. We shouldn't hide what the project does behind a link. I agree though, we could trim the readme down a bit.

[retailcoder/Rubberduck] ckuhn203 commented on issue #226: Make remote location argument optional in ClassFactory.CreateRepository

> We're running short on time for this sprint and this is a backward compatible change. Kicking it to 1.3.

[retailcoder/Rubberduck] ckuhn203 commented on issue #225: ISourceControlProvider needs a DeleteBranch method.

> Same as #226. Sprint is almost up and this is backward compatible. Kicking to 1.3.

[retailcoder/Rubberduck] ckuhn203 pushed 24 commits to UICleanup

[retailcoder/Rubberduck] ckuhn203 pushed commit e97813f1 to UICleanup

> Merge branch 'master' of github.com/retailcoder/Rubberduck into UICleanup

[retailcoder/Rubberduck] ckuhn203 pushed commit 046a1d9f to UICleanup

> fixed build; idk why there was a reference to outlook in this file

hmm... parenthesis in links (needs to be tested)

wait, what? Why did it work for me?

stuff in [links [needs to be fixed]](codereview.stackexchange.com)

there we go

stuff in links [needs to be fixed]

violà

Monking @SimonAndréForsberg!

hey ducky

Looks like I'm getting into multi-threading. I'm frightened.

Fun! Fun! Fun!

lol. Yeah. I don't like writing code I don't understand. =)

multithreading isn't that complicated

Not when you have years upon years of abstraction to work with.

I wouldn't want to actually work with threads.

at least you C# folks have async await and stuff...

and you do have some kind of ExecutorService stuff as well, right?

No idea. Kind of stumbling in the dark right now.

hopefully @Mat'sMug knows

I think I might just have it.... we'll see.

[retailcoder/Rubberduck] ckuhn203 pushed commit 41abe5ce to UICleanup

> TodoExplorer gets wait cursor while parsing; #171 begins

@RubberDuck Task.Run(() => { ... });

Nope.

Gives errors because it's trying to update the GUI on two threads.

Only the GUI thread can update the GUI from what I can gather from the exception.

Exactly. Look for (MethodInvoker) casts in the code base

I cast an inline delegate to invoke the GUI update - can't do it directly.

@RubberDuck found it?

Basically, each thread owns its own stuff, and cannot access objects owned by other threads. So you invoke a delegate on the UI thread, from the background one - and then the UI update runs on the UI thread :)

...at least that's how I understand it!

There's a CR about what I wrote @Mat'sMug. @Duga seems to be down, but I fixed some things.

github.com/retailcoder/Rubberduck/issues/171

@RubberDuck Cool!

$5 the first answer suggests async/await ;)

You might be right.

(mine would.. no time now :(

That seems unnecessary though. The result assignment makes it wait. idk. Like the post says, I've never written a lick of multi-threaded code in my life.

I've gone down the rabbit hole and come back around to that com exception again. Properly disposing of things causes it... Somehow. But I did find the null exception in dockable presenter base.

I can't commit. I can't fix it. I don't know what to do.

Yes I do.

Merge the last sync and grab a beer. It was from before I started this mess.

Or... Stash my changes and make sure it was stable first. Yeah. That's a good idea @Ducky.

It's not me. Master has the same issue.

Oh wow, I borked the extract method refactoring.. while refactoring :(

Fixed.

Oh, and inspections say "variable is never assigned" ...for a Const lol

I must have been more tired than I thought I was

Same issue in 1.1 too.

[retailcoder/Rubberduck] ckuhn203 reopened issue #169: Closing a dockable window causes it to crash when it's subsequently reopened

[retailcoder/Rubberduck] ckuhn203 commented on issue #169: Closing a dockable window causes it to crash when it's subsequently reopened

the test explorer is... not using a base presenter :(

we need to investigate what's happening to the window host in both scenarios

[retailcoder/Rubberduck] ckuhn203 commented on issue #169: Closing a dockable window causes it to crash when it's subsequently reopened

> the test explorer is... not using a base presenter :(

lol

Gotta keep track. This has been driving me nuts for months.

the presenter is written though, it's just not used yet

selfie:

[retailcoder/Rubberduck] retailcoder pushed commit fdd586e7 to master

> fixed a bug introduced in 31a695c4 - an IEnumerable<QualifiedContext<TContext>> can't be filtered with .OfType<TContext> directly, must select the context first.

and boom

[retailcoder/Rubberduck] retailcoder pushed commit de1414b0 to master

> fixed a bug where VariableNotAssignedInspection would complain about... constants never being assigned to.

[retailcoder/Rubberduck] retailcoder pushed commit ad2b5bcf to master

> Cleaned up VariableNotAssignedInspection

[retailcoder/Rubberduck] retailcoder pushed commit 9c20bce1 to master

> removed unused "using" statements

[retailcoder/Rubberduck] retailcoder pushed commit 7db6d9d9 to master

> added generic type constraint on TContext - method was extending every single type out there...

@Duga talk about micro-commits!

[retailcoder/Rubberduck] retailcoder pushed commit 62b5a024 to master

> added Equals and GetHashCode overrides for QualifiedContext<TContext>

[retailcoder/Rubberduck] retailcoder pushed commit ea52bc95 to master

> fixed/reimplemented VariableNotUsedInspection

voilà!

        public override IDictionary<string, Action<VBE>> GetQuickFixes()
        {
            // don't bother implementing this without implementing a ChangeSignatureRefactoring
            return new Dictionary<string, Action<VBE>>
            {
                //{"Remove unused parameter", RemoveUnusedParameter}
            };
        }

[retailcoder/Rubberduck] retailcoder pushed commit 9a2d4d14 to master

> fixed bug in UnusedLocals with usage.MemberName equality check, and implemented ParameterNotUsedInspection.

[retailcoder/Rubberduck] retailcoder pushed commit 034d6294 to master

> added IndentifierUsageInspector.UnassignedParameters()

[retailcoder/Rubberduck] retailcoder pushed commit 6782fe12 to master

> Implemented ParameterCanBeByValInspection; removed "Pass parameter by value" quickfix for ImplicitByRefParameterInspectionResult, since that inspection doens't know whether parameter is assigned or not.