I've put some code together that helps me search an internal ticket system using an HTA application with some TextBoxes and some embedded VBScript that runs PowerShell scripts. The PowerShell scripts are hard coded to a certain directory and I was wondering if there's a better way to accomplish ...
Rubberduck will suggest to *explicitly* declare the constant as a `Variant`. But the parse tree *knows* the value assigned is a *string literal* - therefore Rubberduck should have enough information to declare it as a `String`.
Same here:
Dim foo foo = 123
The parse tree *knows* the assigned value is a number. Rubberduck should declare as `Long`.
> This one started out as an innocent little static class for some IParseTree extension methods. It's now bloated with nested types - various VisualBasic6BaseListener implementations, that ought to be extrated into their own file and made public.
2. Run All Tests /or Just the one test that is meant to fail. 3. Fix code so that it passes.
Assert.IsTrue True
4. Select `Failed Tests` from the run menu.
The test runs, as confirmed with a break point, but the Test Explorer continues to report failure. The same issue is present if running the "Selected Test" after failure. I've not tested the inverse. Run All Tests works fine.
> Type hints are a relic from the dinosaurian ancestors of VBA. Kill with fire. Dim SomeInteger% Dim SomeLong& Dim SomeDecimal@ Dim SomeSingle! Dim SomeDouble# Dim SomeString$ Replace with explicit type declarations: Dim SomeInteger As Integer Dim SomeLong As Long Dim SomeDecimal As Decimal Dim SomeSingle As Single Dim SomeDouble As Double Dim SomeString As String
> With version 1.2, every code inspection we could think of (for now) are implemented. Time to document them all, and explain the reasoning behind each quick-fix.
@RubberDuck OptionBaseInspection can break original code - we'll need to rebase all arrays to not introduce errors by removing Option Base 1... I'm not sure I want that one in 1.2 just yet.
> Simply removing Option Base 1 can break the code if any implicitly-based array is declared. We need to think of a refactoring to address this before this issue can be closed. Deferring this feature to a future release.
@RubberDuck would it break the code inspections configs if I added a member to CodeInspectionType? I'd like to add LanguageOpportunities and have ObsoleteCallStatementUsageInspection, ObsoleteLetStatementUsageInspection and ObsoleteCommentSyntaxInspection in there, as well as OptionBaseInspection and TypeHintUsageInspection
> Add a button to the Code Inspections window and toolbar, to export all inspection results to a text file for sharing, and another to copy them to clipboard, in point-form, markdown-formatted text, for pasting onto a [Code Review Stack Exchange](http://www.codereview.stackexchange.com) (just an example) post/answer.
> This is doable. See [this conversation](http://chat.stackexchange.com/rooms/14929/conversation/extracting-common-interface-for-iinspection-and-codeinspection).
Long story short, both `CodeInspection` (the configuration class) and `IInspection` need to share an `IInspectionModel` interface.
Hmm this is actually not too ugly for Access SQL...
SELECT DISTINCT
'01-Jan' AS [Month]
, (
SELECT SUM(Contract_Count13)
FROM Entry_Type_Raw_Data
WHERE Program_Name4 LIKE 'Carrier*'
AND Creation_Date_Month3 = 'January'
AND Sale_Type1 = 'Dealer Sale'
) / (
SELECT SUM(Contract_Count)
FROM Top5_Raw_Data
WHERE Program_Name LIKE 'Carrier*'
AND Creation_Date_Month = 'January'
) AS [% Carrier USA&CAN]
FROM Entry_Type_Raw_Data
INNER JOIN Top5_Raw_Data
ON Entry_Type_Raw_Data.Program_Name4 = Top5_Raw_Data.Program_Name
Hey Simon just made 0.5 official release of Cardshifter, in case you guys would like to try it :)
> Add a button to the Code Inspections window and toolbar, to export all inspection results to a text file for sharing, and another to copy them to clipboard, in point-form, markdown-formatted text, for pasting onto a [Code Review Stack Exchange](http://www.codereview.stackexchange.com) (just an example) post/answer.
I have a custom class named imera in which I include a range property nameddate_cell`.
When creating a collection of imera's, every imera's date_cell is set to reference to a specific cell in excel.
While attempting to search within the collection by date_cell:
Option Explicit
Public imeraCol ...
That silent moment of satisfaction when you get to show your boss they made an error calculating their stats by hand, and that your SQL formulas do a much more reliable job of calculating stats ;D
Don't.
You've already implemented way too much functionality in that click handler, stop right there!
Extract Methods
You need to refactor a little bit here - extract a method for this part:
TextBox2.Show()
TextBox2.Text = ("Completed without any faults : If error occurs resort to readme i...
> My Rubberduck version is1.1.5497.13430. I think it is the latest downloadable. I send you a screenshot (there are 5 issues, all for typed constants recognized as implicitly Variant). My environment: Windows 7 Home Premium 64-bit MS Access 97 I wait for the 1.2 version. Thank you for your reply. Il 11/02/2015 18:24, Mathieu Guindon ha scritto: > > I cannot reproduce this behavior with build 1.1.5457.13537. However this: > > |Public Const qdfCodCatasto = "vbCodCatasto" > | > > Doesn't yield...
any inspection result, when it should. > |VariableTypeNotDeclaredInspection| works as intended in the current > master > <https://github.com/retailcoder/Rubberduck/blob/master/RetailCoder.VBE/Inspections/VariableTypeNotDeclaredInspection.cs> > - this issue is considered as fixed now, stay tuned for release of > version 1.2 <https://github.com/retailcoder/Rubberduck/milestones>, > scheduled for the end of the month: all code inspections of v1.1 have > been reimplemented, and several new ones...
are coming. > > See opened |[code-inspection]| issues under the Version 1.2 > milestone > <https://github.com/retailcoder/Rubberduck/issues?q=is%3Aopen+milestone%3A%22Version+1.2%22> > to follow progress. > > --- > Reply to this email directly or view it on GitHub > <https://github.com/retailcoder/Rubberduck/issues/194#issuecomment-73923356>. >
> :+1 Awesome! Thanks for your feedback - we haven't tested anything with Office 97, feel free to report more issues after upgrading to v1.2, thanks for your feedback!
> I like this API, but it introduces some difficulties. As currently defined, none of the classes have default constructors. COM exposure requires default constructors, and things normally passed into a constructor are set via properties. I think I'll introduce a layer of abstraction in between the classes we'll use internally and the ones that get exposed to COM Interop. Only trouble with that is naming becomes a problem. The naming issue may be able to be overcome by using ProgId...
IFERROR is an Excel function. You don't use that to handle VBA runtime errors.
What you need is an On Error GoTo statement, and a control flow that goes something like this:
Public Sub Foo()
On Error GoTo ErrHandler
Dim result As String
TryGetResult:
result = GetResult(ActiveCell....
> I suggest default-sorting by Project, then Moduleand then by Priority. User should be able to simply click a column header to sort by priority regardless of project/module.
> Consider a function: Public Function Foo(ByVal bar As String) As Integer Foo = 42 End Function Then a function call: Foo "bar" Either the function has side-effects and should be a procedure, or not using the returned value is a programming error. Rubberduck should warn about the function's return value not being used; formal definition would be something like "a function call that isn't on the right-hand side of a local variable assignment". Possible quick-fix: - [ ] Introduce...
variable: this introduces a local declaration on the line immediately above the function call, and an assignment of that variable with the function call on the right-hand side of the = operator.
> - [ ] Number literals: either `Long` or `Double` (if value has decimals) - [ ] String literals: `String` - [ ] Date literals: `Date` - [ ] Assigned value is `Set`: `Object` is still vague, but better than a `Variant`. - [ ] Right-hand side of the assignment is a native function call. Use the [hard-coded] return type of that known native function. e.g. `CInt` function will always return an `Integer`; `MsgBox` calls return a `Long`, etc. - [ ] Right-hand side of the assignment is a function defined in the active VBProject. Use the function's return type to determine the type of the assigne…
sql = "SELECT STORENUM, STORENUM AS STORE " & _
"FROM table ORDER BY STORENUM"
'Yeah, I know I selected store num twice, but combobox autocompletes don't work unless you do.
> This should only be a "hint" (i.e. not a "warning" or a "suggestion") - even if a variable is explicitly declared as a Variant, there's probably a better type that can be used for it. Rubberduck should hint at that.
I am looking for a third party company similar to Veracode who can provide VBA code certification. Basically my server needs to process Excel files and some of them might have macro code and I want to make sure Macro enabled files are safe to use in my server environment. My plan is to ask my cus...
I have a custom class named imera in which I include a range property nameddate_cell`.
When creating a collection of imera's, every imera's date_cell is set to reference to a specific cell in excel.
While attempting to search within the collection by date_cell:
Option Explicit
Public imeraCol ...
Don't.
You've already implemented way too much functionality in that click handler, stop right there!
Extract Methods
You need to refactor a little bit here - extract a method for this part:
TextBox2.Show()
TextBox2.Text = ("Completed without any faults : If error occurs resort to readme i...
VBA Rubberducking
VBA Rubberducking