I see that, I guess I'm just not "seeing" it. I guess it's only for functions that take a method name and only if you don't ever expect to use that (fairly short) method again in the future?
I mean, I see the value, but it seems... overkill? Confusing? Especially with the shortcut the shortcut method where (int x) => ... becomes simply x => ...
Expression-bodied definitions make sense and relieve some of the vertical space, but they also seem like the one-line If x > 5 Then Exit Sub one line If statements that I tend to avoid in VBA...
@FreeMan IMO The "say what you mean..." falls back to how experienced/comfortable you are with a language. Past-Iven of pre-RD would have been very confused by the code that Present-Iven writes.
Taking another step forward in my AddNewComponent branch. I anticipated copy-pasta-ing the addition logic for each component that would be added. But I'm not sure it will pan out. I'd like some feedback on my thought process.
Is it appropriate to keep the logic contained within a class whose method's return type are subsequently passed to another member?
Or would it be better to pass the member a reference to the IAddComponentService and then internally invoke the AddComponentWithAttributes member on the reference?
Another thing that Iven didn't mention yet: Lambdas can be used to capture the context they are constructed in. That's why they're sometimes called "closures"
> Thanks for the feedback, that's a great idea! A simple "export source files to host document directory" checkbox (cleared by default, to preserve current "prompt everytime" default behavior) in *general settings* could do it. The only thing to watch out for, I think, is that the setting isn't useful when hosted in VB6 and the notion of a "host document" would be confusing then: the option should probably be hidden when the host is VB6.
@FreeMan if you ever felt the need to pass a function to a method (rather than the result of that function), then you've solved it by working around the lack of delegates in VBA (likely by passing an outright object encapsulating that function).
Imagine writing a Filter (or Where) method on some custom collection, and you want the caller to be able to specify the criteria: with delegates you can pass, say, any function that takes an item and returns a Boolean, and then the implementation simply invokes that function for each item and yields the items for which the function returned True.
By allowing to pass a lambda expression / anonymous function rather than a full-fledged object, the language is making it easier and more lightweight to do this.
@this yeah I started extracting all the files and actually organizing things, but I'm wondering if it wouldn't be quicker to just start it over rather than refactor... the tB compiler doesn't seem to like a project that's half uncompilable!
In fact I was hoping for an "extract to ClassName.twin" tool to show up along with the single-file limitation being lifted
> VB6 needs separate thought. I'd love to be able to have Rubberduck encourage the use of actual file system folders, something which is entirely possible but never used because the Project Explorer doesn't show folders.
Maybe we should have a VB6-specific inspection, which would identify mismatches between the Folder annotation and the source file location, with a quickfix of "Move to folder" which would then move the source file and update the .vbp accordingly. If there's appetite for that
> @mansellan the quick-fix also needs to eventually actually delete the source code file from its original location. Definitely needs its own issue, but I think we must implement #4646 first.
VBA is showing me an error with this code. Could you help me to fix this?
Sub datemth()
x = Sheets("output").Range("d2:w2").Find(Month(Sheets("input").Range("j1")))
x.Select
End Sub
The error is "Object variable or With block variable not set":
Well, yeah, that would be an important thing to know... Where does one look for a general "all-clear, it's safe to update to version x.y.z, since that's fixed all the issues in x.y.a through a.y.q"?
@BigBen the "compile error" in the OP would actually be a run-time error, but I can't seem to repro it.. it's a "type mismatch" I get with a Set keyword and a successful Find call (and the expected error 91 when Find fails).
Typed arrays are a mess... even when they're implicitly typed like here. I'd recommend just passing them around as plain Variant parameters, e.g. ByRef imports As Variant; getImportArray is returning a plain Variant. — Mathieu Guindon2 mins ago
not sure how that could be done without breaking back-compat
but yeah I got like 2-3 comments on the RD style guide specifically about the "consider passing arrays as plain variants" bit - and this is exactly why.
it becomes a compile-time "object required" error if the Datatype variable is declared with an actual data type rather than an implicit (or explicit) Variant
@BigBen because their question was unclear and their explanation of the "object required" error should have included the actual variable declarations involved, too
Let's say I'm making a VBA object with a bunch of properties. With the Type backing and such, following the @MathieuGuindon example. Is there a simple way to generate the properties Get\Let? It's a ton of boilerplate
@HackSlash don't bother making the actual private type; just make a bunch of public fields, then use the Encapsulate Field refactoring and select all the public fields - it'll generate all the boilerplate including the private type declaration (it's a checkbox)
I'm having a brain pretzel. I've got an object I want to use in a collection. All read-only properties. How to I generate the collection and set the values of the internal This for each object in the collection?
It's the only way to hide those setters that you need to construct the Thing without allowing your consumers to accidentally modify them by providing the IThing.
See, that's where VBA/VBIDE works toward encouraging you to do it "one giant file that is totally self contained so I can easily export and import into other projects" which means you end up with an untestable entity.
@IvenBach I think the feeds is weird. it works then stops working. IDK.
Ok, so I've made a unit constructor and a collection constructor. The collection constructor calls the unit constructor in a loop. Then it returns the collection of units. I'm not sure if this is a terrible thing but I think it does what I want.
ok a stupid question regarding statistics? accounting? whatever. Let's say I have a column that tracks the apples consumed, then another that tracks oranges consumed. I can then calculate AverageApplesConsumed and AverageOrangesConsumed using just the AVG() function. However, do I (AVG(ApplesConsumed) + AVG(OrangesConsumed))/2 or do I AVG(ApplesConsumed + OrangedConsumed) to get the average of fruit consumption?
Man, proper casing in C# is getting to me. Especially since I'm going through an online class using a primitive web-based editor that doesn't do any sort of autocomplete.
I'm too used to the VBE fixing the case of everything for me. That's how I know I spelled it correctly!
@FreeMan be aware the intellisense in C# is different than VBIDE.
that matters because IBigThing _bigThing can be typed like IBT<tab>_bT<tab>
You couldn't do that with VBIDE's intellisense which requires that you get few characters at least, then do some upping/downing with the arrow keys to get the item you want to autocomplete.
@this that's pretty snifty! this editor doesn't have anything vaguely resembling autocomplete...
@Freeflow let's be honest here, after 3 semesters of Calculus in high school and a 4th my freshman year of college earning myself 4 straight Cs, I pretty much gave up on the Actuarial Science major... That was also the limit of my stats classes...
the fact that I can properly write "math" (singular, not like those crazy Brits) is one of my major mathematical accomplishments!
:D
Can one create overloads on a class constructor, allowing different properties to be set at run-time, or is there only one possible?
wondering out loud - no present need...
yes, yes I can.
just had to wait 2 steps in the course I'm working through
Supposedly you can call a collection item by a string name assigned when added but I'm getting "Run-time error '438' Object doesn't support this property or method"
"
Key String
Optional. A unique String expression that specifies a key string that can be used instead of a positional index to access this new element in the collection. "
Oh my, it's worse than expected. If I access a member of the returned object it works but I can't get a handle on the object itself...
Doesn't matter if I declare the container to be of the custom object type, variant, or generic object. I get an error instead of a returned object
VBA is showing me an error with this code. Could you help me to fix this?
Sub datemth()
x = Sheets("output").Range("d2:w2").Find(Month(Sheets("input").Range("j1")))
x.Select
End Sub
The error is "Object variable or With block variable not set":
VBA Rubberducking
VBA Rubberducking