« first day (2185 days earlier)      last day (44 days later) » 

12:01 AM
RELOAD!
[rubberduck-vba/examples] 5 commits. 303 additions. 2 deletions.
[rubberduck-vba/Rubberduck] 2 commits. 6 issue comments. 2 additions. 4 deletions.
[Zomis/Games] 10 commits. 1 opened issue. 3 closed issues. 2 issue comments. 269 additions. 190 deletions.
[Minesweeper] Games Played: 169, Bombs Used: 104, Moves Performed: 22762, New Users: 15
 
 
7 hours later…
6:37 AM
@BloggingDuck option to Select only Property Gets is one I could use often.
> Instead, copy the IUser interface into the new Class1 module, select all, and Ctrl+H to replace “Property Get ” (with the trailing space) with “Function With” (without the trailing space).
^ I believe screenshots of this will help readers that don’t do this type of renaming understand what you’re actually doing.
 
 
5 hours later…
11:45 AM
> #5506 fixed it for me! I was able to load the project and run a full parse for the first time without the application hang I was experiencing before. Thank you @MDoerner for your work on this!
 
 
1 hour later…
12:55 PM
Where should I best put the TextBoxErrorStyle, into ToolBar.xaml or into DefaultStyle.xaml?
I plan to reuse it in all rename related dialogs.
Should I also move the EnumToLocalizedStringConverter and the DeclarationToQualifiedNameConverter into one of those files?
Somehow, I currently feel motivated to code again.
 
1:22 PM
@BloggingDuck Awesome article. The Builder example really lends itself to showcasing the bulk code generation/modification chops of RD. Really well done.
 
2:04 PM
@M.Doerner The DefaultStyle.xaml should only contain styles. Because it's then used as a dictionary in other xaml files, there are restrictions on what you can put in DefaultStyles.xaml. Which is partially why Toolbar.xaml still has some styling elements.
@BZngr Absolutely agree. Beautiful job, @MathieuGuindon!
 
So, are image resources allowed in DefaultStyle?
If not, it will go into ToolBar.
 
I don't remember having any images.... but I am not sure I had to move images; I left them as they were since they were usually specific to a particular element. It all depends on whether a ResourceDictionary is allowed to have an image or not.
 
I currently have the error icon image in the resource dictionary of the Rename control, the MoveToFolder control, the MoveFolder control and the AnnotateDeclaration control.
 
I see. I wasn't really focusing on the icon handling in the style PR
so if it should be consolidated, we should try, I guess.
 
I use it in the new TextBoxErrorStyle, which basically makes the textbox look like the one on the rename dialog when there is a validation error and, in addition, has a tool tip with the first error message.
I plan to change the three other dialogs to use it, too.
 
2:15 PM
I think the WPF way would have been to define a control template once, then re-use that template in other places sot hat you only define the icon once in that template, and the dialogs that needs similar textbox + icon functionality just instantiates that template.
Unfortunately I've never actually created a template so I don't know how that would be done.
 
The TextBoxErrorStyle basically does that; it defines an error template to use. However, to show the error tooltip conditional on whether there is an error, I need a style trigger.
To implement a real control template would probably be a bit more involved.
 
 
2 hours later…
4:54 PM
@IvenBach oh yes, good idea!
 
 
3 hours later…
7:26 PM
@BloggingDuck I do not like the idea to generate a result for a missing tribute if there is a @Predeclared annotation, but the attribute has the value False.
 
@M.Doerner I'm not suggesting that either - that bit was written from the POV of the user wondering why it wouldn't work ;-) ...but I always try to find AttributeOutOfSync results under Rubberduck Opportunities. I recall a convo about it being a Code Quality Issue on the basis that is could break the code (like VB_PredeclaredId being out of sync does), but... I just think it makes more sense under RD Opportunities
 
7:46 PM
The way it is written, I have associated the We'll have to change that with the previous sentence.
Ordering the sentence the other way around would make it unambiguous.
 
Thanks, will edit =)
 
 
2 hours later…
9:31 PM
 

« first day (2185 days earlier)      last day (44 days later) »