VBA Rubberducking

« first day (1861 days earlier) ← previous day next day → last day (1319 days later) »

11:09 PM

[rubberduck-vba/Rubberduck] IvenBach synchronized pull request #5044: Enclose regex assistant whitespace with identifying curly braces

[rubberduck-vba/Rubberduck] codecov[bot] edited comment on pull request #5044: Enclose regex assistant whitespace with identifying curly braces

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/5044?src=pr&el=h1) Report
> Merging [#5044](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/5044?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/1c9a6b957b7241f2e04ca4f938e06a2955e295d7?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `63.64%`.

```diff
@@ Coverage Diff @@
## next #5044 +/- ##
=======================

IvenBach

I feel better about the state of commits for that PR.

Duga

11:21 PM

[rubberduck-vba/Rubberduck] bclothier commented on Rubberduck.Resources/RubberduckUI.resx of pull request #5044: Enclose regex assistant whitespace with identifying curly braces

this

@IvenBach Nicely done!

Duga

[rubberduck-vba/Rubberduck] build for commit f7b12e0a on unknown branch: AppVeyor build succeeded

Vogel612

@this in this case it's because Duga actually escapes these for you

this

no, I can type _<space>_ here

but on GH, I must type _<space>_

Duga's not involved here.

Vogel612

hmm ...

probably GH is being more liberal in what it accepts as HTML

@IvenBach Sorry for raining on your parade a bit there. I really like these changes :)

IvenBach

11:36 PM

@Vogel612 huh? Oh the initial comment? It may have seemed a really strange request. Especially coming from past-Iven who'd only visited the pond a few times before that PR.

Vogel612

@IvenBach nah, the "Request Changes" review ...

Duga

[rubberduck-vba/Rubberduck] Vogel612 commented on Rubberduck.RegexAssistant/WhitespaceToString.cs of pull request #5044: Enclose regex assistant whitespace with identifying curly braces

IvenBach

Oh. I hadn't noticed that. I was conversing with a co-worker.

Duga

[rubberduck-vba/Rubberduck] IvenBach commented on Rubberduck.Resources/RubberduckUI.resx of pull request #5044: Enclose regex assistant whitespace with identifying curly braces

this

@Duga @Vogel612 are you saying htat a regex expression will never match a CRLF?

Vogel612

11:47 PM