VBA Rubberducking

4:14 PM

Hi all, been a couple months since I was here to pick the hive-brain. I was wondering if there are any features in the RD indent functions to auto-wrap VBA code comments to a certain line length..? It would be a bit more than just adding hard returns, because it would have to manage the indenting whitespace and single-quote at the beginning of each line.

Mathieu Guindon

not at this time, but that would be a nice feature request :)

the easiest would be to convert them to line-continued comments

i.e. add a line continuation + NEWLINE at the break position

(and optionally align beginning of the continued comment with the previous start position)

spinjector

Oh wow, i didn't know comments could be continued. I just tried it. But yea, anywho...an auto-wrap feature would be killer. But whatever way, it would have to cleave at a word-boundary (space), and then manage extra characters are the end (continuation) or at the beginning (whitespace + quote) - not all that complicated actually...

Vogel612

@MathieuGuindon I think we do have an open feature request around that already...

Mathieu Guindon

IIRC it was about having the indenter enforce maximum line length, not specifically about comments. I could be mistaken though

Vogel612

ah no. you're right

spinjector

4:27 PM

And a more ambitious approach would be to load an English (and French) word lists for hyphenation & basic spell-checking.

But I'd be thrilled just with auto-wrap. <3

this

I'd say that this is best done once we have AvalonEdit set up

spinjector

Should I go put a request in?

this

hmm....come to think of it, does VS even have spell checker?

I think not....

Vogel612

spellcheckers are notoriously resource-hungry

this

and with various conventions like PascalCase or camelCase or snake_case, it can't be easy.

spinjector

4:30 PM

Yes, a query for every word. I don't think VS has any spellcheck classes, but then it might, there's a heckofalot in there.

this

and it'd look fugly on a codebase that has lot of disemboweled words to boot.

spinjector

Yea, I wasn't thinking full-blown Msword-style spelling & grammar, just a basic top-10,000 wordlist type of thing, non-sensitive case.

Oh and here go the gears turning in my head. Merge the word list with VBA keywords, and any references, and defined variables & procedure names in the current project.

this

Ok, but how do you recognize a misspelled word vs. an unrecognized word?

spinjector

You don't.

If it's not in the list, it's "misspelled", just like any spell-checker that hits a word it doesn't recognize. There would have be a basic feature to add unrecognized words to a whitelist of course, but again- more complication, and I don't even know if there are any "hooks" into the IDE for that kind of thing. I think it would have to occur when RD updates and parses the code?

Comintern

@this It doesn't, but there are plugins available.

Mathieu Guindon

4:40 PM

if anything like a spell-checker is ever implemented in RD, I'd rather it be something like R#'s smart completion list - e.g. you type f and it knows you mean fooThing so all you need to do is type f{TAB}

would be context-sensitive

this

@Comintern and I bet it'll make VS run 100x slower

Yes, putting intelligence in the Intellisense would be much more valuable

2

what I would dearly love is to have C# style where you can type the capital letter to select the member

Comintern

@this It actually isn't that bad at all - the one I have only does string literals.

this

Ah, that does make more sense. I think the original idea was to spellcheck the identifiers too

which is much more harder, IMO.

Comintern

^

It's actually a lot more convenient than handling all of the QA notes for typos.

this

Yeah, i totally get that.

Mathieu Guindon

5:00 PM

Option Explicit is my identifier spellcheck

2

Hosch250

5:30 PM

@this Yes!

It came in with the latest major release, LOL.

this

well, shoot me.

Hosch250

@this BLAM!

Well, what was that all about?

this

oh, spininjector wanted that in VBE. I was thinking that VS didn't have it but apparently I was wrong.

Hosch250

Brand new feature. I think I got it Monday last week?

this

how serendipitous for Microsoft in its everlasting quest to make a fool out of me.

IvenBach

5:45 PM

@this :click: That's why the VBE complains when doing Msgbox "I be lazy "&fooRange&" and need to fix that."

Type characters.

this

yep

IvenBach

Makes perfect sense. Years later.

Mathieu Guindon

in RD we call them type hints

and... there's an inspection for that

(I think the "type hint" inspection would fire up a result for it anyway)

Vogel612

if not there will be a feature request around

somewhere... just gotta find it

Mathieu Guindon

feature-code-inspections enhancement -> 265 results

mansellan

6:01 PM

@Hosch250 Saw it today - first thing I did was to downgrade it from Suggestion to Hint. It may end up disabled altogether...

IvenBach

I read up about ref vs `out in stackoverflow.com/questions/1516876/…. My code is in VBA

Private Sub MatchHSSSections(ByRef beamSections As Sections, ByRef columnSections As Sections)
    Dim matchedColumns As Sections
    Dim columnSection As Section
    For Each columnSection In columnSections
        If beamSections.Widths.Exists(columnSection.Width) Then
           matchedColumns.Add columnSection
        End If
    Next
    Set columnSections = matchedColumns

    Dim matchedBeams As Sections
    Dim beamSection As Section
    For Each beamSection In beamSections
        If columnSections.Widths.Exists(beamSection.Width) Then

Hosch250

It's remarkably good, though.

It almost never fires anything for my code.

Except for a couple that I added to the ignore list.

IvenBach

Within the method it is reassigned. I know Mug suggests using outFoo as the name for out parameters that are passed ByRef. Would refFoo be applicable in this case since the results are dependent on the initially supplied values?

This feels like a warranted use of apps Hungarian to indicate intent.

mansellan

@Hosch250 Hmm, can add words to solution for team or individual... might not suck after all.

Mathieu Guindon

refFoo is thwarted by just wrapping the argument with parentheses; do that with outFoo and you know you just deprived yourself of a return value

this

6:05 PM

Just to point out --- you might want to use a UDT as a return of the function

Mathieu Guindon

I've created label hacktoberfest-2018, feel free to sprinkle across easy issues that would be nice to have implemented by newcomers - I'll give it a round some time this week, too.

this

that way you avoid the hackiness/murkiness of using multiple parameters-that-are-really-return

Mathieu Guindon

@this I tend to under-use UDTs, but you're probably right

this

class is another alternative

Mathieu Guindon

class is a much more solid alternative

this

6:06 PM

TBH, I'm not that enthusiastic about using UDT. They have lot of problems.

Mathieu Guindon

^

this

but for cases where you need "tuples", they suffice

Mathieu Guindon

as does a dictionary :)

IvenBach

Both Section and Sections are classes I've created. The current format is mostly how it was originally done via passing arrays back and forth.

this

then you're now stringifying parts of your code.

Mathieu Guindon

6:08 PM

indeed. custom class wins

this

you know what'd be awesome, though? RD able to inspect when stringifed code is wrong

like it or not, VBA does too much string for us to get rid of it entirely.

Mathieu Guindon

we kind of already have it for worksheets

IvenBach

~~I'd rather have a function that returns the~~ Testing an MVCE.

this

you mean using Sheet1 instead of Application.Worksheets("Sheet1"), sure, that's one way. In Access we prefer Me.MyControl over Me.Controls("MyControl") for same reason

mansellan

@this aren't they just structs?

Mathieu Guindon

6:10 PM

each member needs its own inspection, I think

this

@mansellan with a lot of baggages

mansellan

ah ok, been a while since I used VB in anger

this

LOL

there's many silly limitations--- no casting to Variant, no exposing it outside an class module, no pinning of variable-length data type to name a few.

Mathieu Guindon

and they're mutable

mansellan

ah yes. the second one especially rings a bell - iirc I thought that was odd at the time

fastest way of parsing fixed-width files though. used that one :-)

Duga

6:17 PM

[rubberduck-vba/Rubberduck] retailcoder added label up-for-grabs to issue #4213: Inspection for use of IsEmpty with non-Variant types.

[rubberduck-vba/Rubberduck] retailcoder added label good first issue to issue #4213: Inspection for use of IsEmpty with non-Variant types.

[rubberduck-vba/Rubberduck] retailcoder added label hacktoberfest-2018 to issue #4213: Inspection for use of IsEmpty with non-Variant types.

[rubberduck-vba/Rubberduck] retailcoder added label difficulty-01-duckling to issue #4213: Inspection for use of IsEmpty with non-Variant types.

[rubberduck-vba/Rubberduck] retailcoder added label difficulty-01-duckling to issue #4212: Inspection for use of IsMissing with non-Variant types.

[rubberduck-vba/Rubberduck] retailcoder added label up-for-grabs to issue #4212: Inspection for use of IsMissing with non-Variant types.

[rubberduck-vba/Rubberduck] retailcoder added label hacktoberfest-2018 to issue #4212: Inspection for use of IsMissing with non-Variant types.

[rubberduck-vba/Rubberduck] retailcoder added label up-for-grabs to issue #4166: Inspection for use of legacy Local in On Error Goto 0 OEG0 statement

[rubberduck-vba/Rubberduck] retailcoder added label difficulty-01-duckling to issue #4166: Inspection for use of legacy Local in On Error Goto 0 OEG0 statement

[rubberduck-vba/Rubberduck] retailcoder added label hacktoberfest-2018 to issue #4166: Inspection for use of legacy Local in On Error Goto 0 OEG0 statement

[rubberduck-vba/Rubberduck] retailcoder added label good first issue to issue #4166: Inspection for use of legacy Local in On Error Goto 0 OEG0 statement

[rubberduck-vba/Rubberduck] retailcoder edited issue #4166: Inspection for use of legacy On Local Error statement

[rubberduck-vba/Rubberduck] retailcoder added label hacktoberfest-2018 to issue #4018: "Module has no '@Folder annotation"

[rubberduck-vba/Rubberduck] retailcoder added label up-for-grabs to issue #4028: Add right-click menu to Code Inspections

[rubberduck-vba/Rubberduck] retailcoder added label difficulty-01-duckling to issue #4028: Add right-click menu to Code Inspections

[rubberduck-vba/Rubberduck] retailcoder added label good first issue to issue #4028: Add right-click menu to Code Inspections

[rubberduck-vba/Rubberduck] retailcoder added label hacktoberfest-2018 to issue #4028: Add right-click menu to Code Inspections

this

@Duga lives!

Duga

[rubberduck-vba/Rubberduck] retailcoder added label hacktoberfest-2018 to issue #3549: Inspection for possible unhandled error in event handler

[rubberduck-vba/Rubberduck] retailcoder added label good first issue to issue #3549: Inspection for possible unhandled error in event handler

Hosch250

Holy cow.

Duga

[rubberduck-vba/Rubberduck] retailcoder added label hacktoberfest-2018 to issue #3533: Array definition has implicit lower bound

[rubberduck-vba/Rubberduck] retailcoder added label hacktoberfest-2018 to issue #3320: Inspection for Range.Value2 over Range.Value

[rubberduck-vba/Rubberduck] retailcoder added label hacktoberfest-2018 to issue #3306: Warn about assignment attempts on read-only properties

[rubberduck-vba/Rubberduck] retailcoder added label good first issue to issue #2859: RD needs an inspection for Property Lets with Object parameters.

[rubberduck-vba/Rubberduck] retailcoder added label hacktoberfest-2018 to issue #2859: RD needs an inspection for Property Lets with Object parameters.

Mathieu Guindon

OMG I'm so sorry I thought she was dead!

lol

#FunFact - issue history shows hacktoberfest label was added last year on some of these

Duga

6:34 PM

[rubberduck-vba/Rubberduck] retailcoder created comment on issue #3276: Code inspection should warn if variable is declared at module and method level

> ShadowedDeclarationInspection catches this.

[rubberduck-vba/Rubberduck] retailcoder closed issue #3276: Code inspection should warn if variable is declared at module and method level

IvenBach

6:53 PM

From a semantic level which is the more proper word: Distinct or Unique? I'm creating a function that will return a dictionary containing non-duplicated widths. IE there are widths of 4,4,4,6,6,8,8,8,8,8,8,8,10,10,10,12 the result will be 4,6,8,10,12.

FreeMan

According to this the new function Excel UNIQUE would, return 4,6,8,10,12 as the "unique" list, but gives an option to return just 12 as the only one with no duplicates - i.e. the "Unique" one. In SQL SELECT DISTINCT would get you 4,6,8,10,12, so I think that would be more obviously known to more programmers.

IvenBach

@FreeMan I'm already leaning towards UniqueWidths. But my tiny usage of SQL made me think of DistinctWidths as an option.

This API will never be released to the wild so I could change it in the future...

I need to get to those articles. Much more to learn.

this

fyi SQL doesn't help you. You SELECT DISTINCT but CREATE UNIQUE INDEX

IvenBach

7:09 PM

That settles it. Unique I go.

this

Hooray for inconsistency!

IvenBach

The base fact I'm even remotely concerned about this minor distinction means I'm learning.

Mathieu Guindon

7:35 PM

@IvenBach or, we've successfully made you as pedantic as we are! ;-)

3

IvenBach

You're certainly making progress on it.

Hosch250

FWIW, I'd have done Distinct because it's slightly more common.

But Unique works too. It's such a unique word.

KySoto

7:52 PM

welp that one disgusting macro atrocity that was working on for a while is completed... again

and i made it betterer than when you first saw it

refactored the hell out of it

FreeMan

@IvenBach well played

IvenBach

8:10 PM

Less hell and more code?

KySoto

8:27 PM

less code too

i have a before and after

the before is hard to read because i used lazy variable names like rs rs2 rs3

:D

on a nice note i think that rubberduck did a nice job of formatting the code

'Connections
Dim cVMFG1 'As ADODB.Connection
Dim cVMI
'commands
Dim com5Para 'As ADODB.Command
Dim com1Para
Dim comTolerance
'Recordsets
Dim rsPreviousSequence 'As ADODB.Recordset
Dim rsPreviousSequenceQuantities
Dim rsCurrentSequenceQuantities
Dim rsToleranceEntry
'Queries
Dim qryPreviousSequence
Dim qryGoodAndBadQuantity
Dim qryInitialQuantity
Dim qryCreateToleranceEntry
Dim qryReadToleranceEntry
'Other
Dim out

vs

Dim c 'As ADODB.Connection
Dim com 'As ADODB.Command
Dim com2
Dim rs 'As ADODB.Recordset
Dim rs2
Dim rs3
'Parameters that will be reused
'Queries in one place
Dim qry
Dim qry2
Dim qry3
Dim out

If Not (GOOD_QTY = 0 And BAD_QTY = 0) Then
qry = "SELECT DISTINCT TOP 1 SEQUENCE_NO FROM OPERATION WHERE (WORKORDER_BASE_ID = ?) AND (WORKORDER_LOT_ID = ?) AND (WORKORDER_SPLIT_ID = ?) AND (WORKORDER_SUB_ID = ?) and(SEQUENCE_NO < ?) ORDER BY SEQUENCE_NO DESC"

granted i added features into the refactored copy

so its not a 1:1 comparison

but just by the variable naming, it feels nicer.

IvenBach

Good variable names alone is sometimes worth a refactoring.

The new array functions that are coming for Excel look pretty nifty.

Mathieu Guindon

FWIW a splash screen that's shown without any actual work getting done and disappears after a preset number of seconds, is just plain obnoxious. Anyway, what specific version and bitness of Excel is the error being thrown for? — Mathieu Guindon 19 secs ago

that's outright criminal

"let me show you a stupid useless form every time you open that worksheet, just for the heck of it, because I feel fancy - oh and it'll crash for some users because #VBA7 and #Win64"

the RD splash has a grand total of 0 milliseconds of hard-coded delay

it says "initializing", it actually "initializes"

this

8:52 PM

Would it be ok if the splash form was recalibrating splines?

IvenBach

"Because they can" probably isn't the best answer.

Vogel612

I apparently found 400 tests ...

IvenBach

Should there be a check box for unit tests allowing the inclusion of the Fakes variable? I don't know what it's use is currently and always get inspections results from it.

Mathieu Guindon

just comment it out?

Vogel612

Fakes are Rubberduck's way of exposing Mocks

I think we want to push awareness of them

hum ... apparently I broke testfiles

IvenBach

9:03 PM

Is there an article about fakes and mocking? I'd like to decrement my ignorance regarding them.

Mathieu Guindon

@IvenBach Go ahead, mock VBA

Vogel612

in an attempt to make it simple:

You want to allow unit-tests to really test only the unit you're testing and not all the messy other components that it may be using

Mathieu Guindon

coming soon: @IvenBach's "OMG Rubberduck can do that??!!" moment

IvenBach

@MathieuGuindon I can only dry out the knowledge sponge so fast. I can only appreciate so fast!

Vogel612

fwiw we finally got running tests again :D

~cough

@Vogel612 and I removed them again because they were in classes that were removed from the csproj, but not removed from the file system ...

but I broke some unreachable case unit tests

because the locale for parsing floating point literals is bork again

mansellan

9:14 PM

@this reference to Postman?

this

no, older than that. SIMCity

Duga

[rubberduck-vba/Rubberduck] Vogel612 synchronized pull request #4383: Csproj format update, fixes #3944

[rubberduck-vba/Rubberduck] build for commit 8b56b252 on unknown branch: AppVeyor was unable to build non-mergeable pull request

mansellan

ah ok. Postman's are amusing in an "ok, seen it a few times now, joke's getting old" kinda way...

Duga

BUILD FAILURE!

[rubberduck-vba/Rubberduck] [codecov[bot]](github.com/apps/codecov) edited comment on pull request #4383: Csproj format update, fixes #3944

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4383?src=pr&el=h1) Report
> Merging [#4383](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4383?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/49d5bfb9e9d3e92e4a80acdb2af68123827bbf02?src=pr&el=desc) will **decrease** coverage by `0.91%`.
> The diff coverage is `n/a`.

```diff
@@ Coverage Diff @@
## next #4383 +/- ##
==========================

Vogel612

bleh

who broke mergeability again?

oh well. that's what I get, innit?

Mathieu Guindon

9:17 PM

I merged the COMWrapper analyzer PR earlier

Vogel612

changes to the RubberduckTestsCodeAnalysis project?

aah... yea makes sense..

this

i wonder how many conflicts we had in past only in *.csproj and *.sln files compared to other files.

wouldn't surprise me at all if they constituted like 90% of the conflicts in past

Vogel612

I messed with the packages, that's why it's conflicting now

Mathieu Guindon

.resx files are commonly conflicted too

this

oh yeah that's true. everyone's adding to the end of the file.

doesn't help that we have (had?) this mega-resx file in RubberduckUI.resx

Duga

9:20 PM

[rubberduck-vba/Rubberduck] Vogel612 synchronized pull request #4383: Csproj format update, fixes #3944

[rubberduck-vba/Rubberduck] [codecov[bot]](github.com/apps/codecov) edited comment on pull request #4383: Csproj format update, fixes #3944

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4383?src=pr&el=h1) Report
> Merging [#4383](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4383?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/6df939d9edd3dd3f129f74996e6936f3c880e6da?src=pr&el=desc) will **decrease** coverage by `0.9%`.
> The diff coverage is `n/a`.

```diff
@@ Coverage Diff @@
## next #4383 +/- ##
=============================

[rubberduck-vba/Rubberduck] mansellan assigned mansellan to issue #1479: Give each Code Explorer Node a Custom Context Menu

mansellan

@Duga got something cooking...

Duga

[rubberduck-vba/Rubberduck] build for commit 12d96619 on unknown branch: AppVeyor build failed

BUILD FAILURE!

Vogel612

@Duga helpful path reference is helpful ...

IvenBach

9:36 PM

System.Runtime.InteropServices.COMException (0x800A802D): Name conflicts with existing module, project, or object library
   at Microsoft.Vbe.Interop._References.AddFromFile(String FileName)
   at Rubberduck.VBEditor.SafeComWrappers.VBA.References.AddFromFile(String path) in C:\Users\cpaustell\Source\Repos\Rubberduck\Rubberduck.VBEditor.VBA\SafeComWrappers\VB\References.cs:line 59
   at Rubberduck.UnitTesting.VBEInteraction.EnsureProjectReferencesUnitTesting(IVBProject project) in C:\Users\cpaustell\Source\Repos\Rubberduck\Rubberduck.UnitTesting\UnitTesting\VBEInteraction.cs:line 99

Getting error when trying to run unit tests.

this

will it run if you remove the RD from your references?

Mathieu Guindon

TTQW

IvenBach

@this Runs without a problem.

this

ok, now run it again.

IvenBach

Runs a second time without issue.

Was I supposed to have added a reference to RD?

this

9:42 PM

no. there's something else at play.

restart the host and try again

does it fail?

KySoto

effing sharepoint...

IvenBach

Restarted and no problem running tests.

KySoto

one of hte databases we used for our migration from MOSS 2007 to SP 2013 foundation was causing our full database backup to fail

this

@IvenBach could it have been running with a older version of RD, say, prior to 2.2?

that'd be the only explanation I can came up for that error

IvenBach

I just pulled from next and built prior to running unit tests.

this

9:51 PM

no, i meant the VBA project

e.g. it had a reference to an older version of RD

IvenBach

I'm not sure about that. Don't think so since I added the reference to get early binding.

this

@KySoto if you gonna use SP, why not at least use Office365?

KySoto

because it costs too much

and sp2013 foundation is free

it also wasnt my choice ;P

this

well you get what you paid for?

KySoto

oh it wasnt an in use database that was causing hte issue

it was just the one i got from a windows internal database and imported

i deleted it and we will likely be much happier now that we arent wasting gigs of space on useless sharepoint databases

but yeah, its not really worth it for office 365 for us anyhow

especially if we did the package with sharepoint and stuff

thats like 25-35 bucks a month per computer

well user, but then we have generic users for the floor operators

so i dunno how that would work

IvenBach

10:03 PM

@this Appears you're right. Added reference again and it's running without issue.

Vogel612

welp.... the new console host is a royal pain

so... who of you folks want to venture a guess as to why that is?

KySoto

hmm looks like a linux console

i dunno if that matters

Vogel612

narp, that's WSL under Windows 10 in a windows console host

my linux console wouldn't do that

it also probably wouldn't recognize /bin/grep

KySoto

at first i thought you were doing some VS stuff and somehow using the linux shell

and was very confused, then i looked at hte first command and realized its probably just windows being windows with linux

Duga

[rubberduck-vba/Rubberduck] IvenBach created comment on issue #4386: Unit tests grouping by outcome doesn't group by outcome

> Likely related: Run>Failed tests immediately after Run>All tests has no affect. Must parse and run all to have tests run.

KySoto

10:12 PM

If you pipe the output to a file do you get all that white space?

Vogel612

haven't tried...

but I assume it's because grep is aliased to use color output and the default linux colors grep uses are not supported by the console host

piping to file will remove the coloring (because --color=auto)

KySoto

i am by no means a linux expert

or even very linux proficient

i have to look up the commands to do just about everything

now to be fair to me, i only get the text based help, i never need to delve into the crap that is youtube tutorials

Vogel612

hmm ... I can move about directories, use tabcomplete and I used to know a handful of flags to tar

I can unzip from console, grep, and find work most of the time on the first attempt and I regularly need to reread stuff on awk and sed

everything else is lots of manpaging

KySoto

yeah. i dont really know what grep does

Vogel612

quick as heck regex searching through text files

KySoto

10:22 PM

then again, all of my experience comes from me tinkering at home with no real direction

Duga

[rubberduck-vba/Rubberduck] Vogel612 synchronized pull request #4383: Csproj format update, fixes #3944

[rubberduck-vba/Rubberduck] [codecov[bot]](github.com/apps/codecov) edited comment on pull request #4383: Csproj format update, fixes #3944

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4383?src=pr&el=h1) Report
> Merging [#4383](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4383?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/6df939d9edd3dd3f129f74996e6936f3c880e6da?src=pr&el=desc) will **decrease** coverage by `0.9%`.
> The diff coverage is `n/a`.

```diff
@@ Coverage Diff @@
## next #4383 +/- ##
=============================

Vogel612

@Duga shaddap

the codecov bot thing is quite annoying

Duga

[rubberduck-vba/Rubberduck] build for commit 713bcfe1 on unknown branch: AppVeyor build failed

BUILD FAILURE!

Vogel612

~growls

IvenBach

For AreSame when there's a failure is the number that's returned the memory address for each item?

Duga

10:35 PM

[rubberduck-vba/Rubberduck] Vogel612 synchronized pull request #4383: Csproj format update, fixes #3944

[rubberduck-vba/Rubberduck] [codecov[bot]](github.com/apps/codecov) edited comment on pull request #4383: Csproj format update, fixes #3944

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4383?src=pr&el=h1) Report
> Merging [#4383](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4383?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/6df939d9edd3dd3f129f74996e6936f3c880e6da?src=pr&el=desc) will **decrease** coverage by `0.9%`.
> The diff coverage is `n/a`.

```diff
@@ Coverage Diff @@
## next #4383 +/- ##
=============================

Vogel612

@IvenBach I hope not, because that information is pretty nonsensical

the address of any object is useless for terminated programs, unless you have a heap snapshot from the moment you also got the address from ...

and even then it's mostly useless...

Duga

[rubberduck-vba/Rubberduck] build for commit 5bb75563 on unknown branch: AppVeyor build failed

BUILD FAILURE!

Vogel612

agh

Duga

[rubberduck-vba/Rubberduck] Vogel612 synchronized pull request #4383: Csproj format update, fixes #3944

[rubberduck-vba/Rubberduck] [codecov[bot]](github.com/apps/codecov) edited comment on pull request #4383: Csproj format update, fixes #3944

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4383?src=pr&el=h1) Report
> Merging [#4383](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4383?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/6df939d9edd3dd3f129f74996e6936f3c880e6da?src=pr&el=desc) will **decrease** coverage by `0.9%`.
> The diff coverage is `n/a`.

```diff
@@ Coverage Diff @@
## next #4383 +/- ##
=============================

[rubberduck-vba/Rubberduck] build for commit e8d3c078 on unknown branch: AppVeyor build failed

BUILD FAILURE!

Vogel612

okay NOW I am annoyed

VS builds the stuff just fine, but it's faking stuff so much that the MSBuild build fails

this is ridiculous

IDEs with their own toolchain are an antipattern

IvenBach

10:45 PM

    For Each checkSection In sut
        Debug.Print checkSection.Name
    Next

    'Act:

    'Assert:
    Assert.Succeed

Would that be the correct way to check that I implemented an iterable collection properly via unit tests?

Comintern

@IvenBach AreSame is returning the hash codes.

I'm not sure if that's better or worse than the pointers, FWIW.

IvenBach

So the output of a hash function en.wikipedia.org/wiki/Cryptographic_hash_function? Something that ought to return a unique value from a given input?

Duga

[rubberduck-vba/Rubberduck] Vogel612 synchronized pull request #4383: Csproj format update, fixes #3944

[rubberduck-vba/Rubberduck] [codecov[bot]](github.com/apps/codecov) edited comment on pull request #4383: Csproj format update, fixes #3944

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4383?src=pr&el=h1) Report
> Merging [#4383](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4383?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/6df939d9edd3dd3f129f74996e6936f3c880e6da?src=pr&el=desc) will **decrease** coverage by `0.9%`.
> The diff coverage is `n/a`.

```diff
@@ Coverage Diff @@
## next #4383 +/- ##
=============================

Comintern

@IvenBach Whatever the default implementation of object.GetHashCode() is. The code for it is here.

Duga

[rubberduck-vba/Rubberduck] build for commit 1f620430 on unknown branch: AppVeyor build failed

BUILD FAILURE!

Vogel612

10:51 PM

ha!

now it's only the incorrect analyzers remaining

at least hopefully

either way... I'm fixing that and then it's enough for today

Duga

[rubberduck-vba/Rubberduck] Vogel612 synchronized pull request #4383: Csproj format update, fixes #3944

[rubberduck-vba/Rubberduck] [codecov[bot]](github.com/apps/codecov) edited comment on pull request #4383: Csproj format update, fixes #3944

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4383?src=pr&el=h1) Report
> Merging [#4383](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4383?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/6df939d9edd3dd3f129f74996e6936f3c880e6da?src=pr&el=desc) will **decrease** coverage by `0.9%`.
> The diff coverage is `n/a`.

```diff
@@ Coverage Diff @@
## next #4383 +/- ##
=============================

Vogel612

44kLoC deletions and Rubberduck.Core is still not moved

Duga

[rubberduck-vba/Rubberduck] build for commit 2bfa5c16 on unknown branch: AppVeyor build failed

BUILD FAILURE!

Vogel612

yup. that's because the move isn't done on Core yet.

but it's enough for today

seems like stuff is building now

Toodles!

Mathieu Guindon

11:07 PM

@IvenBach wait is there an Assert.Succeed method?? Why?

IvenBach

Comintern may have forgotten why.

That's really cool you can see who added what line of code last.

Comintern

You can absolutely call Worksheet_Change - the only difference between an event handler and any other Sub is that it's registered as a callback function for the event. The problem is that Target is an undeclared Variant in the OP's Workbook_Open implementation. That means when it gets passed as a parameter that needs to be a Range, the implicit cast fails and results in an error 424 (Object required). The OP can't simply put the code from Worksheet_Change in at 'your code here, because it still ignores the problem that the code in question tests against Target... — Comintern 20 secs ago

Swing and a miss.

@IvenBach Comintern absolutely forgot why. Give me a sec, that's probably in the chat history if I can find it.

IvenBach

@this #If debugMode Then
Public Sub SomeSubForDebugging()
    Debug.Print "Foo"
End Sub
#End If

Just made hiding tools very easy. :+1: Thanks.

Duck check: Should github.com/rubberduck-vba/Rubberduck/blob/next/Rubberduck.Main/… be listed as Rubberduck.Main.ComClientLibrary.UnitTesting? I can't recall if I've already asked this namespace question before. Should it match up with what folder it's within?

I'd asked before about Rubberduck != Rubberduck.Core in github.com/rubberduck-vba/Rubberduck/blob/next/Rubberduck.Core/… but the folder structure still matches.

Comintern

11:22 PM

@IvenBach Check the folder properties to see if it's a namespace provider.

Mathieu Guindon

@Comintern can? sure. should? nope..

Comintern

^

It's deleted ATM.

Mathieu Guindon

saw that

IvenBach

I only see a single property on the folder.

Comintern

Right after he asked me to "prove it". I'm guessing he beat me to it.

Mathieu Guindon

11:28 PM

@Comintern I honestly can't imagine a reason for Assert.Succeed to exist... isn't assert supposed to be a reason for a test to fail?

Duga

[rubberduck-vba/Rubberduck] retailcoder synchronized pull request #4387: Fixes (most of) SCP

Comintern

@IvenBach The chat history would imply that I added Assert.Succeed as a complement to Assert.Fail, probably to handle tests where you expect a throw?

IvenBach

IIRC A while back when I took it out Assert.Succeed to see what would happen the test still passed. Made me wonder if it should have initially been a fail, kind of like a Boolean initializing to False, and requiring proof the test actually passed.

@Comintern That was when I first started coming to the pond. #Memories

@Comintern stackoverflow.com/questions/1078885/… is telling me it's a R# feature.

Comintern

I guess it would be symmetric, one possible use case would be to see if you get to a specific place in the test code. There's an Assert.Pass in nunit and similar methods in other testing frameworks. Agreed that it isn't the ideal structure though.

@IvenBach Oh yeah... I forgot VS could care less.

Duga

[rubberduck-vba/Rubberduck] build for commit a89b416d on unknown branch: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] [codecov[bot]](github.com/apps/codecov) created comment on pull request #4387: Fixes (most of) SCP

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4387?src=pr&el=h1) Report
> Merging [#4387](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4387?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/49d5bfb9e9d3e92e4a80acdb2af68123827bbf02?src=pr&el=desc) will **increase** coverage by `0.07%`.
> The diff coverage is `38.28%`.

```diff
@@ Coverage Diff @@
## next #4387 +/- ##
=======================

[rubberduck-vba/Rubberduck] build for commit a89b416d on unknown branch: 57.84% (target 0%)

Mathieu Guindon

11:40 PM

@Duga yay!

Duga

[rubberduck-vba/Rubberduck] [codecov[bot]](github.com/apps/codecov) edited comment on pull request #4387: Fixes (most of) SCP

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4387?src=pr&el=h1) Report
> Merging [#4387](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/4387?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/49d5bfb9e9d3e92e4a80acdb2af68123827bbf02?src=pr&el=desc) will **increase** coverage by `0.07%`.
> The diff coverage is `38.28%`.

```diff
@@ Coverage Diff @@
## next #4387 +/- ##
=======================

Transcript for