VBA Rubberducking

@MathieuGuindon btw there's a broken resource, too

for quickfix in module or something like that.

yeah

3:05 PM

I don't mind the aggregation of Use meaningful names as much as I don't like the fact that there's no way to identify what it's complaining about.

I wonder why the IDisposable interface isn't exposed in stdole2.tlb. It lives in oleaut32, is it just not considered "standard"?

also, pulling the .resx into Rubberduck.Resources did not magically fix the localization weirdness I'm having here

if avalonedit is still a pipe dream, maybe modify the toolwindow to correspond to the active code pane window?

@FreeMan hence, useless :)

@Comintern IDisposable?

3:05 PM

I just double clicked each of the 4 lines I showed in the screen shot & they all jump me to the same line of code, none of which are appropriate to the error reported.

@this yeah we need to do that

@MathieuGuindon semantics... :)

'Requires a reference to mscorlib
Implements IDisposable

Public Sub IDisposable_Dispose()

End Sub

hmm. I don't follow why it would be expected to be in stdole2.tlb, or even oleaut32.

awgaya

comintern is back :O hello @comintern

3:08 PM

It predates .NET even IIR. Here it is in the registry:

@awgaya Hey there.

@awgaya also had his "OMG HE'S BACK" moment a few weeks ago :)

These things come in threes. Who else is missing?

hmm

Shadow of Silicon.

awgaya

hosch? I think he's not active anymore right?

3:10 PM

Not so much in development, but I'm in the room.

@Comintern but as it is says, it's located in mscorlib.tlb.

I can see it in the OleView as well. So still not following why we're looking at oleaut32 or stdole2.

@this No, look closer - the interface is defined at the top in oleaut32.dll.

The highlighted line is a spurious click.

InprocServer32 [<no name>] = C:\Windows\SysWOW64\oleaut32.dll

Oh, there's all kinds of fun stuff in there.

Hmm. considering that ours is:

\CLSID\{69E194DA-43F0-3B33-B105-9B8188A6F040}\InprocServer32
@="mscoree.dll"

I suspect that there's some redirection going on.

mscoree.dll takes care of our classes. But someone else has to take care of mscoree/mscorlib, so...

3:16 PM

Hmm...

@Comintern @Phrancis was back last night! (You talked to him...) He hasn't been 'round these parts in a while...

also:

2 hours ago, by FreeMan

@Phrancis talking to @Comintern - it's like Dawn of the Living Dead but in a good way! Welcome back!!!

@this I think you might be right. Time to climb out of that particular rabbit hole for now.

@Comintern also it strikes me that there is no CATID for that registry. In contrast, all of our COM-visible classes get decorated with a CATID for .NET Category, which I believe is used by mscoree.dll to help it load the class using the extra keys that normally aren't used by COM itself.

It doesn't seem to be an MFC thing AFAICT.

would they have based their .NET runtime classes on MFC? :O

3:30 PM

oh wow, just noticed I'm 1 vote short of passing David Zemens on the VBA all-time top users :) stackoverflow.com/tags/vba/topusers

3

/s/passing/matching

/s/users/answerers

I should be working

@MathieuGuindon And half the answers too.

@MathieuGuindon That reminds me, I really should get an updated RD repo on my work machine.

@Hosch250 yeah... impostorSyndrome++;

Kind of nervous though, given that I can't break my current tooling like I could at home.

@Comintern updating to VS2017 made it rather hard for me to work on RD at work

(still on 2013 here)

3:42 PM

@MathieuGuindon I thought it was updating to VS 2015.

That's the one I did. 2017 was done when you brought Roslyn in.

whichever brought C# 6.0 to RD

@MathieuGuindon 2015.

and yes, I MISS C# 6.0 AT WORK

like, badly

@MathieuGuindon Another debate won.

could be worse. you could be forced to work on .NET 2.0.

3:43 PM

We're "officially" on 2015, but we have the licenses. I have like 4 versions of VS installed going back to VS6.

@this Could be even worse, you could have to occasionally compile stuff with command-line scripts written in the 80's.

could be worse, you could be debugging ASP-Classic in Notepad (gosh I don't miss that gig)

Don't even get me started about our batch file "system"...

@MathieuGuindon Oh I remember that!

Notepad ++, actually

@Comintern need to do the same on my home machine...

Q: How to unset focus/make cursor disappear in Access?

4:17 PM

why do folks keep fighting user32.dll?

0

I have a form in Access; when you put the cursor in a text box or combo box, and then click a blank area, it doesn't go away. Just vexing. I want it to respond like the message field I'm typing in now. Click an open area next to it and it is unselected or focus is unset. TIA

@MathieuGuindon Because that's how ***** browsers work.

that's how Windows works

something has the focus

you can't just "unfocus" a control

@MathieuGuindon Sure you can.

that said I'm not sure how Access forms behave, so..

@Hosch250 no, you can't.

Basically, he wants to unfocus the input field.

@MathieuGuindon Well, not "control" but what most people think of "controls" as.

4:21 PM

when you click a blank area, you put the focus on a specific <div>, that's all

Yeah, but the cursor stops blinking...

Because Access controls aren't controls, per se

still, repro'd with a UserForm + textbox

but I didn't?

huh?

4:26 PM

It was Excel that I could sort of repro but not consistently

typing in cell sometimes makes cursor go away, other time it's still there.

But with userform textbox consistently hides the cursor.

whereas w/ Access textbox, cursor never hide.

and here we go

@AnsgarWiechers the word tag carries that information. VBA is a language, not a type library. Here the language is PowerShell.... — Mathieu Guindon 6 secs ago

@this ok, color me confused. it's not doing that here

oh gee... 47 unread notifications on GH

IDK what to say....

maybe it's actually a OS thing???

41 of those from RD

I need to stop following Antlr

4:30 PM

@MathieuGuindon why?

not so bad actually

@Duga does a good job at making GH notifications redundant

welp. you have outstanding notifications from shadowofsilicon's fork?

@MathieuGuindon provided that you don't piss her off that she ragequits. ;-)

speaking of that.. is @Simon aware of #dugadown?

last message in testbed: 13 hours ago ...

4:32 PM

@MathieuGuindon ANTLR doesn't really seem to be your issue...

> shadowofsilicon committed on 14 Aug 2017

aye

not anymore lol

that repo can't even exist anymore, I think..

hmm, the link is somehow still working though

just to confirm - does there exist a higher level of rate limit? e.g. 100 posts in an hour, no more posts for a day?

poke @SimonForsberg about Duga looking like she's down

4:35 PM

not that I know of

@this possibly the IP block, but that limit should be rather conservative

@Vogel612 if that wasn't a power-ping, I don't think he got ping'd

#modabuse :)

hi @bruglesco

Hi mug!

4:37 PM

so @bruglesco when you learning C# to put in your first Rubberduck Contribution?

:)

Maybe I should start today

woohoo!

Does @Duga have a post limit? I thought I saw something along those lines when I was looking at the CR question but that might have been when scraping comments from SE

AFAIK there's only a throttle (that's fairly easy to hit)

might be Simon's server is down ATM

happens every now and then

4:41 PM

yes he does complain about that. He has a bug that it goes down every 14 days or something predictable like that.

memory leak perhaps?

I'm sorry, Mug, I don't remember him saying anything like that. /memory leak

github.com/Zomis/Server2/issues/28 11 days

crap, that sucks

Solution: schedule system to reboot every 10 days.

4

4:45 PM

sounds like a job for cron and putting duga into a systemd service

@bruglesco duck with us.

Duga needs her own cloud, with redundancy and all

@bruglesco FYI, about your job search, I've been thinking you might want to look into some hard CS stuff. Normally, I wouldn't recommend this, but C++ is often used specifically because there are constraints (time, space, etc.) where at least a moderate understanding of these will help.

Also, pick one project and get a bit of experience with it. You want to have something to be able to talk about more/less extensively in an interview.

@Hosch250 I assume you mean like hyper optimization algorithms and techniques since this is C++'s major benefit?

Yeah. You could look at various stable/unstable sorting algorithms. You can learn a LOT from those.

4:49 PM

@Hosch250 That's why I was looking into open source

Some are optimized for space usage. Some for time.

@Hosch250 they're also kinda fun. but then again its all fun.

5:33 PM

Steel is really poisonous. Stick a steel sword directly into your enemies stomach - see? Instantly poisoned. — Whelkaholism yesterday

lol

also:

"Sword of Latent Fatality", made of a chromium alloy. Might not get you today, but in 15-20 years you could start to develop thyroid cancer. On the plus side, you get to meet Erin Brockovich! — Pink Sweetener yesterday

I wonder if WB.SE will ever cease to amaze me. Probably not.

It's a fun site

Been hanging out there for a few weeks.

@this Set Windows to auto-update in the process :P

5:50 PM

@Hosch250 but is Simon running Duga on windows?

Not sure.

pretty sure he's not

NGinx doesn't play so nice on windows IIRC

Linus won't have none of 10-day maximum uptime linux distros, you know...

@Vogel612 Seems like it's not playing nice on Linux either, if he's using Linux.

true that

@this it ain't the linux-distro that's messing around here

5:53 PM

@Vogel612 no that was in response to Hosch's suggestion to turn on autoupdate for random and frequent reboots.

@this Confirmed.

comintern@fidel ~/Rubberduck $ uptime
 12:54:46 up 10 days, 18:49,  1 user,  load average: 0.74, 0.72, 0.66

I'm considering a custom man page that describes it as "the time since you had to cut power at the fuse box for longer than the UPS could handle".

 19:57:23 up  1:37,  3 users,  load average: 1,41, 1,48, 1,48

in The 2nd Monitor, 2 hours ago, by Vogel612

it's a somewhat humbling experience when your VPN stops working because you updated dbus

@Vogel612 Do you ever use git describe <blob>?

@IvenBach no, why do you ask?

@Vogel612 Your wiring is obviously better than mine.

5:58 PM

I'm actually rather surprised at the user-count...

Going through some examples of git and commands it can do. It came up and since you're the ~~expert~~ imposter with git thought to ask.

hmm ... I don't usually need describe. If I could make proper use of it, I usually do a log --graph --decorate --oneline which is ... a bit more useful

it seems to be a nice tool for scripting tho

@Comintern expect lot of noobs to open issues/questions/whatever `how come UPS gets to handle my box?!? How do I stop those brownshirts?"

LOL!

would the best way to globally ignore '@Ignore ... be to s/'@Ignore/'@ Ignore?

I'm thinking about all the inspection results that don't quite work right and that I'm ignoring until they're fixed. as fixes roll out, it would be worthwhile to remove all the ignores, let inspections run & see what still falls out.

6:23 PM

@Vogel612 For git commits there can only ever be 2 parents? IE a merge.

The dashed line indicates the second non-default parent.

@IvenBach Nope.

destroyallsoftware.com/blog/2017/…

Octopus merge...

Dumb VBA mechanics/behind-the-scenes question

    ThisWorkbook.Worksheets(rngTemplate.Value).Copy

    Dim shtNewTemplate As Worksheet
    Set shtNewTemplate = ActiveSheet
    MsgBox shtNewTemplate.Name
    shtNewTemplate.Move After:=wbkEmployeeAudit.Worksheets(wbkEmployeeAudit.Worksheets.Count)
    MsgBox shtNewTemplate.Name

@Hosch250 I'm guessing the typical merge for RD will be 2 parent merge.

Why does the first Msgbox work but the second one gives automation error? It appears the variable is halfway losing track of the sheet object on move.

6:35 PM

Am I talking out of my ass here?

@Tim yeah... though general "computer programming" vs the historical lingo & heritage of BASIC -> QBASIC -> VB might not necessarily be the same IMO. — Mathieu Guindon 2 mins ago

But ?shtNewTemplate is nothing gives False

@IvenBach it's a useful simplification, but ....

Obviously I should just re-Set the variable, but I was wondering what is happening mechanically there

Is it because a sheet object is actually a child item of a workbook and it no longer has the same parent object so things are screwed up?

@IvenBach Yes.

I wouldn't be surprised if all of them were.

(And yes, re-Seting the variable worked just fine)

6:38 PM

Just knowing an octopus merge is possible is enough, for now.

@puzzlepiece87 if you had assigned it using say, Sheet1 rather than ActiveWorksheet, do you get the same symptom?

How would I assign a newly created sheet using Sheet1?

Because if all my other sheets are named the newly created sheet would be Sheet1?

(Also, I wish we could do Set assignments on sheet objects on the same line as a .Move or .Copy, but alas.)

if you want a new worksheet then Set shtNewTemplate = ThisWorkBook.WorkSheets.Add

(aircode)

I'm probably missing your point, but I don't.

I'm copying a worksheet, then moving the copy into the intended destination.

nope.

if I understood the code, correctly what you did was.... 1) copy the content of the template into memory, 2) set a variable to the ActiveSheet, 3) move that sheet to some other place.

I don't see anything that creates the new sheet nor paste happening.

Unless it's somewhere else outside the code that you pasted.

6:46 PM

@this No. When you use the .Copy method on a sheet object, it creates a new sheet object that is a copy of the original. If you don't specify a destination, it is placed in a new workbook.

@this You are right for using the .Copy method on a Range object, though.

@this the Excel type library implementation of Worksheet.Copy does

#TIL

Worksheet.Copy should have been a function that returns the Worksheet reference

but anyway - my question was whether using reference to the sheet instead of ActiveSheet would avoid that quirk.

My thought was that because it's transient, methods like moving it around would invalidate the reference.

We do observe similar behavior with say, CurrentDb for example.

?CurrentDb.TableDefs("foo").Fields(0).Name <== is OK

I'm not sure how to get the reference for a dynamically created sheet when you can't Set it on the same line it's created. Tricky problem for sure.

6:51 PM

For each f in CurrentDb.TableDefs("foo").Fields:?f.Name:Next <== boom error

wtf

Set d = CurrentDb:For Each f in d.TableDefs("foo").Fields:?f.Name:Next <== OK again

11 mins ago, by puzzlepiece87

(Also, I wish we could do Set assignments on sheet objects on the same line as a .Move or .Copy, but alas.)

@puzzlepiece87 Couldn't you ThisWorkbook.Worksheets(rngTemplate.Value).Copy After:=wbkEmployeeAudit.Worksheets(wbkEmployeeAudit.Worksheets.Count) and avoid the ActiveSheet alltogether?

Sure, that would be another way around it.

6:53 PM

when you consider that CurrentDb is a function, and I suspect ActiveWorksheet is also a function.... you can't "re-reference" it, basically.

Oh okay

@Vogel612 Ah, I realize now - there's been a power failure around here, this explains a lot.

oh gee

@this So basically you suspect that shtNewTemplate is linked to the ActiveSheet function when I do it my way rather than simply to the sheet object that was created?

Seems plausible enough I suppose.

I'll run it @IvenBach's way to confirm or not.

@puzzlepiece87 thinking about it a bit more, not exactly. You're not directly calling the ActiveWorksheet as I illustrated in my CurrentDb example but the principle is same; the underying object is transient so you can't assume it to be still there.

6:55 PM

Were you using shtNewTemplate to modify things on it afterwards or was that just for recordkeeping while it was being created and then moved?

esp. not after you've run some methods that mutates the object in some manner.

@this @IvenBach Nope, avoiding ActiveSheet use doesn't help.

Fascinating.

I think it's because of how a Worksheet object relates to its parent workbook and how that has changed in the interim.

^

6:57 PM

exactly

That'd be my kneejerk response.

@IvenBach Just for recordkeeping while it was being created and moved.

The parent magically changes and it doesn't like it.

Ok, new test.... take the ObjPtr(ThisWorkBook.WorkSheets(whatever)) before the Move and again after.

@puzzlepiece87 what I don't get, though, is that it would invalidate the collection, but not the individual objects.

i mean, it'd be silly to move around the ginomorous Worksheet object in the memory... right?

@this Am I doing this right?

    Dim objPtr1 As Object
    Set objPtr1 = objPtr(shtNewTemplate)

6:59 PM

it's not an object. It's a LongPtr

^

just Debug.Print objPtr(shtNewTemplate)

I'm getting Compile Error: Type Mismatch

Oh okay, thanks

but --

don't use shtNewTemplate

use ThisWorkbook.WorkSheets(NameOfshtNewTemplate)

294051712
294050984

Two different ones

To be clear, here's what I ran:

    ThisWorkbook.Worksheets(rngTemplate.Value).Copy

    Dim shtNewTemplate As Worksheet
    Set shtNewTemplate = ActiveSheet
    Debug.Print objPtr(shtNewTemplate)
    shtNewTemplate.Move After:=wbkEmployeeAudit.Worksheets(wbkEmployeeAudit.Worksheets.Count)
    Set shtNewTemplate = wbkEmployeeAudit.Worksheets(wbkEmployeeAudit.Worksheets.Count)
    Debug.Print objPtr(shtNewTemplate)

Oh, I should probably use a third one in the middle

one second

7:01 PM

interesting

that doesn't look right to me still. how do you know it's the same worksheet?

technically, it's not the same worksheet.

Interesting:

260157152
260157152
260156320

For:

    Dim shtNewTemplate As Worksheet
    Set shtNewTemplate = ActiveSheet
    Debug.Print objPtr(shtNewTemplate)
    shtNewTemplate.Move After:=wbkEmployeeAudit.Worksheets(wbkEmployeeAudit.Worksheets.Count)
    Debug.Print objPtr(shtNewTemplate)
    Set shtNewTemplate = wbkEmployeeAudit.Worksheets(wbkEmployeeAudit.Worksheets.Count)
    Debug.Print objPtr(shtNewTemplate)

the point is to get the same worksheet from the collection.

wbkEmployeeAudit.WorkSheets.Count is just taking the last worksheet

That said, if I put Debug.Print shtNewTemplate.Name after the second pointer above, it can't tell me the name

7:03 PM

which might not be the original shtNewTemplate... right? (#NotAnExcelGuy)

For i = 1 To wbkEmployeeAudit.Worksheets.Count
    Debug.Print ObjPtr(wbkEmployeeAudit.Worksheets(i))
Next

So it still has the same pointer but is starting to bug out.

That's the behavior I expect if the pointer to the worksheet has shifted after the Move.

I can't refer to the properties of the sheet anymore, but it knows it's not empty.

Yeah, that makes sense, that's what I'm understanding now as well.

the problem is that the variable shtNewTemplate doesn't know that.

@MathieuGuindon probably should add .Name to the output, so we're comparing apples to apples

7:05 PM

@this It's the same, but yeah with a new parent workbook.

yeah

Thanks for helping me to understand the mechanics everyone :)

And I hadn't used the ObjPtr() method before so that was new also

@puzzlepiece87 hm, so if you're moving a worksheet from one workbook to another, wouldn't that delete from the original workbook?

#LearningTheExcelModel

Yes

So there's technically three workbooks there

oh, then that's totally expected.

7:07 PM

The first workbook where the templates reside

Then the .Copy creates a new (second) workbook with the copied template

Then the .Move moves the copied template to the waiting report (a third workbook) in progress

once moved, it's gone, but it can't tell variables to go anywhere. So you're left with a dangling variable referencing black hole

The 2nd workbook disappears due to 0 worksheets

@this Exactly right, that's what I was discovering. I figured that the worksheet variable would have the parent workbook object updated automatically as the worksheet object was moved around, basically.

But that was not the case. Black hole was the case.

@Vogel612 @MathieuGuindon @Duga should be up and running again.

Thanks for notifying me.

@SimonForsberg Yay!!

thanks for the quick fixing :)

7:19 PM

@SimonForsberg phew!

♪ ooooh Duga, Duga-Duga ♪ I'm so lost without you oooh, ooooh Duga, Duga-Duga ♪

8

Coming soon to a bookshelf near you, @SimonForsberg's new tome, The Proper Care and Handling of a Fickle, Female Chat-bot. Get your signed copy at a Borders Bookstore near you!

@FreeMan Step 1: Don't let her have a power failure.

@MathieuGuindon did you just sticky ~~post~~ star your own comment?

@FreeMan And seconded.

I didn't

7:23 PM

@SimonForsberg Teach her to enjoy being handled by the boys in brown

@MathieuGuindon whew! ;)

I swear I'm not going to get any work done until the WordPress people get done trashing the place. It's like having raccoons loose in your house.

[rubberduck-vba/Rubberduck] DevulskyA opened issue #4201: it is randomly adding the loop word in the code

> it is randomly adding the word "loop" in the code

@Duga bwahaha

[rubberduck-vba/Rubberduck] retailcoder created comment on issue #4201: it is randomly adding the loop word in the code

> Not quite randomly - the line you're hitting ENTER (or TAB) on contains the keyword `Do`.

This is a known autocompletion glitch, will definitely be fixed by the 2.3 green release.

[rubberduck-vba/Rubberduck] retailcoder added label bug to issue #4201: it is randomly adding the loop word in the code

[rubberduck-vba/Rubberduck] retailcoder added label feature-autocomplete to issue #4201: it is randomly adding the loop word in the code

@Duga Welcome back.

7:32 PM

[rubberduck-vba/Rubberduck] retailcoder edited comment on issue #4201: it is randomly adding the loop word in the code

@SimonForsberg Thanks for resurrecting @Duga, again.

> Not quite randomly - the line you're hitting ENTER (or TAB) on contains the keyword `Do` (apparently it could be in a string or a comment).

This is a known autocompletion glitch, will definitely be fixed by the 2.3 green release.

[rubberduck-vba/Rubberduck] retailcoder added label duplicate to issue #4201: it is randomly adding the loop word in the code

@MathieuGuindon that is what you get for using regex!

[rubberduck-vba/Rubberduck] retailcoder created comment on issue #4201: it is randomly adding the loop word in the code

> ref. #4168

@Vogel612 leveraging the CodeStringParser will definitely make this a walk in the park

7:34 PM

@IvenBach Oh my god, it really doesn't take long between her being back and you all starting to use her.

@SimonForsberg she's the 2nd most talkative here

wow... I'm downright an order of magnitude less talkative than you @MathieuGuindon

ooh, I hit 100K messages recently!

@Vogel612 I've already surpassed you because of all my questions.

@Vogel612 if it's any consolation, @SimonForsberg is yet another order of magnitude less talkative than you are :)

7:37 PM

@IvenBach add to that that I've become talkative in other rooms...

[rubberduck-vba/Rubberduck] retailcoder created comment on issue #4201: it is randomly adding the loop word in the code

> In the meantime you can tweak autocompletion settings, and turn off the buggy block completion.

@MathieuGuindon I bet that your 100K'th message was this one:

17 mins ago, by Mathieu Guindon

♪ ooooh Duga, Duga-Duga ♪ I'm so lost without you oooh, ooooh Duga, Duga-Duga ♪

nah, it was some 300+ messages ago

@MathieuGuindon Well, I don't aim at being a regular in here though. I'm only here when you folks have @Duga issues, or when I need some VBA opinion about a question...

@SimonForsberg Duga is completely invaluable to Rubberduck :)

7:40 PM

I had 4 Consider renaming parameter 'x' inspections in a module. I double-clicked on the first one, came up with a gooderer alternative, then hit the quick-fix and selected Rename. When RD was done, all 4 were renamed. Is that Status-By-Design?

@MathieuGuindon Just like she is invaluable to us all <3

@FreeMan probably a bug: the inspection should only flag the declaration, not every single one of its references. can you repro?

gimme a minute & let me see...

@MathieuGuindon - yup. Issue incoming

[rubberduck-vba/Rubberduck] daFreeMan opened issue #4202: 'Rename Parameter' QuickFix fixes too much

> Starting with this code:

```VBA
Public Property Let ColorID(ByVal x As String)
pColorID = x
End Property
Public Property Let Red(ByVal x As Long)
pRed = x
End Property
Public Property Let Green(ByVal x As Long)
pGreen = x
End Property
Public Property Let Blue(ByVal x As Long)
pBlue = x
End Property
```

I get these inspections, which are perfectly reasonable:
![rd rename inspections](https://user-images.githubusercontent.com/11889733/42841597-919bc750-89d8-11e8-8328-

[rubberduck-vba/Rubberduck] daFreeMan edited issue #4202: 'Rename Parameter' QuickFix fixes too much

@Duga ooh that's completely different... and quite a bug

7:50 PM

you're welcome!

[rubberduck-vba/Rubberduck] retailcoder added label bug to issue #4202: 'Rename Parameter' QuickFix fixes too much

[rubberduck-vba/Rubberduck] retailcoder added label critical to issue #4202: 'Rename Parameter' QuickFix fixes too much

[rubberduck-vba/Rubberduck] retailcoder added label feature-refactorings to issue #4202: 'Rename Parameter' QuickFix fixes too much

[rubberduck-vba/Rubberduck] retailcoder added label refactoring-rename to issue #4202: 'Rename Parameter' QuickFix fixes too much

[rubberduck-vba/Rubberduck] retailcoder added label regression to issue #4202: 'Rename Parameter' QuickFix fixes too much

[rubberduck-vba/Rubberduck] retailcoder created comment on issue #4202: 'Rename Parameter' QuickFix fixes too much

> This is a regression bug, possibly involving the resolver (needs to be determined).

I thought you were saying that the inspection was essentially returning too many results

and, FYI, I repo'd the results on another set of Leters elsewhere that had similarly short names

@MathieuGuindon nope! :D

I think it's a resolver bug :/

[rubberduck-vba/Rubberduck] retailcoder added label resolver to issue #4202: 'Rename Parameter' QuickFix fixes too much

7:54 PM

the more I think about it, the less probable it is that it's a bug with the refactoring itself

rename simply iterates a declaration's references.

ummm... I just noticed that it renamed x across multiple modules, not just the one I was in.

I'm fixing up some poor parameter names in a different module and there's one called colorCode and the Leter has nothing to do with colors, so I would have never used that here...

@FreeMan after seeing the issue, I was suspecting exactly that

that bug has turned refactor/rename into replace all

Hmmm... that looks similar to the scoping issues that the built in declarations are having.

Yup - and it's an issue with a manually called Refactor|Rename as well (I'd presume that the same code is called...)

the quickfix invokes the refactoring, yes

@Comintern that's a showstopper bug for 2.3 to me