> The following unit test for Fakes.InputBox.ReturnsWhen fails. Same happens for MsgBox, other Fakes not tested.
``` '@TestMethod Public Sub InputBoxFakeReturnsWhenWorks() On Error GoTo TestFail
Dim userInput As String Fakes.InputBox.ReturnsWhen "prompt", "Dummy1", "dummy1 user input" Fakes.InputBox.ReturnsWhen "prompt", "Expected", "expected user input" Fakes.InputBox.ReturnsWhen "prompt", "Dummy2", "dummy2 user input"
> Thanks for reporting! Could the setup with invocation index 2 isn't failing just because InputBox is only invoked once? We'll use that MCVE to get ourselves a stack trace, looks like there's a cast somewhere that's throwing... thanks a bunch!
hey @Mat'sMug, there is a Compile() member in the VBE extensions for ITypeLib. It does a silent compile (if the VBE project is not already compiled), and throws an exception if compilation fails. Would that be useful at all? Perhaps to use it before parsing?
@WaynePhillipsEA @Mat'sMug / whoever else -- correct me if I'm wrong but I think it's still useful since we only need to track the projects simply to not confuse VBAProject with another VBAProject, so even if the GUID wasn't persisted to next session, we still have a way of making distinction between projects with same names... right?
The only reason it wouldn't work is if the VBE generates a 'wrapper' for the underlying implementation of VBProject every time you access it in the VBProjects collection. I would hope not, but you never can be sure without testing
I suppose one minor point to mention would be if you closed a project, the next project might get the memory address of the last opened project. Very unlikely though. You're tracking project close/open events anyway, so you can deal with that.
@WaynePhillipsEA it's also how source control knows the project is in a repository
@WaynePhillipsEA I've learned to distrust whatever the VBIDE API spits out...
HashCodes of what should be the same object tend to be different between calls, so without a writable ID we can't be 100% sure we're looking at the very same object
oh, I mean to ask earlier -- I got a compiler warning because I had defined the operator == and != -- but I didn't override object's Equals and HashCode
does it even make sense to do something like this:
public override bool Equals(object obj)
{
return this == obj as ExtractMethodParameter;
}
public override int GetHashCode()
{
return base.GetHashCode();
When == is used on an expression of type object, it'll resolve to System.Object.ReferenceEquals.
Equals is just a virtual method and behaves as such, so the overridden version will be used (which, for string type compares the contents).
i.e. if you override Equals and make it do anything other than ReferenceEquals, you should also override ==
and if you override ==, then you should override !=
== is the identity test. It will return true if the two objects being tested are in fact the same object. Equals() performs an equality test, and will return true if the two objects consider themselves equal.
Identity testing is faster, so you can use it when there's no need for more expensive e...
I am writing a simple function, such as:
Function myFunction() As Variant
'Some rules
End Function
For the above function, is it possible to assign an Alias like you can do with API calls?
Obviously this isn't the proper syntax, but you get the idea:
Function myFunction() Alias myFunc ...
This over-the-top awesome examplary answer will be earning a bounty as soon as the question is eligible for one. Keep them coming! — Mat's Mug6 secs ago
I'll have to be more careful about that then. I would have thought the pressure would be more on the functions, but I guess they have the benefit of returning something, so subs become more ominous.
Yeah, I need to crack Clean Code back open now that I have a much better grasp.
I've also only recently realized how useful case-sensitivity is with naming. For example, knowing that dataframe is a variable whereas DataFrame is a Class is huge when learning.
I agree with his point that case insensitivity is easier to write, but I find the insensitivity easier to use. I am perpetually guilty of creating a variable that is the same exact name as a class Dim Foo as Foo for example, and while this only rarely bites me in the rear, I know that it will likely present issues in more complex cases. I just dont want to spend the time creating a more complex and meaningless name though when the original name makes the most sense.
Insensitivity helps with that, but at the cost of being acutely aware of what letters should and shouldn't be uppercase. It also makes it easier to identify what is being accessed like an instance, but is actually a class.
I figured as much. Its a curse of making accurate names, you use up the most accurate name when you need it again.
@Mat'sMug I do too now, and thats all well and good for building classes. But when I use those classes to do other stuff I either need a new class to handle the job of a Sub, or I end up with a variable with the same name as a class.
Its only so far ever been an issue with Enums though, so I am trying to be more conscious of fully qualifying enum calls.
last big project I did, my domain terminology included terms like "collection" and "model" ...yet I kept the naming convention I had, and ended up with types like ModelCollection (a custom collection holding IModel objects), ModelModel (an IModel that represents a [domain] model), CollectionModel (an IModel representing a [domain] collection), ...and parameter names like m to identify an IModel instance.
Naming is hard. I use similar conventions. I have a Query and QueryParameter, QueryCollectionQueryCollectionFactory and an IQueryable interface (all the classes have interfaces too). But I generally use the name of the class for parameters. So QueryCollection.AddQuery(Query as IQuery).
hmm, I wouldn't expect a QueryCollection to take anything other than some kind of Query items - I'd just have an Add method taking (ByVal item As IQuery)
(and yes, I lowercase item and value every time :)
It may actually be add, and I could change it to item but that solves the problem for one class. I would have to find a solution for every instance and then change them all at once (otherwise my naming would be inconsistent).
@Mat'sMug just a thought depending on how far away the avalon is - if it's going to take much more while, one thing we can do is to take snapshot of attributes using Wayne's API, then reapply after.
@Mat'sMug you mean, inspections will then be just red underlining on the offensive line and a pop-up with descriptions and suggestions when you hover over them, like in VS?
other topic, the MVC, I see all of the controllers inheriting from Controller, but I can't inspect this class... is it an ASP thing I don't have on my VS?
and note that it's JS that let us move beyond a simplistic Request-Response model
which is also why when you use a JS-heavy application, you end up using MVVM.... BUT you may still use MVC on the server side (because, Request-Response).
almost all the people I know who work as programmers are doing websites with mostly .NET or php and a ton of JS. On them offering me books or whatever, I was always like meeh I'l read this book on assembly/compilers/languages/C++ first.
but I do second the advice to look explicitly for ASP.NET MVC -- only ASP.NET might get you the old WebForms technology and you don't want that either.
I'm reading all the time all those CR articles from @Mat'sMug, and mostly, I'm finding myself with the trouble to visualise how all the code in CR interacts with each other... specially when the same project is spanned across many articles
yeah, but it's using code from an article which is using code from an article which is using code from an article... I can't follow xD
@Mat'sMug, is it possible for you to email me a .xlsm with that thing working? :( I've tried copying your code but I can't get this thing to compile, don't know what I copied wrong :(
Context
I'm working on a little project that consists in a series of Microsoft Excel add-ins (.xlam). The code being submitted for review here, is located in the Reflection project:
Feel free to comment on the project architecture, but I'm mostly interested in the Reflection.LinqEnumerable cl...
Delegate
This class module defines what I'm calling, in this context, a Delegate - here a function that can take a number of parameters, evaluate a result, and return a value. Close enough to the actual "delegate" thing I find.
Example usage
Set x = Delegate.Create("(x) => MsgBox(""Hello, "" & x
> I knew a lady, who came from Duluth. Bit by a dog with a rabid tooth. She went to her grave just a little too soon. Flew a late howl on the yellow moon. Where do bad folks go when they die? They don't go to Heaven where the angels fly. They go to a lake of fire and fry. Won't see 'em again, 'til the fourth of July.
@Hosch250 Think that'd endanger them even more - they'd either get killed by coyotes or get shot down by gun-toting rednecks looking for a coon hat (!)
@Hosch250 I also like Metallica, some Avenged Sevenfold, and for the past six months or so I've been listening to some Sonny Boy Williamson II - quite the contrast.
Yeah, has to be very profitable business. Ranchers pay them to clear their land. Tourists pay them for privilege of mowing down the pigs with guns they won't be able to have.
When == is used on an expression of type object, it'll resolve to System.Object.ReferenceEquals.
Equals is just a virtual method and behaves as such, so the overridden version will be used (which, for string type compares the contents).
I am writing a simple function, such as:
Function myFunction() As Variant
'Some rules
End Function
For the above function, is it possible to assign an Alias like you can do with API calls?
Obviously this isn't the proper syntax, but you get the idea:
Function myFunction() Alias myFunc ...
Context
I'm working on a little project that consists in a series of Microsoft Excel add-ins (.xlam). The code being submitted for review here, is located in the Reflection project:
Feel free to comment on the project architecture, but I'm mostly interested in the Reflection.LinqEnumerable cl...
VBA Rubberducking
VBA Rubberducking